Completed
Pull Request — 3.x (#6048)
by Javier
02:51
created
src/Admin/AbstractAdmin.php 1 patch
Doc Comments   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1040,6 +1040,7 @@  discard block
 block discarded – undo
1040 1040
 
1041 1041
     /**
1042 1042
      * NEXT_MAJOR: remove this method.
1043
+     * @param string $subClass
1043 1044
      */
1044 1045
     public function addSubClass($subClass)
1045 1046
     {
@@ -2378,7 +2379,7 @@  discard block
 block discarded – undo
2378 2379
      *
2379 2380
      * @param string $context
2380 2381
      *
2381
-     * @return array
2382
+     * @return string[]
2382 2383
      */
2383 2384
     public function getPermissionsShow($context)
2384 2385
     {
@@ -2949,6 +2950,7 @@  discard block
 block discarded – undo
2949 2950
      * NEXT_MAJOR: remove this method.
2950 2951
      *
2951 2952
      * @deprecated Use configureTabMenu instead
2953
+     * @param string $action
2952 2954
      */
2953 2955
     protected function configureSideMenu(ItemInterface $menu, $action, ?AdminInterface $childAdmin = null)
2954 2956
     {
Please login to merge, or discard this patch.
src/Admin/Pool.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -87,6 +87,7 @@  discard block
 block discarded – undo
87 87
      * @param string $title
88 88
      * @param string $logoTitle
89 89
      * @param array  $options
90
+     * @param PropertyAccessorInterface $propertyAccessor
90 91
      */
91 92
     public function __construct(
92 93
         ContainerInterface $container,
@@ -386,7 +387,7 @@  discard block
 block discarded – undo
386 387
     }
387 388
 
388 389
     /**
389
-     * @return array
390
+     * @return string[]
390 391
      */
391 392
     public function getAdminServiceIds()
392 393
     {
Please login to merge, or discard this patch.
src/Controller/CRUDController.php 1 patch
Doc Comments   +9 added lines, -5 removed lines patch added patch discarded remove patch
@@ -66,6 +66,9 @@  discard block
 block discarded – undo
66 66
      */
67 67
     private $templateRegistry;
68 68
 
69
+    /**
70
+     * @param ContainerInterface $container
71
+     */
69 72
     public function setContainer(?ContainerInterface $container = null)
70 73
     {
71 74
         $this->container = $container;
@@ -195,7 +198,7 @@  discard block
 block discarded – undo
195 198
     /**
196 199
      * Delete action.
197 200
      *
198
-     * @param int|string|null $id
201
+     * @param integer|null $id
199 202
      *
200 203
      * @throws NotFoundHttpException If the object does not exist
201 204
      * @throws AccessDeniedException If access is not granted
@@ -791,7 +794,7 @@  discard block
 block discarded – undo
791 794
     /**
792 795
      * View history revision of object.
793 796
      *
794
-     * @param int|string|null $id
797
+     * @param null|integer $id
795 798
      * @param string|null     $revision
796 799
      *
797 800
      * @throws AccessDeniedException If access is not granted
@@ -854,9 +857,9 @@  discard block
 block discarded – undo
854 857
     /**
855 858
      * Compare history revisions of object.
856 859
      *
857
-     * @param int|string|null $id
858
-     * @param int|string|null $base_revision
859
-     * @param int|string|null $compare_revision
860
+     * @param null|integer $id
861
+     * @param null|integer $base_revision
862
+     * @param null|integer $compare_revision
860 863
      *
861 864
      * @throws AccessDeniedException If access is not granted
862 865
      * @throws NotFoundHttpException If the object or revision does not exist or the audit reader is not available
@@ -1580,6 +1583,7 @@  discard block
 block discarded – undo
1580 1583
 
1581 1584
     /**
1582 1585
      * Sets the admin form theme to form view. Used for compatibility between Symfony versions.
1586
+     * @param string[] $theme
1583 1587
      */
1584 1588
     private function setFormTheme(FormView $formView, ?array $theme = null): void
1585 1589
     {
Please login to merge, or discard this patch.
src/Form/ChoiceList/ModelChoiceLoader.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -65,6 +65,7 @@
 block discarded – undo
65 65
      * @param string|null $property
66 66
      * @param mixed|null  $query
67 67
      * @param array       $choices
68
+     * @param PropertyAccessorInterface $propertyAccessor
68 69
      */
69 70
     public function __construct(
70 71
         ModelManagerInterface $modelManager,
Please login to merge, or discard this patch.
src/Menu/Matcher/Voter/AdminVoter.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -38,6 +38,9 @@  discard block
 block discarded – undo
38 38
      */
39 39
     private $request = null;
40 40
 
41
+    /**
42
+     * @param RequestStack $requestStack
43
+     */
41 44
     public function __construct(?RequestStack $requestStack = null)
42 45
     {
43 46
         $this->requestStack = $requestStack;
@@ -46,6 +49,7 @@  discard block
 block discarded – undo
46 49
     /**
47 50
      * @deprecated since sonata-project/admin-bundle 3.31. Pass a RequestStack to the constructor instead.
48 51
      *
52
+     * @param Request $request
49 53
      * @return $this
50 54
      */
51 55
     public function setRequest($request)
Please login to merge, or discard this patch.
src/Security/Handler/AclSecurityHandler.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -184,6 +184,9 @@
 block discarded – undo
184 184
         return $acls;
185 185
     }
186 186
 
187
+    /**
188
+     * @param UserSecurityIdentity $securityIdentity
189
+     */
187 190
     public function addObjectOwner(AclInterface $acl, ?UserSecurityIdentity $securityIdentity = null)
188 191
     {
189 192
         if (false === $this->findClassAceIndexByUsername($acl, $securityIdentity->getUsername())) {
Please login to merge, or discard this patch.
src/Twig/Extension/SonataAdminExtension.php 1 patch
Doc Comments   +5 added lines, -4 removed lines patch added patch discarded remove patch
@@ -184,7 +184,7 @@  discard block
 block discarded – undo
184 184
     /**
185 185
      * render a list element from the FieldDescription.
186 186
      *
187
-     * @param object $object
187
+     * @param \stdClass $object
188 188
      * @param array  $params
189 189
      *
190 190
      * @return string
@@ -265,7 +265,7 @@  discard block
 block discarded – undo
265 265
     /**
266 266
      * render a view element.
267 267
      *
268
-     * @param object $object
268
+     * @param \stdClass $object
269 269
      *
270 270
      * @return string
271 271
      */
@@ -402,7 +402,8 @@  discard block
 block discarded – undo
402 402
     /**
403 403
      * Get the identifiers as a string that is safe to use in a url.
404 404
      *
405
-     * @param object $model
405
+     * @param \stdClass $model
406
+     * @param AdminInterface $admin
406 407
      *
407 408
      * @return string string representation of the id that is safe to use in a url
408 409
      */
@@ -424,7 +425,7 @@  discard block
 block discarded – undo
424 425
     }
425 426
 
426 427
     /**
427
-     * @return string|bool
428
+     * @return string|false
428 429
      */
429 430
     public function getXEditableType($type)
430 431
     {
Please login to merge, or discard this patch.
src/Util/AdminObjectAclData.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -80,6 +80,7 @@
 block discarded – undo
80 80
     /**
81 81
      * @param object $object
82 82
      * @param string $maskBuilderClass
83
+     * @param \Traversable $aclRoles
83 84
      */
84 85
     public function __construct(
85 86
         AdminInterface $admin,
Please login to merge, or discard this patch.