Completed
Pull Request — 3.x (#5411)
by Grégoire
08:01 queued 04:10
created
src/Admin/AbstractAdmin.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,6 @@
 block discarded – undo
13 13
 
14 14
 use Doctrine\Common\Util\ClassUtils;
15 15
 use Knp\Menu\FactoryInterface as MenuFactoryInterface;
16
-use Knp\Menu\ItemInterface;
17 16
 use Knp\Menu\ItemInterface as MenuItemInterface;
18 17
 use Sonata\AdminBundle\Builder\DatagridBuilderInterface;
19 18
 use Sonata\AdminBundle\Builder\FormContractorInterface;
Please login to merge, or discard this patch.
Doc Comments   +10 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1024,6 +1024,7 @@  discard block
 block discarded – undo
1024 1024
 
1025 1025
     /**
1026 1026
      * NEXT_MAJOR: remove this method.
1027
+     * @param string $subClass
1027 1028
      */
1028 1029
     public function addSubClass($subClass)
1029 1030
     {
@@ -1146,6 +1147,10 @@  discard block
 block discarded – undo
1146 1147
         return $this->routeGenerator->hasAdminRoute($this, $name);
1147 1148
     }
1148 1149
 
1150
+    /**
1151
+     * @param string $name
1152
+     * @param string $adminCode
1153
+     */
1149 1154
     public function isCurrentRoute($name, $adminCode = null)
1150 1155
     {
1151 1156
         if (!$this->hasRequest()) {
@@ -2291,7 +2296,7 @@  discard block
 block discarded – undo
2291 2296
      *
2292 2297
      * @param string $context
2293 2298
      *
2294
-     * @return array
2299
+     * @return string[]
2295 2300
      */
2296 2301
     public function getPermissionsShow($context)
2297 2302
     {
@@ -2596,6 +2601,9 @@  discard block
 block discarded – undo
2596 2601
         return true;
2597 2602
     }
2598 2603
 
2604
+    /**
2605
+     * @param string $action
2606
+     */
2599 2607
     public function configureActionButtons($action, $object = null)
2600 2608
     {
2601 2609
         $list = [];
@@ -2847,6 +2855,7 @@  discard block
 block discarded – undo
2847 2855
     /**
2848 2856
      * NEXT_MAJOR: remove this method.
2849 2857
      *
2858
+     * @param string $action
2850 2859
      * @return mixed
2851 2860
      *
2852 2861
      * @deprecated Use configureTabMenu instead
Please login to merge, or discard this patch.
src/Admin/FieldDescriptionCollection.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
     }
31 31
 
32 32
     /**
33
-     * @return array
33
+     * @return FieldDescriptionInterface[]
34 34
      */
35 35
     public function getElements()
36 36
     {
Please login to merge, or discard this patch.
src/Generator/ControllerGenerator.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@
 block discarded – undo
31 31
     private $file;
32 32
 
33 33
     /**
34
-     * @param array|string $skeletonDirectory
34
+     * @param string $skeletonDirectory
35 35
      */
36 36
     public function __construct($skeletonDirectory)
37 37
     {
Please login to merge, or discard this patch.
src/Controller/PolyfillControllerTrait.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -25,6 +25,9 @@
 block discarded – undo
25 25
  */
26 26
 trait PolyfillControllerTrait
27 27
 {
28
+    /**
29
+     * @param string $methodName
30
+     */
28 31
     public function __call($methodName, $arguments)
29 32
     {
30 33
         $this->proxyToController($methodName, $arguments);
Please login to merge, or discard this patch.
tests/Menu/Matcher/Voter/AdminVoterTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -70,6 +70,7 @@  discard block
 block discarded – undo
70 70
 
71 71
     /**
72 72
      * {@inheritdoc}
73
+     * @param string $code
73 74
      */
74 75
     private function getAdmin($code, $list = false, $granted = false)
75 76
     {
@@ -102,6 +103,8 @@  discard block
 block discarded – undo
102 103
 
103 104
     /**
104 105
      * {@inheritdoc}
106
+     * @param string $parentCode
107
+     * @param string $childCode
105 108
      */
106 109
     private function getChildAdmin($parentCode, $childCode, $list = false, $granted = false)
107 110
     {
Please login to merge, or discard this patch.
tests/Datagrid/DatagridMapperTest.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -266,6 +266,12 @@
 block discarded – undo
266 266
         ], array_keys($this->datagrid->getFilters()));
267 267
     }
268 268
 
269
+    /**
270
+     * @param string $name
271
+     * @param string $label
272
+     *
273
+     * @return string
274
+     */
269 275
     private function getFieldDescriptionMock($name = null, $label = null)
270 276
     {
271 277
         $fieldDescription = $this->getMockForAbstractClass(BaseFieldDescription::class);
Please login to merge, or discard this patch.
tests/Datagrid/ListMapperTest.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -255,6 +255,12 @@
 block discarded – undo
255 255
         ], true), print_r($this->fieldDescriptionCollection->getElements(), true));
256 256
     }
257 257
 
258
+    /**
259
+     * @param string $name
260
+     * @param string $label
261
+     *
262
+     * @return string
263
+     */
258 264
     private function getFieldDescriptionMock($name = null, $label = null)
259 265
     {
260 266
         $fieldDescription = $this->getMockForAbstractClass(BaseFieldDescription::class);
Please login to merge, or discard this patch.
tests/Show/ShowMapperTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -455,6 +455,10 @@
 block discarded – undo
455 455
         $this->showMapper = new ShowMapper($this->showBuilder, $this->fieldDescriptionCollection, $this->admin);
456 456
     }
457 457
 
458
+    /**
459
+     * @param string $name
460
+     * @param string $label
461
+     */
458 462
     private function getFieldDescriptionMock($name = null, $label = null)
459 463
     {
460 464
         $fieldDescription = $this->getMockForAbstractClass(BaseFieldDescription::class);
Please login to merge, or discard this patch.
src/Controller/CRUDController.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -208,7 +208,7 @@  discard block
 block discarded – undo
208 208
     /**
209 209
      * Delete action.
210 210
      *
211
-     * @param int|string|null $id
211
+     * @param integer|null $id
212 212
      *
213 213
      * @throws NotFoundHttpException If the object does not exist
214 214
      * @throws AccessDeniedException If access is not granted
@@ -726,7 +726,7 @@  discard block
 block discarded – undo
726 726
     /**
727 727
      * View history revision of object.
728 728
      *
729
-     * @param int|string|null $id
729
+     * @param null|integer $id
730 730
      * @param string|null     $revision
731 731
      *
732 732
      * @throws AccessDeniedException If access is not granted
@@ -786,9 +786,9 @@  discard block
 block discarded – undo
786 786
     /**
787 787
      * Compare history revisions of object.
788 788
      *
789
-     * @param int|string|null $id
790
-     * @param int|string|null $base_revision
791
-     * @param int|string|null $compare_revision
789
+     * @param null|integer $id
790
+     * @param null|integer $base_revision
791
+     * @param null|integer $compare_revision
792 792
      *
793 793
      * @throws AccessDeniedException If access is not granted
794 794
      * @throws NotFoundHttpException If the object or revision does not exist or the audit reader is not available
Please login to merge, or discard this patch.