Completed
Pull Request — 3.x (#5411)
by Grégoire
08:01 queued 04:10
created
src/Datagrid/Pager.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -432,7 +432,7 @@  discard block
 block discarded – undo
432 432
      * Returns a parameter.
433 433
      *
434 434
      * @param string $name
435
-     * @param mixed  $default
435
+     * @param null|string  $default
436 436
      *
437 437
      * @return mixed
438 438
      */
@@ -457,7 +457,7 @@  discard block
 block discarded – undo
457 457
      * Sets a parameter.
458 458
      *
459 459
      * @param string $name
460
-     * @param mixed  $value
460
+     * @param string  $value
461 461
      */
462 462
     public function setParameter($name, $value)
463 463
     {
Please login to merge, or discard this patch.
src/Form/ChoiceList/ModelChoiceList.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -101,7 +101,7 @@
 block discarded – undo
101 101
      * @param string            $class
102 102
      * @param string|null       $property
103 103
      * @param QueryBuilder|null $query
104
-     * @param array             $choices
104
+     * @param integer[]             $choices
105 105
      */
106 106
     public function __construct(
107 107
         ModelManagerInterface $modelManager,
Please login to merge, or discard this patch.
src/Generator/AdminGenerator.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@
 block discarded – undo
37 37
     private $file;
38 38
 
39 39
     /**
40
-     * @param array|string $skeletonDirectories
40
+     * @param string $skeletonDirectories
41 41
      */
42 42
     public function __construct(ModelManagerInterface $modelManager, $skeletonDirectories)
43 43
     {
Please login to merge, or discard this patch.
tests/Admin/Extension/LockExtensionTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -210,6 +210,10 @@
 block discarded – undo
210 210
         return new FormMapper($contractor->reveal(), $formBuilder, $this->admin->reveal());
211 211
     }
212 212
 
213
+    /**
214
+     * @param string $uniqid
215
+     * @param Request $request
216
+     */
213 217
     private function configureAdmin($uniqid = null, $request = null, $modelManager = null): void
214 218
     {
215 219
         $this->admin->getUniqid()->willReturn($uniqid);
Please login to merge, or discard this patch.
tests/Controller/CRUDControllerTest.php 1 patch
Doc Comments   +7 added lines patch added patch discarded remove patch
@@ -3685,6 +3685,9 @@  discard block
 block discarded – undo
3685 3685
         ];
3686 3686
     }
3687 3687
 
3688
+    /**
3689
+     * @param string $method
3690
+     */
3688 3691
     private function assertLoggerLogsModelManagerException($subject, $method): void
3689 3692
     {
3690 3693
         $exception = new ModelManagerException(
@@ -3707,6 +3710,10 @@  discard block
 block discarded – undo
3707 3710
             ]);
3708 3711
     }
3709 3712
 
3713
+    /**
3714
+     * @param string $id
3715
+     * @param string $domain
3716
+     */
3710 3717
     private function expectTranslate($id, array $parameters = [], $domain = null, $locale = null): void
3711 3718
     {
3712 3719
         $this->translator->expects($this->once())
Please login to merge, or discard this patch.
src/Menu/Matcher/Voter/AdminVoter.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -42,6 +42,7 @@
 block discarded – undo
42 42
     /**
43 43
      * @deprecated since version 3.31. Pass a RequestStack to the constructor instead.
44 44
      *
45
+     * @param Request $request
45 46
      * @return $this
46 47
      */
47 48
     public function setRequest($request)
Please login to merge, or discard this patch.
src/Admin/BaseFieldDescription.php 1 patch
Doc Comments   +10 added lines patch added patch discarded remove patch
@@ -447,6 +447,9 @@  discard block
 block discarded – undo
447 447
         return implode('-', $components);
448 448
     }
449 449
 
450
+    /**
451
+     * @param string $fieldName
452
+     */
450 453
     private function hasCachedFieldGetter($object, $fieldName)
451 454
     {
452 455
         return isset(
@@ -454,6 +457,9 @@  discard block
 block discarded – undo
454 457
         );
455 458
     }
456 459
 
460
+    /**
461
+     * @param string $fieldName
462
+     */
457 463
     private function callCachedGetter($object, $fieldName, array $parameters = [])
458 464
     {
459 465
         $getterKey = $this->getFieldGetterKey($object, $fieldName);
@@ -472,6 +478,10 @@  discard block
 block discarded – undo
472 478
         return $object->{$fieldName};
473 479
     }
474 480
 
481
+    /**
482
+     * @param string $fieldName
483
+     * @param string $method
484
+     */
475 485
     private function cacheFieldGetter($object, $fieldName, $method, $getter = null)
476 486
     {
477 487
         $getterKey = $this->getFieldGetterKey($object, $fieldName);
Please login to merge, or discard this patch.
src/Admin/Pool.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -295,7 +295,7 @@
 block discarded – undo
295 295
     }
296 296
 
297 297
     /**
298
-     * @return array
298
+     * @return string[]
299 299
      */
300 300
     public function getAdminServiceIds()
301 301
     {
Please login to merge, or discard this patch.
tests/Admin/PoolTest.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -293,7 +293,7 @@  discard block
 block discarded – undo
293 293
     }
294 294
 
295 295
     /**
296
-     * @return Symfony\Component\DependencyInjection\ContainerInterface - the mock of container interface
296
+     * @return ContainerInterface - the mock of container interface
297 297
      */
298 298
     private function getContainer()
299 299
     {
@@ -307,6 +307,9 @@  discard block
 block discarded – undo
307 307
         return $containerMock;
308 308
     }
309 309
 
310
+    /**
311
+     * @param string $serviceId
312
+     */
310 313
     private function getItemArray($serviceId)
311 314
     {
312 315
         return [
Please login to merge, or discard this patch.