sonata-project / SonataAdminBundle

src/Admin/AbstractAdmin.php

Unused Use Statements -1 removed lines

@@ -13,7 +13,6 @@
 
 use Doctrine\Common\Util\ClassUtils;
 use Knp\Menu\FactoryInterface as MenuFactoryInterface;
-use Knp\Menu\ItemInterface;
 use Knp\Menu\ItemInterface as MenuItemInterface;
 use Sonata\AdminBundle\Builder\DatagridBuilderInterface;
 use Sonata\AdminBundle\Builder\FormContractorInterface;

Doc Comments +12 added lines, -1 removed lines

@@ -949,6 +949,7 @@ 
 
     /**
      * NEXT_MAJOR: remove this method.
+     * @param string $subClass
      */
     public function addSubClass($subClass): void
     {
@@ -1104,6 +1105,10 @@ 
         return $this->routeGenerator->hasAdminRoute($this, $name);
     }
 
+    /**
+     * @param string $name
+     * @param string $adminCode
+     */
     public function isCurrentRoute($name, $adminCode = null)
     {
         if (!$this->hasRequest()) {
@@ -2130,7 +2135,7 @@ 
      *
      * @param string $context
      *
-     * @return array
+     * @return string[]
      */
     public function getPermissionsShow($context)
     {
@@ -2408,6 +2413,7 @@ 
 
     /**
      * {@inheritdoc}
+     * @param string $action
      */
     public function hasAccess($action, $object = null)
     {
@@ -2532,6 +2538,7 @@ 
 
     /**
      * {@inheritdoc}
+     * @param boolean $isShown
      */
     final public function showMosaicButton($isShown): void
     {
@@ -2652,6 +2659,9 @@ 
     {
     }
 
+    /**
+     * @param string $action
+     */
     protected function configureActionButtons($buttonList, $action, $object = null)
     {
         return $buttonList;
@@ -2673,6 +2683,7 @@ 
      * NEXT_MAJOR: remove this method.
      *
      * @deprecated Use configureTabMenu instead
+     * @param string $action
      */
     protected function configureSideMenu(MenuItemInterface $menu, $action, AdminInterface $childAdmin = null)
     {

src/Admin/FieldDescriptionCollection.php

Doc Comments +1 added lines, -1 removed lines

@@ -30,7 +30,7 @@
     }
 
     /**
-     * @return array
+     * @return FieldDescriptionInterface[]
      */
     public function getElements()
     {

src/Generator/ControllerGenerator.php

Doc Comments +1 added lines, -1 removed lines

@@ -31,7 +31,7 @@
     private $file;
 
     /**
-     * @param array|string $skeletonDirectory
+     * @param string $skeletonDirectory
      */
     public function __construct($skeletonDirectory)
     {

src/Controller/CRUDController.php

Doc Comments +5 added lines, -5 removed lines

@@ -208,7 +208,7 @@ 
     /**
      * Delete action.
      *
-     * @param int|string|null $id
+     * @param integer|null $id
      *
      * @throws NotFoundHttpException If the object does not exist
      * @throws AccessDeniedException If access is not granted
@@ -726,7 +726,7 @@ 
     /**
      * View history revision of object.
      *
-     * @param int|string|null $id
+     * @param null|integer $id
      * @param string|null     $revision
      *
      * @throws AccessDeniedException If access is not granted
@@ -786,9 +786,9 @@ 
     /**
      * Compare history revisions of object.
      *
-     * @param int|string|null $id
-     * @param int|string|null $base_revision
-     * @param int|string|null $compare_revision
+     * @param null|integer $id
+     * @param null|integer $base_revision
+     * @param null|integer $compare_revision
      *
      * @throws AccessDeniedException If access is not granted
      * @throws NotFoundHttpException If the object or revision does not exist or the audit reader is not available

tests/Datagrid/PagerTest.php

Doc Comments +4 added lines

@@ -639,6 +639,10 @@
         $this->assertNull($this->pager->getQuery());
     }
 
+    /**
+     * @param Pager $obj
+     * @param string $name
+     */
     protected function callMethod($obj, $name, array $args = [])
     {
         $class = new \ReflectionClass($obj);

src/Form/ChoiceList/ModelChoiceList.php

Doc Comments +1 added lines, -1 removed lines

@@ -101,7 +101,7 @@
      * @param string            $class
      * @param string|null       $property
      * @param QueryBuilder|null $query
-     * @param array             $choices
+     * @param integer[]             $choices
      */
     public function __construct(
         ModelManagerInterface $modelManager,

src/Generator/AdminGenerator.php

Doc Comments +1 added lines, -1 removed lines

@@ -37,7 +37,7 @@
     private $file;
 
     /**
-     * @param array|string $skeletonDirectories
+     * @param string $skeletonDirectories
      */
     public function __construct(ModelManagerInterface $modelManager, $skeletonDirectories)
     {

src/Controller/PolyfillControllerTrait.php

Doc Comments +3 added lines

@@ -27,6 +27,9 @@
  */
 trait PolyfillControllerTrait
 {
+    /**
+     * @param string $methodName
+     */
     public function __call($methodName, $arguments): void
     {
         $this->proxyToController($methodName, $arguments);

src/Datagrid/Pager.php

Doc Comments +2 added lines, -2 removed lines

@@ -434,7 +434,7 @@ 
      * Returns a parameter.
      *
      * @param string $name
-     * @param mixed  $default
+     * @param null|string  $default
      *
      * @return mixed
      */
@@ -459,7 +459,7 @@ 
      * Sets a parameter.
      *
      * @param string $name
-     * @param mixed  $value
+     * @param string  $value
      */
     public function setParameter($name, $value): void
     {