Completed
Pull Request — 3.x (#4635)
by Konstantin
03:58
created
Admin/AbstractAdmin.php 2 patches
Doc Comments   +6 added lines, -4 removed lines patch added patch discarded remove patch
@@ -1165,6 +1165,8 @@  discard block
 block discarded – undo
1165 1165
 
1166 1166
     /**
1167 1167
      * {@inheritdoc}
1168
+     * @param string $name
1169
+     * @param string $adminCode
1168 1170
      */
1169 1171
     public function isCurrentRoute($name, $adminCode = null)
1170 1172
     {
@@ -2448,7 +2450,7 @@  discard block
 block discarded – undo
2448 2450
      *
2449 2451
      * @param string $context
2450 2452
      *
2451
-     * @return array
2453
+     * @return string[]
2452 2454
      */
2453 2455
     public function getPermissionsShow($context)
2454 2456
     {
@@ -2692,7 +2694,7 @@  discard block
 block discarded – undo
2692 2694
     /**
2693 2695
      * Set custom per page options.
2694 2696
      *
2695
-     * @param array $options
2697
+     * @param integer[] $options
2696 2698
      */
2697 2699
     public function setPerPageOptions(array $options)
2698 2700
     {
@@ -2854,6 +2856,7 @@  discard block
 block discarded – undo
2854 2856
 
2855 2857
     /**
2856 2858
      * {@inheritdoc}
2859
+     * @param string $action
2857 2860
      */
2858 2861
     public function configureActionButtons($action, $object = null)
2859 2862
     {
@@ -2985,7 +2988,6 @@  discard block
 block discarded – undo
2985 2988
     }
2986 2989
 
2987 2990
     /**
2988
-     * @param FormMapper $form
2989 2991
      */
2990 2992
     final public function getSearchResultLink($object)
2991 2993
     {
@@ -3102,7 +3104,7 @@  discard block
 block discarded – undo
3102 3104
      * NEXT_MAJOR: remove this method.
3103 3105
      *
3104 3106
      * @param MenuItemInterface $menu
3105
-     * @param                   $action
3107
+     * @param                   string $action
3106 3108
      * @param AdminInterface    $childAdmin
3107 3109
      *
3108 3110
      * @return mixed
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,6 @@
 block discarded – undo
13 13
 
14 14
 use Doctrine\Common\Util\ClassUtils;
15 15
 use Knp\Menu\FactoryInterface as MenuFactoryInterface;
16
-use Knp\Menu\ItemInterface;
17 16
 use Knp\Menu\ItemInterface as MenuItemInterface;
18 17
 use Sonata\AdminBundle\Builder\DatagridBuilderInterface;
19 18
 use Sonata\AdminBundle\Builder\FormContractorInterface;
Please login to merge, or discard this patch.
Admin/FieldDescriptionCollection.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
     }
31 31
 
32 32
     /**
33
-     * @return array
33
+     * @return FieldDescriptionInterface[]
34 34
      */
35 35
     public function getElements()
36 36
     {
Please login to merge, or discard this patch.
Admin/Pool.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -278,7 +278,7 @@  discard block
 block discarded – undo
278 278
     }
279 279
 
280 280
     /**
281
-     * @param array $adminServiceIds
281
+     * @param string[] $adminServiceIds
282 282
      */
283 283
     public function setAdminServiceIds(array $adminServiceIds)
284 284
     {
@@ -286,7 +286,7 @@  discard block
 block discarded – undo
286 286
     }
287 287
 
288 288
     /**
289
-     * @return array
289
+     * @return string[]
290 290
      */
291 291
     public function getAdminServiceIds()
292 292
     {
@@ -318,7 +318,7 @@  discard block
 block discarded – undo
318 318
     }
319 319
 
320 320
     /**
321
-     * @return array
321
+     * @return string[]
322 322
      */
323 323
     public function getTemplates()
324 324
     {
Please login to merge, or discard this patch.
Controller/CRUDController.php 1 patch
Doc Comments   +6 added lines, -5 removed lines patch added patch discarded remove patch
@@ -58,6 +58,7 @@  discard block
 block discarded – undo
58 58
 
59 59
     /**
60 60
      * {@inheritdoc}
61
+     * @param null|string $view
61 62
      */
62 63
     public function render($view, array $parameters = array(), Response $response = null)
63 64
     {
@@ -147,7 +148,7 @@  discard block
 block discarded – undo
147 148
     /**
148 149
      * Delete action.
149 150
      *
150
-     * @param int|string|null $id
151
+     * @param integer|null $id
151 152
      *
152 153
      * @return Response|RedirectResponse
153 154
      *
@@ -655,7 +656,7 @@  discard block
 block discarded – undo
655 656
     /**
656 657
      * View history revision of object.
657 658
      *
658
-     * @param int|string|null $id
659
+     * @param null|integer $id
659 660
      * @param string|null     $revision
660 661
      *
661 662
      * @return Response
@@ -715,9 +716,9 @@  discard block
 block discarded – undo
715 716
     /**
716 717
      * Compare history revisions of object.
717 718
      *
718
-     * @param int|string|null $id
719
-     * @param int|string|null $base_revision
720
-     * @param int|string|null $compare_revision
719
+     * @param null|integer $id
720
+     * @param null|integer $base_revision
721
+     * @param null|integer $compare_revision
721 722
      *
722 723
      * @return Response
723 724
      *
Please login to merge, or discard this patch.
Datagrid/ListMapper.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@
 block discarded – undo
67 67
      * @throws \RuntimeException
68 68
      *
69 69
      * @param mixed $name
70
-     * @param mixed $type
70
+     * @param string|null $type
71 71
      * @param array $fieldDescriptionOptions
72 72
      *
73 73
      * @return ListMapper
Please login to merge, or discard this patch.
Datagrid/Pager.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -459,7 +459,7 @@  discard block
 block discarded – undo
459 459
      * Returns a parameter.
460 460
      *
461 461
      * @param string $name
462
-     * @param mixed  $default
462
+     * @param null|string  $default
463 463
      *
464 464
      * @return mixed
465 465
      */
@@ -484,7 +484,7 @@  discard block
 block discarded – undo
484 484
      * Sets a parameter.
485 485
      *
486 486
      * @param string $name
487
-     * @param mixed  $value
487
+     * @param string  $value
488 488
      */
489 489
     public function setParameter($name, $value)
490 490
     {
@@ -595,7 +595,7 @@  discard block
 block discarded – undo
595 595
     }
596 596
 
597 597
     /**
598
-     * @param array $countColumn
598
+     * @param string[] $countColumn
599 599
      *
600 600
      * @return array
601 601
      */
Please login to merge, or discard this patch.
Form/DataTransformer/ModelsToArrayTransformer.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@
 block discarded – undo
50 50
      *
51 51
      * @param ModelChoiceList|LazyChoiceList|ModelChoiceLoader $choiceList
52 52
      * @param ModelManagerInterface                            $modelManager
53
-     * @param $class
53
+     * @param string $class
54 54
      *
55 55
      * @throws RuntimeException
56 56
      */
Please login to merge, or discard this patch.
Generator/AdminGenerator.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@
 block discarded – undo
38 38
 
39 39
     /**
40 40
      * @param ModelManagerInterface $modelManager
41
-     * @param array|string          $skeletonDirectories
41
+     * @param string          $skeletonDirectories
42 42
      */
43 43
     public function __construct(ModelManagerInterface $modelManager, $skeletonDirectories)
44 44
     {
Please login to merge, or discard this patch.
Generator/ControllerGenerator.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@
 block discarded – undo
31 31
     private $file;
32 32
 
33 33
     /**
34
-     * @param array|string $skeletonDirectory
34
+     * @param string $skeletonDirectory
35 35
      */
36 36
     public function __construct($skeletonDirectory)
37 37
     {
Please login to merge, or discard this patch.