Completed
Pull Request — 3.x (#5415)
by Grégoire
03:54
created
src/Admin/BaseFieldDescription.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -473,6 +473,9 @@
 block discarded – undo
473 473
         return $object->{$fieldName};
474 474
     }
475 475
 
476
+    /**
477
+     * @param string $fieldName
478
+     */
476 479
     private function cacheFieldGetter($object, ?string $fieldName, string $method, ?string $getter = null)
477 480
     {
478 481
         $getterKey = $this->getFieldGetterKey($object, $fieldName);
Please login to merge, or discard this patch.
src/Twig/GlobalVariables.php 1 patch
Doc Comments   +7 added lines, -3 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
     /**
72 72
      * @param string $code
73 73
      * @param string $action
74
-     * @param array  $parameters
74
+     * @param string[]  $parameters
75 75
      * @param int    $absolute
76 76
      *
77 77
      * @return string
@@ -86,8 +86,8 @@  discard block
 block discarded – undo
86 86
     /**
87 87
      * @param string $code
88 88
      * @param string $action
89
-     * @param mixed  $object
90
-     * @param array  $parameters
89
+     * @param string  $object
90
+     * @param string[]  $parameters
91 91
      * @param int    $absolute
92 92
      *
93 93
      * @return string
@@ -99,6 +99,10 @@  discard block
 block discarded – undo
99 99
         return $this->getAdminPool()->getAdminByAdminCode($code)->generateObjectUrl($action, $object, $parameters, $absolute);
100 100
     }
101 101
 
102
+    /**
103
+     * @param string $code
104
+     * @param string $action
105
+     */
102 106
     private function getCodeAction($code, $action): array
103 107
     {
104 108
         if ($pipe = strpos($code, '|')) {
Please login to merge, or discard this patch.
tests/Action/RetrieveAutocompleteItemsActionTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -298,6 +298,9 @@
 block discarded – undo
298 298
         $formConfig->getAttribute('target_admin_access_action')->willReturn('list');
299 299
     }
300 300
 
301
+    /**
302
+     * @param string $field
303
+     */
301 304
     private function configureFormConfigComplexPropertyArray($field): void
302 305
     {
303 306
         $form = $this->prophesize(Form::class);
Please login to merge, or discard this patch.
tests/Admin/Extension/LockExtensionTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -212,6 +212,10 @@
 block discarded – undo
212 212
         return new FormMapper($contractor->reveal(), $formBuilder, $this->admin->reveal());
213 213
     }
214 214
 
215
+    /**
216
+     * @param string $uniqid
217
+     * @param Request $request
218
+     */
215 219
     private function configureAdmin(
216 220
         ?string $uniqid = null,
217 221
         ?Request $request = null,
Please login to merge, or discard this patch.
tests/Admin/PoolTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -341,6 +341,9 @@
 block discarded – undo
341 341
         return $containerMock;
342 342
     }
343 343
 
344
+    /**
345
+     * @param string $serviceId
346
+     */
344 347
     private function getItemArray($serviceId): array
345 348
     {
346 349
         return [
Please login to merge, or discard this patch.
tests/Controller/CRUDControllerTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -3986,6 +3986,9 @@
 block discarded – undo
3986 3986
             ]);
3987 3987
     }
3988 3988
 
3989
+    /**
3990
+     * @param string $domain
3991
+     */
3989 3992
     private function expectTranslate(
3990 3993
         string $id,
3991 3994
         array $parameters = [],
Please login to merge, or discard this patch.
tests/Datagrid/DatagridMapperTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -263,6 +263,10 @@
 block discarded – undo
263 263
         ], array_keys($this->datagrid->getFilters()));
264 264
     }
265 265
 
266
+    /**
267
+     * @param string $name
268
+     * @param string $label
269
+     */
266 270
     private function getFieldDescriptionMock(?string $name = null, ?string $label = null): BaseFieldDescription
267 271
     {
268 272
         $fieldDescription = $this->getMockForAbstractClass(BaseFieldDescription::class);
Please login to merge, or discard this patch.
tests/Datagrid/ListMapperTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -257,6 +257,10 @@
 block discarded – undo
257 257
         ], true), print_r($this->fieldDescriptionCollection->getElements(), true));
258 258
     }
259 259
 
260
+    /**
261
+     * @param string $name
262
+     * @param string $label
263
+     */
260 264
     private function getFieldDescriptionMock(?string $name = null, ?string $label = null): BaseFieldDescription
261 265
     {
262 266
         $fieldDescription = $this->getMockForAbstractClass(BaseFieldDescription::class);
Please login to merge, or discard this patch.
tests/Menu/Provider/GroupMenuProviderTest.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -21,7 +21,6 @@
 block discarded – undo
21 21
 use PHPUnit\Framework\MockObject\MockObject as MockObject;
22 22
 use PHPUnit\Framework\TestCase;
23 23
 use Sonata\AdminBundle\Admin\AbstractAdmin;
24
-use Sonata\AdminBundle\Admin\AdminInterface;
25 24
 use Sonata\AdminBundle\Admin\Pool;
26 25
 use Sonata\AdminBundle\Menu\Provider\GroupMenuProvider;
27 26
 use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;
Please login to merge, or discard this patch.