Completed
Pull Request — 3.x (#5135)
by Grégoire
04:22
created
src/Admin/AbstractAdmin.php 1 patch
Doc Comments   +10 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1024,6 +1024,7 @@  discard block
 block discarded – undo
1024 1024
 
1025 1025
     /**
1026 1026
      * NEXT_MAJOR: remove this method.
1027
+     * @param string $subClass
1027 1028
      */
1028 1029
     public function addSubClass($subClass)
1029 1030
     {
@@ -1146,6 +1147,10 @@  discard block
 block discarded – undo
1146 1147
         return $this->routeGenerator->hasAdminRoute($this, $name);
1147 1148
     }
1148 1149
 
1150
+    /**
1151
+     * @param string $name
1152
+     * @param string $adminCode
1153
+     */
1149 1154
     public function isCurrentRoute($name, $adminCode = null)
1150 1155
     {
1151 1156
         if (!$this->hasRequest()) {
@@ -2291,7 +2296,7 @@  discard block
 block discarded – undo
2291 2296
      *
2292 2297
      * @param string $context
2293 2298
      *
2294
-     * @return array
2299
+     * @return string[]
2295 2300
      */
2296 2301
     public function getPermissionsShow($context)
2297 2302
     {
@@ -2596,6 +2601,9 @@  discard block
 block discarded – undo
2596 2601
         return true;
2597 2602
     }
2598 2603
 
2604
+    /**
2605
+     * @param string $action
2606
+     */
2599 2607
     public function configureActionButtons($action, $object = null)
2600 2608
     {
2601 2609
         $list = [];
@@ -2847,6 +2855,7 @@  discard block
 block discarded – undo
2847 2855
     /**
2848 2856
      * NEXT_MAJOR: remove this method.
2849 2857
      *
2858
+     * @param string $action
2850 2859
      * @return mixed
2851 2860
      *
2852 2861
      * @deprecated Use configureTabMenu instead
Please login to merge, or discard this patch.
src/Twig/GlobalVariables.php 1 patch
Doc Comments   +5 added lines, -3 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
     /**
68 68
      * @param string $code
69 69
      * @param string $action
70
-     * @param array  $parameters
70
+     * @param string[]  $parameters
71 71
      * @param int    $absolute
72 72
      *
73 73
      * @return string
@@ -82,8 +82,8 @@  discard block
 block discarded – undo
82 82
     /**
83 83
      * @param string $code
84 84
      * @param string $action
85
-     * @param mixed  $object
86
-     * @param array  $parameters
85
+     * @param string  $object
86
+     * @param string[]  $parameters
87 87
      * @param int    $absolute
88 88
      *
89 89
      * @return string
@@ -96,6 +96,8 @@  discard block
 block discarded – undo
96 96
     }
97 97
 
98 98
     /**
99
+     * @param string $code
100
+     * @param string $action
99 101
      * @return array
100 102
      */
101 103
     private function getCodeAction($code, $action)
Please login to merge, or discard this patch.
src/Admin/AdminInterface.php 1 patch
Doc Comments   +78 added lines, -4 removed lines patch added patch discarded remove patch
@@ -32,6 +32,9 @@  discard block
 block discarded – undo
32 32
  */
33 33
 interface AdminInterface extends AccessRegistryInterface, FieldDescriptionRegistryInterface, LifecycleHookProviderInterface, MenuBuilderInterface, ParentAdminInterface, UrlGeneratorInterface
34 34
 {
35
+    /**
36
+     * @return void
37
+     */
35 38
     public function setMenuFactory(MenuFactoryInterface $menuFactory);
36 39
 
37 40
     /**
@@ -39,8 +42,14 @@  discard block
 block discarded – undo
39 42
      */
40 43
     public function getMenuFactory();
41 44
 
45
+    /**
46
+     * @return void
47
+     */
42 48
     public function setFormContractor(FormContractorInterface $formContractor);
43 49
 
50
+    /**
51
+     * @return void
52
+     */
44 53
     public function setListBuilder(ListBuilderInterface $listBuilder);
45 54
 
46 55
     /**
@@ -48,6 +57,9 @@  discard block
 block discarded – undo
48 57
      */
49 58
     public function getListBuilder();
50 59
 
60
+    /**
61
+     * @return void
62
+     */
51 63
     public function setDatagridBuilder(DatagridBuilderInterface $datagridBuilder);
52 64
 
53 65
     /**
@@ -55,6 +67,9 @@  discard block
 block discarded – undo
55 67
      */
56 68
     public function getDatagridBuilder();
57 69
 
70
+    /**
71
+     * @return void
72
+     */
58 73
     public function setTranslator(TranslatorInterface $translator);
59 74
 
60 75
     /**
@@ -62,8 +77,14 @@  discard block
 block discarded – undo
62 77
      */
63 78
     public function getTranslator();
64 79
 
80
+    /**
81
+     * @return void
82
+     */
65 83
     public function setRequest(Request $request);
66 84
 
85
+    /**
86
+     * @return void
87
+     */
67 88
     public function setConfigurationPool(Pool $pool);
68 89
 
69 90
     /**
@@ -76,6 +97,9 @@  discard block
 block discarded – undo
76 97
      */
77 98
     public function getClass();
78 99
 
100
+    /**
101
+     * @return void
102
+     */
79 103
     public function attachAdminClass(FieldDescriptionInterface $fieldDescription);
80 104
 
81 105
     /**
@@ -87,6 +111,7 @@  discard block
 block discarded – undo
87 111
      * Set base controller name.
88 112
      *
89 113
      * @param string $baseControllerName
114
+     * @return void
90 115
      */
91 116
     public function setBaseControllerName($baseControllerName);
92 117
 
@@ -159,6 +184,9 @@  discard block
 block discarded – undo
159 184
      */
160 185
     public function getSecurityInformation();
161 186
 
187
+    /**
188
+     * @return void
189
+     */
162 190
     public function setParentFieldDescription(FieldDescriptionInterface $parentFieldDescription);
163 191
 
164 192
     /**
@@ -223,6 +251,9 @@  discard block
 block discarded – undo
223 251
      */
224 252
     // public function isCurrentRoute($name, $adminCode = null);
225 253
 
254
+    /**
255
+     * @return void
256
+     */
226 257
     public function setSecurityHandler(SecurityHandlerInterface $securityHandler);
227 258
 
228 259
     /**
@@ -250,12 +281,13 @@  discard block
 block discarded – undo
250 281
      *
251 282
      * @param object $entity
252 283
      *
253
-     * @return mixed
284
+     * @return string
254 285
      */
255 286
     public function id($entity);
256 287
 
257 288
     /**
258 289
      * @param ValidatorInterface $validator
290
+     * @return void
259 291
      */
260 292
     public function setValidator($validator);
261 293
 
@@ -265,10 +297,13 @@  discard block
 block discarded – undo
265 297
     public function getValidator();
266 298
 
267 299
     /**
268
-     * @return array
300
+     * @return FieldDescriptionCollection
269 301
      */
270 302
     public function getShow();
271 303
 
304
+    /**
305
+     * @return void
306
+     */
272 307
     public function setFormTheme(array $formTheme);
273 308
 
274 309
     /**
@@ -276,6 +311,9 @@  discard block
 block discarded – undo
276 311
      */
277 312
     public function getFormTheme();
278 313
 
314
+    /**
315
+     * @return void
316
+     */
279 317
     public function setFilterTheme(array $filterTheme);
280 318
 
281 319
     /**
@@ -283,6 +321,9 @@  discard block
 block discarded – undo
283 321
      */
284 322
     public function getFilterTheme();
285 323
 
324
+    /**
325
+     * @return void
326
+     */
286 327
     public function addExtension(AdminExtensionInterface $extension);
287 328
 
288 329
     /**
@@ -292,6 +333,9 @@  discard block
 block discarded – undo
292 333
      */
293 334
     public function getExtensions();
294 335
 
336
+    /**
337
+     * @return void
338
+     */
295 339
     public function setRouteBuilder(RouteBuilderInterface $routeBuilder);
296 340
 
297 341
     /**
@@ -306,6 +350,9 @@  discard block
 block discarded – undo
306 350
      */
307 351
     public function toString($object);
308 352
 
353
+    /**
354
+     * @return void
355
+     */
309 356
     public function setLabelTranslatorStrategy(LabelTranslatorStrategyInterface $labelTranslatorStrategy);
310 357
 
311 358
     /**
@@ -329,6 +376,7 @@  discard block
 block discarded – undo
329 376
 
330 377
     /**
331 378
      * @param string $uniqId
379
+     * @return void
332 380
      */
333 381
     public function setUniqid($uniqId);
334 382
 
@@ -348,6 +396,7 @@  discard block
 block discarded – undo
348 396
 
349 397
     /**
350 398
      * @param object $subject
399
+     * @return void
351 400
      */
352 401
     public function setSubject($subject);
353 402
 
@@ -384,7 +433,7 @@  discard block
 block discarded – undo
384 433
     /**
385 434
      * Returns the array of allowed export formats.
386 435
      *
387
-     * @return array
436
+     * @return string[]
388 437
      */
389 438
     public function getExportFormats();
390 439
 
@@ -395,6 +444,9 @@  discard block
 block discarded – undo
395 444
      */
396 445
     public function getDataSourceIterator();
397 446
 
447
+    /**
448
+     * @return void
449
+     */
398 450
     public function configure();
399 451
 
400 452
     /**
@@ -403,6 +455,7 @@  discard block
 block discarded – undo
403 455
      * @param string $actionName
404 456
      * @param array  $idx
405 457
      * @param bool   $allElements
458
+     * @return void
406 459
      */
407 460
     public function preBatchAction($actionName, ProxyQueryInterface $query, array &$idx, $allElements);
408 461
 
@@ -427,6 +480,7 @@  discard block
 block discarded – undo
427 480
      *
428 481
      * @deprecated this feature cannot be stable, use a custom validator,
429 482
      *             the feature will be removed with Symfony 2.2
483
+     * @return void
430 484
      */
431 485
     public function validate(ErrorElement $errorElement, $object);
432 486
 
@@ -441,14 +495,18 @@  discard block
 block discarded – undo
441 495
      * Add object security, fe. make the current user owner of the object.
442 496
      *
443 497
      * @param mixed $object
498
+     * @return void
444 499
      */
445 500
     public function createObjectSecurity($object);
446 501
 
447 502
     /**
448
-     * @return ?AdminInterface
503
+     * @return AdminInterface|null
449 504
      */
450 505
     public function getParent();
451 506
 
507
+    /**
508
+     * @return void
509
+     */
452 510
     public function setParent(self $admin);
453 511
 
454 512
     /**
@@ -473,6 +531,7 @@  discard block
 block discarded – undo
473 531
      * Set the translation domain.
474 532
      *
475 533
      * @param string $translationDomain the translation domain
534
+     * @return void
476 535
      */
477 536
     public function setTranslationDomain($translationDomain);
478 537
 
@@ -492,21 +551,29 @@  discard block
 block discarded – undo
492 551
 
493 552
     /**
494 553
      * Set the form groups.
554
+     * @return void
495 555
      */
496 556
     public function setFormGroups(array $formGroups);
497 557
 
498 558
     public function getFormTabs();
499 559
 
560
+    /**
561
+     * @return void
562
+     */
500 563
     public function setFormTabs(array $formTabs);
501 564
 
502 565
     public function getShowTabs();
503 566
 
567
+    /**
568
+     * @return void
569
+     */
504 570
     public function setShowTabs(array $showTabs);
505 571
 
506 572
     /**
507 573
      * Remove a form group field.
508 574
      *
509 575
      * @param string $key
576
+     * @return void
510 577
      */
511 578
     public function removeFieldFromFormGroup($key);
512 579
 
@@ -519,6 +586,7 @@  discard block
 block discarded – undo
519 586
 
520 587
     /**
521 588
      * Set the show groups.
589
+     * @return void
522 590
      */
523 591
     public function setShowGroups(array $showGroups);
524 592
 
@@ -526,6 +594,7 @@  discard block
 block discarded – undo
526 594
      * Reorder items in showGroup.
527 595
      *
528 596
      * @param string $group
597
+     * @return void
529 598
      */
530 599
     public function reorderShowGroup($group, array $keys);
531 600
 
@@ -533,6 +602,7 @@  discard block
 block discarded – undo
533 602
      * add a FieldDescription.
534 603
      *
535 604
      * @param string $name
605
+     * @return void
536 606
      */
537 607
     public function addFormFieldDescription($name, FieldDescriptionInterface $fieldDescription);
538 608
 
@@ -540,6 +610,7 @@  discard block
 block discarded – undo
540 610
      * Remove a FieldDescription.
541 611
      *
542 612
      * @param string $name
613
+     * @return void
543 614
      */
544 615
     public function removeFormFieldDescription($name);
545 616
 
@@ -552,6 +623,7 @@  discard block
 block discarded – undo
552 623
 
553 624
     /**
554 625
      * Sets the list of supported sub classes.
626
+     * @return void
555 627
      */
556 628
     public function setSubClasses(array $subClasses);
557 629
 
@@ -620,6 +692,7 @@  discard block
 block discarded – undo
620 692
      * Set the current child status.
621 693
      *
622 694
      * @param bool $currentChild
695
+     * @return void
623 696
      */
624 697
     public function setCurrentChild($currentChild);
625 698
 
@@ -653,6 +726,7 @@  discard block
 block discarded – undo
653 726
 
654 727
     /**
655 728
      * @param string $mode
729
+     * @return void
656 730
      */
657 731
     public function setListMode($mode);
658 732
 
Please login to merge, or discard this patch.
src/Admin/FieldDescriptionInterface.php 1 patch
Doc Comments   +13 added lines, -1 removed lines patch added patch discarded remove patch
@@ -20,6 +20,7 @@  discard block
 block discarded – undo
20 20
      * set the field name.
21 21
      *
22 22
      * @param string $fieldName
23
+     * @return void
23 24
      */
24 25
     public function setFieldName($fieldName);
25 26
 
@@ -34,6 +35,7 @@  discard block
 block discarded – undo
34 35
      * Set the name.
35 36
      *
36 37
      * @param string $name
38
+     * @return void
37 39
      */
38 40
     public function setName($name);
39 41
 
@@ -59,6 +61,7 @@  discard block
 block discarded – undo
59 61
      *
60 62
      * @param string $name
61 63
      * @param mixed  $value
64
+     * @return void
62 65
      */
63 66
     public function setOption($name, $value);
64 67
 
@@ -68,6 +71,7 @@  discard block
 block discarded – undo
68 71
      *   - template.
69 72
      *
70 73
      * Then the value are copied across to the related property value
74
+     * @return void
71 75
      */
72 76
     public function setOptions(array $options);
73 77
 
@@ -82,6 +86,7 @@  discard block
 block discarded – undo
82 86
      * return the template used to render the field.
83 87
      *
84 88
      * @param string $template
89
+     * @return void
85 90
      */
86 91
     public function setTemplate($template);
87 92
 
@@ -97,6 +102,7 @@  discard block
 block discarded – undo
97 102
      * or the logic associated to the current FieldDescription object.
98 103
      *
99 104
      * @param string $type
105
+     * @return void
100 106
      */
101 107
     public function setType($type);
102 108
 
@@ -109,6 +115,7 @@  discard block
 block discarded – undo
109 115
 
110 116
     /**
111 117
      * set the parent Admin (only used in nested admin).
118
+     * @return void
112 119
      */
113 120
     public function setParent(AdminInterface $parent);
114 121
 
@@ -170,13 +177,14 @@  discard block
 block discarded – undo
170 177
      * set the association admin instance (only used if the field is linked to an Admin).
171 178
      *
172 179
      * @param AdminInterface $associationAdmin the associated admin
180
+     * @return void
173 181
      */
174 182
     public function setAssociationAdmin(AdminInterface $associationAdmin);
175 183
 
176 184
     /**
177 185
      * return the associated Admin instance (only used if the field is linked to an Admin).
178 186
      *
179
-     * @return ?AdminInterface
187
+     * @return AdminInterface
180 188
      */
181 189
     public function getAssociationAdmin();
182 190
 
@@ -198,6 +206,7 @@  discard block
 block discarded – undo
198 206
 
199 207
     /**
200 208
      * set the admin class linked to this FieldDescription.
209
+     * @return void
201 210
      */
202 211
     public function setAdmin(AdminInterface $admin);
203 212
 
@@ -213,11 +222,13 @@  discard block
 block discarded – undo
213 222
      * @param string $name
214 223
      *
215 224
      * @throws \RuntimeException
225
+     * @return void
216 226
      */
217 227
     public function mergeOption($name, array $options = []);
218 228
 
219 229
     /**
220 230
      * merge options values.
231
+     * @return void
221 232
      */
222 233
     public function mergeOptions(array $options = []);
223 234
 
@@ -225,6 +236,7 @@  discard block
 block discarded – undo
225 236
      * set the original mapping type (only used if the field is linked to an entity).
226 237
      *
227 238
      * @param string|int $mappingType
239
+     * @return void
228 240
      */
229 241
     public function setMappingType($mappingType);
230 242
 
Please login to merge, or discard this patch.
src/Command/Validators.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@
 block discarded – undo
41 41
      *
42 42
      * @throws \InvalidArgumentException
43 43
      *
44
-     * @return array
44
+     * @return string[]
45 45
      */
46 46
     public static function validateEntityName($shortcut)
47 47
     {
Please login to merge, or discard this patch.
src/Datagrid/DatagridInterface.php 1 patch
Doc Comments   +7 added lines, -1 removed lines patch added patch discarded remove patch
@@ -35,6 +35,9 @@  discard block
 block discarded – undo
35 35
      */
36 36
     public function getResults();
37 37
 
38
+    /**
39
+     * @return void
40
+     */
38 41
     public function buildPager();
39 42
 
40 43
     /**
@@ -49,6 +52,7 @@  discard block
 block discarded – undo
49 52
 
50 53
     /**
51 54
      * Reorder filters.
55
+     * @return void
52 56
      */
53 57
     public function reorderFilters(array $keys);
54 58
 
@@ -65,7 +69,8 @@  discard block
 block discarded – undo
65 69
     /**
66 70
      * @param string  $name
67 71
      * @param ?string $operator
68
-     * @param mixed   $value
72
+     * @param string   $value
73
+     * @return void
69 74
      */
70 75
     public function setValue($name, $operator, $value);
71 76
 
@@ -90,6 +95,7 @@  discard block
 block discarded – undo
90 95
 
91 96
     /**
92 97
      * @param string $name
98
+     * @return void
93 99
      */
94 100
     public function removeFilter($name);
95 101
 
Please login to merge, or discard this patch.
src/Datagrid/ProxyQueryInterface.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
     public function getSingleScalarResult();
65 65
 
66 66
     /**
67
-     * @param ?int $firstResult
67
+     * @param null|integer $firstResult
68 68
      *
69 69
      * @return ProxyQueryInterface
70 70
      */
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
     public function getFirstResult();
77 77
 
78 78
     /**
79
-     * @param ?int $maxResults
79
+     * @param null|integer $maxResults
80 80
      *
81 81
      * @return ProxyQueryInterface
82 82
      */
Please login to merge, or discard this patch.