Completed
Pull Request — 3.x (#6277)
by
unknown
03:02
created
src/Util/AdminObjectAclData.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,6 @@
 block discarded – undo
17 17
 use Sonata\AdminBundle\Security\Handler\AclSecurityHandlerInterface;
18 18
 use Symfony\Component\Form\Form;
19 19
 use Symfony\Component\Form\FormInterface;
20
-use Symfony\Component\Security\Acl\Domain\Acl;
21 20
 use Symfony\Component\Security\Acl\Model\MutableAclInterface;
22 21
 
23 22
 /**
Please login to merge, or discard this patch.
src/Util/AdminObjectAclManipulator.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -15,7 +15,6 @@
 block discarded – undo
15 15
 
16 16
 use Sonata\AdminBundle\Form\Type\AclMatrixType;
17 17
 use Symfony\Component\Form\Extension\Core\Type\FormType;
18
-use Symfony\Component\Form\Form;
19 18
 use Symfony\Component\Form\FormBuilderInterface;
20 19
 use Symfony\Component\Form\FormFactoryInterface;
21 20
 use Symfony\Component\Form\FormInterface;
Please login to merge, or discard this patch.
src/Security/Handler/AclSecurityHandler.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -191,6 +191,7 @@
 block discarded – undo
191 191
      * NEXT_MAJOR: change signature to `addObjectOwner(MutableAclInterface $acl, ?UserSecurityIdentity $securityIdentity = null): void`.
192 192
      *
193 193
      * @param MutableAclInterface $acl
194
+     * @param UserSecurityIdentity $securityIdentity
194 195
      *
195 196
      * @return void
196 197
      */
Please login to merge, or discard this patch.
src/Security/Handler/AclSecurityHandlerInterface.php 1 patch
Doc Comments   +5 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,6 +25,7 @@  discard block
 block discarded – undo
25 25
 {
26 26
     /**
27 27
      * Set the permissions not related to an object instance and also to be available when objects do not exist.
28
+     * @return void
28 29
      */
29 30
     public function setAdminPermissions(array $permissions);
30 31
 
@@ -37,6 +38,7 @@  discard block
 block discarded – undo
37 38
 
38 39
     /**
39 40
      * Set the permissions related to an object instance.
41
+     * @return void
40 42
      */
41 43
     public function setObjectPermissions(array $permissions);
42 44
 
@@ -81,6 +83,7 @@  discard block
 block discarded – undo
81 83
      * Add the object class ACE's to the object ACL.
82 84
      *
83 85
      * NEXT_MAJOR: change signature to `addObjectClassAces(MutableAclInterface $acl, array $roleInformation = []): void`.
86
+     * @return void
84 87
      */
85 88
     public function addObjectClassAces(AclInterface $acl, array $roleInformation = []);
86 89
 
@@ -106,6 +109,7 @@  discard block
 block discarded – undo
106 109
 
107 110
     /**
108 111
      * Delete the ACL.
112
+     * @return void
109 113
      */
110 114
     public function deleteAcl(ObjectIdentityInterface $objectIdentity);
111 115
 
@@ -116,7 +120,7 @@  discard block
 block discarded – undo
116 120
      *
117 121
      * @param string $role
118 122
      *
119
-     * @return array-key|false index if found, FALSE if not found
123
+     * @return integer index if found, FALSE if not found
120 124
      */
121 125
     public function findClassAceIndexByRole(AclInterface $acl, $role);
122 126
 
Please login to merge, or discard this patch.