Completed
Pull Request — 3.x (#6277)
by
unknown
02:56
created
src/Util/AdminObjectAclData.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,6 @@
 block discarded – undo
17 17
 use Sonata\AdminBundle\Security\Handler\AclSecurityHandlerInterface;
18 18
 use Symfony\Component\Form\Form;
19 19
 use Symfony\Component\Form\FormInterface;
20
-use Symfony\Component\Security\Acl\Domain\Acl;
21 20
 use Symfony\Component\Security\Acl\Model\MutableAclInterface;
22 21
 
23 22
 /**
Please login to merge, or discard this patch.
src/Util/AdminObjectAclManipulator.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -15,7 +15,6 @@
 block discarded – undo
15 15
 
16 16
 use Sonata\AdminBundle\Form\Type\AclMatrixType;
17 17
 use Symfony\Component\Form\Extension\Core\Type\FormType;
18
-use Symfony\Component\Form\Form;
19 18
 use Symfony\Component\Form\FormBuilderInterface;
20 19
 use Symfony\Component\Form\FormFactoryInterface;
21 20
 use Symfony\Component\Form\FormInterface;
Please login to merge, or discard this patch.
src/Security/Handler/AclSecurityHandler.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -189,6 +189,7 @@
 block discarded – undo
189 189
 
190 190
     /**
191 191
      * NEXT_MAJOR: change signature to `addObjectClassAces(MutableAclInterface $acl, array $roleInformation = []): void`.
192
+     * @param UserSecurityIdentity $securityIdentity
192 193
      */
193 194
     public function addObjectOwner(AclInterface $acl, ?UserSecurityIdentity $securityIdentity = null)
194 195
     {
Please login to merge, or discard this patch.
src/Security/Handler/AclSecurityHandlerInterface.php 1 patch
Doc Comments   +6 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,6 +25,7 @@  discard block
 block discarded – undo
25 25
 {
26 26
     /**
27 27
      * Set the permissions not related to an object instance and also to be available when objects do not exist.
28
+     * @return void
28 29
      */
29 30
     public function setAdminPermissions(array $permissions);
30 31
 
@@ -37,6 +38,7 @@  discard block
 block discarded – undo
37 38
 
38 39
     /**
39 40
      * Set the permissions related to an object instance.
41
+     * @return void
40 42
      */
41 43
     public function setObjectPermissions(array $permissions);
42 44
 
@@ -70,6 +72,7 @@  discard block
 block discarded – undo
70 72
      * Add an object owner ACE to the object ACL.
71 73
      *
72 74
      * NEXT_MAJOR: change signature to `addObjectOwner(MutableAclInterface $acl, ?UserSecurityIdentity $securityIdentity = null): void`.
75
+     * @return void
73 76
      */
74 77
     public function addObjectOwner(AclInterface $acl, ?UserSecurityIdentity $securityIdentity = null);
75 78
 
@@ -77,6 +80,7 @@  discard block
 block discarded – undo
77 80
      * Add the object class ACE's to the object ACL.
78 81
      *
79 82
      * NEXT_MAJOR: change signature to `addObjectClassAces(MutableAclInterface $acl, array $roleInformation = []): void`.
83
+     * @return void
80 84
      */
81 85
     public function addObjectClassAces(AclInterface $acl, array $roleInformation = []);
82 86
 
@@ -102,6 +106,7 @@  discard block
 block discarded – undo
102 106
 
103 107
     /**
104 108
      * Delete the ACL.
109
+     * @return void
105 110
      */
106 111
     public function deleteAcl(ObjectIdentityInterface $objectIdentity);
107 112
 
@@ -112,7 +117,7 @@  discard block
 block discarded – undo
112 117
      *
113 118
      * @param string $role
114 119
      *
115
-     * @return array-key|false index if found, FALSE if not found
120
+     * @return integer index if found, FALSE if not found
116 121
      */
117 122
     public function findClassAceIndexByRole(AclInterface $acl, $role);
118 123
 
Please login to merge, or discard this patch.