sonata-project / SonataAdminBundle

src/Admin/AbstractAdmin.php

Unused Use Statements -1 removed lines

@@ -13,7 +13,6 @@
 
 use Doctrine\Common\Util\ClassUtils;
 use Knp\Menu\FactoryInterface as MenuFactoryInterface;
-use Knp\Menu\ItemInterface;
 use Knp\Menu\ItemInterface as MenuItemInterface;
 use Sonata\AdminBundle\Builder\DatagridBuilderInterface;
 use Sonata\AdminBundle\Builder\FormContractorInterface;

Doc Comments +7 added lines, -4 removed lines

@@ -1019,6 +1019,7 @@ 
 
     /**
      * NEXT_MAJOR: remove this method
+     * @param string $subClass
      */
     public function addSubClass($subClass)
     {
@@ -1172,6 +1173,8 @@ 
 
     /**
      * {@inheritdoc}
+     * @param string $name
+     * @param string $adminCode
      */
     public function isCurrentRoute($name, $adminCode = null)
     {
@@ -2543,7 +2546,7 @@ 
      *
      * @param string $context
      *
-     * @return array
+     * @return string[]
      */
     public function getPermissionsShow($context)
     {
@@ -2786,7 +2789,7 @@ 
     /**
      * Set custom per page options.
      *
-     * @param array $options
+     * @param integer[] $options
      */
     public function setPerPageOptions(array $options)
     {
@@ -2948,6 +2951,7 @@ 
 
     /**
      * {@inheritdoc}
+     * @param string $action
      */
     public function configureActionButtons($action, $object = null)
     {
@@ -3079,7 +3083,6 @@ 
     }
 
     /**
-     * @param FormMapper $form
      */
     final public function getSearchResultLink($object)
     {
@@ -3196,7 +3199,7 @@ 
      * NEXT_MAJOR: remove this method.
      *
      * @param MenuItemInterface $menu
-     * @param                   $action
+     * @param                   string $action
      * @param AdminInterface    $childAdmin
      *
      * @return mixed

src/Admin/FieldDescriptionCollection.php

Doc Comments +1 added lines, -1 removed lines

@@ -30,7 +30,7 @@
     }
 
     /**
-     * @return array
+     * @return FieldDescriptionInterface[]
      */
     public function getElements()
     {

src/Admin/Pool.php

Doc Comments +3 added lines, -3 removed lines

@@ -278,7 +278,7 @@ 
     }
 
     /**
-     * @param array $adminServiceIds
+     * @param string[] $adminServiceIds
      */
     public function setAdminServiceIds(array $adminServiceIds)
     {
@@ -286,7 +286,7 @@ 
     }
 
     /**
-     * @return array
+     * @return string[]
      */
     public function getAdminServiceIds()
     {
@@ -318,7 +318,7 @@ 
     }
 
     /**
-     * @return array
+     * @return string[]
      */
     public function getTemplates()
     {

src/Datagrid/Pager.php

Doc Comments +3 added lines, -3 removed lines

@@ -459,7 +459,7 @@ 
      * Returns a parameter.
      *
      * @param string $name
-     * @param mixed  $default
+     * @param null|string  $default
      *
      * @return mixed
      */
@@ -484,7 +484,7 @@ 
      * Sets a parameter.
      *
      * @param string $name
-     * @param mixed  $value
+     * @param string  $value
      */
     public function setParameter($name, $value)
     {
@@ -595,7 +595,7 @@ 
     }
 
     /**
-     * @param array $countColumn
+     * @param string[] $countColumn
      *
      * @return array
      */

src/Generator/AdminGenerator.php

Doc Comments +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
 
     /**
      * @param ModelManagerInterface $modelManager
-     * @param array|string          $skeletonDirectories
+     * @param string          $skeletonDirectories
      */
     public function __construct(ModelManagerInterface $modelManager, $skeletonDirectories)
     {

src/Generator/ControllerGenerator.php

Doc Comments +1 added lines, -1 removed lines

@@ -31,7 +31,7 @@
     private $file;
 
     /**
-     * @param array|string $skeletonDirectory
+     * @param string $skeletonDirectory
      */
     public function __construct($skeletonDirectory)
     {

src/Twig/Extension/SonataAdminExtension.php

Doc Comments +5 added lines, -5 removed lines

@@ -123,7 +123,7 @@ 
     /**
      * render a list element from the FieldDescription.
      *
-     * @param mixed                     $object
+     * @param \stdClass                     $object
      * @param FieldDescriptionInterface $fieldDescription
      * @param array                     $params
      *
@@ -226,7 +226,7 @@ 
      * render a view element.
      *
      * @param FieldDescriptionInterface $fieldDescription
-     * @param mixed                     $object
+     * @param \stdClass                     $object
      *
      * @return string
      */
@@ -365,7 +365,7 @@ 
     /**
      * Get the identifiers as a string that is safe to use in a url.
      *
-     * @param object         $model
+     * @param \stdClass         $model
      * @param AdminInterface $admin
      *
      * @return string string representation of the id that is safe to use in a url
@@ -390,7 +390,7 @@ 
     /**
      * @param $type
      *
-     * @return string|bool
+     * @return string|false
      */
     public function getXEditableType($type)
     {
@@ -447,7 +447,7 @@ 
      * @param FieldDescriptionInterface $fieldDescription
      * @param string                    $defaultTemplate
      *
-     * @return \Twig_TemplateInterface
+     * @return \Twig_Template
      */
     protected function getTemplate(
         FieldDescriptionInterface $fieldDescription,

tests/Admin/Extension/LockExtensionTest.php

Doc Comments +4 added lines

@@ -195,6 +195,10 @@
         return new FormMapper($contractor->reveal(), $formBuilder, $this->admin->reveal());
     }
 
+    /**
+     * @param string $uniqid
+     * @param Request $request
+     */
     private function configureAdmin($uniqid = null, $request = null, $modelManager = null)
     {
         $this->admin->getUniqid()->willReturn($uniqid);

tests/Controller/CRUDControllerTest.php

Doc Comments +7 added lines

@@ -3759,6 +3759,9 @@ 
         ];
     }
 
+    /**
+     * @param string $method
+     */
     private function assertLoggerLogsModelManagerException($subject, $method)
     {
         $exception = new ModelManagerException(
@@ -3781,6 +3784,10 @@ 
             ]);
     }
 
+    /**
+     * @param string $id
+     * @param string $domain
+     */
     private function expectTranslate($id, array $parameters = [], $domain = null, $locale = null)
     {
         $this->translator->expects($this->once())