Completed
Pull Request — master (#4938)
by Andrey F.
10:45
created
src/Admin/AbstractAdmin.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,6 @@
 block discarded – undo
13 13
 
14 14
 use Doctrine\Common\Util\ClassUtils;
15 15
 use Knp\Menu\FactoryInterface as MenuFactoryInterface;
16
-use Knp\Menu\ItemInterface;
17 16
 use Knp\Menu\ItemInterface as MenuItemInterface;
18 17
 use Sonata\AdminBundle\Builder\DatagridBuilderInterface;
19 18
 use Sonata\AdminBundle\Builder\FormContractorInterface;
Please login to merge, or discard this patch.
Doc Comments   +6 added lines, -1 removed lines patch added patch discarded remove patch
@@ -863,6 +863,7 @@  discard block
 block discarded – undo
863 863
 
864 864
     /**
865 865
      * NEXT_MAJOR: remove this method.
866
+     * @param string $subClass
866 867
      */
867 868
     public function addSubClass($subClass): void
868 869
     {
@@ -1962,7 +1963,7 @@  discard block
 block discarded – undo
1962 1963
      *
1963 1964
      * @param string $context
1964 1965
      *
1965
-     * @return array
1966
+     * @return string[]
1966 1967
      */
1967 1968
     public function getPermissionsShow($context)
1968 1969
     {
@@ -2477,6 +2478,9 @@  discard block
 block discarded – undo
2477 2478
     {
2478 2479
     }
2479 2480
 
2481
+    /**
2482
+     * @param string $action
2483
+     */
2480 2484
     protected function configureActionButtons($buttonList, $action, $object = null)
2481 2485
     {
2482 2486
         return $buttonList;
@@ -2497,6 +2501,7 @@  discard block
 block discarded – undo
2497 2501
     /**
2498 2502
      * NEXT_MAJOR: remove this method.
2499 2503
      *
2504
+     * @param string $action
2500 2505
      * @return mixed
2501 2506
      *
2502 2507
      * @deprecated Use configureTabMenu instead
Please login to merge, or discard this patch.
src/Admin/FieldDescriptionCollection.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
     }
31 31
 
32 32
     /**
33
-     * @return array
33
+     * @return FieldDescriptionInterface[]
34 34
      */
35 35
     public function getElements()
36 36
     {
Please login to merge, or discard this patch.
src/Generator/ControllerGenerator.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@
 block discarded – undo
31 31
     private $file;
32 32
 
33 33
     /**
34
-     * @param array|string $skeletonDirectory
34
+     * @param string $skeletonDirectory
35 35
      */
36 36
     public function __construct($skeletonDirectory)
37 37
     {
Please login to merge, or discard this patch.
tests/Fixtures/Admin/PostAdmin.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -8,6 +8,9 @@
 block discarded – undo
8 8
 {
9 9
     protected $metadataClass = null;
10 10
 
11
+    /**
12
+     * @param string $associationMapping
13
+     */
11 14
     public function setParentAssociationMapping($associationMapping)
12 15
     {
13 16
         $this->parentAssociationMapping = $associationMapping;
Please login to merge, or discard this patch.
tests/Menu/Matcher/Voter/AdminVoterTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -70,6 +70,7 @@  discard block
 block discarded – undo
70 70
 
71 71
     /**
72 72
      * {@inheritdoc}
73
+     * @param string $code
73 74
      */
74 75
     private function getAdmin($code, $list = false, $granted = false)
75 76
     {
@@ -102,6 +103,8 @@  discard block
 block discarded – undo
102 103
 
103 104
     /**
104 105
      * {@inheritdoc}
106
+     * @param string $parentCode
107
+     * @param string $childCode
105 108
      */
106 109
     private function getChildAdmin($parentCode, $childCode, $list = false, $granted = false)
107 110
     {
Please login to merge, or discard this patch.
src/Twig/GlobalVariables.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
     /**
68 68
      * @param string $code
69 69
      * @param string $action
70
-     * @param array  $parameters
70
+     * @param string[]  $parameters
71 71
      * @param int    $absolute
72 72
      *
73 73
      * @return string
@@ -82,8 +82,8 @@  discard block
 block discarded – undo
82 82
     /**
83 83
      * @param string $code
84 84
      * @param string $action
85
-     * @param mixed  $object
86
-     * @param array  $parameters
85
+     * @param string  $object
86
+     * @param string[]  $parameters
87 87
      * @param int    $absolute
88 88
      *
89 89
      * @return string
@@ -96,8 +96,8 @@  discard block
 block discarded – undo
96 96
     }
97 97
 
98 98
     /**
99
-     * @param $code
100
-     * @param $action
99
+     * @param string $code
100
+     * @param string $action
101 101
      *
102 102
      * @return array
103 103
      */
Please login to merge, or discard this patch.
tests/Datagrid/DatagridMapperTest.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -266,6 +266,12 @@
 block discarded – undo
266 266
         ], array_keys($this->datagrid->getFilters()));
267 267
     }
268 268
 
269
+    /**
270
+     * @param string $name
271
+     * @param string $label
272
+     *
273
+     * @return string
274
+     */
269 275
     private function getFieldDescriptionMock($name = null, $label = null)
270 276
     {
271 277
         $fieldDescription = $this->getMockForAbstractClass(BaseFieldDescription::class);
Please login to merge, or discard this patch.
tests/Datagrid/ListMapperTest.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -255,6 +255,12 @@
 block discarded – undo
255 255
         ], true), print_r($this->fieldDescriptionCollection->getElements(), true));
256 256
     }
257 257
 
258
+    /**
259
+     * @param string $name
260
+     * @param string $label
261
+     *
262
+     * @return string
263
+     */
258 264
     private function getFieldDescriptionMock($name = null, $label = null)
259 265
     {
260 266
         $fieldDescription = $this->getMockForAbstractClass(BaseFieldDescription::class);
Please login to merge, or discard this patch.
tests/Show/ShowMapperTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -455,6 +455,10 @@
 block discarded – undo
455 455
         $this->showMapper = new ShowMapper($this->showBuilder, $this->fieldDescriptionCollection, $this->admin);
456 456
     }
457 457
 
458
+    /**
459
+     * @param string $name
460
+     * @param string $label
461
+     */
458 462
     private function getFieldDescriptionMock($name = null, $label = null)
459 463
     {
460 464
         $fieldDescription = $this->getMockForAbstractClass(BaseFieldDescription::class);
Please login to merge, or discard this patch.