sonata-project / SonataAdminBundle

src/Admin/AbstractAdmin.php

Unused Use Statements -1 removed lines

@@ -13,7 +13,6 @@
 
 use Doctrine\Common\Util\ClassUtils;
 use Knp\Menu\FactoryInterface as MenuFactoryInterface;
-use Knp\Menu\ItemInterface;
 use Knp\Menu\ItemInterface as MenuItemInterface;
 use Sonata\AdminBundle\Builder\DatagridBuilderInterface;
 use Sonata\AdminBundle\Builder\FormContractorInterface;

Doc Comments +5 added lines, -1 removed lines

@@ -1954,7 +1954,7 @@ 
      *
      * @param string $context
      *
-     * @return array
+     * @return string[]
      */
     public function getPermissionsShow($context)
     {
@@ -2469,6 +2469,9 @@ 
     {
     }
 
+    /**
+     * @param string $action
+     */
     protected function configureActionButtons($buttonList, $action, $object = null)
     {
         return $buttonList;
@@ -2489,6 +2492,7 @@ 
     /**
      * NEXT_MAJOR: remove this method.
      *
+     * @param string $action
      * @return mixed
      *
      * @deprecated Use configureTabMenu instead

src/Admin/FieldDescriptionCollection.php

Doc Comments +1 added lines, -1 removed lines

@@ -30,7 +30,7 @@
     }
 
     /**
-     * @return array
+     * @return FieldDescriptionInterface[]
      */
     public function getElements()
     {

src/Generator/ControllerGenerator.php

Doc Comments +1 added lines, -1 removed lines

@@ -31,7 +31,7 @@
     private $file;
 
     /**
-     * @param array|string $skeletonDirectory
+     * @param string $skeletonDirectory
      */
     public function __construct($skeletonDirectory)
     {

tests/Fixtures/Admin/PostAdmin.php

Doc Comments +3 added lines

@@ -8,6 +8,9 @@
 {
     protected $metadataClass = null;
 
+    /**
+     * @param string $associationMapping
+     */
     public function setParentAssociationMapping($associationMapping)
     {
         $this->parentAssociationMapping = $associationMapping;

src/Twig/GlobalVariables.php

Doc Comments +5 added lines, -5 removed lines

@@ -67,7 +67,7 @@ 
     /**
      * @param string $code
      * @param string $action
-     * @param array  $parameters
+     * @param string[]  $parameters
      * @param int    $absolute
      *
      * @return string
@@ -82,8 +82,8 @@ 
     /**
      * @param string $code
      * @param string $action
-     * @param mixed  $object
-     * @param array  $parameters
+     * @param string  $object
+     * @param string[]  $parameters
      * @param int    $absolute
      *
      * @return string
@@ -96,8 +96,8 @@ 
     }
 
     /**
-     * @param $code
-     * @param $action
+     * @param string $code
+     * @param string $action
      *
      * @return array
      */

tests/Datagrid/DatagridMapperTest.php

Doc Comments +6 added lines

@@ -266,6 +266,12 @@
         ], array_keys($this->datagrid->getFilters()));
     }
 
+    /**
+     * @param string $name
+     * @param string $label
+     *
+     * @return string
+     */
     private function getFieldDescriptionMock($name = null, $label = null)
     {
         $fieldDescription = $this->getMockForAbstractClass(BaseFieldDescription::class);

tests/Datagrid/ListMapperTest.php

Doc Comments +6 added lines

@@ -255,6 +255,12 @@
         ], true), print_r($this->fieldDescriptionCollection->getElements(), true));
     }
 
+    /**
+     * @param string $name
+     * @param string $label
+     *
+     * @return string
+     */
     private function getFieldDescriptionMock($name = null, $label = null)
     {
         $fieldDescription = $this->getMockForAbstractClass(BaseFieldDescription::class);

tests/Show/ShowMapperTest.php

Doc Comments +4 added lines

@@ -455,6 +455,10 @@
         $this->showMapper = new ShowMapper($this->showBuilder, $this->fieldDescriptionCollection, $this->admin);
     }
 
+    /**
+     * @param string $name
+     * @param string $label
+     */
     private function getFieldDescriptionMock($name = null, $label = null)
     {
         $fieldDescription = $this->getMockForAbstractClass(BaseFieldDescription::class);

src/Controller/CRUDController.php

Doc Comments +5 added lines, -5 removed lines

@@ -208,7 +208,7 @@ 
     /**
      * Delete action.
      *
-     * @param int|string|null $id
+     * @param integer|null $id
      *
      * @throws NotFoundHttpException If the object does not exist
      * @throws AccessDeniedException If access is not granted
@@ -726,7 +726,7 @@ 
     /**
      * View history revision of object.
      *
-     * @param int|string|null $id
+     * @param null|integer $id
      * @param string|null     $revision
      *
      * @throws AccessDeniedException If access is not granted
@@ -786,9 +786,9 @@ 
     /**
      * Compare history revisions of object.
      *
-     * @param int|string|null $id
-     * @param int|string|null $base_revision
-     * @param int|string|null $compare_revision
+     * @param null|integer $id
+     * @param null|integer $base_revision
+     * @param null|integer $compare_revision
      *
      * @throws AccessDeniedException If access is not granted
      * @throws NotFoundHttpException If the object or revision does not exist or the audit reader is not available