View GitHub Repository smr

Schedule Inspection
Subscribe

Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Pull Request — master (#928)
by Dan
04:27
created
Status
Category
Toggle Patches
engine/Default/planet_attack_processing.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -58,8 +58,8 @@  discard block
 
 block discarded – undo
58 58
59 59 
 $totalShieldDamage = 0;
60 60 
 foreach ($attackers as $attacker) {
61 
-	$playerResults =& $attacker->shootPlanet($planet, false);
62 
-	$results['Attackers']['Traders'][$attacker->getAccountID()] =& $playerResults;
61 
+	$playerResults = & $attacker->shootPlanet($planet, false);
62 
+	$results['Attackers']['Traders'][$attacker->getAccountID()] = & $playerResults;
63 63 
 	$results['Attackers']['TotalDamage'] += $playerResults['TotalDamage'];
64 64 
 	foreach ($playerResults['Weapons'] as $weapon) {
65 65 
 		$totalShieldDamage += $weapon['ActualDamage']['Shield'];
 
@@ -70,7 +70,7 @@  discard block
 
 block discarded – undo
70 70 
 $downgradeDamage = $results['Attackers']['TotalDamage'] - $totalShieldDamage;
71 71 
 $results['Attackers']['Downgrades'] = $planet->checkForDowngrade($downgradeDamage);
72 72
73 
-$results['Planet'] =& $planet->shootPlayers($attackers);
73 
+$results['Planet'] = & $planet->shootPlayers($attackers);
74 74
75 75 
 $account->log(LOG_TYPE_PLANET_BUSTING, 'Player attacks planet, the planet does ' . $results['Planet']['TotalDamage'] . ', their team does ' . $results['Attackers']['TotalDamage'] . ' and downgrades: ' . var_export($results['Attackers']['Downgrades'], true), $planet->getSectorID());
76 76
Please login to merge, or discard this patch.
engine/Default/port_attack_processing.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -53,8 +53,8 @@  discard block
 
 block discarded – undo
53 53
54 54 
 $totalShieldDamage = 0;
55 55 
 foreach ($attackers as $attacker) {
56 
-	$playerResults =& $attacker->shootPort($port);
57 
-	$results['Attackers']['Traders'][$attacker->getAccountID()] =& $playerResults;
56 
+	$playerResults = & $attacker->shootPort($port);
57 
+	$results['Attackers']['Traders'][$attacker->getAccountID()] = & $playerResults;
58 58 
 	$results['Attackers']['TotalDamage'] += $playerResults['TotalDamage'];
59 59 
 	foreach ($playerResults['Weapons'] as $weapon) {
60 60 
 		$totalShieldDamage += $weapon['ActualDamage']['Shield'];
 
@@ -65,7 +65,7 @@  discard block
 
 block discarded – undo
65 65 
 $downgradeDamage = $results['Attackers']['TotalDamage'] - $totalShieldDamage;
66 66 
 $results['Attackers']['Downgrades'] = $port->checkForDowngrade($downgradeDamage);
67 67
68 
-$results['Port'] =& $port->shootPlayers($attackers);
68 
+$results['Port'] = & $port->shootPlayers($attackers);
69 69
70 70 
 $account->log(LOG_TYPE_PORT_RAIDING, 'Player attacks port, the port does ' . $results['Port']['TotalDamage'] . ', their team does ' . $results['Attackers']['TotalDamage'] . ' and downgrades ' . $results['Attackers']['Downgrades'] . ' levels.', $port->getSectorID());
71 71
Please login to merge, or discard this patch.