We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
@@ -81,7 +81,7 @@ |
||
| 81 | 81 | foreach ($alliance_vs_ids as $id) { |
| 82 | 82 | $row_alliance = SmrAlliance::getAlliance($id, $player->getGameID()); |
| 83 | 83 | $showRed = (!$curr_alliance->isNone() && $curr_alliance->hasDisbanded()) || |
| 84 | - (!$row_alliance->isNone() && $row_alliance->hasDisbanded()); |
|
| 84 | + (!$row_alliance->isNone() && $row_alliance->hasDisbanded()); |
|
| 85 | 85 | $showBold = $curr_id == $player->getAllianceID() || $id == $player->getAllianceID(); |
| 86 | 86 | $style = ''; |
| 87 | 87 | if ($curr_id == $id && !$row_alliance->isNone()) { |
@@ -14,7 +14,7 @@ |
||
| 14 | 14 | * @param array<mixed> $results |
| 15 | 15 | */ |
| 16 | 16 | public function __construct( |
| 17 | - private readonly ?array $results = null, |
|
| 17 | + private readonly ? array $results = null, |
|
| 18 | 18 | bool $playerDied = false |
| 19 | 19 | ) { |
| 20 | 20 | // If the player died, make sure they see combat results |
@@ -24,8 +24,8 @@ |
||
| 24 | 24 | private readonly int $gameID, |
| 25 | 25 | private readonly ?string $submit = null, |
| 26 | 26 | private readonly ?string $label = null, |
| 27 | - private readonly ?array $accountIDs = null, |
|
| 28 | - private readonly ?array $allianceIDs = null, |
|
| 27 | + private readonly ? array $accountIDs = null, |
|
| 28 | + private readonly ? array $allianceIDs = null, |
|
| 29 | 29 | ) {} |
| 30 | 30 | |
| 31 | 31 | public function build(SmrAccount $account, Template $template): void { |
@@ -90,7 +90,7 @@ |
||
| 90 | 90 | $menuItems[] = ['Link' => Globals::getPlanetListHREF($alliance_id), 'Text' => 'Defense']; |
| 91 | 91 | $menuItems[] = ['Link' => Globals::getPlanetListFinancialHREF($alliance_id), 'Text' => 'Financial']; |
| 92 | 92 | // make the selected index bold |
| 93 | - $boldItem =& $menuItems[$selected_index]['Text']; |
|
| 93 | + $boldItem = & $menuItems[$selected_index]['Text']; |
|
| 94 | 94 | $boldItem = '<span class="bold">' . $boldItem . '</span>'; |
| 95 | 95 | |
| 96 | 96 | $template = Smr\Template::getInstance(); |
@@ -17,9 +17,9 @@ |
||
| 17 | 17 | */ |
| 18 | 18 | public function __construct( |
| 19 | 19 | private readonly ?string $action = null, |
| 20 | - private readonly ?array $results = null, |
|
| 20 | + private readonly ? array $results = null, |
|
| 21 | 21 | private readonly ?int $diffBytes = null, |
| 22 | - private readonly ?array $endedGames = null |
|
| 22 | + private readonly ? array $endedGames = null |
|
| 23 | 23 | ) {} |
| 24 | 24 | |
| 25 | 25 | public function build(SmrAccount $account, Template $template): void { |
@@ -64,9 +64,9 @@ |
||
| 64 | 64 | //find the fine |
| 65 | 65 | //get base for ports that dont happen to trade that good |
| 66 | 66 | $fine = $totalFine = $port->getLevel() * |
| 67 | - (($ship->getCargo(GOODS_SLAVES) * TradeGood::get(GOODS_SLAVES)->basePrice) + |
|
| 68 | - ($ship->getCargo(GOODS_WEAPONS) * TradeGood::get(GOODS_WEAPONS)->basePrice) + |
|
| 69 | - ($ship->getCargo(GOODS_NARCOTICS) * TradeGood::get(GOODS_NARCOTICS)->basePrice)); |
|
| 67 | + (($ship->getCargo(GOODS_SLAVES) * TradeGood::get(GOODS_SLAVES)->basePrice) + |
|
| 68 | + ($ship->getCargo(GOODS_WEAPONS) * TradeGood::get(GOODS_WEAPONS)->basePrice) + |
|
| 69 | + ($ship->getCargo(GOODS_NARCOTICS) * TradeGood::get(GOODS_NARCOTICS)->basePrice)); |
|
| 70 | 70 | $player->increaseHOF($ship->getCargo(GOODS_SLAVES) + $ship->getCargo(GOODS_WEAPONS) + $ship->getCargo(GOODS_NARCOTICS), ['Trade', 'Search', 'Caught', 'Goods Confiscated'], HOF_PUBLIC); |
| 71 | 71 | $player->increaseHOF($totalFine, ['Trade', 'Search', 'Caught', 'Amount Fined'], HOF_PUBLIC); |
| 72 | 72 | $template->assign('TotalFine', $totalFine); |
@@ -24,8 +24,7 @@ |
||
| 24 | 24 | $newID = $dbResult->record()->getInt('max_game_id') + 1; |
| 25 | 25 | |
| 26 | 26 | $join = new DateTime(Request::get('game_join')); |
| 27 | - $start = empty(Request::get('game_start')) ? $join : |
|
| 28 | - new DateTime(Request::get('game_start')); |
|
| 27 | + $start = empty(Request::get('game_start')) ? $join : new DateTime(Request::get('game_start')); |
|
| 29 | 28 | $end = new DateTime(Request::get('game_end')); |
| 30 | 29 | |
| 31 | 30 | $game = SmrGame::createGame($newID); |
@@ -17,8 +17,7 @@ |
||
| 17 | 17 | |
| 18 | 18 | public function build(SmrAccount $account): never { |
| 19 | 19 | $join = new DateTime(Request::get('game_join')); |
| 20 | - $start = empty(Request::get('game_start')) ? $join : |
|
| 21 | - new DateTime(Request::get('game_start')); |
|
| 20 | + $start = empty(Request::get('game_start')) ? $join : new DateTime(Request::get('game_start')); |
|
| 22 | 21 | $end = new DateTime(Request::get('game_end')); |
| 23 | 22 | |
| 24 | 23 | $game = SmrGame::getGame($this->gameID); |