Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Failed Conditions
Pull Request — main (#1487)
by Dan
06:01
created
src/engine/Default/rankings_alliance_vs_alliance.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
 	foreach ($alliance_vs_ids as $id) {
53 53
 		$row_alliance = SmrAlliance::getAlliance($id, $player->getGameID());
54 54
 		$showRed = (!$curr_alliance->isNone() && $curr_alliance->hasDisbanded()) ||
55
-		           (!$row_alliance->isNone() && $row_alliance->hasDisbanded());
55
+				   (!$row_alliance->isNone() && $row_alliance->hasDisbanded());
56 56
 		$showBold = $curr_id == $player->getAllianceID() || $id == $player->getAllianceID();
57 57
 		$style = '';
58 58
 		if ($curr_id == $id && !$row_alliance->isNone()) {
Please login to merge, or discard this patch.
src/templates/Default/engine/Default/map_local.php 1 patch
Braces   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -10,7 +10,10 @@
 block discarded – undo
10 10
 		<td style="width: 80%" class="center">
11 11
 			Local Map of the Known <span class="big bold"><?php echo $GalaxyName ?></span> Galaxy
12 12
 			<br /><br />
13
-			<?php if (isset($Error)) echo $Error; ?>
13
+			<?php if (isset($Error)) {
14
+	echo $Error;
15
+}
16
+?>
14 17
 		</td>
15 18
 		<td style="width: 10%"></td>
16 19
 	</tr>
Please login to merge, or discard this patch.
src/templates/Default/engine/Default/preferences.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -337,8 +337,8 @@
 block discarded – undo
337 337
 					foreach (Globals::getAvailableTemplates() as $Template) {
338 338
 						foreach (Globals::getAvailableColourSchemes($Template) as $ColourScheme) {
339 339
 							$selected = ($ThisAccount->getTemplate() == $Template &&
340
-							             $ThisAccount->getColourScheme() == $ColourScheme &&
341
-							             $ThisAccount->isDefaultCSSEnabled()) ? 'selected' : '';
340
+										 $ThisAccount->getColourScheme() == $ColourScheme &&
341
+										 $ThisAccount->isDefaultCSSEnabled()) ? 'selected' : '';
342 342
 							$name = $Template . ' - ' . $ColourScheme;
343 343
 							?><option value="<?php echo $name; ?>" <?php echo $selected; ?>><?php echo $name; ?></option><?php
344 344
 						}
Please login to merge, or discard this patch.
src/bootstrap.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@
 block discarded – undo
69 69
 	if (!empty(BUG_REPORT_TO_ADDRESSES)) {
70 70
 		$mail = setupMailer();
71 71
 		$mail->Subject = (defined('PAGE_PREFIX') ? PAGE_PREFIX : '??? ') .
72
-		                 'Automatic Bug Report';
72
+						 'Automatic Bug Report';
73 73
 		$mail->setFrom('[email protected]');
74 74
 		$mail->Body = $message;
75 75
 		foreach (BUG_REPORT_TO_ADDRESSES as $toAddress) {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -121,7 +121,7 @@
 block discarded – undo
121 121
  * Can be used to convert any type of notice into an exception.
122 122
  */
123 123
 function exception_error_handler(int $errno, string $errstr, string $errfile, int $errline): bool {
124
-	if (!(error_reporting() & $errno)) {
124
+	if (!(error_reporting()&$errno)) {
125 125
 		return false; // error is suppressed
126 126
 	}
127 127
 	throw new ErrorException($errstr, $errno, E_ERROR, $errfile, $errline);
Please login to merge, or discard this patch.
templates/Default/engine/Default/includes/TraderCombatKillMessage.inc.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -6,7 +6,7 @@
 block discarded – undo
6 6
 } else {
7 7
 	// Killed by port, planet, forces
8 8
 	echo 'The <span class="creds"> ' . number_format($KillResults['LostCredits'])
9
-	     . '</span> credits that were onboard ' . $TargetPlayer->getDisplayName()
10
-	     . "'s ship are lost in the wreckage.<br />";
9
+		 . '</span> credits that were onboard ' . $TargetPlayer->getDisplayName()
10
+		 . "'s ship are lost in the wreckage.<br />";
11 11
 }
12 12
 ?>
Please login to merge, or discard this patch.
src/templates/Default/engine/Default/includes/SectorMap.inc.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -102,7 +102,7 @@
 block discarded – undo
102 102
 						if (!$UniGen) {
103 103
 							$CanScanSector = ($ThisShip->hasScanner() && $isLinkedSector) || $isCurrentSector;
104 104
 							$ShowFriendlyForces = isset($HideAlliedForces) && $HideAlliedForces ?
105
-							                      $Sector->hasPlayerForces($MapPlayer) : $Sector->hasFriendlyForces($MapPlayer);
105
+												  $Sector->hasPlayerForces($MapPlayer) : $Sector->hasFriendlyForces($MapPlayer);
106 106
 							if (($CanScanSector && ($Sector->hasForces() || $Sector->hasPlayers())) || $ShowFriendlyForces || $Sector->hasFriendlyTraders($MapPlayer)) { ?>
107 107
 								<div class="lmtf"><?php
108 108
 									if ($CanScanSector && $Sector->hasEnemyTraders($MapPlayer)) {
Please login to merge, or discard this patch.
src/templates/Default/engine/Default/beta_functions.php 1 patch
Braces   +8 added lines, -2 removed lines patch added patch discarded remove patch
@@ -76,7 +76,10 @@  discard block
 block discarded – undo
76 76
 	<input type="number" name="amount" value="0" min="<?php echo MIN_GLOBAL_RELATIONS; ?>" max="<?php echo MAX_GLOBAL_RELATIONS; ?>" style="width:75px" />&nbsp;
77 77
 	<select name="race"><?php
78 78
 		foreach (Smr\Race::getPlayableNames() as $raceID => $raceName) {
79
-			if ($raceID == $ThisPlayer->getRaceID()) continue; ?>
79
+			if ($raceID == $ThisPlayer->getRaceID()) {
80
+				continue;
81
+			}
82
+			?>
80 83
 			<option value="<?php echo $raceID; ?>"><?php echo $raceName; ?></option><?php
81 84
 		} ?>
82 85
 	</select>&nbsp;&nbsp;
@@ -87,7 +90,10 @@  discard block
 block discarded – undo
87 90
 <form method="POST" action="<?php echo $ChangeRaceHREF; ?>">
88 91
 	<select name="race"><?php
89 92
 		foreach (Smr\Race::getPlayableNames() as $raceID => $raceName) {
90
-			if ($raceID == $ThisPlayer->getRaceID()) continue; ?>
93
+			if ($raceID == $ThisPlayer->getRaceID()) {
94
+				continue;
95
+			}
96
+			?>
91 97
 			<option value="<?php echo $raceID; ?>"><?php echo $raceName; ?></option><?php
92 98
 		} ?>
93 99
 	</select>&nbsp;&nbsp;
Please login to merge, or discard this patch.
src/engine/Default/message_view.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -128,7 +128,7 @@
 block discarded – undo
128 128
 					AND receiver_delete = ' . $db->escapeBoolean(false) . '
129 129
 					ORDER BY send_time DESC');
130 130
 	foreach ($dbResult->records() as $dbRecord) {
131
-		$groupBox =& $messageBox['GroupedMessages'][$dbRecord->getInt('sender_id')];
131
+		$groupBox = & $messageBox['GroupedMessages'][$dbRecord->getInt('sender_id')];
132 132
 		// Limit the number of messages in each group
133 133
 		if (!isset($groupBox['Messages']) || count($groupBox['Messages']) < MESSAGE_SCOUT_GROUP_LIMIT) {
134 134
 			$groupBox['Messages'][] = displayMessage($dbRecord->getInt('message_id'), $dbRecord->getInt('account_id'), $dbRecord->getInt('sender_id'), $player->getGameID(), $dbRecord->getString('message_text'), $dbRecord->getInt('send_time'), $dbRecord->getBoolean('msg_read'), MSG_SCOUT, $player->getAccount());
Please login to merge, or discard this patch.
src/templates/Default/engine/Default/admin/unigen/GameDetails.inc.php 1 patch
Braces   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -44,7 +44,10 @@
 block discarded – undo
44 44
 		<td>
45 45
 			<select name="game_type"><?php
46 46
 			foreach (SmrGame::GAME_TYPES as $GameTypeID => $GameType) {
47
-				?><option value="<?php echo $GameTypeID; ?>" <?php if ($GameType == $Game['gameType']) echo 'selected'; ?>><?php echo $GameType; ?></option><?php
47
+				?><option value="<?php echo $GameTypeID; ?>" <?php if ($GameType == $Game['gameType']) {
48
+					echo 'selected';
49
+				}
50
+				?>><?php echo $GameType; ?></option><?php
48 51
 			} ?>
49 52
 			</select>
50 53
 		</td>
Please login to merge, or discard this patch.