Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Pull Request — master (#1006)
by Dan
15:04
created
Default/engine/Default/includes/PortTraderTeamCombatResults.inc.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
 				}
26 26
 				$TargetPort = $WeaponResults['TargetPort'];
27 27
 
28
-				echo $ShootingPlayer->getDisplayName() ?> fires their <?php echo $ShootingWeapon->getName() ?> at <?php if ($ShotHit && $ActualDamage['TargetAlreadyDead']){ ?>the remnants of <?php } echo $TargetPort->getDisplayName();
28
+				echo $ShootingPlayer->getDisplayName() ?> fires their <?php echo $ShootingWeapon->getName() ?> at <?php if ($ShotHit && $ActualDamage['TargetAlreadyDead']) { ?>the remnants of <?php } echo $TargetPort->getDisplayName();
29 29
 				if (!$ShotHit || !$ActualDamage['TargetAlreadyDead']) {
30 30
 					if (!$ShotHit) {
31 31
 						?> and misses every critical system<?php
@@ -44,9 +44,9 @@  discard block
 block discarded – undo
44 44
 					} else {
45 45
 						?> destroying <?php
46 46
 						$DamageTypes = 0;
47
-						if ($ActualDamage['Shield'] > 0){ $DamageTypes = $DamageTypes+1; }
48
-						if ($ActualDamage['NumCDs'] > 0){ $DamageTypes = $DamageTypes+1; }
49
-						if ($ActualDamage['Armour'] > 0){ $DamageTypes = $DamageTypes+1; }
47
+						if ($ActualDamage['Shield'] > 0) { $DamageTypes = $DamageTypes + 1; }
48
+						if ($ActualDamage['NumCDs'] > 0) { $DamageTypes = $DamageTypes + 1; }
49
+						if ($ActualDamage['Armour'] > 0) { $DamageTypes = $DamageTypes + 1; }
50 50
 
51 51
 						if ($ActualDamage['Shield'] > 0) {
52 52
 							?><span class="shields"><?php echo number_format($ActualDamage['Shield']) ?></span> shields<?php
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
63 63
 				} ?>.
64 64
 				<br /><?php
65 65
 				if ($ShotHit && $ActualDamage['KillingShot']) {
66
-					$this->includeTemplate('includes/PortKillMessage.inc.php',array('KillResults'=>$WeaponResults['KillResults'],'TargetPort'=>$TargetPort,'ShootingPlayer'=>$ShootingPlayer));
66
+					$this->includeTemplate('includes/PortKillMessage.inc.php', array('KillResults'=>$WeaponResults['KillResults'], 'TargetPort'=>$TargetPort, 'ShootingPlayer'=>$ShootingPlayer));
67 67
 				}
68 68
 			}
69 69
 		}
Please login to merge, or discard this patch.
src/templates/Default/engine/Default/includes/PortCombatResults.inc.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
 		}
21 21
 		$TargetPlayer = $WeaponResults['TargetPlayer'];
22 22
 
23
-		echo $CombatPort->getDisplayName() ?> fires an <?php echo $ShootingWeapon->getName() ?> at <?php if ($ShotHit && $ActualDamage['TargetAlreadyDead']){ ?> the debris that was once <?php } echo $TargetPlayer->getDisplayName();
23
+		echo $CombatPort->getDisplayName() ?> fires an <?php echo $ShootingWeapon->getName() ?> at <?php if ($ShotHit && $ActualDamage['TargetAlreadyDead']) { ?> the debris that was once <?php } echo $TargetPlayer->getDisplayName();
24 24
 		if (!$ShotHit || !$ActualDamage['TargetAlreadyDead']) {
25 25
 			if (!$ShotHit) {
26 26
 				?> and misses<?php
@@ -39,9 +39,9 @@  discard block
 block discarded – undo
39 39
 			} else {
40 40
 				?> destroying <?php
41 41
 				$DamageTypes = 0;
42
-				if ($ActualDamage['Shield'] > 0){ $DamageTypes = $DamageTypes+1; }
43
-				if ($ActualDamage['NumCDs'] > 0){ $DamageTypes = $DamageTypes+1; }
44
-				if ($ActualDamage['Armour'] > 0){ $DamageTypes = $DamageTypes+1; }
42
+				if ($ActualDamage['Shield'] > 0) { $DamageTypes = $DamageTypes + 1; }
43
+				if ($ActualDamage['NumCDs'] > 0) { $DamageTypes = $DamageTypes + 1; }
44
+				if ($ActualDamage['Armour'] > 0) { $DamageTypes = $DamageTypes + 1; }
45 45
 
46 46
 				if ($ActualDamage['Shield'] > 0) {
47 47
 					?><span class="shields"><?php echo number_format($ActualDamage['Shield']) ?></span> shields<?php
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
 		} ?>.
59 59
 		<br /><?php
60 60
 		if ($ShotHit && $ActualDamage['KillingShot']) {
61
-			$this->includeTemplate('includes/TraderCombatKillMessage.inc.php',array('KillResults'=>$WeaponResults['KillResults'],'TargetPlayer'=>$TargetPlayer));
61
+			$this->includeTemplate('includes/TraderCombatKillMessage.inc.php', array('KillResults'=>$WeaponResults['KillResults'], 'TargetPlayer'=>$TargetPlayer));
62 62
 		}
63 63
 	}
64 64
 }
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
 	if ($WeaponDamage['Launched'] == 0) {
73 73
 		?> fails to launch it's combat drones<?php
74 74
 	} else {
75
-		?> launches <span class="cds"><?php echo $WeaponDamage['Launched'] ?></span> combat drones at <?php if ($ActualDamage['TargetAlreadyDead']){ ?>the debris that was once <?php } echo $TargetPlayer->getDisplayName();
75
+		?> launches <span class="cds"><?php echo $WeaponDamage['Launched'] ?></span> combat drones at <?php if ($ActualDamage['TargetAlreadyDead']) { ?>the debris that was once <?php } echo $TargetPlayer->getDisplayName();
76 76
 		if (!$ActualDamage['TargetAlreadyDead']) {
77 77
 			if ($ActualDamage['TotalDamage'] == 0) {
78 78
 				if ($WeaponDamage['Shield'] > 0) {
Please login to merge, or discard this patch.
Default/engine/Default/includes/PlanetTraderTeamCombatResults.inc.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
 				}
26 26
 				$TargetPlanet = $WeaponResults['TargetPlanet'];
27 27
 
28
-				echo $ShootingPlayer->getDisplayName() ?> fires their <?php echo $ShootingWeapon->getName() ?> at <?php if ($ShotHit && $ActualDamage['TargetAlreadyDead']){ ?>the debris that was once <?php } echo $TargetPlanet->getCombatName();
28
+				echo $ShootingPlayer->getDisplayName() ?> fires their <?php echo $ShootingWeapon->getName() ?> at <?php if ($ShotHit && $ActualDamage['TargetAlreadyDead']) { ?>the debris that was once <?php } echo $TargetPlanet->getCombatName();
29 29
 				if (!$ShotHit || !$ActualDamage['TargetAlreadyDead']) {
30 30
 					if (!$ShotHit) {
31 31
 						?> and misses<?php
@@ -44,9 +44,9 @@  discard block
 block discarded – undo
44 44
 					} else {
45 45
 						?> destroying <?php
46 46
 						$DamageTypes = 0;
47
-						if ($ActualDamage['Shield'] > 0){ $DamageTypes = $DamageTypes+1; }
48
-						if ($ActualDamage['NumCDs'] > 0){ $DamageTypes = $DamageTypes+1; }
49
-						if ($ActualDamage['Armour'] > 0){ $DamageTypes = $DamageTypes+1; }
47
+						if ($ActualDamage['Shield'] > 0) { $DamageTypes = $DamageTypes + 1; }
48
+						if ($ActualDamage['NumCDs'] > 0) { $DamageTypes = $DamageTypes + 1; }
49
+						if ($ActualDamage['Armour'] > 0) { $DamageTypes = $DamageTypes + 1; }
50 50
 
51 51
 						if ($ActualDamage['Shield'] > 0) {
52 52
 							?><span class="shields"><?php echo number_format($ActualDamage['Shield']) ?></span> shields<?php
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
63 63
 				} ?>.
64 64
 				<br /><?php
65 65
 				if ($ShotHit && $ActualDamage['KillingShot']) {
66
-					$this->includeTemplate('includes/PlanetKillMessage.inc.php',array('KillResults'=>$WeaponResults['KillResults'],'TargetPlanet'=>$TargetPlanet));
66
+					$this->includeTemplate('includes/PlanetKillMessage.inc.php', array('KillResults'=>$WeaponResults['KillResults'], 'TargetPlanet'=>$TargetPlanet));
67 67
 				}
68 68
 			}
69 69
 		}
@@ -73,9 +73,9 @@  discard block
 block discarded – undo
73 73
 			$WeaponDamage = $Drones['WeaponDamage'];
74 74
 			$TargetPlanet = $Drones['TargetPlanet'];
75 75
 			$DamageTypes = 0;
76
-			if ($ActualDamage['Shield'] > 0){ $DamageTypes = $DamageTypes+1; }
77
-			if ($ActualDamage['NumCDs'] > 0){ $DamageTypes = $DamageTypes+1; }
78
-			if ($ActualDamage['Armour'] > 0){ $DamageTypes = $DamageTypes+1; }
76
+			if ($ActualDamage['Shield'] > 0) { $DamageTypes = $DamageTypes + 1; }
77
+			if ($ActualDamage['NumCDs'] > 0) { $DamageTypes = $DamageTypes + 1; }
78
+			if ($ActualDamage['Armour'] > 0) { $DamageTypes = $DamageTypes + 1; }
79 79
 
80 80
 			echo $ShootingPlayer->getDisplayName();
81 81
 			if ($WeaponDamage['Launched'] == 0) {
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
 			} ?>.
119 119
 			<br /><?php
120 120
 			if ($ActualDamage['KillingShot']) {
121
-				$this->includeTemplate('includes/PlanetKillMessage.inc.php',array('KillResults'=>$Drones['KillResults'],'TargetPlanet'=>$TargetPlanet));
121
+				$this->includeTemplate('includes/PlanetKillMessage.inc.php', array('KillResults'=>$Drones['KillResults'], 'TargetPlanet'=>$TargetPlanet));
122 122
 			}
123 123
 		}
124 124
 	}
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
 	} ?>.<br /><br /><?php
134 134
 }
135 135
 $TotalDamage = $TraderTeamCombatResults['TotalDamage']; ?>
136
-This fleet <?php if ($TotalDamage > 0){ ?>hits for a total of <span class="red"><?php echo $TotalDamage ?></span> damage in this round of combat<?php } else{ ?>does no damage this round. You call that a fleet? They need a better recruiter<?php } ?>.<br /><?php
136
+This fleet <?php if ($TotalDamage > 0) { ?>hits for a total of <span class="red"><?php echo $TotalDamage ?></span> damage in this round of combat<?php } else { ?>does no damage this round. You call that a fleet? They need a better recruiter<?php } ?>.<br /><?php
137 137
 foreach ($TraderTeamCombatResults['Downgrades'] as $structureID => $numDestroyed) { ?>
138 138
 	This team destroys <span class="red"><?php echo $numDestroyed; ?> </span><?php echo pluralise((new SmrPlanetStructureType($structureID, []))->name(), $numDestroyed); ?>.<br /><?php
139 139
 } ?>
Please login to merge, or discard this patch.
src/templates/Default/engine/Default/includes/PlanetCombatResults.inc.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
 		}
21 21
 		$TargetPlayer = $WeaponResults['TargetPlayer'];
22 22
 
23
-		echo $CombatPlanet->getCombatName() ?> fires a <?php echo $ShootingWeapon->getName(); ?> at <?php if ($ShotHit && $ActualDamage['TargetAlreadyDead']){ ?> the debris that was once <?php } echo $TargetPlayer->getDisplayName();
23
+		echo $CombatPlanet->getCombatName() ?> fires a <?php echo $ShootingWeapon->getName(); ?> at <?php if ($ShotHit && $ActualDamage['TargetAlreadyDead']) { ?> the debris that was once <?php } echo $TargetPlayer->getDisplayName();
24 24
 		if (!$ShotHit || !$ActualDamage['TargetAlreadyDead']) {
25 25
 			if (!$ShotHit) {
26 26
 				?> and misses<?php
@@ -39,9 +39,9 @@  discard block
 block discarded – undo
39 39
 			} else {
40 40
 				?> destroying <?php
41 41
 				$DamageTypes = 0;
42
-				if ($ActualDamage['Shield'] > 0){ $DamageTypes = $DamageTypes+1; }
43
-				if ($ActualDamage['NumCDs'] > 0){ $DamageTypes = $DamageTypes+1; }
44
-				if ($ActualDamage['Armour'] > 0){ $DamageTypes = $DamageTypes+1; }
42
+				if ($ActualDamage['Shield'] > 0) { $DamageTypes = $DamageTypes + 1; }
43
+				if ($ActualDamage['NumCDs'] > 0) { $DamageTypes = $DamageTypes + 1; }
44
+				if ($ActualDamage['Armour'] > 0) { $DamageTypes = $DamageTypes + 1; }
45 45
 
46 46
 				if ($ActualDamage['Shield'] > 0) {
47 47
 					?><span class="shields"><?php echo number_format($ActualDamage['Shield']); ?></span> shields<?php
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
 		} ?>.
59 59
 		<br /><?php
60 60
 		if ($ShotHit && $ActualDamage['KillingShot']) {
61
-			$this->includeTemplate('includes/TraderCombatKillMessage.inc.php',array('KillResults'=>$WeaponResults['KillResults'],'TargetPlayer'=>$TargetPlayer));
61
+			$this->includeTemplate('includes/TraderCombatKillMessage.inc.php', array('KillResults'=>$WeaponResults['KillResults'], 'TargetPlayer'=>$TargetPlayer));
62 62
 		}
63 63
 	}
64 64
 }
@@ -68,15 +68,15 @@  discard block
 block discarded – undo
68 68
 	$WeaponDamage = $Drones['WeaponDamage'];
69 69
 	$TargetPlayer = $Drones['TargetPlayer'];
70 70
 	$DamageTypes = 0;
71
-	if ($ActualDamage['Shield'] > 0){ $DamageTypes = $DamageTypes+1; }
72
-	if ($ActualDamage['NumCDs'] > 0){ $DamageTypes = $DamageTypes+1; }
73
-	if ($ActualDamage['Armour'] > 0){ $DamageTypes = $DamageTypes+1; }
71
+	if ($ActualDamage['Shield'] > 0) { $DamageTypes = $DamageTypes + 1; }
72
+	if ($ActualDamage['NumCDs'] > 0) { $DamageTypes = $DamageTypes + 1; }
73
+	if ($ActualDamage['Armour'] > 0) { $DamageTypes = $DamageTypes + 1; }
74 74
 
75 75
 	echo $CombatPlanet->getCombatName();
76 76
 	if ($WeaponDamage['Launched'] == 0) {
77 77
 		?> fails to launch it's combat drones<?php
78 78
 	} else {
79
-		?> launches <span class="cds"><?php echo $WeaponDamage['Launched'] ?></span> combat drones at <?php if ($ActualDamage['TargetAlreadyDead']){ ?>the debris that was once <?php } echo $TargetPlayer->getDisplayName();
79
+		?> launches <span class="cds"><?php echo $WeaponDamage['Launched'] ?></span> combat drones at <?php if ($ActualDamage['TargetAlreadyDead']) { ?>the debris that was once <?php } echo $TargetPlayer->getDisplayName();
80 80
 		if (!$ActualDamage['TargetAlreadyDead']) {
81 81
 			if ($ActualDamage['TotalDamage'] == 0) {
82 82
 				if ($WeaponDamage['Shield'] > 0) {
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
 	} ?>.
109 109
 	<br /><?php
110 110
 	if ($ActualDamage['KillingShot']) {
111
-		$this->includeTemplate('includes/TraderCombatKillMessage.inc.php',array('KillResults'=>$Drones['KillResults'],'TargetPlayer'=>$TargetPlayer));
111
+		$this->includeTemplate('includes/TraderCombatKillMessage.inc.php', array('KillResults'=>$Drones['KillResults'], 'TargetPlayer'=>$TargetPlayer));
112 112
 	}
113 113
 }
114 114
 
Please login to merge, or discard this patch.
templates/Default/engine/Default/includes/TraderTeamCombatResults.inc.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -40,9 +40,9 @@  discard block
 block discarded – undo
40 40
 						} else {
41 41
 							?> destroying <?php
42 42
 							$DamageTypes = 0;
43
-							if ($ActualDamage['Shield'] > 0){ $DamageTypes = $DamageTypes+1; }
44
-							if ($ActualDamage['NumCDs'] > 0){ $DamageTypes = $DamageTypes+1; }
45
-							if ($ActualDamage['Armour'] > 0){ $DamageTypes = $DamageTypes+1; }
43
+							if ($ActualDamage['Shield'] > 0) { $DamageTypes = $DamageTypes + 1; }
44
+							if ($ActualDamage['NumCDs'] > 0) { $DamageTypes = $DamageTypes + 1; }
45
+							if ($ActualDamage['Armour'] > 0) { $DamageTypes = $DamageTypes + 1; }
46 46
 
47 47
 							if ($ActualDamage['Shield'] > 0) {
48 48
 								?><span class="shields"><?php echo number_format($ActualDamage['Shield']) ?></span> shields<?php
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
 					} ?>.
60 60
 					<br /><?php
61 61
 					if ($ShotHit && $ActualDamage['KillingShot']) {
62
-						$this->includeTemplate('includes/TraderCombatKillMessage.inc.php',array('KillResults'=>$WeaponResults['KillResults'],'TargetPlayer'=>$TargetPlayer,'ShootingPlayer'=>$ShootingPlayer));
62
+						$this->includeTemplate('includes/TraderCombatKillMessage.inc.php', array('KillResults'=>$WeaponResults['KillResults'], 'TargetPlayer'=>$TargetPlayer, 'ShootingPlayer'=>$ShootingPlayer));
63 63
 					}
64 64
 				}
65 65
 			}
@@ -69,9 +69,9 @@  discard block
 block discarded – undo
69 69
 				$WeaponDamage = $Drones['WeaponDamage'];
70 70
 				$TargetPlayer = $Drones['TargetPlayer'];
71 71
 				$DamageTypes = 0;
72
-				if ($ActualDamage['Shield'] > 0){ $DamageTypes = $DamageTypes+1; }
73
-				if ($ActualDamage['NumCDs'] > 0){ $DamageTypes = $DamageTypes+1; }
74
-				if ($ActualDamage['Armour'] > 0){ $DamageTypes = $DamageTypes+1; }
72
+				if ($ActualDamage['Shield'] > 0) { $DamageTypes = $DamageTypes + 1; }
73
+				if ($ActualDamage['NumCDs'] > 0) { $DamageTypes = $DamageTypes + 1; }
74
+				if ($ActualDamage['Armour'] > 0) { $DamageTypes = $DamageTypes + 1; }
75 75
 
76 76
 				echo $ShootingPlayer->getDisplayName();
77 77
 				if ($WeaponDamage['Launched'] == 0) {
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
 				} ?>.
115 115
 				<br /><?php
116 116
 				if ($ActualDamage['KillingShot']) {
117
-					$this->includeTemplate('includes/TraderCombatKillMessage.inc.php',array('KillResults'=>$Drones['KillResults'],'TargetPlayer'=>$TargetPlayer,'ShootingPlayer'=>$ShootingPlayer));
117
+					$this->includeTemplate('includes/TraderCombatKillMessage.inc.php', array('KillResults'=>$Drones['KillResults'], 'TargetPlayer'=>$TargetPlayer, 'ShootingPlayer'=>$ShootingPlayer));
118 118
 				}
119 119
 			}
120 120
 		}
@@ -130,4 +130,4 @@  discard block
 block discarded – undo
130 130
 	}
131 131
 }
132 132
 $TotalDamage = $TraderTeamCombatResults['TotalDamage']; ?>
133
-This fleet <?php if ($TotalDamage > 0){ ?>hits for a total of <span class="red"><?php echo $TotalDamage ?></span> damage in this round of combat<?php } else{ ?>does no damage this round. You call that a fleet? They need a better recruiter<?php } ?>.<br />
133
+This fleet <?php if ($TotalDamage > 0) { ?>hits for a total of <span class="red"><?php echo $TotalDamage ?></span> damage in this round of combat<?php } else { ?>does no damage this round. You call that a fleet? They need a better recruiter<?php } ?>.<br />
Please login to merge, or discard this patch.