smrealms / smr

lib/Default/Distance.class.inc

Spacing +6 added lines, -6 removed lines

@@ -11,7 +11,7 @@ 
 	private $path = array();
 	private $warpMap = array();
 
-	public function __construct($gameID,$_startSectorId) {
+	public function __construct($gameID, $_startSectorId) {
 		$this->gameID = $gameID;
 		$this->addToPath($_startSectorId);
 	}
@@ -29,7 +29,7 @@ 
 	}
 
 	public function getTotalSectors() {
-		return $this->getDistance()+$this->getNumWarps();
+		return $this->getDistance() + $this->getNumWarps();
 	}
 
 	public function getNumWarps() {
@@ -48,15 +48,15 @@ 
 	 * @return integer
 	 */
 	public function getEndSectorID() {
-		return $this->path[count($this->path)-1];
+		return $this->path[count($this->path) - 1];
 	}
 
 	public function &getEndSector() {
-		return SmrSector::getSector($this->gameID,$this->getEndSectorID());
+		return SmrSector::getSector($this->gameID, $this->getEndSectorID());
 	}
 
 	public function compareTo(Distance $d) {
-		if ($this->equals($d)===true)
+		if ($this->equals($d) === true)
 			return 0;
 		else if ($d->getTurns() > $this->getTurns())
 			return -1;
@@ -108,7 +108,7 @@ 
 	}
 
 	public function isInPath($sectorID) {
-		return in_array($sectorID,$this->getPath());
+		return in_array($sectorID, $this->getPath());
 	}
 
 	/**

lib/Default/AbstractSmrPlayer.class.inc

Spacing +239 added lines, -239 removed lines

@@ -50,9 +50,9 @@ 
 	protected $HOF;
 	protected static $HOFVis;
 
-	protected $hasChanged=false;
-	protected $hasHOFChanged=false;
-	protected static $hasHOFVisChanged=array();
+	protected $hasChanged = false;
+	protected $hasHOFChanged = false;
+	protected static $hasHOFVisChanged = array();
 	protected $hasBountyChanged = array();
 
 	protected function __construct() {
@@ -75,13 +75,13 @@ 
 	}
 
 	public function hasNewbieTurns() {
-		return $this->getNewbieTurns()>0;
+		return $this->getNewbieTurns() > 0;
 	}
 	public function setNewbieTurns($newbieTurns) {
-		if($this->newbieTurns == $newbieTurns)
+		if ($this->newbieTurns == $newbieTurns)
 			return;
-		$this->newbieTurns=$newbieTurns;
-		$this->hasChanged=true;
+		$this->newbieTurns = $newbieTurns;
+		$this->hasChanged = true;
 	}
 
 	public function getShipTypeID() {
@@ -89,10 +89,10 @@ 
 	}
 
 	public function setShipTypeID($shipID) {
-		if($this->shipID == $shipID)
+		if ($this->shipID == $shipID)
 			return;
-		$this->shipID=$shipID;
-		$this->hasChanged=true;
+		$this->shipID = $shipID;
+		$this->hasChanged = true;
 	}
 
 	/**
@@ -109,11 +109,11 @@ 
 	}
 
 	public function &getSectorPlanet() {
-		return SmrPlanet::getPlanet($this->getGameID(),$this->getSectorID());
+		return SmrPlanet::getPlanet($this->getGameID(), $this->getSectorID());
 	}
 
 	public function &getSectorPort() {
-		return SmrPort::getPort($this->getGameID(),$this->getSectorID());
+		return SmrPort::getPort($this->getGameID(), $this->getSectorID());
 	}
 
 	public function getSectorID() {
@@ -121,15 +121,15 @@ 
 	}
 
 	public function &getSector() {
-		return SmrSector::getSector($this->getGameID(),$this->getSectorID());
+		return SmrSector::getSector($this->getGameID(), $this->getSectorID());
 	}
 
 	public function setSectorID($sectorID) {
 		$this->lastSectorID = $this->getSectorID();
-		$this->actionTaken('LeaveSector',array('Sector'=>$this->getSector()));
+		$this->actionTaken('LeaveSector', array('Sector'=>$this->getSector()));
 		$this->sectorID = $sectorID;
-		$this->actionTaken('EnterSector',array('Sector'=>$this->getSector()));
-		$this->hasChanged=true;
+		$this->actionTaken('EnterSector', array('Sector'=>$this->getSector()));
+		$this->hasChanged = true;
 	}
 
 	public function getLastSectorID() {
@@ -164,7 +164,7 @@ 
 	}
 
 	public function isDraftLeader() {
-		if(!isset($this->draftLeader)) {
+		if (!isset($this->draftLeader)) {
 			$this->draftLeader = false;
 			$this->db->query('SELECT 1 FROM draft_leaders WHERE ' . $this->SQL . ' LIMIT 1');
 			if ($this->db->nextRecord()) {
@@ -175,7 +175,7 @@ 
 	}
 
 	public function getGPWriter() {
-		if(!isset($this->gpWriter)) {
+		if (!isset($this->gpWriter)) {
 			$this->gpWriter = false;
 			$this->db->query('SELECT position FROM galactic_post_writer WHERE ' . $this->SQL);
 			if ($this->db->nextRecord()) {
@@ -200,7 +200,7 @@ 
 	}
 
 	public function hasFederalProtection() {
-		$sector = SmrSector::getSector($this->getGameID(),$this->getSectorID());
+		$sector = SmrSector::getSector($this->getGameID(), $this->getSectorID());
 		if (!$sector->offersFederalProtection()) {
 			return false;
 		}
@@ -210,8 +210,8 @@ 
 			return false;
 
 		if ($ship->getAttackRating() <= $this->getSafeAttackRating()) {
-			foreach($sector->getFedRaceIDs() as $fedRaceID) {
-				if($this->canBeProtectedByRace($fedRaceID)) {
+			foreach ($sector->getFedRaceIDs() as $fedRaceID) {
+				if ($this->canBeProtectedByRace($fedRaceID)) {
 					return true;
 				}
 			}
@@ -221,15 +221,15 @@ 
 	}
 
 	public function canBeProtectedByRace($raceID) {
-		if(!isset($this->canFed)) {
+		if (!isset($this->canFed)) {
 			$this->canFed = array();
 			$RACES = Globals::getRaces();
-			foreach($RACES as $raceID2 => $raceName) {
+			foreach ($RACES as $raceID2 => $raceName) {
 				$this->canFed[$raceID2] = $this->getRelation($raceID2) >= ALIGN_FED_PROTECTION;
 			}
 			$this->db->query('SELECT race_id, allowed FROM player_can_fed
 								WHERE ' . $this->SQL . ' AND expiry > ' . $this->db->escapeNumber(TIME));
-			while($this->db->nextRecord()) {
+			while ($this->db->nextRecord()) {
 				$this->canFed[$this->db->getInt('race_id')] = $this->db->getBoolean('allowed');
 			}
 		}
@@ -248,10 +248,10 @@ 
 	}
 
 	public function setDead($bool) {
-		if($this->dead == $bool)
+		if ($this->dead == $bool)
 			return;
-		$this->dead=$bool;
-		$this->hasChanged=true;
+		$this->dead = $bool;
+		$this->hasChanged = true;
 	}
 
 	public function getKills() {
@@ -259,16 +259,16 @@ 
 	}
 
 	public function increaseKills($kills) {
-		if($kills < 0)
+		if ($kills < 0)
 			throw new Exception('Trying to increase negative kills.');
-		$this->setKills($this->kills+$kills);
+		$this->setKills($this->kills + $kills);
 	}
 
 	public function setKills($kills) {
-		if($this->kills == $kills)
+		if ($this->kills == $kills)
 			return;
-		$this->kills=$kills;
-		$this->hasChanged=true;
+		$this->kills = $kills;
+		$this->hasChanged = true;
 	}
 
 	public function getDeaths() {
@@ -276,16 +276,16 @@ 
 	}
 
 	public function increaseDeaths($deaths) {
-		if($deaths < 0)
+		if ($deaths < 0)
 			throw new Exception('Trying to increase negative deaths.');
-		$this->setDeaths($this->getDeaths()+$deaths);
+		$this->setDeaths($this->getDeaths() + $deaths);
 	}
 
 	public function setDeaths($deaths) {
-		if($this->deaths == $deaths)
+		if ($this->deaths == $deaths)
 			return;
 		$this->deaths = $deaths;
-		$this->hasChanged=true;
+		$this->hasChanged = true;
 	}
 
 	public function getAssists() {
@@ -305,26 +305,26 @@ 
 	}
 
 	public function increaseAlignment($align) {
-		if($align < 0)
+		if ($align < 0)
 			throw new Exception('Trying to increase negative align.');
-		if($align == 0)
+		if ($align == 0)
 			return;
 		$align += $this->alignment;
 		$this->setAlignment($align);
 	}
 	public function decreaseAlignment($align) {
-		if($align < 0)
+		if ($align < 0)
 			throw new Exception('Trying to decrease negative align.');
-		if($align == 0)
+		if ($align == 0)
 			return;
 		$align = $this->alignment - $align;
 		$this->setAlignment($align);
 	}
 	public function setAlignment($align) {
-		if($this->alignment == $align)
+		if ($this->alignment == $align)
 			return;
 		$this->alignment = $align;
-		$this->hasChanged=true;
+		$this->hasChanged = true;
 	}
 
 	public function getCredits() {
@@ -336,9 +336,9 @@ 
 	}
 
 	public function getNextLevelPercentAcquired() {
-		if($this->getNextLevelExperience() == $this->getThisLevelExperience())
+		if ($this->getNextLevelExperience() == $this->getThisLevelExperience())
 			return 100;
-		return max(0,min(100,round(($this->getExperience() - $this->getThisLevelExperience()) / ($this->getNextLevelExperience() - $this->getThisLevelExperience())*100)));
+		return max(0, min(100, round(($this->getExperience() - $this->getThisLevelExperience()) / ($this->getNextLevelExperience() - $this->getThisLevelExperience()) * 100)));
 	}
 
 	public function getNextLevelPercentRemaining() {
@@ -347,9 +347,9 @@ 
 
 	public function getNextLevelExperience() {
 		$LEVELS_REQUIREMENTS = Globals::getLevelRequirements();
-		if(!isset($LEVELS_REQUIREMENTS[$this->getLevelID()+1]))
+		if (!isset($LEVELS_REQUIREMENTS[$this->getLevelID() + 1]))
 			return $this->getThisLevelExperience(); //Return current level experience if on last level.
-		return $LEVELS_REQUIREMENTS[$this->getLevelID()+1]['Requirement'];
+		return $LEVELS_REQUIREMENTS[$this->getLevelID() + 1]['Requirement'];
 	}
 
 	public function getThisLevelExperience() {
@@ -358,14 +358,14 @@ 
 	}
 
 	public function setExperience($experience) {
-		if($this->experience == $experience)
+		if ($this->experience == $experience)
 			return;
-		if($experience<MIN_EXPERIENCE)
+		if ($experience < MIN_EXPERIENCE)
 			$experience = MIN_EXPERIENCE;
-		if($experience>MAX_EXPERIENCE)
+		if ($experience > MAX_EXPERIENCE)
 			$experience = MAX_EXPERIENCE;
 		$this->experience = $experience;
-		$this->hasChanged=true;
+		$this->hasChanged = true;
 
 		// Since exp has changed, invalidate the player level so that it can
 		// be recomputed next time it is queried (in case it has changed).
@@ -373,49 +373,49 @@ 
 	}
 
 	public function increaseCredits($credits) {
-		if($credits < 0)
+		if ($credits < 0)
 			throw new Exception('Trying to increase negative credits.');
-		if($credits == 0)
+		if ($credits == 0)
 			return;
 		$credits += $this->credits;
 		$this->setCredits($credits);
 	}
 	public function decreaseCredits($credits) {
-		if($credits < 0)
+		if ($credits < 0)
 			throw new Exception('Trying to decrease negative credits.');
-		if($credits == 0)
+		if ($credits == 0)
 			return;
 		$credits = $this->credits - $credits;
 		$this->setCredits($credits);
 	}
 	public function setCredits($credits) {
-		if($this->credits == $credits)
+		if ($this->credits == $credits)
 			return;
-		if($credits < 0)
+		if ($credits < 0)
 			throw new Exception('Trying to set negative credits.');
-		if($credits > MAX_MONEY)
+		if ($credits > MAX_MONEY)
 			$credits = MAX_MONEY;
 		$this->credits = $credits;
-		$this->hasChanged=true;
+		$this->hasChanged = true;
 	}
 
 	public function increaseExperience($experience) {
-		if($experience < 0)
+		if ($experience < 0)
 			throw new Exception('Trying to increase negative experience.');
-		if($experience == 0)
+		if ($experience == 0)
 			return;
 		$newExperience = $this->experience + $experience;
 		$this->setExperience($newExperience);
-		$this->increaseHOF($experience,array('Experience','Total','Gain'), HOF_PUBLIC);
+		$this->increaseHOF($experience, array('Experience', 'Total', 'Gain'), HOF_PUBLIC);
 	}
 	public function decreaseExperience($experience) {
-		if($experience < 0)
+		if ($experience < 0)
 			throw new Exception('Trying to decrease negative experience.');
-		if($experience == 0)
+		if ($experience == 0)
 			return;
 		$newExperience = $this->experience - $experience;
 		$this->setExperience($newExperience);
-		$this->decreaseHOF($experience,array('Experience','Total','Loss'), HOF_PUBLIC);
+		$this->decreaseHOF($experience, array('Experience', 'Total', 'Loss'), HOF_PUBLIC);
 	}
 
 	public function isLandedOnPlanet() {
@@ -423,10 +423,10 @@ 
 	}
 
 	public function setLandedOnPlanet($bool) {
-		if($this->landedOnPlanet == $bool)
+		if ($this->landedOnPlanet == $bool)
 			return;
-		$this->landedOnPlanet=$bool;
-		$this->hasChanged=true;
+		$this->landedOnPlanet = $bool;
+		$this->hasChanged = true;
 	}
 
 	/**
@@ -472,24 +472,24 @@ 
 		$this->hasChanged = true;
 	}
 
-	public function getDisplayName($includeAlliance=false) {
-		$return = get_colored_text($this->getAlignment(),$this->playerName.' ('.$this->getPlayerID().')');
-		if($this->isNPC()) {
+	public function getDisplayName($includeAlliance = false) {
+		$return = get_colored_text($this->getAlignment(), $this->playerName . ' (' . $this->getPlayerID() . ')');
+		if ($this->isNPC()) {
 			$return .= ' <span class="npcColour">[NPC]</span>';
 		}
-		if($includeAlliance) {
-			$return.= ' (' . $this->getAllianceName() . '</a>' . ')';
+		if ($includeAlliance) {
+			$return .= ' (' . $this->getAllianceName() . '</a>' . ')';
 		}
 		return $return;
 	}
 
 	public function getBBLink() {
-			return '[player='.$this->getPlayerID().']';
+			return '[player=' . $this->getPlayerID() . ']';
 	}
 
-	public function getLinkedDisplayName($includeAlliance=true) {
-		$return = '<a href="'.$this->getTraderSearchHREF().'">'.$this->getDisplayName().'</a>';
-		if($includeAlliance) {
+	public function getLinkedDisplayName($includeAlliance = true) {
+		$return = '<a href="' . $this->getTraderSearchHREF() . '">' . $this->getDisplayName() . '</a>';
+		if ($includeAlliance) {
 			$return .= ' (' . $this->getAllianceName(true) . ')';
 		}
 		return $return;
@@ -505,7 +505,7 @@ 
 
 	public static function getColouredRaceNameOrDefault($otherRaceID, AbstractSmrPlayer $player = null, $linked = false) {
 		$relations = 0;
-		if($player !== null) {
+		if ($player !== null) {
 			$relations = $player->getRelation($otherRaceID);
 		}
 		return Globals::getColouredRaceName($otherRaceID, $relations, $linked);
@@ -516,10 +516,10 @@ 
 	}
 
 	public function setRaceID($raceID) {
-		if($this->raceID == $raceID)
+		if ($this->raceID == $raceID)
 			return;
-		$this->raceID=$raceID;
-		$this->hasChanged=true;
+		$this->raceID = $raceID;
+		$this->hasChanged = true;
 	}
 
 	public function isAllianceLeader($forceUpdate = false) {
@@ -535,27 +535,27 @@ 
 	}
 
 	public function hasAlliance() {
-		return $this->getAllianceID()!=0;
+		return $this->getAllianceID() != 0;
 	}
 
 	public function setAllianceID($ID) {
-		if($this->allianceID == $ID)
+		if ($this->allianceID == $ID)
 			return;
-		$this->allianceID=$ID;
+		$this->allianceID = $ID;
 		if ($this->allianceID != 0) {
 			$status = $this->hasNewbieStatus() ? 'NEWBIE' : 'VETERAN';
 			$this->db->query('INSERT IGNORE INTO player_joined_alliance (account_id,game_id,alliance_id,status) ' .
-				'VALUES ('.$this->db->escapeNumber($this->getAccountID()).','.$this->db->escapeNumber($this->getGameID()).','.$this->db->escapeNumber($this->getAllianceID()).','.$this->db->escapeString($status).')');
+				'VALUES (' . $this->db->escapeNumber($this->getAccountID()) . ',' . $this->db->escapeNumber($this->getGameID()) . ',' . $this->db->escapeNumber($this->getAllianceID()) . ',' . $this->db->escapeString($status) . ')');
 		}
-		$this->hasChanged=true;
+		$this->hasChanged = true;
 	}
 
 	public function getAllianceBBLink() {
-		return $this->hasAlliance()?'[alliance='.$this->getAllianceID().']':$this->getAllianceName();
+		return $this->hasAlliance() ? '[alliance=' . $this->getAllianceID() . ']' : $this->getAllianceName();
 	}
 
-	public function getAllianceName($linked=false, $includeAllianceID=false) {
-		if($this->hasAlliance()) {
+	public function getAllianceName($linked = false, $includeAllianceID = false) {
+		if ($this->hasAlliance()) {
 			return $this->getAlliance()->getAllianceName($linked, $includeAllianceID);
 		}
 		else {
@@ -567,7 +567,7 @@ 
 		if ($allianceID === false) {
 			$allianceID = $this->getAllianceID();
 		}
-		if(!isset($this->allianceRoles[$allianceID])) {
+		if (!isset($this->allianceRoles[$allianceID])) {
 			$this->allianceRoles[$allianceID] = 0;
 			$this->db->query('SELECT role_id
 						FROM player_has_alliance_role
@@ -586,10 +586,10 @@ 
 	}
 
 	public function setCombatDronesKamikazeOnMines($bool) {
-		if($this->combatDronesKamikazeOnMines == $bool)
+		if ($this->combatDronesKamikazeOnMines == $bool)
 			return;
 		$this->combatDronesKamikazeOnMines = $bool;
-		$this->hasChanged=true;
+		$this->hasChanged = true;
 	}
 
 	protected abstract function getGadgetsData();
@@ -599,19 +599,19 @@ 
 	}
 
 	public function getGadget($gadgetID) {
-		if(!is_numeric($gadgetID)) {
+		if (!is_numeric($gadgetID)) {
 			global $GADGETS;
 			$gadgetID = $GADGETS[$gadgetID]['ID'];
 		}
 		$gadgets = $this->getGadgets();
-		if(isset($gadgets[$gadgetID]))
+		if (isset($gadgets[$gadgetID]))
 			return $gadgets[$gadgetID];
 		return false;
 	}
 
 	public function isGadgetEquipped($gadgetID) {
 		$gadget = $this->getGadget($gadgetID);
-		if($gadget===false)
+		if ($gadget === false)
 			return false;
 		return $gadget['Equipped'] > 0 && $gadget['Equipped'] < TIME && ($gadget['Expires'] == 0 || $gadget['Expires'] > TIME) && $gadget['Cooldown'] <= TIME;
 	}
@@ -632,10 +632,10 @@ 
 	}
 
 	public function getRelations() {
-		if(!isset($this->relations)) {
+		if (!isset($this->relations)) {
 			//get relations
 			$RACES = Globals::getRaces();
-			$raceRelations = Globals::getRaceRelations($this->getGameID(),$this->getRaceID());
+			$raceRelations = Globals::getRaceRelations($this->getGameID(), $this->getRaceID());
 			$pureRels = $this->getPureRelations(); // make sure they're initialised.
 			$this->relations = array();
 			foreach ($RACES as $raceID => $raceName) {
@@ -680,26 +680,26 @@ 
 	}
 
 	public function hasMilitaryPayment() {
-		return $this->getMilitaryPayment()>0;
+		return $this->getMilitaryPayment() > 0;
 	}
 
 	public function setMilitaryPayment($amount) {
-		if($this->militaryPayment == $amount)
+		if ($this->militaryPayment == $amount)
 			return;
 		$this->militaryPayment = $amount;
-		$this->hasChanged=true;
+		$this->hasChanged = true;
 	}
 
 	public function increaseMilitaryPayment($amount) {
-		if($amount < 0)
+		if ($amount < 0)
 			throw new Exception('Trying to increase negative military payment.');
-		$this->setMilitaryPayment($this->getMilitaryPayment()+$amount);
+		$this->setMilitaryPayment($this->getMilitaryPayment() + $amount);
 	}
 
 	public function decreaseMilitaryPayment($amount) {
-		if($amount < 0)
+		if ($amount < 0)
 			throw new Exception('Trying to decrease negative military payment.');
-		$this->setMilitaryPayment($this->getMilitaryPayment()-$amount);
+		$this->setMilitaryPayment($this->getMilitaryPayment() - $amount);
 	}
 
 	abstract protected function getBountiesData();
@@ -710,7 +710,7 @@ 
 	}
 
 	public function hasBounties() {
-		return count($this->getBounties())>0;
+		return count($this->getBounties()) > 0;
 	}
 
 	public function getBounty($bountyID) {
@@ -719,7 +719,7 @@ 
 	}
 
 	public function hasBounty($bountyID) {
-		return $this->getBounty($bountyID)!==false;
+		return $this->getBounty($bountyID) !== false;
 	}
 
 	public function getBountyAmount($bountyID) {
@@ -740,15 +740,15 @@ 
 
 	public function getNextBountyID() {
 		$keys = array_keys($this->getBounties());
-		if(count($keys)>0)
-			return max($keys)+1;
+		if (count($keys) > 0)
+			return max($keys) + 1;
 		else
 			return 0;
 	}
 
 	public function setBounty(array $bounty) {
 		$this->bounties[$bounty['ID']] = $bounty;
-		$this->hasBountyChanged[$bounty['ID']]=true;
+		$this->hasBountyChanged[$bounty['ID']] = true;
 	}
 
 	public function setBountyAmount($bountyID, $amount) {
@@ -757,22 +757,22 @@ 
 		$this->setBounty($bounty);
 	}
 
-	public function increaseBountyAmount($bountyID,$amount) {
-		if($amount < 0)
+	public function increaseBountyAmount($bountyID, $amount) {
+		if ($amount < 0)
 			throw new Exception('Trying to increase negative bounty.');
-		$this->setBountyAmount($this->getBountyAmount($bountyID)+$amount);
+		$this->setBountyAmount($this->getBountyAmount($bountyID) + $amount);
 	}
 
-	public function decreaseBountyAmount($bountyID,$amount) {
-		if($amount < 0)
+	public function decreaseBountyAmount($bountyID, $amount) {
+		if ($amount < 0)
 			throw new Exception('Trying to decrease negative bounty.');
-		$this->setBountyAmount($this->getBountyAmount($bountyID)+$amount);
+		$this->setBountyAmount($this->getBountyAmount($bountyID) + $amount);
 	}
 
 	public function getCurrentBounty($type) {
 		$bounties = $this->getBounties();
-		foreach($bounties as $bounty) {
-			if($bounty['Claimer'] == 0 && $bounty['Type']==$type)
+		foreach ($bounties as $bounty) {
+			if ($bounty['Claimer'] == 0 && $bounty['Type'] == $type)
 				return $bounty;
 		}
 		return $this->createBounty($type);
@@ -780,8 +780,8 @@ 
 
 	public function hasCurrentBounty($type) {
 		$bounties = $this->getBounties();
-		foreach($bounties as $bounty) {
-			if($bounty['Claimer'] == 0 && $bounty['Type']==$type)
+		foreach ($bounties as $bounty) {
+			if ($bounty['Claimer'] == 0 && $bounty['Type'] == $type)
 				return true;
 		}
 		return false;
@@ -794,22 +794,22 @@ 
 
 	public function setCurrentBountyAmount($type, $amount) {
 		$bounty = $this->getCurrentBounty($type);
-		if($bounty['Amount'] == $amount)
+		if ($bounty['Amount'] == $amount)
 			return;
 		$bounty['Amount'] = $amount;
 		$this->setBounty($bounty);
 	}
 
-	public function increaseCurrentBountyAmount($type,$amount) {
-		if($amount < 0)
+	public function increaseCurrentBountyAmount($type, $amount) {
+		if ($amount < 0)
 			throw new Exception('Trying to increase negative current bounty.');
-		$this->setCurrentBountyAmount($type,$this->getCurrentBountyAmount($type)+$amount);
+		$this->setCurrentBountyAmount($type, $this->getCurrentBountyAmount($type) + $amount);
 	}
 
-	public function decreaseCurrentBountyAmount($type,$amount) {
-		if($amount < 0)
+	public function decreaseCurrentBountyAmount($type, $amount) {
+		if ($amount < 0)
 			throw new Exception('Trying to decrease negative current bounty.');
-		$this->setCurrentBountyAmount($type,$this->getCurrentBountyAmount($type)-$amount);
+		$this->setCurrentBountyAmount($type, $this->getCurrentBountyAmount($type) - $amount);
 	}
 
 	public function getCurrentBountySmrCredits($type) {
@@ -819,29 +819,29 @@ 
 
 	public function setCurrentBountySmrCredits($type, $credits) {
 		$bounty = $this->getCurrentBounty($type);
-		if($bounty['SmrCredits'] == $credits)
+		if ($bounty['SmrCredits'] == $credits)
 			return;
 		$bounty['SmrCredits'] = $credits;
 		$this->setBounty($bounty);
 	}
 
-	public function increaseCurrentBountySmrCredits($type,$credits) {
-		if($credits<0)
+	public function increaseCurrentBountySmrCredits($type, $credits) {
+		if ($credits < 0)
 			throw new Exception('Trying to increase negative current bounty.');
-		$this->setCurrentBountySmrCredits($type,$this->getCurrentBountySmrCredits($type)+$credits);
+		$this->setCurrentBountySmrCredits($type, $this->getCurrentBountySmrCredits($type) + $credits);
 	}
 
-	public function decreaseCurrentBountySmrCredits($type,$credits) {
-		if($credits<0)
+	public function decreaseCurrentBountySmrCredits($type, $credits) {
+		if ($credits < 0)
 			throw new Exception('Trying to decrease negative current bounty.');
-		$this->setCurrentBountySmrCredits($type,$this->getCurrentBountySmrCredits($type)-$credits);
+		$this->setCurrentBountySmrCredits($type, $this->getCurrentBountySmrCredits($type) - $credits);
 	}
 
 	public function setBountiesClaimable(AbstractSmrPlayer $claimer) {
 		$bounties = $this->getBounties();
-		if(is_array($bounties)) {
-			foreach($bounties as $bounty) {
-				if($bounty['Claimer'] == 0) {
+		if (is_array($bounties)) {
+			foreach ($bounties as $bounty) {
+				if ($bounty['Claimer'] == 0) {
 					$bounty['Claimer'] = $claimer->getAccountID();
 					$this->setBounty($bounty);
 				}
@@ -854,71 +854,71 @@ 
 
 	public function getHOF(array $typeList = null) {
 		$this->getHOFData();
-		if($typeList==null)
+		if ($typeList == null)
 			return $this->HOF;
-		$hof=$this->HOF;
-		foreach($typeList as $type) {
-			if(!isset($hof[$type]))
+		$hof = $this->HOF;
+		foreach ($typeList as $type) {
+			if (!isset($hof[$type]))
 				return 0;
 			$hof = $hof[$type];
 		}
 		return $hof;
 	}
 
-	public function increaseHOF($amount,array $typeList, $visibility) {
-		if($amount < 0)
-			throw new Exception('Trying to increase negative HOF: '.implode(':',$typeList));
-		if($amount == 0)
+	public function increaseHOF($amount, array $typeList, $visibility) {
+		if ($amount < 0)
+			throw new Exception('Trying to increase negative HOF: ' . implode(':', $typeList));
+		if ($amount == 0)
 			return;
-		$this->setHOF($this->getHOF($typeList)+$amount,$typeList, $visibility);
+		$this->setHOF($this->getHOF($typeList) + $amount, $typeList, $visibility);
 	}
 
-	public function decreaseHOF($amount,array $typeList, $visibility) {
-		if($amount < 0)
-			throw new Exception('Trying to decrease negative HOF: '.implode(':',$typeList));
-		if($amount == 0)
+	public function decreaseHOF($amount, array $typeList, $visibility) {
+		if ($amount < 0)
+			throw new Exception('Trying to decrease negative HOF: ' . implode(':', $typeList));
+		if ($amount == 0)
 			return;
-		$this->setHOF($this->getHOF($typeList)-$amount,$typeList, $visibility);
+		$this->setHOF($this->getHOF($typeList) - $amount, $typeList, $visibility);
 	}
 
-	public function setHOF($amount,array $typeList, $visibility) {
-		if(is_array($this->getHOF($typeList)))
-			throw new Exception('Trying to overwrite a HOF type: '.implode(':',$typeList));
-		if($this->isNPC()) {
+	public function setHOF($amount, array $typeList, $visibility) {
+		if (is_array($this->getHOF($typeList)))
+			throw new Exception('Trying to overwrite a HOF type: ' . implode(':', $typeList));
+		if ($this->isNPC()) {
 			// Don't store HOF for NPCs.
 			return;
 		}
-		if($this->getHOF($typeList)==$amount)
+		if ($this->getHOF($typeList) == $amount)
 			return;
-		if($amount < 0)
-			$amount=0;
+		if ($amount < 0)
+			$amount = 0;
 		$this->getHOF();
 
-		$hofType = implode(':',$typeList);
-		if(!isset(self::$HOFVis[$hofType])) {
+		$hofType = implode(':', $typeList);
+		if (!isset(self::$HOFVis[$hofType])) {
 			self::$hasHOFVisChanged[$hofType] = self::HOF_NEW;
 		}
-		else if(self::$HOFVis[$hofType] != $visibility) {
+		else if (self::$HOFVis[$hofType] != $visibility) {
 			self::$hasHOFVisChanged[$hofType] = self::HOF_CHANGED;
 		}
 		self::$HOFVis[$hofType] = $visibility;
 
-		$hof =& $this->HOF;
-		$hofChanged =& $this->hasHOFChanged;
+		$hof = & $this->HOF;
+		$hofChanged = & $this->hasHOFChanged;
 		$new = false;
-		foreach($typeList as $type) {
-			if(!isset($hofChanged[$type]))
+		foreach ($typeList as $type) {
+			if (!isset($hofChanged[$type]))
 				$hofChanged[$type] = array();
-			if(!isset($hof[$type])) {
+			if (!isset($hof[$type])) {
 				$hof[$type] = array();
 				$new = true;
 			}
-			$hof =& $hof[$type];
-			$hofChanged =& $hofChanged[$type];
+			$hof = & $hof[$type];
+			$hofChanged = & $hofChanged[$type];
 		}
-		if($hofChanged==null) {
+		if ($hofChanged == null) {
 			$hofChanged = self::HOF_CHANGED;
-			if($new)
+			if ($new)
 				$hofChanged = self::HOF_NEW;
 		}
 		$hof = $amount;
@@ -936,7 +936,7 @@ 
 	}
 
 	public function hasTurns() {
-		return $this->turns>0;
+		return $this->turns > 0;
 	}
 
 	public function getMaxTurns() {
@@ -944,41 +944,41 @@ 
 //		round(DEFAULT_MAX_TURNS * Globals::getGameSpeed($this->getGameID()));
 	}
 
-	public function setTurns($turns,$newNoob = false,$updateLastActive = false) {
-		if($this->turns == $turns && ($this->newbieTurns == $newNoob || $newNoob==false) && !$updateLastActive)
+	public function setTurns($turns, $newNoob = false, $updateLastActive = false) {
+		if ($this->turns == $turns && ($this->newbieTurns == $newNoob || $newNoob == false) && !$updateLastActive)
 			return;
 
 		// Make sure turns are in range [0, MaxTurns]
 		$this->turns = max(0, min($turns, $this->getMaxTurns()));
 
-		if($newNoob !== false)
+		if ($newNoob !== false)
 			$this->newbieTurns = $newNoob;
 		if ($this->newbieTurns < 0)
 			$this->newbieTurns = 0;
 
-		$this->hasChanged=true;
-		if($updateLastActive === true) {
+		$this->hasChanged = true;
+		if ($updateLastActive === true) {
 			$this->setLastActive(TIME);
 			$this->updateLastCPLAction();
 		}
 	}
 
 	public function takeTurns($take, $noob = 0, $updateLastActive = true) {
-		if($take < 0 || $noob < 0)
+		if ($take < 0 || $noob < 0)
 			throw new Exception('Trying to take negative turns.');
 		$take = ceil($take);
 		$new_turns = $this->getTurns() - $take;
-		$newbiesTaken = min($this->getNewbieTurns(),$noob);
+		$newbiesTaken = min($this->getNewbieTurns(), $noob);
 		$new_noob = $this->getNewbieTurns() - $noob;
 
 		$this->setTurns($new_turns, $new_noob, $updateLastActive);
-		$this->increaseHOF($take,array('Movement','Turns Used','Since Last Death'), HOF_ALLIANCE);
-		$this->increaseHOF($take,array('Movement','Turns Used','Total'), HOF_ALLIANCE);
-		$this->increaseHOF($newbiesTaken,array('Movement','Turns Used','Newbie'), HOF_ALLIANCE);
+		$this->increaseHOF($take, array('Movement', 'Turns Used', 'Since Last Death'), HOF_ALLIANCE);
+		$this->increaseHOF($take, array('Movement', 'Turns Used', 'Total'), HOF_ALLIANCE);
+		$this->increaseHOF($newbiesTaken, array('Movement', 'Turns Used', 'Newbie'), HOF_ALLIANCE);
 	}
 
-	public function giveTurns($give, $noob = 0,$updateLastActive = false) {
-		if($give < 0 || $noob < 0)
+	public function giveTurns($give, $noob = 0, $updateLastActive = false) {
+		if ($give < 0 || $noob < 0)
 			throw new Exception('Trying to give negative turns.');
 		$give = floor($give);
 
@@ -990,10 +990,10 @@ 
 	}
 
 	public function setLastActive($lastActive) {
-		if($this->lastActive == $lastActive)
+		if ($this->lastActive == $lastActive)
 			return;
-		$this->lastActive=$lastActive;
-		$this->hasChanged=true;
+		$this->lastActive = $lastActive;
+		$this->hasChanged = true;
 	}
 
 	public function getLastCPLAction() {
@@ -1001,10 +1001,10 @@ 
 	}
 
 	public function setLastCPLAction($time) {
-		if($this->lastCPLAction == $time)
+		if ($this->lastCPLAction == $time)
 			return;
-		$this->lastCPLAction=$time;
-		$this->hasChanged=true;
+		$this->lastCPLAction = $time;
+		$this->hasChanged = true;
 	}
 
 	public function updateLastCPLAction() {
@@ -1013,7 +1013,7 @@ 
 
 
 	function getCompletedMissions() {
-		if(!isset($this->completedMissions)) {
+		if (!isset($this->completedMissions)) {
 			//Get Player missions
 			$this->db->query('SELECT mission_id FROM player_completed_mission WHERE ' . $this->SQL);
 			$this->completedMissions = array();
@@ -1024,7 +1024,7 @@ 
 	}
 
 	public function getMissions() {
-		if(!isset($this->missions)) {
+		if (!isset($this->missions)) {
 			$this->db->query('SELECT * FROM player_has_mission WHERE ' . $this->SQL);
 			$this->missions = array();
 			while ($this->db->nextRecord()) {
@@ -1045,7 +1045,7 @@ 
 
 	public function getActiveMissions() {
 		$missions = $this->getMissions();
-		foreach($missions as $missionID => $mission) {
+		foreach ($missions as $missionID => $mission) {
 			if ($mission['On Step'] >= count(MISSIONS[$missionID]['Steps'])) {
 				unset($missions[$missionID]);
 			}
@@ -1055,7 +1055,7 @@ 
 
 	function getMission($missionID) {
 		$missions = $this->getMissions();
-		if(isset($missions[$missionID]))
+		if (isset($missions[$missionID]))
 			return $missions[$missionID];
 		return false;
 	}
@@ -1066,7 +1066,7 @@ 
 
 	function updateMission($missionID) {
 		$this->getMissions();
-		if(isset($this->missions[$missionID])) {
+		if (isset($this->missions[$missionID])) {
 			$mission = $this->missions[$missionID];
 			$this->db->query('
 				UPDATE player_has_mission
@@ -1084,15 +1084,15 @@ 
 	}
 
 	private function setupMissionStep($missionID) {
-		$mission =& $this->missions[$missionID];
+		$mission = & $this->missions[$missionID];
 		$step = MISSIONS[$missionID]['Steps'][$mission['On Step']];
-		if(isset($step['PickSector'])) {
+		if (isset($step['PickSector'])) {
 			$realX = Plotter::getX($step['PickSector']['Type'], $step['PickSector']['X'], $this->getGameID());
-			if($realX === false) {
+			if ($realX === false) {
 				throw new Exception('Invalid PickSector definition in mission: ' . $missionID);
 			}
 			$path = Plotter::findDistanceToX($realX, $this->getSector(), true, null, $this);
-			if($path === false) {
+			if ($path === false) {
 				throw new Exception('Cannot find location: ' . $missionID);
 			}
 			$mission['Sector'] = $path->getEndSectorID();
@@ -1102,7 +1102,7 @@ 
 	function addMission($missionID) {
 		$this->getMissions();
 
-		if(isset($this->missions[$missionID]))
+		if (isset($this->missions[$missionID]))
 			return;
 		$sector = 0;
 
@@ -1115,13 +1115,13 @@ 
 			'Starting Sector' => $this->getSectorID()
 		);
 
-		$this->missions[$missionID] =& $mission;
+		$this->missions[$missionID] = & $mission;
 		$this->setupMissionStep($missionID);
 		$this->rebuildMission($missionID);
 
 		$this->db->query('
 			REPLACE INTO player_has_mission (game_id,account_id,mission_id,on_step,progress,unread,starting_sector,mission_sector,step_fails)
-			VALUES ('.$this->db->escapeNumber($this->gameID).','.$this->db->escapeNumber($this->accountID).','.$this->db->escapeNumber($missionID).','.$this->db->escapeNumber($mission['On Step']).','.$this->db->escapeNumber($mission['Progress']).','.$this->db->escapeBoolean($mission['Unread']).','.$this->db->escapeNumber($mission['Starting Sector']).','.$this->db->escapeNumber($mission['Sector']).','.$this->db->escapeNumber($mission['Expires']).')'
+			VALUES ('.$this->db->escapeNumber($this->gameID) . ',' . $this->db->escapeNumber($this->accountID) . ',' . $this->db->escapeNumber($missionID) . ',' . $this->db->escapeNumber($mission['On Step']) . ',' . $this->db->escapeNumber($mission['Progress']) . ',' . $this->db->escapeBoolean($mission['Unread']) . ',' . $this->db->escapeNumber($mission['Starting Sector']) . ',' . $this->db->escapeNumber($mission['Sector']) . ',' . $this->db->escapeNumber($mission['Expires']) . ')'
 		);
 	}
 
@@ -1135,9 +1135,9 @@ 
 		}
 		else {
 			$currentStep = MISSIONS[$missionID]['Steps'][$mission['On Step']];
-			$currentStep['Text'] = str_replace(array('<Race>','<Sector>','<Starting Sector>','<trader>'),array($this->getRaceID(),$mission['Sector'],$mission['Starting Sector'],$this->playerName),$currentStep['Text']);
+			$currentStep['Text'] = str_replace(array('<Race>', '<Sector>', '<Starting Sector>', '<trader>'), array($this->getRaceID(), $mission['Sector'], $mission['Starting Sector'], $this->playerName), $currentStep['Text']);
 			if (isset($currentStep['Task'])) {
-				$currentStep['Task'] = str_replace(array('<Race>','<Sector>','<Starting Sector>','<trader>'),array($this->getRaceID(),$mission['Sector'],$mission['Starting Sector'],$this->playerName),$currentStep['Task']);
+				$currentStep['Task'] = str_replace(array('<Race>', '<Sector>', '<Starting Sector>', '<trader>'), array($this->getRaceID(), $mission['Sector'], $mission['Starting Sector'], $this->playerName), $currentStep['Task']);
 			}
 			if (isset($currentStep['Level'])) {
 				$currentStep['Level'] = str_replace('<Player Level>', $this->getLevelID(), $currentStep['Level']);
@@ -1151,9 +1151,9 @@ 
 
 	function deleteMission($missionID) {
 		$this->getMissions();
-		if(isset($this->missions[$missionID])) {
+		if (isset($this->missions[$missionID])) {
 			unset($this->missions[$missionID]);
-			$this->db->query('DELETE FROM player_has_mission WHERE '.$this->SQL.' AND mission_id = '.$this->db->escapeNumber($missionID).' LIMIT 1');
+			$this->db->query('DELETE FROM player_has_mission WHERE ' . $this->SQL . ' AND mission_id = ' . $this->db->escapeNumber($missionID) . ' LIMIT 1');
 			return true;
 		}
 		return false;
@@ -1162,8 +1162,8 @@ 
 	public function markMissionsRead() {
 		$this->getMissions();
 		$unreadMissions = array();
-		foreach($this->missions as $missionID => &$mission) {
-			if($mission['Unread']) {
+		foreach ($this->missions as $missionID => &$mission) {
+			if ($mission['Unread']) {
 				$unreadMissions[] = $missionID;
 				$mission['Unread'] = false;
 				$this->updateMission($missionID);
@@ -1174,17 +1174,17 @@ 
 
 	public function claimMissionReward($missionID) {
 		$this->getMissions();
-		$mission =& $this->missions[$missionID];
-		if($mission === false) {
+		$mission = & $this->missions[$missionID];
+		if ($mission === false) {
 			throw new Exception('Unknown mission: ' . $missionID);
 		}
-		if($mission['Task'] === false || $mission['Task']['Step'] != 'Claim') {
+		if ($mission['Task'] === false || $mission['Task']['Step'] != 'Claim') {
 			throw new Exception('Cannot claim mission: ' . $missionID . ', for step: ' . $mission['On Step']);
 		}
 		$mission['On Step']++;
 		$mission['Unread'] = true;
-		foreach($mission['Task']['Rewards'] as $rewardItem => $amount) {
-			switch($rewardItem) {
+		foreach ($mission['Task']['Rewards'] as $rewardItem => $amount) {
+			switch ($rewardItem) {
 				case 'Credits':
 					$this->increaseCredits($amount);
 				break;
@@ -1206,14 +1206,14 @@ 
 	public function getAvailableMissions() {
 		$availableMissions = array();
 		foreach (MISSIONS as $missionID => $mission) {
-			if($this->hasMission($missionID)) {
+			if ($this->hasMission($missionID)) {
 				continue;
 			}
 			$realX = Plotter::getX($mission['HasX']['Type'], $mission['HasX']['X'], $this->getGameID());
-			if($realX === false) {
+			if ($realX === false) {
 				throw new Exception('Invalid HasX definition in mission: ' . $missionID);
 			}
-			if($this->getSector()->hasX($realX)) {
+			if ($this->getSector()->hasX($realX)) {
 				$availableMissions[$missionID] = $mission;
 			}
 		}
@@ -1225,31 +1225,31 @@ 
 			throw new Exception('Unknown action: ' . $actionID);
 		}
 // TODO: Reenable this once tested.		if($this->getAccount()->isLoggingEnabled())
-			switch($actionID) {
+			switch ($actionID) {
 				case 'WalkSector':
 					$this->getAccount()->log(LOG_TYPE_MOVEMENT, 'Walks to sector: ' . $values['Sector']->getSectorID(), $this->getSectorID());
 				break;
 				case 'JoinAlliance':
-					$this->getAccount()->log(LOG_TYPE_ALLIANCE, 'joined alliance: '.$values['Alliance']->getAllianceName(), $this->getSectorID());
+					$this->getAccount()->log(LOG_TYPE_ALLIANCE, 'joined alliance: ' . $values['Alliance']->getAllianceName(), $this->getSectorID());
 				break;
 				case 'LeaveAlliance':
-					$this->getAccount()->log(LOG_TYPE_ALLIANCE, 'left alliance: '.$values['Alliance']->getAllianceName(), $this->getSectorID());
+					$this->getAccount()->log(LOG_TYPE_ALLIANCE, 'left alliance: ' . $values['Alliance']->getAllianceName(), $this->getSectorID());
 				break;
 				case 'DisbandAlliance':
-					$this->getAccount()->log(LOG_TYPE_ALLIANCE, 'disbanded alliance '.$values['Alliance']->getAllianceName(), $this->getSectorID());
+					$this->getAccount()->log(LOG_TYPE_ALLIANCE, 'disbanded alliance ' . $values['Alliance']->getAllianceName(), $this->getSectorID());
 				break;
 				case 'KickPlayer':
-					$this->getAccount()->log(LOG_TYPE_ALLIANCE, 'kicked '.$values['Player']->getAccount()->getLogin().' ('.$values['Player']->getPlayerName().') from alliance '.$values['Alliance']->getAllianceName(), 0);
+					$this->getAccount()->log(LOG_TYPE_ALLIANCE, 'kicked ' . $values['Player']->getAccount()->getLogin() . ' (' . $values['Player']->getPlayerName() . ') from alliance ' . $values['Alliance']->getAllianceName(), 0);
 				break;
 				case 'PlayerKicked':
-					$this->getAccount()->log(LOG_TYPE_ALLIANCE, 'was kicked from alliance '.$values['Alliance']->getAllianceName().' by '.$values['Player']->getAccount()->getLogin().' ('.$values['Player']->getPlayerName().')', 0);
+					$this->getAccount()->log(LOG_TYPE_ALLIANCE, 'was kicked from alliance ' . $values['Alliance']->getAllianceName() . ' by ' . $values['Player']->getAccount()->getLogin() . ' (' . $values['Player']->getPlayerName() . ')', 0);
 				break;
 
 			}
 		$this->getMissions();
-		foreach($this->missions as $missionID => &$mission) {
-			if($mission['Task'] !== false && $mission['Task']['Step'] == $actionID) {
-				if(checkMissionRequirements($values, $mission, $this) === true) {
+		foreach ($this->missions as $missionID => &$mission) {
+			if ($mission['Task'] !== false && $mission['Task']['Step'] == $actionID) {
+				if (checkMissionRequirements($values, $mission, $this) === true) {
 					$mission['On Step']++;
 					$mission['Unread'] = true;
 					$this->setupMissionStep($missionID);
@@ -1261,8 +1261,8 @@ 
 	}
 
 	public function canSeeAny(array $otherPlayerArray) {
-		foreach($otherPlayerArray as $otherPlayer) {
-			if($this->canSee($otherPlayer)) {
+		foreach ($otherPlayerArray as $otherPlayer) {
+			if ($this->canSee($otherPlayer)) {
 				return true;
 			}
 		}
@@ -1270,21 +1270,21 @@ 
 	}
 
 	public function canSee(AbstractSmrPlayer $otherPlayer) {
-		if(!$otherPlayer->getShip()->isCloaked())
+		if (!$otherPlayer->getShip()->isCloaked())
 			return true;
-		if($this->sameAlliance($otherPlayer))
+		if ($this->sameAlliance($otherPlayer))
 			return true;
-		if($this->getExperience()>=$otherPlayer->getExperience())
+		if ($this->getExperience() >= $otherPlayer->getExperience())
 			return true;
 		return false;
 	}
 
 	public function equals(AbstractSmrPlayer $otherPlayer = null) {
-		return $otherPlayer!==null && $this->getAccountID()==$otherPlayer->getAccountID() && $this->getGameID()==$otherPlayer->getGameID();
+		return $otherPlayer !== null && $this->getAccountID() == $otherPlayer->getAccountID() && $this->getGameID() == $otherPlayer->getGameID();
 	}
 
 	public function sameAlliance(AbstractSmrPlayer $otherPlayer = null) {
-		return $otherPlayer != null && ($this->equals($otherPlayer) || ($this->hasAlliance() && $this->getAllianceID()==$otherPlayer->getAllianceID()));
+		return $otherPlayer != null && ($this->equals($otherPlayer) || ($this->hasAlliance() && $this->getAllianceID() == $otherPlayer->getAllianceID()));
 	}
 
 	public function sharedForceAlliance(AbstractSmrPlayer $otherPlayer = null) {
@@ -1328,10 +1328,10 @@ 
 	}
 
 	public function meetsAlignmentRestriction($restriction) {
-		if($restriction<0)
-			return $this->getAlignment()<=$restriction;
-		if($restriction>0)
-			return $this->getAlignment()>=$restriction;
+		if ($restriction < 0)
+			return $this->getAlignment() <= $restriction;
+		if ($restriction > 0)
+			return $this->getAlignment() >= $restriction;
 		return true;
 	}
 
@@ -1351,10 +1351,10 @@ 
 	 * Will retrieve all visited sectors, use only when you are likely to check a large number of these
 	 */
 	public function hasVisitedSector($sectorID) {
-		if(!isset($this->visitedSectors)) {
+		if (!isset($this->visitedSectors)) {
 			$this->visitedSectors = array();
 			$this->db->query('SELECT sector_id FROM player_visited_sector WHERE ' . $this->SQL);
-			while($this->db->nextRecord())
+			while ($this->db->nextRecord())
 				$this->visitedSectors[$this->db->getField('sector_id')] = false;
 		}
 		return !isset($this->visitedSectors[$sectorID]);
@@ -1365,7 +1365,7 @@ 
 	}
 
 	public function getExamineTraderHREF() {
-		$container = create_container('skeleton.php','trader_examine.php');
+		$container = create_container('skeleton.php', 'trader_examine.php');
 		$container['target'] = $this->getAccountID();
 		return SmrSession::getNewHREF($container);
 	}
@@ -1375,13 +1375,13 @@ 
 	}
 
 	public function getPlanetKickHREF() {
-		$container = create_container('planet_kick_processing.php','trader_attack_processing.php');
+		$container = create_container('planet_kick_processing.php', 'trader_attack_processing.php');
 		$container['account_id'] = $this->getAccountID();
 		return SmrSession::getNewHREF($container);
 	}
 
 	public function getTraderSearchHREF() {
-		$container = create_container('skeleton.php','trader_search_result.php');
+		$container = create_container('skeleton.php', 'trader_search_result.php');
 		$container['player_id'] = $this->getPlayerID();
 		return SmrSession::getNewHREF($container);
 	}
@@ -1391,7 +1391,7 @@ 
 	}
 
 	public function getToggleWeaponHidingHREF() {
-		$container = create_container('skeleton.php','toggle_processing.php');
+		$container = create_container('skeleton.php', 'toggle_processing.php');
 		$container['toggle'] = 'WeaponHiding';
 		return SmrSession::getNewHREF($container);
 	}

Braces +238 added lines, -163 removed lines

@@ -78,8 +78,9 @@ 
 		return $this->getNewbieTurns()>0;
 	}
 	public function setNewbieTurns($newbieTurns) {
-		if($this->newbieTurns == $newbieTurns)
-			return;
+		if($this->newbieTurns == $newbieTurns) {
+					return;
+		}
 		$this->newbieTurns=$newbieTurns;
 		$this->hasChanged=true;
 	}
@@ -89,8 +90,9 @@ 
 	}
 
 	public function setShipTypeID($shipID) {
-		if($this->shipID == $shipID)
-			return;
+		if($this->shipID == $shipID) {
+					return;
+		}
 		$this->shipID=$shipID;
 		$this->hasChanged=true;
 	}
@@ -206,8 +208,9 @@ 
 		}
 
 		$ship = $this->getShip();
-		if ($ship->hasIllegalGoods())
-			return false;
+		if ($ship->hasIllegalGoods()) {
+					return false;
+		}
 
 		if ($ship->getAttackRating() <= $this->getSafeAttackRating()) {
 			foreach($sector->getFedRaceIDs() as $fedRaceID) {
@@ -248,8 +251,9 @@ 
 	}
 
 	public function setDead($bool) {
-		if($this->dead == $bool)
-			return;
+		if($this->dead == $bool) {
+					return;
+		}
 		$this->dead=$bool;
 		$this->hasChanged=true;
 	}
@@ -259,14 +263,16 @@ 
 	}
 
 	public function increaseKills($kills) {
-		if($kills < 0)
-			throw new Exception('Trying to increase negative kills.');
+		if($kills < 0) {
+					throw new Exception('Trying to increase negative kills.');
+		}
 		$this->setKills($this->kills+$kills);
 	}
 
 	public function setKills($kills) {
-		if($this->kills == $kills)
-			return;
+		if($this->kills == $kills) {
+					return;
+		}
 		$this->kills=$kills;
 		$this->hasChanged=true;
 	}
@@ -276,14 +282,16 @@ 
 	}
 
 	public function increaseDeaths($deaths) {
-		if($deaths < 0)
-			throw new Exception('Trying to increase negative deaths.');
+		if($deaths < 0) {
+					throw new Exception('Trying to increase negative deaths.');
+		}
 		$this->setDeaths($this->getDeaths()+$deaths);
 	}
 
 	public function setDeaths($deaths) {
-		if($this->deaths == $deaths)
-			return;
+		if($this->deaths == $deaths) {
+					return;
+		}
 		$this->deaths = $deaths;
 		$this->hasChanged=true;
 	}
@@ -305,24 +313,29 @@ 
 	}
 
 	public function increaseAlignment($align) {
-		if($align < 0)
-			throw new Exception('Trying to increase negative align.');
-		if($align == 0)
-			return;
+		if($align < 0) {
+					throw new Exception('Trying to increase negative align.');
+		}
+		if($align == 0) {
+					return;
+		}
 		$align += $this->alignment;
 		$this->setAlignment($align);
 	}
 	public function decreaseAlignment($align) {
-		if($align < 0)
-			throw new Exception('Trying to decrease negative align.');
-		if($align == 0)
-			return;
+		if($align < 0) {
+					throw new Exception('Trying to decrease negative align.');
+		}
+		if($align == 0) {
+					return;
+		}
 		$align = $this->alignment - $align;
 		$this->setAlignment($align);
 	}
 	public function setAlignment($align) {
-		if($this->alignment == $align)
-			return;
+		if($this->alignment == $align) {
+					return;
+		}
 		$this->alignment = $align;
 		$this->hasChanged=true;
 	}
@@ -336,8 +349,9 @@ 
 	}
 
 	public function getNextLevelPercentAcquired() {
-		if($this->getNextLevelExperience() == $this->getThisLevelExperience())
-			return 100;
+		if($this->getNextLevelExperience() == $this->getThisLevelExperience()) {
+					return 100;
+		}
 		return max(0,min(100,round(($this->getExperience() - $this->getThisLevelExperience()) / ($this->getNextLevelExperience() - $this->getThisLevelExperience())*100)));
 	}
 
@@ -347,8 +361,10 @@ 
 
 	public function getNextLevelExperience() {
 		$LEVELS_REQUIREMENTS = Globals::getLevelRequirements();
-		if(!isset($LEVELS_REQUIREMENTS[$this->getLevelID()+1]))
-			return $this->getThisLevelExperience(); //Return current level experience if on last level.
+		if(!isset($LEVELS_REQUIREMENTS[$this->getLevelID()+1])) {
+					return $this->getThisLevelExperience();
+		}
+		//Return current level experience if on last level.
 		return $LEVELS_REQUIREMENTS[$this->getLevelID()+1]['Requirement'];
 	}
 
@@ -358,12 +374,15 @@ 
 	}
 
 	public function setExperience($experience) {
-		if($this->experience == $experience)
-			return;
-		if($experience<MIN_EXPERIENCE)
-			$experience = MIN_EXPERIENCE;
-		if($experience>MAX_EXPERIENCE)
-			$experience = MAX_EXPERIENCE;
+		if($this->experience == $experience) {
+					return;
+		}
+		if($experience<MIN_EXPERIENCE) {
+					$experience = MIN_EXPERIENCE;
+		}
+		if($experience>MAX_EXPERIENCE) {
+					$experience = MAX_EXPERIENCE;
+		}
 		$this->experience = $experience;
 		$this->hasChanged=true;
 
@@ -373,46 +392,57 @@ 
 	}
 
 	public function increaseCredits($credits) {
-		if($credits < 0)
-			throw new Exception('Trying to increase negative credits.');
-		if($credits == 0)
-			return;
+		if($credits < 0) {
+					throw new Exception('Trying to increase negative credits.');
+		}
+		if($credits == 0) {
+					return;
+		}
 		$credits += $this->credits;
 		$this->setCredits($credits);
 	}
 	public function decreaseCredits($credits) {
-		if($credits < 0)
-			throw new Exception('Trying to decrease negative credits.');
-		if($credits == 0)
-			return;
+		if($credits < 0) {
+					throw new Exception('Trying to decrease negative credits.');
+		}
+		if($credits == 0) {
+					return;
+		}
 		$credits = $this->credits - $credits;
 		$this->setCredits($credits);
 	}
 	public function setCredits($credits) {
-		if($this->credits == $credits)
-			return;
-		if($credits < 0)
-			throw new Exception('Trying to set negative credits.');
-		if($credits > MAX_MONEY)
-			$credits = MAX_MONEY;
+		if($this->credits == $credits) {
+					return;
+		}
+		if($credits < 0) {
+					throw new Exception('Trying to set negative credits.');
+		}
+		if($credits > MAX_MONEY) {
+					$credits = MAX_MONEY;
+		}
 		$this->credits = $credits;
 		$this->hasChanged=true;
 	}
 
 	public function increaseExperience($experience) {
-		if($experience < 0)
-			throw new Exception('Trying to increase negative experience.');
-		if($experience == 0)
-			return;
+		if($experience < 0) {
+					throw new Exception('Trying to increase negative experience.');
+		}
+		if($experience == 0) {
+					return;
+		}
 		$newExperience = $this->experience + $experience;
 		$this->setExperience($newExperience);
 		$this->increaseHOF($experience,array('Experience','Total','Gain'), HOF_PUBLIC);
 	}
 	public function decreaseExperience($experience) {
-		if($experience < 0)
-			throw new Exception('Trying to decrease negative experience.');
-		if($experience == 0)
-			return;
+		if($experience < 0) {
+					throw new Exception('Trying to decrease negative experience.');
+		}
+		if($experience == 0) {
+					return;
+		}
 		$newExperience = $this->experience - $experience;
 		$this->setExperience($newExperience);
 		$this->decreaseHOF($experience,array('Experience','Total','Loss'), HOF_PUBLIC);
@@ -423,8 +453,9 @@ 
 	}
 
 	public function setLandedOnPlanet($bool) {
-		if($this->landedOnPlanet == $bool)
-			return;
+		if($this->landedOnPlanet == $bool) {
+					return;
+		}
 		$this->landedOnPlanet=$bool;
 		$this->hasChanged=true;
 	}
@@ -438,7 +469,9 @@ 
 		if ($this->level === null) {
 			$LEVELS_REQUIREMENTS = Globals::getLevelRequirements();
 			foreach ($LEVELS_REQUIREMENTS as $level_id => $require) {
-				if ($this->getExperience() >= $require['Requirement']) continue;
+				if ($this->getExperience() >= $require['Requirement']) {
+					continue;
+				}
 				$this->level = $level_id - 1;
 				return $this->level;
 			}
@@ -516,8 +549,9 @@ 
 	}
 
 	public function setRaceID($raceID) {
-		if($this->raceID == $raceID)
-			return;
+		if($this->raceID == $raceID) {
+					return;
+		}
 		$this->raceID=$raceID;
 		$this->hasChanged=true;
 	}
@@ -539,8 +573,9 @@ 
 	}
 
 	public function setAllianceID($ID) {
-		if($this->allianceID == $ID)
-			return;
+		if($this->allianceID == $ID) {
+					return;
+		}
 		$this->allianceID=$ID;
 		if ($this->allianceID != 0) {
 			$status = $this->hasNewbieStatus() ? 'NEWBIE' : 'VETERAN';
@@ -557,8 +592,7 @@ 
 	public function getAllianceName($linked=false, $includeAllianceID=false) {
 		if($this->hasAlliance()) {
 			return $this->getAlliance()->getAllianceName($linked, $includeAllianceID);
-		}
-		else {
+		} else {
 			return 'No Alliance';
 		}
 	}
@@ -586,8 +620,9 @@ 
 	}
 
 	public function setCombatDronesKamikazeOnMines($bool) {
-		if($this->combatDronesKamikazeOnMines == $bool)
-			return;
+		if($this->combatDronesKamikazeOnMines == $bool) {
+					return;
+		}
 		$this->combatDronesKamikazeOnMines = $bool;
 		$this->hasChanged=true;
 	}
@@ -604,15 +639,17 @@ 
 			$gadgetID = $GADGETS[$gadgetID]['ID'];
 		}
 		$gadgets = $this->getGadgets();
-		if(isset($gadgets[$gadgetID]))
-			return $gadgets[$gadgetID];
+		if(isset($gadgets[$gadgetID])) {
+					return $gadgets[$gadgetID];
+		}
 		return false;
 	}
 
 	public function isGadgetEquipped($gadgetID) {
 		$gadget = $this->getGadget($gadgetID);
-		if($gadget===false)
-			return false;
+		if($gadget===false) {
+					return false;
+		}
 		return $gadget['Equipped'] > 0 && $gadget['Equipped'] < TIME && ($gadget['Expires'] == 0 || $gadget['Expires'] > TIME) && $gadget['Cooldown'] <= TIME;
 	}
 
@@ -684,21 +721,24 @@ 
 	}
 
 	public function setMilitaryPayment($amount) {
-		if($this->militaryPayment == $amount)
-			return;
+		if($this->militaryPayment == $amount) {
+					return;
+		}
 		$this->militaryPayment = $amount;
 		$this->hasChanged=true;
 	}
 
 	public function increaseMilitaryPayment($amount) {
-		if($amount < 0)
-			throw new Exception('Trying to increase negative military payment.');
+		if($amount < 0) {
+					throw new Exception('Trying to increase negative military payment.');
+		}
 		$this->setMilitaryPayment($this->getMilitaryPayment()+$amount);
 	}
 
 	public function decreaseMilitaryPayment($amount) {
-		if($amount < 0)
-			throw new Exception('Trying to decrease negative military payment.');
+		if($amount < 0) {
+					throw new Exception('Trying to decrease negative military payment.');
+		}
 		$this->setMilitaryPayment($this->getMilitaryPayment()-$amount);
 	}
 
@@ -740,10 +780,11 @@ 
 
 	public function getNextBountyID() {
 		$keys = array_keys($this->getBounties());
-		if(count($keys)>0)
-			return max($keys)+1;
-		else
-			return 0;
+		if(count($keys)>0) {
+					return max($keys)+1;
+		} else {
+					return 0;
+		}
 	}
 
 	public function setBounty(array $bounty) {
@@ -758,22 +799,25 @@ 
 	}
 
 	public function increaseBountyAmount($bountyID,$amount) {
-		if($amount < 0)
-			throw new Exception('Trying to increase negative bounty.');
+		if($amount < 0) {
+					throw new Exception('Trying to increase negative bounty.');
+		}
 		$this->setBountyAmount($this->getBountyAmount($bountyID)+$amount);
 	}
 
 	public function decreaseBountyAmount($bountyID,$amount) {
-		if($amount < 0)
-			throw new Exception('Trying to decrease negative bounty.');
+		if($amount < 0) {
+					throw new Exception('Trying to decrease negative bounty.');
+		}
 		$this->setBountyAmount($this->getBountyAmount($bountyID)+$amount);
 	}
 
 	public function getCurrentBounty($type) {
 		$bounties = $this->getBounties();
 		foreach($bounties as $bounty) {
-			if($bounty['Claimer'] == 0 && $bounty['Type']==$type)
-				return $bounty;
+			if($bounty['Claimer'] == 0 && $bounty['Type']==$type) {
+							return $bounty;
+			}
 		}
 		return $this->createBounty($type);
 	}
@@ -781,8 +825,9 @@ 
 	public function hasCurrentBounty($type) {
 		$bounties = $this->getBounties();
 		foreach($bounties as $bounty) {
-			if($bounty['Claimer'] == 0 && $bounty['Type']==$type)
-				return true;
+			if($bounty['Claimer'] == 0 && $bounty['Type']==$type) {
+							return true;
+			}
 		}
 		return false;
 	}
@@ -794,21 +839,24 @@ 
 
 	public function setCurrentBountyAmount($type, $amount) {
 		$bounty = $this->getCurrentBounty($type);
-		if($bounty['Amount'] == $amount)
-			return;
+		if($bounty['Amount'] == $amount) {
+					return;
+		}
 		$bounty['Amount'] = $amount;
 		$this->setBounty($bounty);
 	}
 
 	public function increaseCurrentBountyAmount($type,$amount) {
-		if($amount < 0)
-			throw new Exception('Trying to increase negative current bounty.');
+		if($amount < 0) {
+					throw new Exception('Trying to increase negative current bounty.');
+		}
 		$this->setCurrentBountyAmount($type,$this->getCurrentBountyAmount($type)+$amount);
 	}
 
 	public function decreaseCurrentBountyAmount($type,$amount) {
-		if($amount < 0)
-			throw new Exception('Trying to decrease negative current bounty.');
+		if($amount < 0) {
+					throw new Exception('Trying to decrease negative current bounty.');
+		}
 		$this->setCurrentBountyAmount($type,$this->getCurrentBountyAmount($type)-$amount);
 	}
 
@@ -819,21 +867,24 @@ 
 
 	public function setCurrentBountySmrCredits($type, $credits) {
 		$bounty = $this->getCurrentBounty($type);
-		if($bounty['SmrCredits'] == $credits)
-			return;
+		if($bounty['SmrCredits'] == $credits) {
+					return;
+		}
 		$bounty['SmrCredits'] = $credits;
 		$this->setBounty($bounty);
 	}
 
 	public function increaseCurrentBountySmrCredits($type,$credits) {
-		if($credits<0)
-			throw new Exception('Trying to increase negative current bounty.');
+		if($credits<0) {
+					throw new Exception('Trying to increase negative current bounty.');
+		}
 		$this->setCurrentBountySmrCredits($type,$this->getCurrentBountySmrCredits($type)+$credits);
 	}
 
 	public function decreaseCurrentBountySmrCredits($type,$credits) {
-		if($credits<0)
-			throw new Exception('Trying to decrease negative current bounty.');
+		if($credits<0) {
+					throw new Exception('Trying to decrease negative current bounty.');
+		}
 		$this->setCurrentBountySmrCredits($type,$this->getCurrentBountySmrCredits($type)-$credits);
 	}
 
@@ -854,51 +905,59 @@ 
 
 	public function getHOF(array $typeList = null) {
 		$this->getHOFData();
-		if($typeList==null)
-			return $this->HOF;
+		if($typeList==null) {
+					return $this->HOF;
+		}
 		$hof=$this->HOF;
 		foreach($typeList as $type) {
-			if(!isset($hof[$type]))
-				return 0;
+			if(!isset($hof[$type])) {
+							return 0;
+			}
 			$hof = $hof[$type];
 		}
 		return $hof;
 	}
 
 	public function increaseHOF($amount,array $typeList, $visibility) {
-		if($amount < 0)
-			throw new Exception('Trying to increase negative HOF: '.implode(':',$typeList));
-		if($amount == 0)
-			return;
+		if($amount < 0) {
+					throw new Exception('Trying to increase negative HOF: '.implode(':',$typeList));
+		}
+		if($amount == 0) {
+					return;
+		}
 		$this->setHOF($this->getHOF($typeList)+$amount,$typeList, $visibility);
 	}
 
 	public function decreaseHOF($amount,array $typeList, $visibility) {
-		if($amount < 0)
-			throw new Exception('Trying to decrease negative HOF: '.implode(':',$typeList));
-		if($amount == 0)
-			return;
+		if($amount < 0) {
+					throw new Exception('Trying to decrease negative HOF: '.implode(':',$typeList));
+		}
+		if($amount == 0) {
+					return;
+		}
 		$this->setHOF($this->getHOF($typeList)-$amount,$typeList, $visibility);
 	}
 
 	public function setHOF($amount,array $typeList, $visibility) {
-		if(is_array($this->getHOF($typeList)))
-			throw new Exception('Trying to overwrite a HOF type: '.implode(':',$typeList));
+		if(is_array($this->getHOF($typeList))) {
+					throw new Exception('Trying to overwrite a HOF type: '.implode(':',$typeList));
+		}
 		if($this->isNPC()) {
 			// Don't store HOF for NPCs.
 			return;
 		}
-		if($this->getHOF($typeList)==$amount)
-			return;
-		if($amount < 0)
-			$amount=0;
+		if($this->getHOF($typeList)==$amount) {
+					return;
+		}
+		if($amount < 0) {
+					$amount=0;
+		}
 		$this->getHOF();
 
 		$hofType = implode(':',$typeList);
 		if(!isset(self::$HOFVis[$hofType])) {
 			self::$hasHOFVisChanged[$hofType] = self::HOF_NEW;
-		}
-		else if(self::$HOFVis[$hofType] != $visibility) {
+		} else if(self::$HOFVis[$hofType] != $visibility) {
 			self::$hasHOFVisChanged[$hofType] = self::HOF_CHANGED;
 		}
 		self::$HOFVis[$hofType] = $visibility;
@@ -907,8 +966,9 @@ 
 		$hofChanged =& $this->hasHOFChanged;
 		$new = false;
 		foreach($typeList as $type) {
-			if(!isset($hofChanged[$type]))
-				$hofChanged[$type] = array();
+			if(!isset($hofChanged[$type])) {
+							$hofChanged[$type] = array();
+			}
 			if(!isset($hof[$type])) {
 				$hof[$type] = array();
 				$new = true;
@@ -918,8 +978,9 @@ 
 		}
 		if($hofChanged==null) {
 			$hofChanged = self::HOF_CHANGED;
-			if($new)
-				$hofChanged = self::HOF_NEW;
+			if($new) {
+							$hofChanged = self::HOF_NEW;
+			}
 		}
 		$hof = $amount;
 	}
@@ -945,16 +1006,19 @@ 
 	}
 
 	public function setTurns($turns,$newNoob = false,$updateLastActive = false) {
-		if($this->turns == $turns && ($this->newbieTurns == $newNoob || $newNoob==false) && !$updateLastActive)
-			return;
+		if($this->turns == $turns && ($this->newbieTurns == $newNoob || $newNoob==false) && !$updateLastActive) {
+					return;
+		}
 
 		// Make sure turns are in range [0, MaxTurns]
 		$this->turns = max(0, min($turns, $this->getMaxTurns()));
 
-		if($newNoob !== false)
-			$this->newbieTurns = $newNoob;
-		if ($this->newbieTurns < 0)
-			$this->newbieTurns = 0;
+		if($newNoob !== false) {
+					$this->newbieTurns = $newNoob;
+		}
+		if ($this->newbieTurns < 0) {
+					$this->newbieTurns = 0;
+		}
 
 		$this->hasChanged=true;
 		if($updateLastActive === true) {
@@ -964,8 +1028,9 @@ 
 	}
 
 	public function takeTurns($take, $noob = 0, $updateLastActive = true) {
-		if($take < 0 || $noob < 0)
-			throw new Exception('Trying to take negative turns.');
+		if($take < 0 || $noob < 0) {
+					throw new Exception('Trying to take negative turns.');
+		}
 		$take = ceil($take);
 		$new_turns = $this->getTurns() - $take;
 		$newbiesTaken = min($this->getNewbieTurns(),$noob);
@@ -978,8 +1043,9 @@ 
 	}
 
 	public function giveTurns($give, $noob = 0,$updateLastActive = false) {
-		if($give < 0 || $noob < 0)
-			throw new Exception('Trying to give negative turns.');
+		if($give < 0 || $noob < 0) {
+					throw new Exception('Trying to give negative turns.');
+		}
 		$give = floor($give);
 
 		$this->setTurns($this->getTurns() + $give, $this->getNewbieTurns() + $noob, $updateLastActive);
@@ -990,8 +1056,9 @@ 
 	}
 
 	public function setLastActive($lastActive) {
-		if($this->lastActive == $lastActive)
-			return;
+		if($this->lastActive == $lastActive) {
+					return;
+		}
 		$this->lastActive=$lastActive;
 		$this->hasChanged=true;
 	}
@@ -1001,8 +1068,9 @@ 
 	}
 
 	public function setLastCPLAction($time) {
-		if($this->lastCPLAction == $time)
-			return;
+		if($this->lastCPLAction == $time) {
+					return;
+		}
 		$this->lastCPLAction=$time;
 		$this->hasChanged=true;
 	}
@@ -1017,8 +1085,9 @@ 
 			//Get Player missions
 			$this->db->query('SELECT mission_id FROM player_completed_mission WHERE ' . $this->SQL);
 			$this->completedMissions = array();
-			while ($this->db->nextRecord())
-				$this->completedMissions[$this->db->getField('mission_id')] = $this->db->getField('mission_id');
+			while ($this->db->nextRecord()) {
+							$this->completedMissions[$this->db->getField('mission_id')] = $this->db->getField('mission_id');
+			}
 		}
 		return $this->completedMissions;
 	}
@@ -1055,8 +1124,9 @@ 
 
 	function getMission($missionID) {
 		$missions = $this->getMissions();
-		if(isset($missions[$missionID]))
-			return $missions[$missionID];
+		if(isset($missions[$missionID])) {
+					return $missions[$missionID];
+		}
 		return false;
 	}
 
@@ -1102,8 +1172,9 @@ 
 	function addMission($missionID) {
 		$this->getMissions();
 
-		if(isset($this->missions[$missionID]))
-			return;
+		if(isset($this->missions[$missionID])) {
+					return;
+		}
 		$sector = 0;
 
 		$mission = array(
@@ -1132,8 +1203,7 @@ 
 		if ($mission['On Step'] >= count(MISSIONS[$missionID]['Steps'])) {
 			// If we have completed this mission just use false to indicate no current task.
 			$currentStep = false;
-		}
-		else {
+		} else {
 			$currentStep = MISSIONS[$missionID]['Steps'][$mission['On Step']];
 			$currentStep['Text'] = str_replace(array('<Race>','<Sector>','<Starting Sector>','<trader>'),array($this->getRaceID(),$mission['Sector'],$mission['Starting Sector'],$this->playerName),$currentStep['Text']);
 			if (isset($currentStep['Task'])) {
@@ -1141,8 +1211,7 @@ 
 			}
 			if (isset($currentStep['Level'])) {
 				$currentStep['Level'] = str_replace('<Player Level>', $this->getLevelID(), $currentStep['Level']);
-			}
-			else {
+			} else {
 				$currentStep['Level'] = 0;
 			}
 		}
@@ -1270,12 +1339,15 @@ 
 	}
 
 	public function canSee(AbstractSmrPlayer $otherPlayer) {
-		if(!$otherPlayer->getShip()->isCloaked())
-			return true;
-		if($this->sameAlliance($otherPlayer))
-			return true;
-		if($this->getExperience()>=$otherPlayer->getExperience())
-			return true;
+		if(!$otherPlayer->getShip()->isCloaked()) {
+					return true;
+		}
+		if($this->sameAlliance($otherPlayer)) {
+					return true;
+		}
+		if($this->getExperience()>=$otherPlayer->getExperience()) {
+					return true;
+		}
 		return false;
 	}
 
@@ -1328,10 +1400,12 @@ 
 	}
 
 	public function meetsAlignmentRestriction($restriction) {
-		if($restriction<0)
-			return $this->getAlignment()<=$restriction;
-		if($restriction>0)
-			return $this->getAlignment()>=$restriction;
+		if($restriction<0) {
+					return $this->getAlignment()<=$restriction;
+		}
+		if($restriction>0) {
+					return $this->getAlignment()>=$restriction;
+		}
 		return true;
 	}
 
@@ -1354,8 +1428,9 @@ 
 		if(!isset($this->visitedSectors)) {
 			$this->visitedSectors = array();
 			$this->db->query('SELECT sector_id FROM player_visited_sector WHERE ' . $this->SQL);
-			while($this->db->nextRecord())
-				$this->visitedSectors[$this->db->getField('sector_id')] = false;
+			while($this->db->nextRecord()) {
+							$this->visitedSectors[$this->db->getField('sector_id')] = false;
+			}
 		}
 		return !isset($this->visitedSectors[$sectorID]);
 	}

lib/Default/SmrPlanet.class.inc

Spacing +166 added lines, -166 removed lines

@@ -36,7 +36,7 @@ 
 	protected $typeInfo;
 	
 	protected $hasChanged = false;
-	protected $hasChangedFinancial = false;  // for credits, bond, maturity
+	protected $hasChangedFinancial = false; // for credits, bond, maturity
 	protected $hasChangedStockpile = false;
 	protected $hasChangedWeapons = array();
 	protected $hasChangedBuildings = array();
@@ -48,9 +48,9 @@ 
 	protected $delayedArmourDelta = 0;
 
 	public static function refreshCache() {
-		foreach(self::$CACHE_PLANETS as $gameID => &$gamePlanets) {
-			foreach($gamePlanets as $sectorID => &$planet) {
-				$planet = self::getPlanet($gameID,$sectorID,true);
+		foreach (self::$CACHE_PLANETS as $gameID => &$gamePlanets) {
+			foreach ($gamePlanets as $sectorID => &$planet) {
+				$planet = self::getPlanet($gameID, $sectorID, true);
 			}
 		}
 	}
@@ -60,22 +60,22 @@ 
 	}
 
 	public static function savePlanets() {
-		foreach(self::$CACHE_PLANETS as $gamePlanets) {
-			foreach($gamePlanets as $planet) {
+		foreach (self::$CACHE_PLANETS as $gamePlanets) {
+			foreach ($gamePlanets as $planet) {
 				$planet->update();
 			}
 		}
 	}
 
-	public static function &getPlanet($gameID, $sectorID, $forceUpdate=false, $db=null) {
-		if($forceUpdate || !isset(self::$CACHE_PLANETS[$gameID][$sectorID])) {
+	public static function &getPlanet($gameID, $sectorID, $forceUpdate = false, $db = null) {
+		if ($forceUpdate || !isset(self::$CACHE_PLANETS[$gameID][$sectorID])) {
 			self::$CACHE_PLANETS[$gameID][$sectorID] = new SmrPlanet($gameID, $sectorID, $db);
 		}
 		return self::$CACHE_PLANETS[$gameID][$sectorID];
 	}
 
-	public static function &createPlanet($gameID,$sectorID,$type=1) {
-		if(!self::getPlanet($gameID,$sectorID)->exists()) {
+	public static function &createPlanet($gameID, $sectorID, $type = 1) {
+		if (!self::getPlanet($gameID, $sectorID)->exists()) {
 			$minTime = max(SmrGame::getGame($gameID)->getStartDate(),
 			               SmrGame::getGame($gameID)->getStartTurnsDate());
 			$inhabitableTime = $minTime + pow(mt_rand(45, 85), 3);
@@ -85,10 +85,10 @@ 
 			$db->query('INSERT INTO planet (game_id, sector_id, inhabitable_time, planet_type_id)
 				VALUES (' . $db->escapeNumber($gameID) . ', ' . $db->escapeNumber($sectorID) . ', ' . $db->escapeNumber($inhabitableTime) . ', ' . $db->escapeNumber($type) . ')');
 		}
-		return self::getPlanet($gameID,$sectorID,true);
+		return self::getPlanet($gameID, $sectorID, true);
 	}
 
-	public static function removePlanet($gameID,$sectorID) {
+	public static function removePlanet($gameID, $sectorID) {
 		$db = new SmrMySqlDatabase();
 		$SQL = 'game_id = ' . $db->escapeNumber($gameID) . ' AND sector_id = ' . $db->escapeNumber($sectorID);
 		$db->query('DELETE FROM planet WHERE ' . $SQL);
@@ -102,7 +102,7 @@ 
 		unset(self::$CACHE_PLANETS[$gameID][$sectorID]);
 	}
 
-	protected function __construct($gameID, $sectorID, $db=null) {
+	protected function __construct($gameID, $sectorID, $db = null) {
 		$this->db = new SmrMySqlDatabase();
 		$this->SQL = 'game_id = ' . $this->db->escapeNumber($gameID) . ' AND sector_id = ' . $this->db->escapeNumber($sectorID);
 
@@ -115,8 +115,8 @@ 
 		}
 
 		if ($planetExists) {
-			$this->gameID = (int) $gameID;
-			$this->sectorID = (int) $sectorID;
+			$this->gameID = (int)$gameID;
+			$this->sectorID = (int)$sectorID;
 			$this->planetName = stripslashes($db->getField('planet_name'));
 			$this->ownerID = $db->getInt('owner_id');
 			$this->password = $db->getField('password');
@@ -167,7 +167,7 @@ 
 			// calc the interest for the time
 			$interest = $this->getBonds() * $this->getInterestRate();
 
-			if($partial === true && $this->getMaturity() > TIME) {
+			if ($partial === true && $this->getMaturity() > TIME) {
 				// Adjust interest based upon how much of the bond duration has passed.
 				$interest -= ($interest / $this->getBondTime()) * ($this->getMaturity() - TIME);
 			}
@@ -209,7 +209,7 @@ 
 	}
 
 	public function &getGalaxy() {
-		return SmrGalaxy::getGalaxyContaining($this->getGameID(),$this->getSectorID());
+		return SmrGalaxy::getGalaxyContaining($this->getGameID(), $this->getSectorID());
 	}
 
 	public function getOwnerID() {
@@ -217,19 +217,19 @@ 
 	}
 
 	public function hasOwner() {
-		return $this->ownerID!=0;
+		return $this->ownerID != 0;
 	}
 
 	public function setOwnerID($claimerID) {
-		if($this->ownerID==$claimerID) {
+		if ($this->ownerID == $claimerID) {
 			return;
 		}
-		$this->ownerID=$claimerID;
+		$this->ownerID = $claimerID;
 		$this->hasChanged = true;
 	}
 
 	public function &getOwner() {
-		return SmrPlayer::getPlayer($this->getOwnerID(),$this->getGameID());
+		return SmrPlayer::getPlayer($this->getOwnerID(), $this->getGameID());
 	}
 
 	public function getPassword() {
@@ -237,10 +237,10 @@ 
 	}
 
 	public function setPassword($password) {
-		if($this->password==$password) {
+		if ($this->password == $password) {
 			return;
 		}
-		$this->password=$password;
+		$this->password = $password;
 		$this->hasChanged = true;
 	}
 
@@ -253,10 +253,10 @@ 
 	}
 
 	public function setCredits($num) {
-		if($this->credits==$num) {
+		if ($this->credits == $num) {
 			return;
 		}
-		if($num < 0) {
+		if ($num < 0) {
 			throw new Exception('You cannot set negative credits.');
 		}
 		$this->credits = $num;
@@ -264,14 +264,14 @@ 
 	}
 
 	public function increaseCredits($num) {
-		if($num == 0) {
+		if ($num == 0) {
 			return;
 		}
 		$this->setCredits($this->getCredits() + $num);
 	}
 
 	public function decreaseCredits($num) {
-		if($num == 0) {
+		if ($num == 0) {
 			return;
 		}
 		$this->setCredits($this->getCredits() - $num);
@@ -282,10 +282,10 @@ 
 	}
 
 	public function setMaturity($num) {
-		if($this->maturity==$num) {
+		if ($this->maturity == $num) {
 			return;
 		}
-		if($num < 0) {
+		if ($num < 0) {
 			throw new Exception('You cannot set negative maturity.');
 		}
 		$this->maturity = $num;
@@ -297,10 +297,10 @@ 
 	}
 
 	public function setBonds($num) {
-		if($this->bonds==$num) {
+		if ($this->bonds == $num) {
 			return;
 		}
-		if($num < 0) {
+		if ($num < 0) {
 			throw new Exception('You cannot set negative bonds.');
 		}
 		$this->bonds = $num;
@@ -308,14 +308,14 @@ 
 	}
 	
 	public function increaseBonds($num) {
-		if($num == 0) {
+		if ($num == 0) {
 			return;
 		}
 		$this->setBonds($this->getBonds() + $num);
 	}
 
 	public function decreaseBonds($num) {
-		if($num == 0) {
+		if ($num == 0) {
 			return;
 		}
 		$this->setBonds($this->getBonds() - $num);
@@ -344,27 +344,27 @@ 
 	}
 
 	public function getShields($delayed = false) {
-		return $this->shields + ($delayed?$this->delayedShieldsDelta:0);
+		return $this->shields + ($delayed ? $this->delayedShieldsDelta : 0);
 	}
 
 	public function hasShields($delayed = false) {
-		return $this->getShields($delayed)>0;
+		return $this->getShields($delayed) > 0;
 	}
 
 	public function setShields($shields) {
 		$shields = max(0, min($shields, $this->getMaxShields()));
-		if($this->shields == $shields) {
+		if ($this->shields == $shields) {
 			return;
 		}
-		$this->shields=$shields;
+		$this->shields = $shields;
 		$this->hasChanged = true;
 	}
 
 	public function decreaseShields($number, $delayed = false) {
-		if($number == 0) {
+		if ($number == 0) {
 			return;
 		}
-		if($delayed===false) {
+		if ($delayed === false) {
 			$this->setShields($this->getShields() - $number);
 		}
 		else {
@@ -373,10 +373,10 @@ 
 	}
 
 	public function increaseShields($number, $delayed = false) {
-		if($number == 0) {
+		if ($number == 0) {
 			return;
 		}
-		if($delayed===false) {
+		if ($delayed === false) {
 			$this->setShields($this->getShields() + $number);
 		}
 		else {
@@ -389,16 +389,16 @@ 
 	}
 
 	public function getArmour($delayed = false) {
-		return $this->armour + ($delayed?$this->delayedArmourDelta:0);
+		return $this->armour + ($delayed ? $this->delayedArmourDelta : 0);
 	}
 
 	public function hasArmour($delayed = false) {
-		return $this->getArmour($delayed)>0;
+		return $this->getArmour($delayed) > 0;
 	}
 
 	public function setArmour($armour) {
 		$armour = max(0, min($armour, $this->getMaxArmour()));
-		if($this->armour == $armour) {
+		if ($this->armour == $armour) {
 			return;
 		}
 		$this->armour = $armour;
@@ -406,10 +406,10 @@ 
 	}
 
 	public function decreaseArmour($number, $delayed = false) {
-		if($number == 0) {
+		if ($number == 0) {
 			return;
 		}
-		if($delayed===false) {
+		if ($delayed === false) {
 			$this->setArmour($this->getArmour() - $number);
 		}
 		else {
@@ -418,10 +418,10 @@ 
 	}
 
 	public function increaseArmour($number, $delayed = false) {
-		if($number == 0) {
+		if ($number == 0) {
 			return;
 		}
-		if($delayed===false) {
+		if ($delayed === false) {
 			$this->setArmour($this->getArmour() + $number);
 		}
 		else {
@@ -434,27 +434,27 @@ 
 	}
 
 	public function getCDs($delayed = false) {
-		return $this->drones + ($delayed?$this->delayedCDsDelta:0);
+		return $this->drones + ($delayed ? $this->delayedCDsDelta : 0);
 	}
 
 	public function hasCDs($delayed = false) {
-		return $this->getCDs($delayed)>0;
+		return $this->getCDs($delayed) > 0;
 	}
 
 	public function setCDs($combatDrones) {
 		$combatDrones = max(0, min($combatDrones, $this->getMaxCDs()));
-		if($this->drones == $combatDrones) {
+		if ($this->drones == $combatDrones) {
 			return;
 		}
-		$this->drones=$combatDrones;
+		$this->drones = $combatDrones;
 		$this->hasChanged = true;
 	}
 
 	public function decreaseCDs($number, $delayed = false) {
-		if($number == 0) {
+		if ($number == 0) {
 			return;
 		}
-		if($delayed===false) {
+		if ($delayed === false) {
 			$this->setCDs($this->getCDs() - $number);
 		}
 		else {
@@ -463,10 +463,10 @@ 
 	}
 
 	public function increaseCDs($number, $delayed = false) {
-		if($number == 0) {
+		if ($number == 0) {
 			return;
 		}
-		if($delayed===false) {
+		if ($delayed === false) {
 			$this->setCDs($this->getCDs() + $number);
 		}
 		else {
@@ -514,13 +514,13 @@ 
 		if ($orderID == 0) {
 			throw new Exception('Cannot move this weapon up!');
 		}
-		if (isset($this->mountedWeapons[$orderID-1])) {
-			$previousWeapon = $this->mountedWeapons[$orderID-1];
+		if (isset($this->mountedWeapons[$orderID - 1])) {
+			$previousWeapon = $this->mountedWeapons[$orderID - 1];
 		}
 		if (isset($this->mountedWeapons[$orderID])) {
-			$this->mountedWeapons[$orderID-1] = $this->mountedWeapons[$orderID];
+			$this->mountedWeapons[$orderID - 1] = $this->mountedWeapons[$orderID];
 		} else {
-			unset($this->mountedWeapons[$orderID-1]);
+			unset($this->mountedWeapons[$orderID - 1]);
 		}
 		if (isset($previousWeapon)) {
 			$this->mountedWeapons[$orderID] = $previousWeapon;
@@ -528,21 +528,21 @@ 
 			unset($this->mountedWeapons[$orderID]);
 		}
 		$this->hasChangedWeapons[$orderID] = true;
-		$this->hasChangedWeapons[$orderID-1] = true;
+		$this->hasChangedWeapons[$orderID - 1] = true;
 	}
 
 	public function moveMountedWeaponDown($orderID) {
 		$this->getMountedWeapons(); // Make sure array is initialized
-		if ($orderID == $this->getMaxMountedWeapons()-1) {
+		if ($orderID == $this->getMaxMountedWeapons() - 1) {
 			throw new Exception('Cannot move this weapon down!');
 		}
-		if (isset($this->mountedWeapons[$orderID+1])) {
-			$nextWeapon = $this->mountedWeapons[$orderID+1];
+		if (isset($this->mountedWeapons[$orderID + 1])) {
+			$nextWeapon = $this->mountedWeapons[$orderID + 1];
 		}
 		if (isset($this->mountedWeapons[$orderID])) {
-			$this->mountedWeapons[$orderID+1] = $this->mountedWeapons[$orderID];
+			$this->mountedWeapons[$orderID + 1] = $this->mountedWeapons[$orderID];
 		} else {
-			unset($this->mountedWeapons[$orderID+1]);
+			unset($this->mountedWeapons[$orderID + 1]);
 		}
 		if (isset($nextWeapon)) {
 			$this->mountedWeapons[$orderID] = $nextWeapon;
@@ -550,7 +550,7 @@ 
 			unset($this->mountedWeapons[$orderID]);
 		}
 		$this->hasChangedWeapons[$orderID] = true;
-		$this->hasChangedWeapons[$orderID+1] = true;
+		$this->hasChangedWeapons[$orderID + 1] = true;
 	}
 
 
@@ -559,11 +559,11 @@ 
 	}
 
 	public function exists() {
-		return $this->getGameID()!=null && $this->getSectorID()!==null;
+		return $this->getGameID() != null && $this->getSectorID() !== null;
 	}
 
-	public function getStockpile($goodID=false) {
-		if(!isset($this->stockpile)) {
+	public function getStockpile($goodID = false) {
+		if (!isset($this->stockpile)) {
 			// initialize cargo array
 			$this->stockpile = array();
 			// get supplies from db
@@ -572,15 +572,15 @@ 
 			while ($this->db->nextRecord())
 				$this->stockpile[$this->db->getInt('good_id')] = $this->db->getInt('amount');
 		}
-		if($goodID===false)
+		if ($goodID === false)
 			return $this->stockpile;
-		if(isset($this->stockpile[$goodID]))
+		if (isset($this->stockpile[$goodID]))
 			return $this->stockpile[$goodID];
 		return 0;
 	}
 
-	public function hasStockpile($goodID=false) {
-		if($goodID===false) {
+	public function hasStockpile($goodID = false) {
+		if ($goodID === false) {
 			$stockpile = $this->getStockpile($goodID);
 			return count($stockpile) > 0 && max($stockpile) > 0;
 		}
@@ -589,31 +589,31 @@ 
 		}
 	}
 
-	public function setStockpile($goodID,$amount) {
-		if($amount < 0) {
+	public function setStockpile($goodID, $amount) {
+		if ($amount < 0) {
 			throw new Exception('Trying to set negative stockpile.');
 		}
-		if($this->getStockpile($goodID) == $amount) {
+		if ($this->getStockpile($goodID) == $amount) {
 			return;
 		}
 		$this->stockpile[$goodID] = $amount;
 		$this->hasChangedStockpile = true;
 	}
 
-	public function decreaseStockpile($goodID,$amount) {
-		if($amount < 0)
+	public function decreaseStockpile($goodID, $amount) {
+		if ($amount < 0)
 			throw new Exception('Trying to decrease negative stockpile.');
-		$this->setStockpile($goodID,$this->getStockpile($goodID) - $amount);
+		$this->setStockpile($goodID, $this->getStockpile($goodID) - $amount);
 	}
 
-	public function increaseStockpile($goodID,$amount) {
-		if($amount < 0)
+	public function increaseStockpile($goodID, $amount) {
+		if ($amount < 0)
 			throw new Exception('Trying to increase negative stockpile.');
-		$this->setStockpile($goodID,$this->getStockpile($goodID) + $amount);
+		$this->setStockpile($goodID, $this->getStockpile($goodID) + $amount);
 	}
 
 	public function getBuildings() {
-		if(!isset($this->buildings)) {
+		if (!isset($this->buildings)) {
 			$this->buildings = array();
 
 			// get buildingss from db
@@ -631,41 +631,41 @@ 
 
 	public function getBuilding($buildingTypeID) {
 		$buildings = $this->getBuildings();
-		if(isset($buildings[$buildingTypeID])) {
+		if (isset($buildings[$buildingTypeID])) {
 			return $buildings[$buildingTypeID];
 		}
 		return 0;
 	}
 
 	public function hasBuilding($buildingTypeID) {
-		return $this->getBuilding($buildingTypeID)>0;
+		return $this->getBuilding($buildingTypeID) > 0;
 	}
 
-	public function setBuilding($buildingTypeID,$number) {
-		if($this->getBuilding($buildingTypeID) == $number)
+	public function setBuilding($buildingTypeID, $number) {
+		if ($this->getBuilding($buildingTypeID) == $number)
 			return;
 
 		$this->buildings[$buildingTypeID] = $number;
 		$this->hasChangedBuildings[$buildingTypeID] = true;
 	}
 
-	public function increaseBuilding($buildingTypeID,$number) {
-		$this->setBuilding($buildingTypeID,$this->getBuilding($buildingTypeID)+$number);
+	public function increaseBuilding($buildingTypeID, $number) {
+		$this->setBuilding($buildingTypeID, $this->getBuilding($buildingTypeID) + $number);
 	}
 
-	public function destroyBuilding($buildingTypeID,$number) {
-		if(!$this->hasBuilding($buildingTypeID)) {
+	public function destroyBuilding($buildingTypeID, $number) {
+		if (!$this->hasBuilding($buildingTypeID)) {
 			throw new Exception('Trying to destroy a nonexistent building');
 		}
-		$this->setBuilding($buildingTypeID,$this->getBuilding($buildingTypeID)-$number);
+		$this->setBuilding($buildingTypeID, $this->getBuilding($buildingTypeID) - $number);
 	}
 
 	function getCurrentlyBuilding() {
-		if(!isset($this->currentlyBuilding)) {
+		if (!isset($this->currentlyBuilding)) {
 			$this->currentlyBuilding = array();
 
 			$this->db->query('SELECT * FROM planet_is_building WHERE ' . $this->SQL);
-			while($this->db->nextRecord()) {
+			while ($this->db->nextRecord()) {
 				$this->currentlyBuilding[$this->db->getInt('building_slot_id')] = array(
 					'BuildingSlotID' => $this->db->getInt('building_slot_id'),
 					'ConstructionID' => $this->db->getInt('construction_id'),
@@ -681,9 +681,9 @@ 
 					unset($this->currentlyBuilding[$id]);
 					$expGain = $this->getConstructionExp($building['ConstructionID']);
 					$player = SmrPlayer::getPlayer($building['ConstructorID'], $this->getGameID());
-					$player->increaseHOF(1, array('Planet','Buildings','Built'), HOF_ALLIANCE);
+					$player->increaseHOF(1, array('Planet', 'Buildings', 'Built'), HOF_ALLIANCE);
 					$player->increaseExperience($expGain);
-					$player->increaseHOF($expGain, array('Planet','Buildings','Experience'), HOF_ALLIANCE);
+					$player->increaseHOF($expGain, array('Planet', 'Buildings', 'Experience'), HOF_ALLIANCE);
 					$this->hasStoppedBuilding[] = $building['BuildingSlotID'];
 					$this->increaseBuilding($building['ConstructionID'], 1);
 
@@ -700,8 +700,8 @@ 
 		return $this->currentlyBuilding;
 	}
 
-	public function getMaxBuildings($buildingTypeID=false) {
-		if($buildingTypeID===false) {
+	public function getMaxBuildings($buildingTypeID = false) {
+		if ($buildingTypeID === false) {
 			$structs = $this->typeInfo::STRUCTURES;
 			return array_combine(array_keys($structs),
 			                     array_column($structs, 'max_amount'));
@@ -718,13 +718,13 @@ 
 			return;
 		}
 		$this->typeID = $num;
-		$this->db->query('UPDATE planet SET planet_type_id = '.$this->db->escapeNumber($num).' WHERE '.$this->SQL);
+		$this->db->query('UPDATE planet SET planet_type_id = ' . $this->db->escapeNumber($num) . ' WHERE ' . $this->SQL);
 		$this->typeInfo = SmrPlanetType::getTypeInfo($this->getTypeID());
 		
 		//trim buildings first
 		foreach ($this->getBuildings() as $id => $amt) {
 			if ($this->getMaxBuildings($id) < $amt) {
-				$this->destroyBuilding($id,$amt - $this->getMaxBuildings($id));
+				$this->destroyBuilding($id, $amt - $this->getMaxBuildings($id));
 			}
 		}
 		
@@ -755,7 +755,7 @@ 
 		return $this->typeInfo->maxLanded();
 	}
 
-	public function getStructureTypes($structureID=false) {
+	public function getStructureTypes($structureID = false) {
 		return $this->typeInfo->structureTypes($structureID);
 	}
 
@@ -781,14 +781,14 @@ 
 	}
 	
 	public function update() {
-		if(!$this->exists()) {
+		if (!$this->exists()) {
 			return;
 		}
 		$this->doDelayedUpdates();
-		if($this->hasChanged) {
+		if ($this->hasChanged) {
 			$this->db->query('UPDATE planet SET
 									owner_id = ' . $this->db->escapeNumber($this->ownerID) . ',
-									password = '.$this->db->escapeString($this->password) .',
+									password = '.$this->db->escapeString($this->password) . ',
 									planet_name = ' . $this->db->escapeString($this->planetName) . ',
 									shields = ' . $this->db->escapeNumber($this->shields) . ',
 									armour = ' . $this->db->escapeNumber($this->armour) . ',
@@ -809,7 +809,7 @@ 
 			$this->hasChangedFinancial = false;
 		}
 
-		if($this->hasChangedStockpile) {
+		if ($this->hasChangedStockpile) {
 			// write stockpile info
 			foreach ($this->getStockpile() as $id => $amount) {
 				if ($amount != 0) {
@@ -826,21 +826,21 @@ 
 		if ($this->hasChangedWeapons) {
 			foreach (array_keys($this->hasChangedWeapons) as $orderID) {
 				if (isset($this->mountedWeapons[$orderID])) {
-					$this->db->query('REPLACE INTO planet_has_weapon (game_id, sector_id, order_id, weapon_type_id) VALUES ('.$this->db->escapeNumber($this->getGameID()).','.$this->db->escapeNumber($this->getSectorID()).','.$this->db->escapeNumber($orderID).','.$this->db->escapeNumber($this->mountedWeapons[$orderID]->getWeaponTypeID()).')');
+					$this->db->query('REPLACE INTO planet_has_weapon (game_id, sector_id, order_id, weapon_type_id) VALUES (' . $this->db->escapeNumber($this->getGameID()) . ',' . $this->db->escapeNumber($this->getSectorID()) . ',' . $this->db->escapeNumber($orderID) . ',' . $this->db->escapeNumber($this->mountedWeapons[$orderID]->getWeaponTypeID()) . ')');
 				} else {
-					$this->db->query('DELETE FROM planet_has_weapon WHERE '.$this->SQL.' AND order_id='.$this->db->escapeNumber($orderID));
+					$this->db->query('DELETE FROM planet_has_weapon WHERE ' . $this->SQL . ' AND order_id=' . $this->db->escapeNumber($orderID));
 				}
 			}
 		}
 
-		if(count($this->hasStoppedBuilding)>0) {
+		if (count($this->hasStoppedBuilding) > 0) {
 			$this->db->query('DELETE FROM planet_is_building WHERE ' . $this->SQL . '
 								AND building_slot_id IN (' . $this->db->escapeArray($this->hasStoppedBuilding) . ') LIMIT ' . count($this->hasStoppedBuilding));
 			$this->hasStoppedBuilding = array();
 		}
 		// write building info
 		foreach ($this->hasChangedBuildings as $id => $hasChanged) {
-			if($hasChanged===true) {
+			if ($hasChanged === true) {
 				if ($this->hasBuilding($id)) {
 					$this->db->query('REPLACE INTO planet_has_building (game_id, sector_id, construction_id, amount) ' .
 										'VALUES(' . $this->db->escapeNumber($this->gameID) . ', ' . $this->db->escapeNumber($this->sectorID) . ', ' . $this->db->escapeNumber($id) . ', ' . $this->db->escapeNumber($this->getBuilding($id)) . ')');
@@ -855,15 +855,15 @@ 
 	}
 
 	function getLevel() {
-		return array_sum($this->getBuildings())/3;
+		return array_sum($this->getBuildings()) / 3;
 	}
 	
 	function getMaxLevel() {
-		return array_sum($this->getMaxBuildings())/3;
+		return array_sum($this->getMaxBuildings()) / 3;
 	}
 
 	function accuracy() {
-		if($this->hasWeapons()) {
+		if ($this->hasWeapons()) {
 			$weapons = $this->getWeapons();
 			return $weapons[0]->getModifiedPlanetAccuracy($this);
 		}
@@ -889,10 +889,10 @@ 
 	}
 
 	function canBuild(AbstractSmrPlayer $constructor, $constructionID) {
-		if($this->hasCurrentlyBuilding()) {
+		if ($this->hasCurrentlyBuilding()) {
 			return 'There is already a building in progress!';
 		}
-		if($this->getBuilding($constructionID) >= $this->getMaxBuildings($constructionID)) {
+		if ($this->getBuilding($constructionID) >= $this->getMaxBuildings($constructionID)) {
 			return 'This planet has reached the maximum buildings of that type.';
 		}
 		$cost = $this->getStructureTypes($constructionID)->creditCost();
@@ -918,7 +918,7 @@ 
 	private function getCompletionModifier($constructionID) {
 		$currentBuildings = $this->getBuilding($constructionID);
 		$maxBuildings = $this->getMaxBuildings($constructionID);
-		return 0.01 + 2.97 * pow($currentBuildings/$maxBuildings, 2);
+		return 0.01 + 2.97 * pow($currentBuildings / $maxBuildings, 2);
 	}
 
 	// Amount of exp gained to build the next building of this type
@@ -935,13 +935,13 @@ 
 	}
 	
 	function startBuilding(AbstractSmrPlayer $constructor, $constructionID) {
-		if(($message = $this->canBuild($constructor, $constructionID)) !== true) {
-			throw new Exception('Unable to start building: '.$message);
+		if (($message = $this->canBuild($constructor, $constructionID)) !== true) {
+			throw new Exception('Unable to start building: ' . $message);
 		}
 		$constructor->decreaseCredits($this->getStructureTypes($constructionID)->creditCost());
 		// take the goods that are needed
 		foreach ($this->getStructureTypes($constructionID)->goods() as $goodID => $amount) {
-			$this->decreaseStockpile($goodID,$amount);
+			$this->decreaseStockpile($goodID, $amount);
 		}
 		foreach ($this->getStructureTypes($constructionID)->hardwareCost() as $hardwareID) {
 			$constructor->getShip()->setHardware($hardwareID, 0);
@@ -964,13 +964,13 @@ 
 	function stopBuilding($constructionID) {
 		$matchingBuilding = false;
 		$latestFinish = 0;
-		foreach($this->getCurrentlyBuilding() as $key => $building) {
-			if($building['ConstructionID'] == $constructionID && $building['Finishes'] > $latestFinish) {
+		foreach ($this->getCurrentlyBuilding() as $key => $building) {
+			if ($building['ConstructionID'] == $constructionID && $building['Finishes'] > $latestFinish) {
 				$latestFinish = $building['Finishes'];
 				$matchingBuilding = $building;
 			}
 		}
-		if($matchingBuilding) {
+		if ($matchingBuilding) {
 			$this->hasStoppedBuilding[] = $matchingBuilding['BuildingSlotID'];
 			unset($this->currentlyBuilding[$matchingBuilding['BuildingSlotID']]);
 			return true;
@@ -983,7 +983,7 @@ 
 	}
 
 	public function setName($name) {
-		if($this->planetName == $name) {
+		if ($this->planetName == $name) {
 			return;
 		}
 		$this->planetName = $name;
@@ -991,15 +991,15 @@ 
 	}
 
 	public function getDisplayName() {
-		return '<span style="color:yellow;font-variant:small-caps">' . $this->getName() . '(#'.$this->getSectorID().')</span>';;
+		return '<span style="color:yellow;font-variant:small-caps">' . $this->getName() . '(#' . $this->getSectorID() . ')</span>'; ;
 	}
 
 	public function isInhabitable() {
-		return $this->inhabitableTime<= TIME;
+		return $this->inhabitableTime <= TIME;
 	}
 
 	public function isClaimed() {
-		return $this->ownerID>0;
+		return $this->ownerID > 0;
 	}
 
 	public function removeClaimed() {
@@ -1041,9 +1041,9 @@ 
 	}
 
 	public function attackedBy(AbstractSmrPlayer $trigger, array $attackers) {
-		$trigger->increaseHOF(1,array('Combat','Planet','Number Of Triggers'), HOF_PUBLIC);
+		$trigger->increaseHOF(1, array('Combat', 'Planet', 'Number Of Triggers'), HOF_PUBLIC);
 		foreach ($attackers as $attacker) {
-			$attacker->increaseHOF(1,array('Combat','Planet','Number Of Attacks'), HOF_PUBLIC);
+			$attacker->increaseHOF(1, array('Combat', 'Planet', 'Number Of Attacks'), HOF_PUBLIC);
 			$this->db->query('REPLACE INTO player_attacks_planet (game_id, account_id, sector_id, time, level) VALUES ' .
 					'(' . $this->db->escapeNumber($this->getGameID()) . ', ' . $this->db->escapeNumber($attacker->getAccountID()) . ', ' . $this->db->escapeNumber($this->getSectorID()) . ', ' . $this->db->escapeNumber(TIME) . ', ' . $this->db->escapeNumber($this->getLevel()) . ')');
 		}
@@ -1052,9 +1052,9 @@ 
 		// Note: Attack uniqueness determined by planet owner.
 		$owner = $this->getOwner();
 		$this->db->query('SELECT 1 FROM news WHERE type = \'BREAKING\' AND game_id = ' . $this->db->escapeNumber($trigger->getGameID()) . ' AND dead_id=' . $this->db->escapeNumber($owner->getAccountID()) . ' AND time > ' . $this->db->escapeNumber(TIME - self::TIME_ATTACK_NEWS_COOLDOWN) . ' LIMIT 1');
-		if ($this->db->getNumRows()==0) {
+		if ($this->db->getNumRows() == 0) {
 			if (count($attackers) >= 5) {
-				$text = count($attackers) . ' members of '.$trigger->getAllianceBBLink().' have been spotted attacking ' .
+				$text = count($attackers) . ' members of ' . $trigger->getAllianceBBLink() . ' have been spotted attacking ' .
 					$this->getDisplayName() . ' in sector ' . Globals::getSectorBBLink($this->getSectorID()) . '. The planet is owned by ' . $owner->getBBLink();
 				if ($owner->hasAlliance()) {
 					$text .= ', a member of ' . $owner->getAllianceBBLink();
@@ -1068,7 +1068,7 @@ 
 	
 	
 	public function &getPlayers() {
-		return SmrPlayer::getPlanetPlayers($this->getGameID(),$this->getSectorID());
+		return SmrPlayer::getPlanetPlayers($this->getGameID(), $this->getSectorID());
 	}
 
 	public function countPlayers() {
@@ -1080,7 +1080,7 @@ 
 	}
 
 	public function &getOtherTraders(AbstractSmrPlayer $player) {
-		$players = SmrPlayer::getPlanetPlayers($this->getGameID(),$this->getSectorID()); //Do not use & because we unset something and only want that in what we return
+		$players = SmrPlayer::getPlanetPlayers($this->getGameID(), $this->getSectorID()); //Do not use & because we unset something and only want that in what we return
 		unset($players[$player->getAccountID()]);
 		return $players;
 	}
@@ -1090,22 +1090,22 @@ 
 	}
 
 	public function hasEnemyTraders(AbstractSmrPlayer $player) {
-		if(!$this->hasOtherTraders($player))
+		if (!$this->hasOtherTraders($player))
 			return false;
 		$otherPlayers = $this->getOtherTraders($player);
-		foreach($otherPlayers as $otherPlayer) {
-			if(!$player->traderNAPAlliance($otherPlayer))
+		foreach ($otherPlayers as $otherPlayer) {
+			if (!$player->traderNAPAlliance($otherPlayer))
 				return true;
 		}
 		return false;
 	}
 
 	public function hasFriendlyTraders(AbstractSmrPlayer $player) {
-		if(!$this->hasOtherTraders($player))
+		if (!$this->hasOtherTraders($player))
 			return false;
 		$otherPlayers = $this->getOtherTraders($player);
-		foreach($otherPlayers as $otherPlayer) {
-			if($player->traderNAPAlliance($otherPlayer))
+		foreach ($otherPlayers as $otherPlayer) {
+			if ($player->traderNAPAlliance($otherPlayer))
 				return true;
 		}
 		return false;
@@ -1113,14 +1113,14 @@ 
 
 	public function &getWeapons() {
 		$weapons = $this->getMountedWeapons();
-		for($i=0; $i<$this->getBuilding(PLANET_TURRET); ++$i) {
+		for ($i = 0; $i < $this->getBuilding(PLANET_TURRET); ++$i) {
 			$weapons[] = SmrWeapon::getWeapon(WEAPON_PLANET_TURRET);
 		}
 		return $weapons;
 	}
 
 	public function hasWeapons() {
-		return count($this->getWeapons())>0;
+		return count($this->getWeapons()) > 0;
 	}
 
 	public function &shootPlayer(AbstractSmrPlayer $targetPlayer) {
@@ -1129,25 +1129,25 @@ 
 
 	public function &shootPlayers(array $targetPlayers) {
 		$results = array('Planet' => $this, 'TotalDamage' => 0, 'TotalDamagePerTargetPlayer' => array());
-		foreach($targetPlayers as $targetPlayer) {
+		foreach ($targetPlayers as $targetPlayer) {
 			$results['TotalDamagePerTargetPlayer'][$targetPlayer->getAccountID()] = 0;
 		}
-		if($this->isDestroyed()) {
+		if ($this->isDestroyed()) {
 			$results['DeadBeforeShot'] = true;
 			return $results;
 		}
 		$results['DeadBeforeShot'] = false;
 		$weapons = $this->getWeapons();
-		foreach($weapons as $orderID => $weapon) {
-			$results['Weapons'][$orderID] =& $weapon->shootPlayerAsPlanet($this, $targetPlayers[array_rand($targetPlayers)]);
-			if($results['Weapons'][$orderID]['Hit']) {
+		foreach ($weapons as $orderID => $weapon) {
+			$results['Weapons'][$orderID] = & $weapon->shootPlayerAsPlanet($this, $targetPlayers[array_rand($targetPlayers)]);
+			if ($results['Weapons'][$orderID]['Hit']) {
 				$results['TotalDamage'] += $results['Weapons'][$orderID]['ActualDamage']['TotalDamage'];
 				$results['TotalDamagePerTargetPlayer'][$results['Weapons'][$orderID]['TargetPlayer']->getAccountID()] += $results['Weapons'][$orderID]['ActualDamage']['TotalDamage'];
 			}
 		}
-		if($this->hasCDs()) {
-			$thisCDs = new SmrCombatDrones($this->getGameID(),$this->getCDs(),true);
-			$results['Drones'] =& $thisCDs->shootPlayerAsPlanet($this, $targetPlayers[array_rand($targetPlayers)]);
+		if ($this->hasCDs()) {
+			$thisCDs = new SmrCombatDrones($this->getGameID(), $this->getCDs(), true);
+			$results['Drones'] = & $thisCDs->shootPlayerAsPlanet($this, $targetPlayers[array_rand($targetPlayers)]);
 			$results['TotalDamage'] += $results['Drones']['ActualDamage']['TotalDamage'];
 			$results['TotalDamagePerTargetPlayer'][$results['Drones']['TargetPlayer']->getAccountID()] += $results['Drones']['ActualDamage']['TotalDamage'];
 		}
@@ -1159,7 +1159,7 @@ 
 		// For every 70 damage there is a 15% chance of destroying a structure.
 		// Which structure is destroyed depends on the ratio of buildings and
 		// the time it takes to build them.
-		for ($i = 0; $damage > self::DAMAGE_NEEDED_FOR_DOWNGRADE_CHANCE; $damage-=self::DAMAGE_NEEDED_FOR_DOWNGRADE_CHANCE) {
+		for ($i = 0; $damage > self::DAMAGE_NEEDED_FOR_DOWNGRADE_CHANCE; $damage -= self::DAMAGE_NEEDED_FOR_DOWNGRADE_CHANCE) {
 			// Stop if the planet has no more buildlings
 			if ($this->getLevel() == 0) {
 				break;
@@ -1173,7 +1173,7 @@ 
 				$destroyID = getWeightedRandom($chanceFactors);
 				$this->destroyBuilding($destroyID, 1);
 				$this->checkForExcessDefense();
-				$results .= 'This team destroys <span class="red">1</span> '.$this->getStructureTypes($destroyID)->name().'.<br />';
+				$results .= 'This team destroys <span class="red">1</span> ' . $this->getStructureTypes($destroyID)->name() . '.<br />';
 			}
 		}
 		return $results;
@@ -1184,20 +1184,20 @@ 
 		$shieldDamage = 0;
 		$cdDamage = 0;
 		$armourDamage = 0;
-		if(!$alreadyDead) {
-			if($damage['Shield'] || !$this->hasShields(true)) {
-				$shieldDamage = $this->doShieldDamage(min($damage['MaxDamage'],$damage['Shield']),$delayed);
+		if (!$alreadyDead) {
+			if ($damage['Shield'] || !$this->hasShields(true)) {
+				$shieldDamage = $this->doShieldDamage(min($damage['MaxDamage'], $damage['Shield']), $delayed);
 				$damage['Shield'] -= $shieldDamage;
 				$damage['MaxDamage'] -= $shieldDamage;
 
-				if(!$this->hasShields(true) && ($shieldDamage == 0 || $damage['Rollover'])) {
+				if (!$this->hasShields(true) && ($shieldDamage == 0 || $damage['Rollover'])) {
 					if ($this->hasCDs(true)) {
-						$cdDamage = $this->doCDDamage(min($damage['MaxDamage'],$damage['Armour']),$delayed);
+						$cdDamage = $this->doCDDamage(min($damage['MaxDamage'], $damage['Armour']), $delayed);
 						$damage['Armour'] -= $cdDamage;
 						$damage['MaxDamage'] -= $cdDamage;
 					}
 					if ($this->hasArmour(true) && ($cdDamage == 0 || $damage['Rollover'])) {
-						$armourDamage = $this->doArmourDamage(min($damage['MaxDamage'],$damage['Armour']),$delayed);
+						$armourDamage = $this->doArmourDamage(min($damage['MaxDamage'], $damage['Armour']), $delayed);
 						$damage['Armour'] -= $armourDamage;
 						$damage['MaxDamage'] -= $armourDamage;
 					}
@@ -1205,7 +1205,7 @@ 
 
 			}
 			else { // hit drones behind shields - we should only use this reduced damage branch if we cannot hit shields.
-				$cdDamage = $this->doCDDamage(floor(min($damage['MaxDamage'],$damage['Armour'])*DRONES_BEHIND_SHIELDS_DAMAGE_PERCENT),$delayed);
+				$cdDamage = $this->doCDDamage(floor(min($damage['MaxDamage'], $damage['Armour']) * DRONES_BEHIND_SHIELDS_DAMAGE_PERCENT), $delayed);
 			}
 		}
 
@@ -1217,27 +1217,27 @@ 
 			'HasShields' => $this->hasShields(true),
 			'HasArmour' => $this->hasArmour(true),
 			'CDs' => $cdDamage,
-			'NumCDs' => $cdDamage/CD_ARMOUR,
+			'NumCDs' => $cdDamage / CD_ARMOUR,
 			'HasCDs' => $this->hasCDs(true),
-			'TotalDamage' => $shieldDamage+$cdDamage+$armourDamage
+			'TotalDamage' => $shieldDamage + $cdDamage + $armourDamage
 		);
 		return $return;
 	}
 
 	protected function doShieldDamage($damage, $delayed) {
-		$actualDamage = min($this->getShields(true),$damage);
+		$actualDamage = min($this->getShields(true), $damage);
 		$this->decreaseShields($actualDamage, $delayed);
 		return $actualDamage;
 	}
 
 	protected function doCDDamage($damage, $delayed) {
-		$actualDamage = min($this->getCDs(true),floor($damage/CD_ARMOUR));
+		$actualDamage = min($this->getCDs(true), floor($damage / CD_ARMOUR));
 		$this->decreaseCDs($actualDamage, $delayed);
-		return $actualDamage*CD_ARMOUR;
+		return $actualDamage * CD_ARMOUR;
 	}
 	
 	protected function doArmourDamage($damage, $delayed) {
-		$actualDamage = min($this->getArmour(true),$damage);;
+		$actualDamage = min($this->getArmour(true), $damage); ;
 		$this->decreaseArmour($actualDamage, $delayed);
 		return $actualDamage;
 	}
@@ -1246,9 +1246,9 @@ 
 		//get all players involved for HoF
 		$this->db->query('SELECT account_id,level FROM player_attacks_planet WHERE ' . $this->SQL . ' AND time > ' . $this->db->escapeNumber(TIME - self::TIME_TO_CREDIT_BUST));
 		while ($this->db->nextRecord()) {
-			$currPlayer = SmrPlayer::getPlayer($this->db->getInt('account_id'),$this->getGameID());
-			$currPlayer->increaseHOF($this->db->getInt('level'),array('Combat','Planet','Levels'), HOF_PUBLIC);
-			$currPlayer->increaseHOF(1,array('Combat','Planet','Completed'), HOF_PUBLIC);
+			$currPlayer = SmrPlayer::getPlayer($this->db->getInt('account_id'), $this->getGameID());
+			$currPlayer->increaseHOF($this->db->getInt('level'), array('Combat', 'Planet', 'Levels'), HOF_PUBLIC);
+			$currPlayer->increaseHOF(1, array('Combat', 'Planet', 'Completed'), HOF_PUBLIC);
 		}
 		$this->db->query('DELETE FROM player_attacks_planet WHERE ' . $this->SQL);
 	}

lib/Default/SmrForce.class.inc

Spacing +113 added lines, -113 removed lines

@@ -20,19 +20,19 @@ 
 	protected $ownerID;
 	protected $sectorID;
 	protected $gameID;
-	protected $combatDrones=0;
-	protected $scoutDrones=0;
-	protected $mines=0;
-	protected $expire=0;
+	protected $combatDrones = 0;
+	protected $scoutDrones = 0;
+	protected $mines = 0;
+	protected $expire = 0;
 
 	protected $isNew;
 	protected $hasChanged = false;
 
 	public static function refreshCache() {
-		foreach(self::$CACHE_FORCES as $gameID => &$gameForces) {
-			foreach($gameForces as $sectorID => &$gameSectorForces) {
-				foreach($gameSectorForces as $ownerID => &$forces) {
-					$forces = self::getForce($gameID,$sectorID,$ownerID,true);
+		foreach (self::$CACHE_FORCES as $gameID => &$gameForces) {
+			foreach ($gameForces as $sectorID => &$gameSectorForces) {
+				foreach ($gameSectorForces as $ownerID => &$forces) {
+					$forces = self::getForce($gameID, $sectorID, $ownerID, true);
 				}
 			}
 		}
@@ -44,22 +44,22 @@ 
 	}
 
 	public static function saveForces() {
-		foreach(self::$CACHE_FORCES as $gameForces) {
-			foreach($gameForces as $gameSectorForces) {
-				foreach($gameSectorForces as $forces) {
+		foreach (self::$CACHE_FORCES as $gameForces) {
+			foreach ($gameForces as $gameSectorForces) {
+				foreach ($gameSectorForces as $forces) {
 					$forces->update();
 				}
 			}
 		}
 	}
 
-	public static function &getSectorForces($gameID,$sectorID,$forceUpdate = false) {
-		if($forceUpdate || !isset(self::$CACHE_SECTOR_FORCES[$gameID][$sectorID])) {
-			self::tidyUpForces(SmrGalaxy::getGalaxyContaining($gameID,$sectorID));
+	public static function &getSectorForces($gameID, $sectorID, $forceUpdate = false) {
+		if ($forceUpdate || !isset(self::$CACHE_SECTOR_FORCES[$gameID][$sectorID])) {
+			self::tidyUpForces(SmrGalaxy::getGalaxyContaining($gameID, $sectorID));
 			$db = new SmrMySqlDatabase();
 			$db->query('SELECT * FROM sector_has_forces WHERE sector_id = ' . $db->escapeNumber($sectorID) . ' AND game_id=' . $db->escapeNumber($gameID) . ' ORDER BY expire_time ASC');
 			$forces = array();
-			while($db->nextRecord()) {
+			while ($db->nextRecord()) {
 				$ownerID = $db->getInt('owner_id');
 				$forces[$ownerID] = self::getForce($gameID, $sectorID, $ownerID, $forceUpdate, $db);
 			}
@@ -68,9 +68,9 @@ 
 		return self::$CACHE_SECTOR_FORCES[$gameID][$sectorID];
 	}
 
-	public static function &getForce($gameID, $sectorID, $ownerID, $forceUpdate=false, $db=null) {
-		if($forceUpdate || !isset(self::$CACHE_FORCES[$gameID][$sectorID][$ownerID])) {
-			self::tidyUpForces(SmrGalaxy::getGalaxyContaining($gameID,$sectorID));
+	public static function &getForce($gameID, $sectorID, $ownerID, $forceUpdate = false, $db = null) {
+		if ($forceUpdate || !isset(self::$CACHE_FORCES[$gameID][$sectorID][$ownerID])) {
+			self::tidyUpForces(SmrGalaxy::getGalaxyContaining($gameID, $sectorID));
 			$p = new SmrForce($gameID, $sectorID, $ownerID, $db);
 			self::$CACHE_FORCES[$gameID][$sectorID][$ownerID] = $p;
 		}
@@ -78,24 +78,24 @@ 
 	}
 
 	public static function tidyUpForces(SmrGalaxy $galaxyToTidy) {
-		if(!isset(self::$TIDIED_UP[$galaxyToTidy->getGameID()][$galaxyToTidy->getGalaxyID()])) {
+		if (!isset(self::$TIDIED_UP[$galaxyToTidy->getGameID()][$galaxyToTidy->getGalaxyID()])) {
 			self::$TIDIED_UP[$galaxyToTidy->getGameID()][$galaxyToTidy->getGalaxyID()] = true;
 			$db = new SmrMySqlDatabase();
 			$db->query('UPDATE sector_has_forces
 						SET refresher=0,
 							expire_time = (refresh_at + if(combat_drones+mines=0,
-															LEAST('.$db->escapeNumber(self::LOWEST_MAX_EXPIRE_SCOUTS_ONLY).', scout_drones*'.$db->escapeNumber(self::TIME_PER_SCOUT_ONLY).'),
-															LEAST('.$db->escapeNumber($galaxyToTidy->getMaxForceTime()).', (combat_drones*'.$db->escapeNumber(self::TIME_PERCENT_PER_COMBAT).'+scout_drones*'.$db->escapeNumber(self::TIME_PERCENT_PER_SCOUT).'+mines*'.$db->escapeNumber(self::TIME_PERCENT_PER_MINE).')*'.$db->escapeNumber($galaxyToTidy->getMaxForceTime()).')
+															LEAST('.$db->escapeNumber(self::LOWEST_MAX_EXPIRE_SCOUTS_ONLY) . ', scout_drones*' . $db->escapeNumber(self::TIME_PER_SCOUT_ONLY) . '),
+															LEAST('.$db->escapeNumber($galaxyToTidy->getMaxForceTime()) . ', (combat_drones*' . $db->escapeNumber(self::TIME_PERCENT_PER_COMBAT) . '+scout_drones*' . $db->escapeNumber(self::TIME_PERCENT_PER_SCOUT) . '+mines*' . $db->escapeNumber(self::TIME_PERCENT_PER_MINE) . ')*' . $db->escapeNumber($galaxyToTidy->getMaxForceTime()) . ')
 														))
-						WHERE game_id = '.$db->escapeNumber($galaxyToTidy->getGameID()).' AND sector_id >= '.$db->escapeNumber($galaxyToTidy->getStartSector()).' AND sector_id <= '.$db->escapeNumber($galaxyToTidy->getEndSector()).' AND refresher != 0 AND refresh_at <= '.$db->escapeNumber(TIME));
+						WHERE game_id = '.$db->escapeNumber($galaxyToTidy->getGameID()) . ' AND sector_id >= ' . $db->escapeNumber($galaxyToTidy->getStartSector()) . ' AND sector_id <= ' . $db->escapeNumber($galaxyToTidy->getEndSector()) . ' AND refresher != 0 AND refresh_at <= ' . $db->escapeNumber(TIME));
 			$db->query('DELETE FROM sector_has_forces WHERE expire_time < ' . $db->escapeNumber(TIME));
 		}
 	}
 
-	protected function __construct($gameID, $sectorID, $ownerID, $db=null) {
+	protected function __construct($gameID, $sectorID, $ownerID, $db = null) {
 		$this->db = new SmrMySqlDatabase();
-		$this->SQL = 'game_id = '.$this->db->escapeNumber($gameID).'
-		              AND sector_id = '.$this->db->escapeNumber($sectorID).'
+		$this->SQL = 'game_id = ' . $this->db->escapeNumber($gameID) . '
+		              AND sector_id = '.$this->db->escapeNumber($sectorID) . '
 		              AND owner_id = '.$this->db->escapeNumber($ownerID);
 
 		if (isset($db)) {
@@ -118,31 +118,31 @@ 
 	}
 
 	public function exists() {
-		return ($this->hasCDs()||$this->hasSDs()||$this->hasMines())&&!$this->hasExpired();
+		return ($this->hasCDs() || $this->hasSDs() || $this->hasMines()) && !$this->hasExpired();
 	}
 
 	public function canAcceptCDs() {
-		return $this->getCDs()<50;
+		return $this->getCDs() < 50;
 	}
 
 	public function canAcceptSDs() {
-		return $this->getSDs()<5;
+		return $this->getSDs() < 5;
 	}
 
 	public function canAcceptMines() {
-		return $this->getMines()<50;
+		return $this->getMines() < 50;
 	}
 
 	public function hasCDs() {
-		return $this->getCDs()>0;
+		return $this->getCDs() > 0;
 	}
 
 	public function hasSDs() {
-		return $this->getSDs()>0;
+		return $this->getSDs() > 0;
 	}
 
 	public function hasMines() {
-		return $this->getMines()>0;
+		return $this->getMines() > 0;
 	}
 
 	public function getCDs() {
@@ -158,52 +158,52 @@ 
 	}
 
 	public function addMines($amount) {
-		if($amount<0) {
+		if ($amount < 0) {
 			throw new Exception('Cannot add negative mines.');
 		}
 		$this->setMines($this->getMines() + $amount);
 	}
 
 	public function addCDs($amount) {
-		if($amount<0) {
+		if ($amount < 0) {
 			throw new Exception('Cannot add negative CDs.');
 		}
 		$this->setCDs($this->getCDs() + $amount);
 	}
 
 	public function addSDs($amount) {
-		if($amount<0) {
+		if ($amount < 0) {
 			throw new Exception('Cannot add negative SDs.');
 		}
 		$this->setSDs($this->getSDs() + $amount);
 	}
 
 	public function takeMines($amount) {
-		if($amount<0) {
+		if ($amount < 0) {
 			throw new Exception('Cannot take negative mines.');
 		}
 		$this->setMines($this->getMines() - $amount);
 	}
 
 	public function takeCDs($amount) {
-		if($amount<0) {
+		if ($amount < 0) {
 			throw new Exception('Cannot take negative CDs.');
 		}
 		$this->setCDs($this->getCDs() - $amount);
 	}
 
 	public function takeSDs($amount) {
-		if($amount<0) {
+		if ($amount < 0) {
 			throw new Exception('Cannot take negative SDs.');
 		}
 		$this->setSDs($this->getSDs() - $amount);
 	}
 
 	public function setMines($amount) {
-		if($amount<0) {
+		if ($amount < 0) {
 			throw new Exception('Cannot set negative mines.');
 		}
-		if($amount==$this->getMines()) {
+		if ($amount == $this->getMines()) {
 			return;
 		}
 		$this->hasChanged = true;
@@ -211,10 +211,10 @@ 
 	}
 
 	public function setCDs($amount) {
-		if($amount<0) {
+		if ($amount < 0) {
 			throw new Exception('Cannot set negative CDs.');
 		}
-		if($amount==$this->getCDs()) {
+		if ($amount == $this->getCDs()) {
 			return;
 		}
 		$this->hasChanged = true;
@@ -222,10 +222,10 @@ 
 	}
 
 	public function setSDs($amount) {
-		if($amount<0) {
+		if ($amount < 0) {
 			throw new Exception('Cannot set negative SDs.');
 		}
-		if($amount==$this->getSDs()) {
+		if ($amount == $this->getSDs()) {
 			return;
 		}
 		$this->hasChanged = true;
@@ -233,7 +233,7 @@ 
 	}
 
 	public function hasExpired() {
-		return $this->expire<TIME;
+		return $this->expire < TIME;
 	}
 
 	public function getExpire() {
@@ -241,38 +241,38 @@ 
 	}
 
 	public function setExpire($time) {
-		if($time<0) {
+		if ($time < 0) {
 			throw new Exception('Cannot set negative expiry.');
 		}
-		if($time==$this->getExpire()) {
+		if ($time == $this->getExpire()) {
 			return;
 		}
-		if($time > TIME + $this->getMaxExpireTime()) {
+		if ($time > TIME + $this->getMaxExpireTime()) {
 			$time = TIME + $this->getMaxExpireTime();
 		}
 		$this->hasChanged = true;
 		$this->expire = $time;
-		if(!$this->isNew)
+		if (!$this->isNew)
 			$this->update();
 	}
 
 	public function updateExpire() {
 		// Changed (26/10/05) - scout drones count * 2
-		if($this->getCDs() == 0 && $this->getMines() == 0 && $this->getSDs() > 0) {
-			$time = self::TIME_PER_SCOUT_ONLY*$this->getSDs();
+		if ($this->getCDs() == 0 && $this->getMines() == 0 && $this->getSDs() > 0) {
+			$time = self::TIME_PER_SCOUT_ONLY * $this->getSDs();
 		}
 		else {
-			$time = ($this->getCDs()*self::TIME_PERCENT_PER_COMBAT + $this->getSDs()*self::TIME_PERCENT_PER_SCOUT + $this->getMines()*self::TIME_PERCENT_PER_MINE) * $this->getMaxGalaxyExpireTime();
+			$time = ($this->getCDs() * self::TIME_PERCENT_PER_COMBAT + $this->getSDs() * self::TIME_PERCENT_PER_SCOUT + $this->getMines() * self::TIME_PERCENT_PER_MINE) * $this->getMaxGalaxyExpireTime();
 		}
 		$this->setExpire(TIME + $time);
 	}
 
 	public function getMaxExpireTime() {
-		if($this->hasCDs()||$this->hasMines()) {
+		if ($this->hasCDs() || $this->hasMines()) {
 			return $this->getMaxGalaxyExpireTime();
 		}
-		if(!$this->hasCDs() && !$this->hasMines() && $this->hasSDs()) {
-			return max(self::LOWEST_MAX_EXPIRE_SCOUTS_ONLY,$this->getMaxGalaxyExpireTime());
+		if (!$this->hasCDs() && !$this->hasMines() && $this->hasSDs()) {
+			return max(self::LOWEST_MAX_EXPIRE_SCOUTS_ONLY, $this->getMaxGalaxyExpireTime());
 		}
 		return 0;
 	}
@@ -283,26 +283,26 @@ 
 
 	public function getBumpTurnCost(AbstractSmrShip $ship) {
 		$mines = $this->getMines();
-		if($mines <= 1) {
+		if ($mines <= 1) {
 			return 0;
 		}
-		if($mines < 10) {
+		if ($mines < 10) {
 			$turns = 1;
 		}
-		else if($mines < 25) {
+		else if ($mines < 25) {
 			$turns = 2;
 		}
 		else {
 			$turns = 3;
 		}
-		if($ship->isFederal() || $ship->hasDCS()) {
+		if ($ship->isFederal() || $ship->hasDCS()) {
 			$turns -= 1;
 		}
 		return $turns;
 	}
 
 	public function getAttackTurnCost(AbstractSmrShip $ship) {
-		if($ship->isFederal() || $ship->hasDCS()) {
+		if ($ship->isFederal() || $ship->hasDCS()) {
 			return 2;
 		}
 		return 3;
@@ -317,45 +317,45 @@ 
 	}
 
 	public function &getSector() {
-		return SmrSector::getSector($this->getGameID(),$this->getSectorID());
+		return SmrSector::getSector($this->getGameID(), $this->getSectorID());
 	}
 
 	public function getSectorID() {
 		return $this->sectorID;
 	}
 
-	public function ping($pingMessage, AbstractSmrPlayer $playerPinging, $skipCheck=false) {
-		if(!$this->hasSDs() && !$skipCheck) {
+	public function ping($pingMessage, AbstractSmrPlayer $playerPinging, $skipCheck = false) {
+		if (!$this->hasSDs() && !$skipCheck) {
 			return;
 		}
 		$owner = $this->getOwner();
-		if(!$playerPinging->sameAlliance($owner)) {
-			$playerPinging->sendMessage($owner->getAccountID(), MSG_SCOUT, $pingMessage,false);
+		if (!$playerPinging->sameAlliance($owner)) {
+			$playerPinging->sendMessage($owner->getAccountID(), MSG_SCOUT, $pingMessage, false);
 		}
 	}
 
 	function &getGalaxy() {
-		return SmrGalaxy::getGalaxyContaining($this->getGameID(),$this->getSectorID());
+		return SmrGalaxy::getGalaxyContaining($this->getGameID(), $this->getSectorID());
 	}
 
 	function &getOwner() {
-		return SmrPlayer::getPlayer($this->getOwnerID(),$this->getGameID());
+		return SmrPlayer::getPlayer($this->getOwnerID(), $this->getGameID());
 	}
 
 	public function update() {
-		if(!$this->isNew) {
+		if (!$this->isNew) {
 			if (!$this->exists()) {
 				$this->db->query('DELETE FROM sector_has_forces WHERE ' . $this->SQL);
-				$this->isNew=true;
+				$this->isNew = true;
 			}
 			else if ($this->hasChanged) {
-				$this->db->query('UPDATE sector_has_forces SET combat_drones = '.$this->db->escapeNumber($this->combatDrones).', scout_drones = ' . $this->db->escapeNumber($this->scoutDrones) . ', mines = ' . $this->db->escapeNumber($this->mines) . ', expire_time = ' . $this->db->escapeNumber($this->expire) . ' WHERE ' . $this->SQL);
+				$this->db->query('UPDATE sector_has_forces SET combat_drones = ' . $this->db->escapeNumber($this->combatDrones) . ', scout_drones = ' . $this->db->escapeNumber($this->scoutDrones) . ', mines = ' . $this->db->escapeNumber($this->mines) . ', expire_time = ' . $this->db->escapeNumber($this->expire) . ' WHERE ' . $this->SQL);
 			}
 		}
-		else if($this->exists()) {
+		else if ($this->exists()) {
 			$this->db->query('INSERT INTO sector_has_forces (game_id, sector_id, owner_id, combat_drones, scout_drones, mines, expire_time)
-								VALUES('.$this->db->escapeNumber($this->gameID).', '.$this->db->escapeNumber($this->sectorID).', '.$this->db->escapeNumber($this->ownerID).', '.$this->db->escapeNumber($this->combatDrones).', '.$this->db->escapeNumber($this->scoutDrones).', '.$this->db->escapeNumber($this->mines).', '.$this->db->escapeNumber($this->expire).')');
-			$this->isNew=false;
+								VALUES('.$this->db->escapeNumber($this->gameID) . ', ' . $this->db->escapeNumber($this->sectorID) . ', ' . $this->db->escapeNumber($this->ownerID) . ', ' . $this->db->escapeNumber($this->combatDrones) . ', ' . $this->db->escapeNumber($this->scoutDrones) . ', ' . $this->db->escapeNumber($this->mines) . ', ' . $this->db->escapeNumber($this->expire) . ')');
+			$this->isNew = false;
 		}
 		// This instance is now in sync with the database
 		$this->hasChanged = false;
@@ -370,20 +370,20 @@ 
 
 	public function getExamineDropForcesHREF() {
 		$container = create_container('skeleton.php', 'forces_drop.php');
-		$container['owner_id']	= $this->getOwnerID();
+		$container['owner_id'] = $this->getOwnerID();
 		return SmrSession::getNewHREF($container);
 	}
 
 	public function getAttackForcesHREF() {
 		$container = create_container('forces_attack_processing.php');
 		$container['action'] = 'attack';
-		$container['owner_id']	= $this->getOwnerID();
+		$container['owner_id'] = $this->getOwnerID();
 		return SmrSession::getNewHREF($container);
 	}
 
 	public function getRefreshHREF() {
 		$container = create_container('forces_refresh_processing.php');
-		$container['owner_id']	= $this->getOwnerID();
+		$container['owner_id'] = $this->getOwnerID();
 		return SmrSession::getNewHREF($container);
 	}
 
@@ -393,74 +393,74 @@ 
 
 	public function getDropSDHREF() {
 		$container = $this->getDropContainer();
-		$container['drop_scout_drones']	= 1;
+		$container['drop_scout_drones'] = 1;
 		return SmrSession::getNewHREF($container);
 	}
 
 	public function getTakeSDHREF() {
 		$container = $this->getDropContainer();
-		$container['take_scout_drones']	= 1;
+		$container['take_scout_drones'] = 1;
 		return SmrSession::getNewHREF($container);
 	}
 
 	public function getDropCDHREF() {
 		$container = $this->getDropContainer();
-		$container['drop_combat_drones']	= 1;
+		$container['drop_combat_drones'] = 1;
 		return SmrSession::getNewHREF($container);
 	}
 
 	public function getTakeCDHREF() {
 		$container = $this->getDropContainer();
-		$container['take_combat_drones']	= 1;
+		$container['take_combat_drones'] = 1;
 		return SmrSession::getNewHREF($container);
 	}
 
 	public function getDropMineHREF() {
 		$container = $this->getDropContainer();
-		$container['drop_mines']	= 1;
+		$container['drop_mines'] = 1;
 		return SmrSession::getNewHREF($container);
 	}
 
 	public function getTakeMineHREF() {
 		$container = $this->getDropContainer();
-		$container['take_mines']	= 1;
+		$container['take_mines'] = 1;
 		return SmrSession::getNewHREF($container);
 	}
 
 	public static function getRefreshAllHREF() {
 		$container = array();
-		$container['url']		= 'forces_mass_refresh.php';
+		$container['url'] = 'forces_mass_refresh.php';
 		return SmrSession::getNewHREF($container);
 	}
 
-	public function &shootPlayer(AbstractSmrPlayer $targetPlayer,$minesAreAttacker) {
-		return $this->shootPlayers(array($targetPlayer),$minesAreAttacker);
+	public function &shootPlayer(AbstractSmrPlayer $targetPlayer, $minesAreAttacker) {
+		return $this->shootPlayers(array($targetPlayer), $minesAreAttacker);
 	}
 
-	public function &shootPlayers(array $targetPlayers,$minesAreAttacker) {
+	public function &shootPlayers(array $targetPlayers, $minesAreAttacker) {
 		$results = array('TotalDamage' => 0);
-		if(!$this->exists()) {
+		if (!$this->exists()) {
 			$results['DeadBeforeShot'] = true;
 			return $results;
 		}
 		$results['DeadBeforeShot'] = false;
 
-		if($this->hasMines()) {
-			$thisMines = new SmrMines($this->getGameID(),$this->getMines());
-			$results['Results']['Mines'] =& $thisMines->shootPlayerAsForce($this, $targetPlayers[array_rand($targetPlayers)],$minesAreAttacker);
+		if ($this->hasMines()) {
+			$thisMines = new SmrMines($this->getGameID(), $this->getMines());
+			$results['Results']['Mines'] = & $thisMines->shootPlayerAsForce($this, $targetPlayers[array_rand($targetPlayers)], $minesAreAttacker);
 			$results['TotalDamage'] += $results['Results']['Mines']['ActualDamage']['TotalDamage'];
 		}
 
-		if($this->hasCDs()) {
-			$thisCDs = new SmrCombatDrones($this->getGameID(),$this->getCDs());
-			$results['Results']['Drones'] =& $thisCDs->shootPlayerAsForce($this, $targetPlayers[array_rand($targetPlayers)]);
+		if ($this->hasCDs()) {
+			$thisCDs = new SmrCombatDrones($this->getGameID(), $this->getCDs());
+			$results['Results']['Drones'] = & $thisCDs->shootPlayerAsForce($this, $targetPlayers[array_rand($targetPlayers)]);
 			$results['TotalDamage'] += $results['Results']['Drones']['ActualDamage']['TotalDamage'];
 		}
 
-		if(!$minesAreAttacker) {
-			if($this->hasSDs()) {
-				$thisSDs = new SmrScoutDrones($this->getGameID(),$this->getSDs());
-				$results['Results']['Scouts'] =& $thisSDs->shootPlayerAsForce($this, $targetPlayers[array_rand($targetPlayers)]);
+		if (!$minesAreAttacker) {
+			if ($this->hasSDs()) {
+				$thisSDs = new SmrScoutDrones($this->getGameID(), $this->getSDs());
+				$results['Results']['Scouts'] = & $thisSDs->shootPlayerAsForce($this, $targetPlayers[array_rand($targetPlayers)]);
 				$results['TotalDamage'] += $results['Results']['Scouts']['ActualDamage']['TotalDamage'];
 			}
 		}
@@ -474,16 +474,16 @@ 
 		$minesDamage = 0;
 		$cdDamage = 0;
 		$sdDamage = 0;
-		if(!$alreadyDead) {
-			$minesDamage = $this->doMinesDamage(min($damage['MaxDamage'],$damage['Armour']));
+		if (!$alreadyDead) {
+			$minesDamage = $this->doMinesDamage(min($damage['MaxDamage'], $damage['Armour']));
 			$damage['Armour'] -= $minesDamage;
 			$damage['MaxDamage'] -= $minesDamage;
-			if(!$this->hasMines() && ($minesDamage == 0 || $damage['Rollover'])) {
-				$cdDamage = $this->doCDDamage(min($damage['MaxDamage'],$damage['Armour']));
+			if (!$this->hasMines() && ($minesDamage == 0 || $damage['Rollover'])) {
+				$cdDamage = $this->doCDDamage(min($damage['MaxDamage'], $damage['Armour']));
 				$damage['Armour'] -= $cdDamage;
 				$damage['MaxDamage'] -= $cdDamage;
-				if(!$this->hasCDs() && ($cdDamage == 0 || $damage['Rollover'])) {
-					$sdDamage = $this->doSDDamage(min($damage['MaxDamage'],$damage['Armour']));
+				if (!$this->hasCDs() && ($cdDamage == 0 || $damage['Rollover'])) {
+					$sdDamage = $this->doSDDamage(min($damage['MaxDamage'], $damage['Armour']));
 				}
 			}
 		}
@@ -491,35 +491,35 @@ 
 						'KillingShot' => !$alreadyDead && !$this->exists(),
 						'TargetAlreadyDead' => $alreadyDead,
 						'Mines' => $minesDamage,
-						'NumMines' => $minesDamage/MINE_ARMOUR,
+						'NumMines' => $minesDamage / MINE_ARMOUR,
 						'HasMines' => $this->hasMines(),
 						'CDs' => $cdDamage,
-						'NumCDs' => $cdDamage/CD_ARMOUR,
+						'NumCDs' => $cdDamage / CD_ARMOUR,
 						'HasCDs' => $this->hasCDs(),
 						'SDs' => $sdDamage,
-						'NumSDs' => $sdDamage/SD_ARMOUR,
+						'NumSDs' => $sdDamage / SD_ARMOUR,
 						'HasSDs' => $this->hasSDs(),
-						'TotalDamage' => $minesDamage+$cdDamage+$sdDamage
+						'TotalDamage' => $minesDamage + $cdDamage + $sdDamage
 		);
 		return $return;
 	}
 
 	protected function doMinesDamage($damage) {
-		$actualDamage = min($this->getMines(),floor($damage/MINE_ARMOUR));
+		$actualDamage = min($this->getMines(), floor($damage / MINE_ARMOUR));
 		$this->takeMines($actualDamage);
-		return $actualDamage*MINE_ARMOUR;
+		return $actualDamage * MINE_ARMOUR;
 	}
 
 	protected function doCDDamage($damage) {
-		$actualDamage = min($this->getCDs(),floor($damage/CD_ARMOUR));
+		$actualDamage = min($this->getCDs(), floor($damage / CD_ARMOUR));
 		$this->takeCDs($actualDamage);
-		return $actualDamage*CD_ARMOUR;
+		return $actualDamage * CD_ARMOUR;
 	}
 
 	protected function doSDDamage($damage) {
-		$actualDamage = min($this->getSDs(),floor($damage/SD_ARMOUR));
+		$actualDamage = min($this->getSDs(), floor($damage / SD_ARMOUR));
 		$this->takeSDs($actualDamage);
-		return $actualDamage*SD_ARMOUR;
+		return $actualDamage * SD_ARMOUR;
 	}
 
 	public function &killForcesByPlayer(AbstractSmrPlayer $killer) {

admin/Default/1.6/universe_create_ports.php

Spacing +3 added lines, -3 removed lines

@@ -4,18 +4,18 @@
 	throw new Exception('Gal_on not found!');
 }
 
-$galaxy = SmrGalaxy::getGalaxy($var['game_id'],$var['gal_on']);
+$galaxy = SmrGalaxy::getGalaxy($var['game_id'], $var['gal_on']);
 $template->assign('Galaxy', $galaxy);
 
 //get totals
 $total = array();
 $totalPorts = array();
 $total['Ports'] = 0;
-for ($i=1; $i<=SmrPort::MAX_LEVEL; $i++) {
+for ($i = 1; $i <= SmrPort::MAX_LEVEL; $i++) {
 	$totalPorts[$i] = 0;
 }
 foreach ($galaxy->getSectors() as $galSector) {
-	if($galSector->hasPort()) {
+	if ($galSector->hasPort()) {
 		$totalPorts[$galSector->getPort()->getLevel()]++;
 		$total['Ports']++;
 	}