Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Failed Conditions
Pull Request — main (#1494)
by Dan
08:06 queued 03:15
created
src/pages/Admin/NewsletterSendProcessor.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
 
25 25
 		$mail->Subject = Request::get('subject');
26 26
 
27
-		$set_mail_body = function (PHPMailer $mail, ?string $newsletterHtml, ?string $newsletterText, ?string $salutation): void {
27
+		$set_mail_body = function(PHPMailer $mail, ?string $newsletterHtml, ?string $newsletterText, ?string $salutation): void {
28 28
 			// Prepend the salutation if one is given
29 29
 			if ($salutation) {
30 30
 				if (!empty($newsletterHtml)) {
Please login to merge, or discard this patch.
src/pages/Admin/CombatSimulator.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@
 block discarded – undo
17 17
 	 * @param array<\AbstractSmrPlayer> $defenders
18 18
 	 */
19 19
 	public function __construct(
20
-		private readonly ?array $results = null,
20
+		private readonly ? array $results = null,
21 21
 		private readonly array $attackers = [],
22 22
 		private readonly array $defenders = []
23 23
 	) {}
Please login to merge, or discard this patch.
src/pages/Admin/UniGen/CreateGameProcessor.php 1 patch
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -28,8 +28,7 @@
 block discarded – undo
28 28
 		if ($join === false) {
29 29
 			create_error('Join Date is not valid!');
30 30
 		}
31
-		$start = empty(Request::get('game_start')) ? $join :
32
-			DateTime::createFromFormat('d/m/Y|', Request::get('game_start'));
31
+		$start = empty(Request::get('game_start')) ? $join : DateTime::createFromFormat('d/m/Y|', Request::get('game_start'));
33 32
 		if ($start === false) {
34 33
 			create_error('Start Date is not valid!');
35 34
 		}
Please login to merge, or discard this patch.
src/pages/Admin/UniGen/EditGameProcessor.php 1 patch
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -18,8 +18,7 @@
 block discarded – undo
18 18
 	public function build(SmrAccount $account): never {
19 19
 		// Get the dates ("|" sets hr/min/sec to 0)
20 20
 		$join = DateTime::createFromFormat('d/m/Y|', Request::get('game_join'));
21
-		$start = empty(Request::get('game_start')) ? $join :
22
-			DateTime::createFromFormat('d/m/Y|', Request::get('game_start'));
21
+		$start = empty(Request::get('game_start')) ? $join : DateTime::createFromFormat('d/m/Y|', Request::get('game_start'));
23 22
 		$end = DateTime::createFromFormat('d/m/Y|', Request::get('game_end'));
24 23
 
25 24
 		$game = SmrGame::getGame($this->gameID);
Please login to merge, or discard this patch.
src/pages/Admin/DatabaseCleanup.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -17,15 +17,15 @@
 block discarded – undo
17 17
 	 */
18 18
 	public function __construct(
19 19
 		private readonly ?string $action = null,
20
-		private readonly ?array $results = null,
20
+		private readonly ? array $results = null,
21 21
 		private readonly ?int $diffBytes = null,
22
-		private readonly ?array $endedGames = null
22
+		private readonly ? array $endedGames = null
23 23
 	) {}
24 24
 
25 25
 	public function build(SmrAccount $account, Template $template): void {
26 26
 		$template->assign('PageTopic', 'Database Cleanup');
27 27
 
28
-		$bytesToMB = function (int $bytes): string {
28
+		$bytesToMB = function(int $bytes): string {
29 29
 			return round($bytes / (1024 * 1024), 1) . ' MB';
30 30
 		};
31 31
 
Please login to merge, or discard this patch.
src/pages/Player/MessageView.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -128,7 +128,7 @@
 block discarded – undo
128 128
 					AND receiver_delete = ' . $db->escapeBoolean(false) . '
129 129
 					ORDER BY send_time DESC');
130 130
 	foreach ($dbResult->records() as $dbRecord) {
131
-		$groupBox =& $messageBox['GroupedMessages'][$dbRecord->getInt('sender_id')];
131
+		$groupBox = & $messageBox['GroupedMessages'][$dbRecord->getInt('sender_id')];
132 132
 		// Limit the number of messages in each group
133 133
 		if (!isset($groupBox['Messages']) || count($groupBox['Messages']) < MESSAGE_SCOUT_GROUP_LIMIT) {
134 134
 			$groupBox['Messages'][] = displayMessage($dbRecord->getInt('message_id'), $dbRecord->getInt('account_id'), $dbRecord->getInt('sender_id'), $player->getGameID(), $dbRecord->getString('message_text'), $dbRecord->getInt('send_time'), $dbRecord->getBoolean('msg_read'), MSG_SCOUT, $player->getAccount());
Please login to merge, or discard this patch.
src/pages/Player/ChatSharing.php 2 patches
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -38,8 +38,8 @@  discard block
 block discarded – undo
38 38
 			$shareFrom[$fromAccountId] = [
39 39
 				'Player ID' => $otherPlayer == null ? '-' : $otherPlayer->getPlayerID(),
40 40
 				'Player Name' => $otherPlayer == null ?
41
-				                 '<b>Account</b>: ' . SmrAccount::getAccount($fromAccountId)->getHofDisplayName() :
42
-				                 $otherPlayer->getDisplayName(),
41
+								 '<b>Account</b>: ' . SmrAccount::getAccount($fromAccountId)->getHofDisplayName() :
42
+								 $otherPlayer->getDisplayName(),
43 43
 				'All Games' => $gameId == 0 ? '<span class="green">YES</span>' : '<span class="red">NO</span>',
44 44
 				'Game ID' => $gameId,
45 45
 			];
@@ -59,8 +59,8 @@  discard block
 block discarded – undo
59 59
 			$shareTo[$toAccountId] = [
60 60
 				'Player ID' => $otherPlayer == null ? '-' : $otherPlayer->getPlayerID(),
61 61
 				'Player Name' => $otherPlayer == null ?
62
-				                 '<b>Account</b>: ' . SmrAccount::getAccount($toAccountId)->getHofDisplayName() :
63
-				                 $otherPlayer->getDisplayName(),
62
+								 '<b>Account</b>: ' . SmrAccount::getAccount($toAccountId)->getHofDisplayName() :
63
+								 $otherPlayer->getDisplayName(),
64 64
 				'All Games' => $gameId == 0 ? '<span class="green">YES</span>' : '<span class="red">NO</span>',
65 65
 				'Game ID' => $gameId,
66 66
 			];
Please login to merge, or discard this patch.
Spacing   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -38,8 +38,7 @@  discard block
 block discarded – undo
38 38
 			$shareFrom[$fromAccountId] = [
39 39
 				'Player ID' => $otherPlayer == null ? '-' : $otherPlayer->getPlayerID(),
40 40
 				'Player Name' => $otherPlayer == null ?
41
-				                 '<b>Account</b>: ' . SmrAccount::getAccount($fromAccountId)->getHofDisplayName() :
42
-				                 $otherPlayer->getDisplayName(),
41
+				                 '<b>Account</b>: ' . SmrAccount::getAccount($fromAccountId)->getHofDisplayName() : $otherPlayer->getDisplayName(),
43 42
 				'All Games' => $gameId == 0 ? '<span class="green">YES</span>' : '<span class="red">NO</span>',
44 43
 				'Game ID' => $gameId,
45 44
 			];
@@ -59,8 +58,7 @@  discard block
 block discarded – undo
59 58
 			$shareTo[$toAccountId] = [
60 59
 				'Player ID' => $otherPlayer == null ? '-' : $otherPlayer->getPlayerID(),
61 60
 				'Player Name' => $otherPlayer == null ?
62
-				                 '<b>Account</b>: ' . SmrAccount::getAccount($toAccountId)->getHofDisplayName() :
63
-				                 $otherPlayer->getDisplayName(),
61
+				                 '<b>Account</b>: ' . SmrAccount::getAccount($toAccountId)->getHofDisplayName() : $otherPlayer->getDisplayName(),
64 62
 				'All Games' => $gameId == 0 ? '<span class="green">YES</span>' : '<span class="red">NO</span>',
65 63
 				'Game ID' => $gameId,
66 64
 			];
Please login to merge, or discard this patch.
src/pages/Player/Rankings/AllianceVsAlliance.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -81,7 +81,7 @@
 block discarded – undo
81 81
 			foreach ($alliance_vs_ids as $id) {
82 82
 				$row_alliance = SmrAlliance::getAlliance($id, $player->getGameID());
83 83
 				$showRed = (!$curr_alliance->isNone() && $curr_alliance->hasDisbanded()) ||
84
-				           (!$row_alliance->isNone() && $row_alliance->hasDisbanded());
84
+						   (!$row_alliance->isNone() && $row_alliance->hasDisbanded());
85 85
 				$showBold = $curr_id == $player->getAllianceID() || $id == $player->getAllianceID();
86 86
 				$style = '';
87 87
 				if ($curr_id == $id && !$row_alliance->isNone()) {
Please login to merge, or discard this patch.
src/pages/Player/ShopGoods.php 1 patch
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -65,9 +65,9 @@
 block discarded – undo
65 65
 					//get base for ports that dont happen to trade that good
66 66
 					$GOODS = Globals::getGoods();
67 67
 					$fine = $totalFine = $port->getLevel() *
68
-					    (($ship->getCargo(GOODS_SLAVES) * $GOODS[GOODS_SLAVES]['BasePrice']) +
69
-					     ($ship->getCargo(GOODS_WEAPONS) * $GOODS[GOODS_WEAPONS]['BasePrice']) +
70
-					     ($ship->getCargo(GOODS_NARCOTICS) * $GOODS[GOODS_NARCOTICS]['BasePrice']));
68
+						(($ship->getCargo(GOODS_SLAVES) * $GOODS[GOODS_SLAVES]['BasePrice']) +
69
+						 ($ship->getCargo(GOODS_WEAPONS) * $GOODS[GOODS_WEAPONS]['BasePrice']) +
70
+						 ($ship->getCargo(GOODS_NARCOTICS) * $GOODS[GOODS_NARCOTICS]['BasePrice']));
71 71
 					$player->increaseHOF($ship->getCargo(GOODS_SLAVES) + $ship->getCargo(GOODS_WEAPONS) + $ship->getCargo(GOODS_NARCOTICS), ['Trade', 'Search', 'Caught', 'Goods Confiscated'], HOF_PUBLIC);
72 72
 					$player->increaseHOF($totalFine, ['Trade', 'Search', 'Caught', 'Amount Fined'], HOF_PUBLIC);
73 73
 					$template->assign('TotalFine', $totalFine);
Please login to merge, or discard this patch.