Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Failed Conditions
Pull Request — master (#812)
by Dan
04:25
created
templates/Default/engine/Default/preferences.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -316,8 +316,8 @@
 block discarded – undo
316 316
 					foreach (Globals::getAvailableTemplates() as $AvailableTemplate => $ColourSchemes) {
317 317
 						foreach ($ColourSchemes as $ColourScheme) {
318 318
 							$selected = ($ThisAccount->getTemplate() == $AvailableTemplate &&
319
-							             $ThisAccount->getColourScheme() == $ColourScheme &&
320
-							             $ThisAccount->isDefaultCSSEnabled()) ? 'selected' : '';
319
+										 $ThisAccount->getColourScheme() == $ColourScheme &&
320
+										 $ThisAccount->isDefaultCSSEnabled()) ? 'selected' : '';
321 321
 							$name = $AvailableTemplate . ' - ' . $ColourScheme;
322 322
 							?><option value="<?php echo $name; ?>" <?php echo $selected; ?>><?php echo $name; ?></option><?php
323 323
 						}
Please login to merge, or discard this patch.
templates/Default/engine/Default/combat_log_viewer.php 1 patch
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -20,11 +20,11 @@
 block discarded – undo
20 20
 	$this->includeTemplate('includes/ForceFullCombatResults.inc', array('FullForceCombatResults'=>$CombatResults));
21 21
 } else if ($CombatResultsType == 'PORT') {
22 22
 	$this->includeTemplate('includes/PortFullCombatResults.inc', array('FullPortCombatResults'=>$CombatResults,
23
-	                                                                  'MinimalDisplay'=>false,
24
-	                                                                  'AlreadyDestroyed'=>false));
23
+																	  'MinimalDisplay'=>false,
24
+																	  'AlreadyDestroyed'=>false));
25 25
 } else if ($CombatResultsType == 'PLANET') {
26 26
 	$this->includeTemplate('includes/PlanetFullCombatResults.inc', array('FullPlanetCombatResults'=>$CombatResults,
27
-	                                                                    'MinimalDisplay'=>false,
28
-	                                                                    'AlreadyDestroyed'=>false));
27
+																		'MinimalDisplay'=>false,
28
+																		'AlreadyDestroyed'=>false));
29 29
 }
30 30
 ?>
Please login to merge, or discard this patch.
templates/Default/engine/Default/includes/SectorMap.inc 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -102,7 +102,7 @@
 block discarded – undo
102 102
 						if (!$UniGen) {
103 103
 							$CanScanSector = ($ThisShip->hasScanner() && $isLinkedSector) || $isCurrentSector;
104 104
 							$ShowFriendlyForces = isset($HideAlliedForces) && $HideAlliedForces ?
105
-							                      $Sector->hasPlayerForces($MapPlayer) : $Sector->hasFriendlyForces($MapPlayer);
105
+												  $Sector->hasPlayerForces($MapPlayer) : $Sector->hasFriendlyForces($MapPlayer);
106 106
 							if (($CanScanSector && ($Sector->hasForces() || $Sector->hasPlayers())) || $ShowFriendlyForces || $Sector->hasFriendlyTraders($MapPlayer)) { ?>
107 107
 								<div class="lmtf"><?php
108 108
 									if ($CanScanSector && $Sector->hasEnemyTraders($MapPlayer)) {
Please login to merge, or discard this patch.
templates/Default/engine/Default/map_local.php 1 patch
Braces   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -10,7 +10,10 @@
 block discarded – undo
10 10
 		<td style="width: 80%" class="center">
11 11
 			Local Map of the Known <span class="big bold"><?php echo $GalaxyName ?></span> Galaxy
12 12
 			<br /><br />
13
-			<?php if (isset($Error)) echo $Error; ?>
13
+			<?php if (isset($Error)) {
14
+	echo $Error;
15
+}
16
+?>
14 17
 		</td>
15 18
 		<td style="width: 10%"></td>
16 19
 	</tr>
Please login to merge, or discard this patch.
engine/Default/hall_of_fame_new.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -20,13 +20,13 @@
 block discarded – undo
20 20
 const USER_SCORE_NAME = 'User Score';
21 21
 $hofTypes = array(DONATION_NAME=>true, USER_SCORE_NAME=>true);
22 22
 while ($db->nextRecord()) {
23
-	$hof =& $hofTypes;
23
+	$hof = & $hofTypes;
24 24
 	$typeList = explode(':', $db->getField('type'));
25 25
 	foreach ($typeList as $type) {
26 26
 		if (!isset($hof[$type])) {
27 27
 			$hof[$type] = array();
28 28
 		}
29
-		$hof =& $hof[$type];
29
+		$hof = & $hof[$type];
30 30
 	}
31 31
 	$hof = true;
32 32
 }
Please login to merge, or discard this patch.
Braces   +9 added lines, -8 removed lines patch added patch discarded remove patch
@@ -1,18 +1,21 @@  discard block
 block discarded – undo
1 1
 <?php declare(strict_types=1);
2 2
 require_once(get_file_loc('hof.functions.inc'));
3 3
 $game_id = null;
4
-if (isset($var['game_id'])) $game_id = $var['game_id'];
4
+if (isset($var['game_id'])) {
5
+	$game_id = $var['game_id'];
6
+}
5 7
 
6 8
 if (empty($game_id)) {
7 9
 	$topic = 'All Time Hall of Fame';
8
-}
9
-else {
10
+} else {
10 11
 	$topic = 'Hall of Fame: ' . SmrGame::getGame($game_id)->getDisplayName();
11 12
 }
12 13
 $template->assign('PageTopic', $topic);
13 14
 
14 15
 $container = create_container('skeleton.php', 'hall_of_fame_player_detail.php');
15
-if (isset($game_id)) $container['game_id'] = $game_id;
16
+if (isset($game_id)) {
17
+	$container['game_id'] = $game_id;
18
+}
16 19
 $template->assign('PersonalHofHREF', SmrSession::getNewHREF($container));
17 20
 
18 21
 $db->query('SELECT type FROM hof_visibility WHERE visibility != ' . $db->escapeString(HOF_PRIVATE) . ' ORDER BY type');
@@ -35,8 +38,7 @@  discard block
 block discarded – undo
35 38
 if (!isset($var['view'])) {
36 39
 	$categories = getHofCategories($hofTypes, $game_id, $account->getAccountID());
37 40
 	$template->assign('Categories', $categories);
38
-}
39
-else {
41
+} else {
40 42
 	$gameIDSql = ' AND game_id ' . (isset($game_id) ? '= ' . $db->escapeNumber($game_id) : 'IN (SELECT game_id FROM game WHERE end_time < ' . TIME . ' AND ignore_stats = ' . $db->escapeBoolean(false) . ')');
41 43
 
42 44
 	$vis = HOF_PUBLIC;
@@ -51,8 +53,7 @@  discard block
 block discarded – undo
51 53
 		$statements = SmrAccount::getUserScoreCaseStatement($db);
52 54
 		$query = 'SELECT account_id, ' . $statements['CASE'] . ' amount FROM (SELECT account_id, type, SUM(amount) amount FROM player_hof WHERE type IN (' . $statements['IN'] . ')' . $gameIDSql . ' GROUP BY account_id,type) x GROUP BY account_id ORDER BY amount DESC, account_id ASC LIMIT 25';
53 55
 		$db->query($query);
54
-	}
55
-	else {
56
+	} else {
56 57
 		$db->query('SELECT visibility FROM hof_visibility WHERE type = ' . $db->escapeArray($viewType, false, true, ':', false) . ' LIMIT 1');
57 58
 		if ($db->nextRecord()) {
58 59
 			$vis = $db->getField('visibility');
Please login to merge, or discard this patch.
engine/Default/hall_of_fame_player_detail.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -20,13 +20,13 @@
 block discarded – undo
20 20
 const USER_SCORE_NAME = 'User Score';
21 21
 $hofTypes = array(DONATION_NAME=>true, USER_SCORE_NAME=>true);
22 22
 while ($db->nextRecord()) {
23
-	$hof =& $hofTypes;
23
+	$hof = & $hofTypes;
24 24
 	$typeList = explode(':', $db->getField('type'));
25 25
 	foreach ($typeList as $type) {
26 26
 		if (!isset($hof[$type])) {
27 27
 			$hof[$type] = array();
28 28
 		}
29
-		$hof =& $hof[$type];
29
+		$hof = & $hof[$type];
30 30
 	}
31 31
 	$hof = true;
32 32
 }
Please login to merge, or discard this patch.
templates/Default/admin/Default/location_edit.php 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -19,8 +19,7 @@
 block discarded – undo
19 19
 	</tr><?php
20 20
 if (isset($Locations)) {
21 21
 	$this->includeTemplate('includes/ViewLocations.inc', array('Locations'=>$Locations));
22
-}
23
-else { ?>
22
+} else { ?>
24 23
 	<tr>
25 24
 		<td><input name="name" type="text" value="<?php echo htmlspecialchars($Location->getName()); ?>" /></td>
26 25
 		<td><input name="action" type="text" value="<?php echo htmlspecialchars($Location->getAction()); ?>" /></td>
Please login to merge, or discard this patch.
templates/Default/engine/Default/includes/PlanetFullCombatResults.inc 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -4,8 +4,7 @@
 block discarded – undo
4 4
 		<h1>Attacker Results</h1><br /><?php
5 5
 	}
6 6
 	$this->includeTemplate('includes/PlanetTraderTeamCombatResults.inc', array('TraderTeamCombatResults'=>$FullPlanetCombatResults['Attackers'], 'MinimalDisplay'=>$MinimalDisplay));
7
-}
8
-else if (!$MinimalDisplay) {
7
+} else if (!$MinimalDisplay) {
9 8
 	?><span class="bold">The planet is already destroyed.</span><?php
10 9
 }
11 10
 ?><br /><?php
Please login to merge, or discard this patch.
engine/Default/bar_gambling_processing.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -180,7 +180,7 @@
 block discarded – undo
180 180
 	//heres the AIs cards
181 181
 	$i = 1;
182 182
 	if ((get_value($ai_card) == 21 && count($ai_card) == 2) ||
183
-	    (get_value($player_card) > 21 && get_value($ai_card) <= 21)) {
183
+		(get_value($player_card) > 21 && get_value($ai_card) <= 21)) {
184 184
 		$message .= ('<h1 class="red center">Bank Wins</h1>');
185 185
 	}
186 186
 	$message .= ('<div class="center">Bank\'s Cards are</div><br /><table class="center"><tr>');
Please login to merge, or discard this patch.