smrealms / smr

engine/Default/planet_financial_processing.php

Braces +1 added lines, -2 removed lines

@@ -28,8 +28,7 @@
 		$player->decreaseCredits($amount);
 		$planet->increaseCredits($amount);
 		$account->log(LOG_TYPE_BANK, 'Player puts ' . $amount . ' credits on planet', $player->getSectorID());
-	}
-	elseif ($action == 'Withdraw') {
+	} elseif ($action == 'Withdraw') {
 		if ($planet->getCredits() < $amount) {
 			create_error('There are not enough credits in the planetary account!');
 		}

engine/Default/course_plot_processing.php

Braces +10 added lines, -4 removed lines

@@ -1,9 +1,15 @@
 <?php declare(strict_types=1);
 
-if (isset($var['from'])) $start = $var['from'];
-else $start = trim($_POST['from']);
-if (isset($var['to'])) $target = $var['to'];
-else $target = trim($_POST['to']);
+if (isset($var['from'])) {
+	$start = $var['from'];
+} else {
+	$start = trim($_POST['from']);
+}
+if (isset($var['to'])) {
+	$target = $var['to'];
+} else {
+	$target = trim($_POST['to']);
+}
 
 // perform some basic checks on both numbers
 if (empty($start) || empty($target)) {

engine/Default/hall_of_fame_new.php

Braces +9 added lines, -8 removed lines

@@ -1,18 +1,21 @@ 
 <?php declare(strict_types=1);
 require_once(get_file_loc('hof.functions.inc'));
 $game_id = null;
-if (isset($var['game_id'])) $game_id = $var['game_id'];
+if (isset($var['game_id'])) {
+	$game_id = $var['game_id'];
+}
 
 if (empty($game_id)) {
 	$topic = 'All Time Hall of Fame';
-}
-else {
+} else {
 	$topic = 'Hall of Fame: ' . SmrGame::getGame($game_id)->getDisplayName();
 }
 $template->assign('PageTopic', $topic);
 
 $container = create_container('skeleton.php', 'hall_of_fame_player_detail.php');
-if (isset($game_id)) $container['game_id'] = $game_id;
+if (isset($game_id)) {
+	$container['game_id'] = $game_id;
+}
 $template->assign('PersonalHofHREF', SmrSession::getNewHREF($container));
 
 $db->query('SELECT type FROM hof_visibility WHERE visibility != ' . $db->escapeString(HOF_PRIVATE) . ' ORDER BY type');
@@ -35,8 +38,7 @@ 
 if (!isset($var['view'])) {
 	$categories = getHofCategories($hofTypes, $game_id, $account->getAccountID());
 	$template->assign('Categories', $categories);
-}
-else {
+} else {
 	$gameIDSql = ' AND game_id ' . (isset($game_id) ? '= ' . $db->escapeNumber($game_id) : 'IN (SELECT game_id FROM game WHERE end_time < ' . TIME . ' AND ignore_stats = ' . $db->escapeBoolean(false) . ')');
 
 	$vis = HOF_PUBLIC;
@@ -51,8 +53,7 @@ 
 		$statements = SmrAccount::getUserScoreCaseStatement($db);
 		$query = 'SELECT account_id, ' . $statements['CASE'] . ' amount FROM (SELECT account_id, type, SUM(amount) amount FROM player_hof WHERE type IN (' . $statements['IN'] . ')' . $gameIDSql . ' GROUP BY account_id,type) x GROUP BY account_id ORDER BY amount DESC, account_id ASC LIMIT 25';
 		$db->query($query);
-	}
-	else {
+	} else {
 		$db->query('SELECT visibility FROM hof_visibility WHERE type = ' . $db->escapeArray($viewType, false, true, ':', false) . ' LIMIT 1');
 		if ($db->nextRecord()) {
 			$vis = $db->getField('visibility');

engine/Default/current_sector.php

Braces +14 added lines, -9 removed lines

@@ -35,9 +35,13 @@ 
 
 foreach ($links as $key => $linkArray) {
 	if ($linkArray['ID'] > 0 && $linkArray['ID'] != $player->getSectorID()) {
-		if ($player->getLastSectorID() == $linkArray['ID']) $class = 'lastVisited';
-		else if (isset($unvisited[$linkArray['ID']])) $class = 'unvisited';
-		else $class = 'visited';
+		if ($player->getLastSectorID() == $linkArray['ID']) {
+			$class = 'lastVisited';
+		} else if (isset($unvisited[$linkArray['ID']])) {
+			$class = 'unvisited';
+		} else {
+			$class = 'visited';
+		}
 		$links[$key]['Class'] = $class;
 	}
 }
@@ -83,11 +87,9 @@ 
 	} else {
 		$protectionMessage = '<span class="blue">PROTECTION</span>: You are under <span class="green">NEWBIE</span> protection.';
 	}
-}
-elseif ($player->hasFederalProtection()) {
+} elseif ($player->hasFederalProtection()) {
 	$protectionMessage = '<span class="blue">PROTECTION</span>: You are under <span class="blue">FEDERAL</span> protection.';
-}
-elseif ($sector->offersFederalProtection()) {
+} elseif ($sector->offersFederalProtection()) {
 	$protectionMessage = '<span class="blue">PROTECTION</span>: You are <span class="red">NOT</span> under protection.';
 }
 
@@ -117,7 +119,9 @@ 
 }
 
 //error msgs take precedence
-if (isset($var['errorMsg'])) $template->assign('ErrorMessage', $var['errorMsg']);
+if (isset($var['errorMsg'])) {
+	$template->assign('ErrorMessage', $var['errorMsg']);
+}
 
 // *******************************************
 // *
@@ -152,8 +156,9 @@ 
 				$remainingTime = $db->getInt('refresh_at') - TIME;
 				$forceRefreshMessage = '<span class="green">REFRESH</span>: All forces will be refreshed in ' . $remainingTime . ' seconds.';
 				$db->query('REPLACE INTO sector_message (game_id, account_id, message) VALUES (' . $db->escapeNumber($player->getGameID()) . ', ' . $db->escapeNumber($player->getAccountID()) . ', \'[Force Check]\')');
+			} else {
+				$forceRefreshMessage = '<span class="green">REFRESH</span>: All forces have finished refreshing.';
 			}
-			else $forceRefreshMessage = '<span class="green">REFRESH</span>: All forces have finished refreshing.';
 			$template->assign('ForceRefreshMessage', $forceRefreshMessage);
 		}
 	}

engine/Default/feature_request_vote_processing.php

Braces +1 added lines, -2 removed lines

@@ -15,8 +15,7 @@
 	}
 
 	forward(create_container('skeleton.php', 'feature_request.php'));
-}
-else if ($_REQUEST['action'] == 'Set Status') {
+} else if ($_REQUEST['action'] == 'Set Status') {
 	if (empty($_REQUEST['status'])) {
 		create_error('You have to select a status to set');
 	}

engine/Default/bank_anon_detail_processing.php

Braces +3 added lines, -6 removed lines

@@ -21,8 +21,7 @@ 
 	$db->query('SELECT transaction_id FROM anon_bank_transactions WHERE game_id = ' . $db->escapeNumber($player->getGameID()) . ' AND anon_id = ' . $db->escapeNumber($account_num) . ' ORDER BY transaction_id DESC LIMIT 1');
 	if ($db->nextRecord()) {
 		$trans_id = $db->getInt('transaction_id') + 1;
-	}
-	else {
+	} else {
 		$trans_id = 1;
 	}
 	$db->query('INSERT INTO anon_bank_transactions (account_id, game_id, anon_id, transaction_id, transaction, amount, time) ' .
@@ -32,8 +31,7 @@ 
 
 	// log action
 	$account->log(LOG_TYPE_BANK, 'Deposits ' . $amount . ' credits in anonymous account #' . $account_num, $player->getSectorID());
-}
-else {
+} else {
 	$db->query('SELECT * FROM anon_bank WHERE anon_id = ' . $db->escapeNumber($account_num) . ' AND game_id = ' . $db->escapeNumber($player->getGameID()));
 	$db->nextRecord();
 	if ($db->getInt('amount') < $amount) {
@@ -42,8 +40,7 @@ 
 	$db->query('SELECT transaction_id FROM anon_bank_transactions WHERE game_id = ' . $db->escapeNumber($player->getGameID()) . ' AND anon_id = ' . $db->escapeNumber($account_num) . ' ORDER BY transaction_id DESC LIMIT 1');
 	if ($db->nextRecord()) {
 		$trans_id = $db->getInt('transaction_id') + 1;
-	}
-	else {
+	} else {
 		$trans_id = 1;
 	}
 	$db->query('INSERT INTO anon_bank_transactions (account_id, game_id, anon_id, transaction_id, transaction, amount, time)

engine/Default/planet_ownership_processing.php

Braces +2 added lines, -4 removed lines

@@ -22,8 +22,7 @@ 
 	$planet->removePassword();
 	$planet->update();
 	$account->log(LOG_TYPE_PLANETS, 'Player takes ownership of planet.', $player->getSectorID());
-}
-else if ($action == 'Rename') {
+} else if ($action == 'Rename') {
 	$name = trim($_REQUEST['name']);
 	if (empty($name)) {
 		create_error('You cannot leave your planet nameless!');
@@ -33,8 +32,7 @@ 
 	$planet->update();
 	$account->log(LOG_TYPE_PLANETS, 'Player renames planet to ' . $name . '.', $player->getSectorID());
 
-}
-else if ($action == 'Set Password') {
+} else if ($action == 'Set Password') {
 	// set password
 	$planet->setPassword($password);
 	$planet->update();

engine/Default/message_delete_processing.php

Braces +4 added lines, -8 removed lines

@@ -19,8 +19,7 @@ 
 			while ($db->nextRecord()) {
 				$message_id_list[] = $db->getInt('message_id');
 			}
-		}
-		else {
+		} else {
 			$message_id_list[] = $id;
 		}
 	}
@@ -29,20 +28,17 @@ 
 	} else {
 		$db->query('UPDATE message SET receiver_delete = ' . $db->escapeBoolean(true) . ' WHERE message_id IN (' . $db->escapeArray($message_id_list) . ')');
 	}
-}
-else {
+} else {
 	if ($var['folder_id'] == MSG_SCOUT) {
 		$db->query('UPDATE message SET receiver_delete = ' . $db->escapeBoolean(true) . '
 					WHERE account_id = ' . $db->escapeNumber($player->getAccountID()) . '
 						AND message_type_id = '.$db->escapeNumber($var['folder_id']) . '
 						AND game_id = ' . $db->escapeNumber($player->getGameID()));
-	}
-	else if ($var['folder_id'] == MSG_SENT) {
+	} else if ($var['folder_id'] == MSG_SENT) {
 		$db->query('UPDATE message SET sender_delete = ' . $db->escapeBoolean(true) . '
 					WHERE sender_id = ' . $db->escapeNumber($player->getAccountID()) . '
 						AND game_id = ' . $db->escapeNumber($player->getGameID()));
-	}
-	else {
+	} else {
 		$db->query('UPDATE message SET receiver_delete = ' . $db->escapeBoolean(true) . '
 					WHERE account_id = ' . $db->escapeNumber($player->getAccountID()) . '
 						AND game_id = ' . $db->escapeNumber($player->getGameID()) . '

lib/Album/album_functions.php

Braces +7 added lines, -8 removed lines

@@ -53,9 +53,9 @@ 
 
 			echo('<span style="font-size:85%;"><b>[' . date(defined('DATE_FULL_SHORT') ?DATE_FULL_SHORT:DEFAULT_DATE_FULL_SHORT, $created) . ']</b> Picture of <a href="?nick=' . urlencode($nick) . '">' . $nick . '</a> added</span><br />');
 		}
+	} else {
+			echo('<span style="font-size:85%;">no entries</span>');
 	}
-	else
-		echo('<span style="font-size:85%;">no entries</span>');
 	echo('</p>');
 }
 
@@ -87,8 +87,7 @@ 
 		$other = nl2br(stripslashes($db->getField('other')));
 		$page_views = $db->getInt('page_views');
 		$disabled = $db->getBoolean('disabled');
-	}
-	else {
+	} else {
 		echo('<h1>Error</h1>');
 		echo('This user doesn\'t have an entry in our album!');
 		return;
@@ -164,9 +163,9 @@ 
 
 	if (empty($website)) {
 		$website = 'N/A';
+	} else {
+			$website = '<a href="' . $website . '" target="_new">' . $website . '</a>';
 	}
-	else
-		$website = '<a href="' . $website . '" target="_new">' . $website . '</a>';
 	echo('<tr>');
 	echo('<td class="right bold" width="10%">Website:</td><td>' . $website . '</td>');
 	echo('</tr>');
@@ -225,9 +224,9 @@ 
 		echo('</tr>');
 		echo('</table>');
 		echo('</form>');
+	} else {
+			echo('<p>Please <a href="/login.php?return_page=/album/?nick=' . urlencode($nick) . '"><u>login</u></a> if you want comment on this picture!</p>');
 	}
-	else
-		echo('<p>Please <a href="/login.php?return_page=/album/?nick=' . urlencode($nick) . '"><u>login</u></a> if you want comment on this picture!</p>');
 
 	echo('</td>');
 	echo('</tr>');