Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Pull Request — master (#1031)
by Dan
05:03
created
src/tools/npc/npc.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
 		}
117 117
 
118 118
 		try {
119
-			$TRADE_ROUTE =& $GLOBALS['TRADE_ROUTE'];
119
+			$TRADE_ROUTE = & $GLOBALS['TRADE_ROUTE'];
120 120
 			debug('Action #' . $actions);
121 121
 
122 122
 			//We have to reload player on each loop
@@ -140,14 +140,14 @@  discard block
 block discarded – undo
140 140
 			}
141 141
 
142 142
 			if (!isset($TRADE_ROUTE)) { //We only want to change trade route if there isn't already one set.
143
-				$TRADE_ROUTES =& findRoutes($player);
144
-				$TRADE_ROUTE =& changeRoute($TRADE_ROUTES);
143
+				$TRADE_ROUTES = & findRoutes($player);
144
+				$TRADE_ROUTE = & changeRoute($TRADE_ROUTES);
145 145
 			}
146 146
 
147 147
 			if ($player->isDead()) {
148 148
 				debug('Some evil person killed us, let\'s move on now.');
149 149
 				$previousContainer = null; //We died, we don't care what we were doing beforehand.
150
-				$TRADE_ROUTE =& changeRoute($TRADE_ROUTES); //Change route
150
+				$TRADE_ROUTE = & changeRoute($TRADE_ROUTES); //Change route
151 151
 				processContainer(Page::create('death_processing.php'));
152 152
 			}
153 153
 			if ($player->getNewbieTurns() <= NEWBIE_TURNS_WARNING_LIMIT && $player->getNewbieWarning()) {
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
223 223
 								processContainer(tradeGoods($goodID, $player, $port));
224 224
 							} else {
225 225
 								//Move to next route or fed.
226
-								if (($TRADE_ROUTE =& changeRoute($TRADE_ROUTES)) === false) {
226
+								if (($TRADE_ROUTE = & changeRoute($TRADE_ROUTES)) === false) {
227 227
 									debug('Changing Route Failed');
228 228
 									processContainer(plotToFed($player));
229 229
 								} else {
@@ -250,7 +250,7 @@  discard block
 block discarded – undo
250 250
 							processContainer(tradeGoods($goodID, $player, $port));
251 251
 						} else {
252 252
 							//Move to next route or fed.
253
-							if (($TRADE_ROUTE =& changeRoute($TRADE_ROUTES)) === false) {
253
+							if (($TRADE_ROUTE = & changeRoute($TRADE_ROUTES)) === false) {
254 254
 								debug('Changing Route Failed');
255 255
 								processContainer(plotToFed($player));
256 256
 							} else {
@@ -582,9 +582,9 @@  discard block
 block discarded – undo
582 582
 		return $false;
583 583
 	}
584 584
 	$routeKey = array_rand($tradeRoutes);
585
-	$tradeRoute =& $tradeRoutes[$routeKey];
585
+	$tradeRoute = & $tradeRoutes[$routeKey];
586 586
 	unset($tradeRoutes[$routeKey]);
587
-	$GLOBALS['TRADE_ROUTE'] =& $tradeRoute;
587
+	$GLOBALS['TRADE_ROUTE'] = & $tradeRoute;
588 588
 	debug('Switched route', $tradeRoute);
589 589
 	return $tradeRoute;
590 590
 }
Please login to merge, or discard this patch.
src/engine/Default/combat_simulator.php 1 patch
Spacing   +34 added lines, -34 removed lines patch added patch discarded remove patch
@@ -1,79 +1,79 @@  discard block
 block discarded – undo
1 1
 <?php declare(strict_types=1);
2
-$template->assign('PageTopic','Combat Simulator');
2
+$template->assign('PageTopic', 'Combat Simulator');
3 3
 
4
-$template->assign('EditDummysLink', Page::create('skeleton.php','edit_dummys.php')->href());
4
+$template->assign('EditDummysLink', Page::create('skeleton.php', 'edit_dummys.php')->href());
5 5
 $template->assign('DummyNames', DummyPlayer::getDummyPlayerNames());
6 6
 
7 7
 $duplicates = false;
8 8
 $usedNames = array();
9 9
 $realAttackers = array();
10 10
 $attackers = array();
11
-$i=1;
12
-if(isset($_POST['attackers']))
13
-	foreach($_POST['attackers'] as $attackerName) {
14
-		if($attackerName=='none')
11
+$i = 1;
12
+if (isset($_POST['attackers']))
13
+	foreach ($_POST['attackers'] as $attackerName) {
14
+		if ($attackerName == 'none')
15 15
 			continue;
16
-		if(isset($usedNames[$attackerName])) {
16
+		if (isset($usedNames[$attackerName])) {
17 17
 			$duplicates = true;
18 18
 			continue;
19 19
 		}
20 20
 		$usedNames[$attackerName] = true;
21
-		$attackers[$i] =& DummyPlayer::getCachedDummyPlayer($attackerName);
21
+		$attackers[$i] = & DummyPlayer::getCachedDummyPlayer($attackerName);
22 22
 		$attackers[$i]->setAllianceID(1);
23
-		$realAttackers[$i] =& $attackers[$i];
23
+		$realAttackers[$i] = & $attackers[$i];
24 24
 		++$i;
25 25
 	}
26 26
 
27
-for(;$i<=10;++$i)
27
+for (;$i <= 10; ++$i)
28 28
 	$attackers[$i] = null;
29
-$template->assign('Attackers',$attackers);
29
+$template->assign('Attackers', $attackers);
30 30
 
31
-$i=1;
31
+$i = 1;
32 32
 $realDefenders = array();
33 33
 $defenders = array();
34
-if(isset($_POST['defenders']))
35
-	foreach($_POST['defenders'] as $defenderName) {
36
-		if($defenderName=='none')
34
+if (isset($_POST['defenders']))
35
+	foreach ($_POST['defenders'] as $defenderName) {
36
+		if ($defenderName == 'none')
37 37
 			continue;
38
-		if(isset($usedNames[$defenderName])) {
38
+		if (isset($usedNames[$defenderName])) {
39 39
 			$duplicates = true;
40 40
 			continue;
41 41
 		}
42 42
 		$usedNames[$attackerName] = true;
43
-		$defenders[$i] =& DummyPlayer::getCachedDummyPlayer($defenderName);
43
+		$defenders[$i] = & DummyPlayer::getCachedDummyPlayer($defenderName);
44 44
 		$defenders[$i]->setAllianceID(2);
45
-		$realDefenders[$i] =& $defenders[$i];
45
+		$realDefenders[$i] = & $defenders[$i];
46 46
 		++$i;
47 47
 	}
48 48
 
49
-for(;$i<=10;++$i)
49
+for (;$i <= 10; ++$i)
50 50
 	$defenders[$i] = null;
51
-$template->assign('Defenders',$defenders);
51
+$template->assign('Defenders', $defenders);
52 52
 
53
-$template->assign('Duplicates',$duplicates);
53
+$template->assign('Duplicates', $duplicates);
54 54
 
55
-$template->assign('CombatSimHREF', Page::create('skeleton.php','combat_simulator.php')->href());
55
+$template->assign('CombatSimHREF', Page::create('skeleton.php', 'combat_simulator.php')->href());
56 56
 
57 57
 if (!empty($realAttackers) && !empty($realDefenders)) {
58
-	if(isset($_REQUEST['run'])) {
59
-		runAnAttack($realAttackers,$realDefenders);
58
+	if (isset($_REQUEST['run'])) {
59
+		runAnAttack($realAttackers, $realDefenders);
60 60
 	}
61
-	if(isset($_REQUEST['death_run'])) {
62
-		while(count($realAttackers)>0 && count($realDefenders)>0) {
63
-			runAnAttack($realAttackers,$realDefenders);
64
-			foreach($realAttackers as $key => &$teamPlayer) {
65
-				if($teamPlayer->isDead())
61
+	if (isset($_REQUEST['death_run'])) {
62
+		while (count($realAttackers) > 0 && count($realDefenders) > 0) {
63
+			runAnAttack($realAttackers, $realDefenders);
64
+			foreach ($realAttackers as $key => &$teamPlayer) {
65
+				if ($teamPlayer->isDead())
66 66
 					unset($realAttackers[$key]);
67 67
 			} unset($teamPlayer);
68
-			foreach($realDefenders as $key => &$teamPlayer) {
69
-				if($teamPlayer->isDead())
68
+			foreach ($realDefenders as $key => &$teamPlayer) {
69
+				if ($teamPlayer->isDead())
70 70
 					unset($realDefenders[$key]);
71 71
 			} unset($teamPlayer);
72 72
 		}
73 73
 	}
74 74
 }
75 75
 
76
-function runAnAttack($realAttackers,$realDefenders) {
76
+function runAnAttack($realAttackers, $realDefenders) {
77 77
 	global $template;
78 78
 	$results = array('Attackers' => array('Traders' => array(), 'TotalDamage' => 0),
79 79
 					'Defenders' => array('Traders' => array(), 'TotalDamage' => 0));
@@ -84,8 +84,8 @@  discard block
 block discarded – undo
84 84
 	}
85 85
 	foreach ($realDefenders as $accountID => $teamPlayer) {
86 86
 		$playerResults = $teamPlayer->shootPlayers($realAttackers);
87
-		$results['Defenders']['Traders'][]  = $playerResults;
87
+		$results['Defenders']['Traders'][] = $playerResults;
88 88
 		$results['Defenders']['TotalDamage'] += $playerResults['TotalDamage'];
89 89
 	}
90
-	$template->assign('TraderCombatResults',$results);
90
+	$template->assign('TraderCombatResults', $results);
91 91
 }
Please login to merge, or discard this patch.
src/lib/Default/smr.inc.php 1 patch
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -375,8 +375,9 @@
 block discarded – undo
375 375
 
376 376
 		if (!$player->isDead() && $player->getNewbieTurns() <= NEWBIE_TURNS_WARNING_LIMIT &&
377 377
 			$player->getNewbieWarning() &&
378
-			$var['url'] != 'newbie_warning_processing.php')
379
-			Page::create('newbie_warning_processing.php')->go();
378
+			$var['url'] != 'newbie_warning_processing.php') {
379
+					Page::create('newbie_warning_processing.php')->go();
380
+		}
380 381
 	}
381 382
 
382 383
 	// Initialize the template
Please login to merge, or discard this patch.
src/admin/Default/1.6/universe_create_planets.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@
 block discarded – undo
33 33
 
34 34
 // Form to make planet changes
35 35
 $container = Page::create('1.6/universe_create_save_processing.php',
36
-                              '1.6/universe_create_sectors.php', $var);
36
+							  '1.6/universe_create_sectors.php', $var);
37 37
 $template->assign('CreatePlanetsFormHREF', $container->href());
38 38
 
39 39
 // HREF to cancel and return to the previous page
Please login to merge, or discard this patch.
src/admin/Default/1.6/universe_create_locations.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -94,7 +94,7 @@
 block discarded – undo
94 94
 
95 95
 // Form to make location changes
96 96
 $container = Page::create('1.6/universe_create_save_processing.php',
97
-                              '1.6/universe_create_sectors.php', $var);
97
+							  '1.6/universe_create_sectors.php', $var);
98 98
 $template->assign('CreateLocationsFormHREF', $container->href());
99 99
 
100 100
 // HREF to cancel and return to the previous page
Please login to merge, or discard this patch.
src/admin/Default/enable_game_processing.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -7,4 +7,4 @@
 block discarded – undo
7 7
 $msg = '<span class="green">SUCCESS: </span>Enabled game ' . $game->getDisplayName();
8 8
 
9 9
 Page::create('skeleton.php', 'enable_game.php',
10
-             array('processing_msg' => $msg))->go();
10
+			 array('processing_msg' => $msg))->go();
Please login to merge, or discard this patch.