sminnee / silverstripe-framework

src/Forms/UploadReceiver.php

Doc Comments -1 removed lines

@@ -97,7 +97,6 @@
      * for each of these categories
      *
      * @param string $category Category name
-     * @param string,... $categories Additional category names
      * @return $this
      */
     public function setAllowedFileCategories($category)

tests/behat/features/bootstrap/SilverStripe/Framework/Test/Behaviour/CmsFormsContext.php

Doc Comments +1 added lines

@@ -32,6 +32,7 @@
 
     /**
      * Get Mink session from MinkContext
+     * @return \Behat\Mink\Session
      */
     public function getSession($name = null)
     {

tests/php/Core/ObjectTest/Extending.php

Doc Comments +17 added lines

@@ -12,11 +12,22 @@ 
         Extending_Extension::class,
     );
 
+    /**
+     * @param integer $first
+     * @param integer $second
+     * @param integer $third
+     */
     public function getResults(&$first, &$second, &$third)
     {
         // Before extending should be invoked second
         $this->beforeExtending(
             'updateResult',
+
+            /**
+             * @param integer $first
+             * @param integer $second
+             * @param integer $third
+             */
             function (&$first, &$second, &$third) {
                 if ($first === 1 && $second === 2 && $third === 3) {
                     $first = 11;
@@ -31,6 +42,12 @@ 
         // After extending should be invoked fourth
         $this->afterExtending(
             'updateResult',
+
+            /**
+             * @param integer $first
+             * @param integer $second
+             * @param integer $third
+             */
             function (&$first, &$second, &$third) {
                 if ($first === 21 && $second === 22 && $third = 23) {
                     $first = 31;

tests/php/Core/Startup/ErrorControlChainTest/ErrorControlChainTest_Chain.php

Doc Comments +5 added lines, -1 removed lines

@@ -31,7 +31,7 @@ 
     /**
      * Modify method visibility to public for testing
      *
-     * @param mixed $errors
+     * @param string $errors
      */
     public function setDisplayErrors($errors)
     {
@@ -40,6 +40,10 @@ 
     }
 
     // Change function visibility to be testable directly
+
+    /**
+     * @param string $memstring
+     */
     public function translateMemstring($memstring)
     {
         return parent::translateMemstring($memstring);

tests/php/Dev/CsvBulkLoaderTest.php

Doc Comments +3 added lines

@@ -271,6 +271,9 @@
     }
 
 
+    /**
+     * @param resource $file
+     */
     protected function getLineCount(&$file)
     {
         $i = 0;

tests/php/Forms/DropdownFieldTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -399,7 +399,7 @@
      * string of HTML.
      *
      * @param  string $html HTML to scan for elements
-     * @return SimpleXMLElement
+     * @return \SimpleXMLElement
      */
     public function findOptionElements($html)
     {

tests/php/Forms/GridField/GridField_URLHandlerTest/TestComponent_ItemRequest.php

Doc Comments +3 added lines

@@ -20,6 +20,9 @@
 
     protected $id;
 
+    /**
+     * @param string $link
+     */
     public function __construct($gridField, $id, $link)
     {
         $this->gridField = $gridField;

tests/php/Security/GroupTest/MemberForm.php

Doc Comments +4 added lines

@@ -9,6 +9,10 @@
 class MemberForm extends Form
 {
 
+    /**
+     * @param \SilverStripe\Control\Controller $controller
+     * @param string $name
+     */
     public function __construct($controller, $name)
     {
         $fields = TestMember::singleton()->getCMSFields();

tests/php/Security/SecurityTest.php

Doc Comments +4 added lines

@@ -676,6 +676,8 @@ 
     /**
      * Execute a log-in form using Director::test().
      * Helper method for the tests above
+     * @param string $email
+     * @param string $password
      */
     public function doTestLoginForm($email, $password, $backURL = 'test/link')
     {
@@ -697,6 +699,8 @@ 
 
     /**
      * Helper method to execute a change password form
+     * @param string $oldPassword
+     * @param string $newPassword
      */
     public function doTestChangepasswordForm($oldPassword, $newPassword)
     {

Unused Use Statements -3 removed lines

@@ -2,7 +2,6 @@ 
 
 namespace SilverStripe\Security\Tests;
 
-use PhpConsole\Auth;
 use SilverStripe\ORM\DataObject;
 use SilverStripe\ORM\FieldType\DBDatetime;
 use SilverStripe\ORM\FieldType\DBClassName;
@@ -13,11 +12,9 @@ 
 use SilverStripe\Security\Member;
 use SilverStripe\Security\MemberAuthenticator;
 use SilverStripe\Security\Security;
-use SilverStripe\Security\Permission;
 use SilverStripe\Core\Config\Config;
 use SilverStripe\Core\Convert;
 use SilverStripe\Dev\FunctionalTest;
-use SilverStripe\Dev\TestOnly;
 use SilverStripe\Control\HTTPResponse;
 use SilverStripe\Control\Session;
 use SilverStripe\Control\Director;