sminnee / silverstripe-framework

src/Security/BasicAuth.php

Unused Use Statements -1 removed lines

@@ -9,7 +9,6 @@
 use SilverStripe\Core\Config\Configurable;
 use SilverStripe\Dev\SapphireTest;
 use SilverStripe\Core\Injector\Injector;
-
 use SilverStripe\Security\MemberAuthenticator\Authenticator;
 
 /**

src/Security/MemberAuthenticator/Authenticator.php

Doc Comments +2 added lines, -1 removed lines

@@ -51,8 +51,8 @@ 
      * Attempt to find and authenticate member if possible from the given data
      *
      * @param array $data
-     * @param Form $form
      * @param bool &$success Success flag
+     * @param string $message
      * @return Member Found member, regardless of successful login
      */
     protected function authenticateMember($data, &$message, &$success)
@@ -192,6 +192,7 @@ 
 
     /**
      * @inherit
+     * @param string $link
      */
     public function getLoginHandler($link)
     {

src/Security/Security.php

Doc Comments +10 added lines, -5 removed lines

@@ -561,8 +561,7 @@ 
     /**
      * Combine the given forms into a formset with a tabbed interface
      *
-     * @param array $authenticators List of Authenticator instances
-     * @return string
+     * @return \SilverStripe\ORM\FieldType\DBHTMLText
      */
     protected function generateLoginFormSet($forms)
     {
@@ -628,6 +627,7 @@ 
      * For multiple authenticators, Security_MultiAuthenticatorLogin is used.
      * See getTemplatesFor and getIncludeTemplate for how to override template logic
      *
+     * @param HTTPRequest $request
      * @return string|HTTPResponse Returns the "login" page as HTML code.
      */
     public function login($request)
@@ -658,6 +658,10 @@ 
         $handlers = $authenticators;
         array_walk(
             $handlers,
+
+            /**
+             * @param HTTPRequest $auth
+             */
             function (&$auth, $name) use ($link) {
                 $auth = $auth->getLoginHandler(Controller::join_links($link, $name));
             }
@@ -745,7 +749,7 @@ 
 
     /**
      * Render the given fragments into a security page controller with the given title.
-     * @param $title string The title to give the security page
+     * @param string $title string The title to give the security page
      * @param $fragments A map of objects to render into the page, e.g. "Form"
      * @param $templates An array of templates to use for the render
      */
@@ -912,7 +916,7 @@ 
      * Factory method for the lost password form
      *
      * @skipUpgrade
-     * @return ChangePasswordForm Returns the lost password form
+     * @return MemberAuthenticator\ChangePasswordForm Returns the lost password form
      */
     public function ChangePasswordForm()
     {
@@ -1197,6 +1201,7 @@ 
 
     /**
      * For the database_is_ready call to return a certain value - used for testing
+     * @param boolean $isReady
      */
     public static function force_database_is_ready($isReady)
     {
@@ -1240,7 +1245,7 @@ 
     /**
      * Set to true to ignore access to disallowed actions, rather than returning permission failure
      * Note that this is just a flag that other code needs to check with Security::ignore_disallowed_actions()
-     * @param $flag True or false
+     * @param boolean $flag True or false
      */
     public static function set_ignore_disallowed_actions($flag)
     {

tests/php/Security/MemberAuthenticatorTest.php

Unused Use Statements -5 removed lines

@@ -2,11 +2,7 @@ 
 
 namespace SilverStripe\Security\Tests;
 
-use SilverStripe\ORM\DataObject;
 use SilverStripe\ORM\FieldType\DBDatetime;
-use SilverStripe\ORM\ValidationResult;
-use SilverStripe\Security\PasswordEncryptor;
-use SilverStripe\Security\PasswordEncryptor_PHPHash;
 use SilverStripe\Security\Security;
 use SilverStripe\Security\Member;
 use SilverStripe\Security\MemberAuthenticator\Authenticator;
@@ -14,7 +10,6 @@ 
 use SilverStripe\Security\CMSMemberLoginForm;
 use SilverStripe\Core\Config\Config;
 use SilverStripe\Dev\SapphireTest;
-use SilverStripe\Forms\FieldList;
 use SilverStripe\Forms\Form;
 use SilverStripe\Control\HTTPRequest;
 

tests/php/Security/MemberTest.php

Unused Use Statements -1 removed lines

@@ -11,7 +11,6 @@
 use SilverStripe\ORM\DB;
 use SilverStripe\ORM\FieldType\DBDatetime;
 use SilverStripe\Security\Member;
-use SilverStripe\Security\MemberAuthenticator;
 use SilverStripe\Security\Security;
 use SilverStripe\Security\MemberPassword;
 use SilverStripe\Security\Group;