sminnee / silverstripe-framework

tests/php/Forms/NumericFieldTest.php

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use SilverStripe\Dev\SapphireTest;
 use SilverStripe\Forms\NumericField;
 use SilverStripe\Forms\RequiredFields;
-use SilverStripe\i18n\i18n;
 
 class NumericFieldTest extends SapphireTest
 {

tests/php/View/SSViewerCacheBlockTest.php

Doc Comments +3 added lines

@@ -41,6 +41,9 @@
         Injector::inst()->get(CacheInterface::class . '.cacheblock')->clear();
     }
 
+    /**
+     * @param string $template
+     */
     protected function _runtemplate($template, $data = null)
     {
         if ($data === null) {

src/Core/Manifest/Module.php

Doc Comments +4 added lines

@@ -28,6 +28,10 @@
      */
     protected $composerData = null;
 
+    /**
+     * @param string $path
+     * @param string $base
+     */
     public function __construct($path, $base)
     {
         $this->path = rtrim($path, '/\\');

src/Dev/FunctionalTest.php

Doc Comments +2 added lines, -2 removed lines

@@ -226,7 +226,7 @@ 
      * Find an attribute in a SimpleXMLElement object by name.
      * @param SimpleXMLElement $object
      * @param string $attribute Name of attribute to find
-     * @return SimpleXMLElement object of the attribute
+     * @return boolean object of the attribute
      */
     public function findAttribute($object, $attribute)
     {
@@ -260,7 +260,7 @@ 
      * Note:   characters are stripped from the content; make sure that your assertions take this into account.
      *
      * @param string $selector A basic CSS selector, e.g. 'li.jobs h3'
-     * @param array|string $expectedMatches The content of at least one of the matched tags
+     * @param string[] $expectedMatches The content of at least one of the matched tags
      * @param string $message
      * @throws PHPUnit_Framework_AssertionFailedError
      */

src/Dev/SapphireTest.php

Unused Use Statements -3 removed lines

@@ -14,8 +14,6 @@ 
 use SilverStripe\Core\ClassInfo;
 use SilverStripe\Core\Config\ConfigLoader;
 use SilverStripe\Core\Config\CoreConfigFactory;
-use SilverStripe\Core\Config\DefaultConfig;
-use SilverStripe\Core\Config\Middleware\ExtensionMiddleware;
 use SilverStripe\Core\Flushable;
 use SilverStripe\Core\Injector\Injector;
 use SilverStripe\Core\Manifest\ClassManifest;
@@ -38,7 +36,6 @@ 
 use SilverStripe\View\ThemeResourceLoader;
 use SilverStripe\View\ThemeManifest;
 use PHPUnit_Framework_TestCase;
-use Translatable;
 use LogicException;
 use Exception;
 

Doc Comments +8 added lines, -5 removed lines

@@ -184,6 +184,9 @@ 
         return self::$is_running_test;
     }
 
+    /**
+     * @param boolean $bool
+     */
     public static function set_is_running_test($bool)
     {
         self::$is_running_test = $bool;
@@ -662,10 +665,10 @@ 
     /**
      * Assert that the matching email was sent since the last call to clearEmails()
      * All of the parameters can either be a string, or, if they start with "/", a PREG-compatible regular expression.
-     * @param $to
+     * @param string $to
      * @param $from
-     * @param $subject
-     * @param $content
+     * @param string $subject
+     * @param string $content
      * @return array Contains the keys: 'type', 'to', 'from', 'subject', 'content', 'plainContent', 'attachedFiles',
      *               'customHeaders', 'htmlContent', inlineImages'
      */
@@ -898,7 +901,7 @@ 
      * @param string $expectedSQL
      * @param string $actualSQL
      * @param string $message
-     * @param float|int $delta
+     * @param integer $delta
      * @param integer $maxDepth
      * @param boolean $canonicalize
      * @param boolean $ignoreCase
@@ -1186,7 +1189,7 @@ 
      * Create a member and group with the given permission code, and log in with it.
      * Returns the member ID.
      *
-     * @param string|array $permCode Either a permission, or list of permissions
+     * @param string $permCode Either a permission, or list of permissions
      * @return int Member ID
      */
     public function logInWithPermission($permCode = "ADMIN")

src/Forms/FormRequestHandler.php

Doc Comments +1 added lines, -1 removed lines

@@ -388,7 +388,7 @@
     /**
      * Fields can have action to, let's check if anyone of the responds to $funcname them
      *
-     * @param SS_List|array $fields
+     * @param FieldList $fields
      * @param callable $funcName
      * @return FormField
      */

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use BadMethodCallException;
 use SilverStripe\Control\Controller;
-use SilverStripe\Control\Director;
 use SilverStripe\Control\HTTPRequest;
 use SilverStripe\Control\HTTPResponse;
 use SilverStripe\Control\HTTPResponse_Exception;

src/Security/PasswordEncryptor_Blowfish.php

Doc Comments +5 added lines

@@ -165,6 +165,11 @@
         return sprintf('%02d', self::$cost) . '$' . substr($generator->randomToken('sha1'), 0, 22);
     }
 
+    /**
+     * @param string|false $hash
+     * @param string $password
+     * @param string $salt
+     */
     public function check($hash, $password, $salt = null, $member = null)
     {
         if (strpos($hash, '$2y$') === 0) {

tests/php/Control/ControllerTest.php

Unused Use Statements -2 removed lines

@@ -3,8 +3,6 @@
 namespace SilverStripe\Control\Tests;
 
 use InvalidArgumentException;
-use PHPUnit_Framework_Error;
-use SilverStripe\Control\RequestHandler;
 use SilverStripe\Control\Tests\ControllerTest\AccessBaseController;
 use SilverStripe\Control\Tests\ControllerTest\AccessSecuredController;
 use SilverStripe\Control\Tests\ControllerTest\AccessWildcardSecuredController;

tests/php/Forms/FormFieldTest.php

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use SilverStripe\Core\Config\Config;
 use SilverStripe\Core\ClassInfo;
 use SilverStripe\Dev\SapphireTest;
-use SilverStripe\Control\Controller;
 use SilverStripe\Forms\FormField;
 use SilverStripe\Forms\Tests\FormFieldTest\TestExtension;
 use SilverStripe\Forms\TextField;