sminnee / silverstripe-framework

src/Dev/FunctionalTest.php

Doc Comments +2 added lines, -2 removed lines

@@ -226,7 +226,7 @@ 
      * Find an attribute in a SimpleXMLElement object by name.
      * @param SimpleXMLElement $object
      * @param string $attribute Name of attribute to find
-     * @return SimpleXMLElement object of the attribute
+     * @return boolean object of the attribute
      */
     public function findAttribute($object, $attribute)
     {
@@ -260,7 +260,7 @@ 
      * Note:   characters are stripped from the content; make sure that your assertions take this into account.
      *
      * @param string $selector A basic CSS selector, e.g. 'li.jobs h3'
-     * @param array|string $expectedMatches The content of at least one of the matched tags
+     * @param string[] $expectedMatches The content of at least one of the matched tags
      * @param string $message
      * @throws PHPUnit_Framework_AssertionFailedError
      */

tests/php/Core/Manifest/ManifestFileFinderTest.php

Doc Comments +5 added lines

@@ -19,6 +19,11 @@
         parent::__construct();
     }
 
+    /**
+     * @param ManifestFileFinder $finder
+     * @param null|string $base
+     * @param string[] $expect
+     */
     public function assertFinderFinds($finder, $base, $expect, $message = null)
     {
         if (!$base) {

src/Control/Controller.php

Unused Use Statements -1 removed lines

@@ -8,7 +8,6 @@
 use SilverStripe\ORM\DataModel;
 use SilverStripe\ORM\FieldType\DBHTMLText;
 use SilverStripe\Security\BasicAuth;
-use SilverStripe\Security\Member;
 use SilverStripe\Security\Security;
 use SilverStripe\View\SSViewer;
 use SilverStripe\View\TemplateGlobalProvider;

src/Core/ClassInfo.php

Doc Comments +3 added lines

@@ -310,6 +310,9 @@
 
     private static $method_from_cache = array();
 
+    /**
+     * @param string $method
+     */
     public static function has_method_from($class, $method, $compclass)
     {
         $lClass = strtolower($class);

src/Dev/CSVParser.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use SilverStripe\Core\Injector\Injectable;
 use Iterator;
-
 use SilverStripe\Control\Director;
 
 /**

src/Forms/ConfirmedPasswordField.php

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 use SilverStripe\ORM\DataObjectInterface;
 use SilverStripe\Security\Member;
 use SilverStripe\Security\Security;
-use SilverStripe\View\Requirements;
 
 /**
  * Two masked input fields, checks for matching passwords.

src/ORM/DataQuery.php

Doc Comments +1 added lines, -1 removed lines

@@ -190,7 +190,7 @@
     /**
      * Ensure that the query is ready to execute.
      *
-     * @param array|null $queriedColumns Any columns to filter the query by
+     * @param string[] $queriedColumns Any columns to filter the query by
      * @return SQLSelect The finalised sql query
      */
     public function getFinalisedQuery($queriedColumns = null)

src/Security/IdentityStore.php

Doc Comments +2 added lines, -2 removed lines

@@ -18,7 +18,7 @@ 
      * @param Member $member The member to log in.
      * @param Boolean $persistent boolean If set to true, the login may persist beyond the current session.
      * @param HTTPRequest $request The request of the visitor that is logging in, to get, for example, cookies.
-     * @param HTTPResponse $response The response object to modify, if needed.
+     * @return void
      */
     public function logIn(Member $member, $persistent, HTTPRequest $request);
 
@@ -26,7 +26,7 @@ 
      * Log any logged-in member out of this identity store.
      *
      * @param HTTPRequest $request The request of the visitor that is logging out, to get, for example, cookies.
-     * @param HTTPResponse $response The response object to modify, if needed.
+     * @return void
      */
     public function logOut(HTTPRequest $request);
 }

tests/php/Core/Manifest/fixtures/namespaced_classmanifest/module/classes/ClassI.php

Unused Use Statements +1 added lines, -3 removed lines

@@ -6,11 +6,9 @@
 /** @skipUpgrade */
 use SilverStripe\Admin\ModelAdmin;
 /** @skipUpgrade */
-use SilverStripe\Control\Controller  as  Cont ;
 /** @skipUpgrade */
-use SilverStripe\Control\HTTPRequest as Request, SilverStripe\Control\HTTPResponse as Response, SilverStripe\Security\PermissionProvider as P;
+use SilverStripe\Security\PermissionProvider as P;
 /** @skipUpgrade */
-use silverstripe\test\ClassA;
 /** @skipUpgrade */
 use \SilverStripe\Core\ClassInfo;