sminnee / silverstripe-framework

tests/forms/uploadfield/AssetFieldTest.php

Doc Comments +4 added lines, -2 removed lines

@@ -298,7 +298,6 @@ 
 	 * Simulates a form post to the test controller with the specified file tuple (Filename, Hash, Variant)
 	 *
 	 * @param string $fileField Name of field to assign ids to
-	 * @param array $ids list of file IDs
 	 * @return boolean Array with key 'errors'
 	 */
 	protected function mockUploadFileSave($fileField, $filename, $hash, $variant = null) {
@@ -328,7 +327,7 @@ 
 	 * Simulates a file upload
 	 *
 	 * @param string $fileField Name of the field to mock upload for
-	 * @param array $tmpFileName Name of temporary file to upload
+	 * @param string $tmpFileName Name of temporary file to upload
 	 * @return SS_HTTPResponse form response
 	 */
 	protected function mockFileUpload($fileField, $tmpFileName) {
@@ -360,6 +359,9 @@ 
 		return $this->record;
 	}
 
+	/**
+	 * @param AssetFieldTest_Controller $controller
+	 */
 	function __construct($controller = null, $name = 'Form') {
 		if(empty($controller)) {
 			$controller = new AssetFieldTest_Controller();

tests/forms/uploadfield/UploadFieldTest.php

Doc Comments +7 added lines, -1 removed lines

@@ -936,7 +936,7 @@ 
 	 * Simulates a file upload
 	 *
 	 * @param string $fileField Name of the field to mock upload for
-	 * @param array $tmpFileName Name of temporary file to upload
+	 * @param string $tmpFileName Name of temporary file to upload
 	 * @return SS_HTTPResponse form response
 	 */
 	protected function mockFileUpload($fileField, $tmpFileName) {
@@ -948,6 +948,9 @@ 
 		);
 	}
 
+	/**
+	 * @param string $fileField
+	 */
 	protected function mockFileExists($fileField, $fileName) {
 		return $this->get(
 			"UploadFieldTest_Controller/Form/field/{$fileField}/fileexists?filename=".urlencode($fileName)
@@ -1075,6 +1078,9 @@ 
 		return $this->record;
 	}
 
+	/**
+	 * @param UploadFieldTest_Controller $controller
+	 */
 	function __construct($controller = null, $name = 'Form') {
 		if(empty($controller)) {
 			$controller = new UploadFieldTest_Controller();

tests/security/SecurityTest.php

Doc Comments +4 added lines

@@ -580,6 +580,8 @@ 
 	/**
 	 * Execute a log-in form using Director::test().
 	 * Helper method for the tests above
+	 * @param string $email
+	 * @param string $password
 	 */
 	public function doTestLoginForm($email, $password, $backURL = 'test/link') {
 		$this->get(Config::inst()->get('Security', 'logout_url'));
@@ -600,6 +602,8 @@ 
 
 	/**
 	 * Helper method to execute a change password form
+	 * @param string $oldPassword
+	 * @param string $newPassword
 	 */
 	public function doTestChangepasswordForm($oldPassword, $newPassword) {
 		return $this->submitForm(

admin/code/LeftAndMain.php

Doc Comments +7 added lines, -3 removed lines

@@ -191,7 +191,7 @@ 
 	/**
 	 * Gets the combined configuration of all LeafAndMain subclasses required by the client app.
 	 *
-	 * @return array
+	 * @return string
 	 *
 	 * WARNING: Experimental API
 	 */
@@ -881,6 +881,7 @@ 
 	 * Return a list of appropriate templates for this class, with the given suffix using
 	 * {@link SSViewer::get_templates_by_class()}
 	 *
+	 * @param string $suffix
 	 * @return array
 	 */
 	public function getTemplatesWithSuffix($suffix) {
@@ -1750,7 +1751,7 @@ 
 	 * The controller might not have any previewable content, in which case
 	 * this method returns FALSE.
 	 *
-	 * @return String|boolean
+	 * @return boolean
 	 */
 	public function LinkPreview() {
 		return false;
@@ -1937,7 +1938,7 @@ 
 	}
 
 	/**
-	 * @return String
+	 * @return DBField
 	 */
 	public function Locale() {
 		return DBField::create_field('Locale', i18n::get_locale());
@@ -2103,6 +2104,9 @@ 
 		return (parent::isFinished() || $this->isFinished);
 	}
 
+	/**
+	 * @param boolean $bool
+	 */
 	public function setIsFinished($bool) {
 		$this->isFinished = $bool;
 	}

admin/code/CampaignAdmin.php

Doc Comments +5 added lines, -5 removed lines

@@ -194,7 +194,7 @@ 
 	/**
 	 * REST endpoint to get a list of campaigns.
 	 *
-	 * @param SS_HTTPRequest $request
+	 * @param HTTPRequest $request
 	 *
 	 * @return HTTPResponse
 	 */
@@ -335,7 +335,7 @@ 
 	/**
 	 * Gets viewable list of campaigns
 	 *
-	 * @return SS_List
+	 * @return SilverStripe\Model\ArrayList
 	 */
 	protected function getListItems() {
 		return ChangeSet::get()
@@ -349,7 +349,7 @@ 
 	/**
 	 * REST endpoint to get a campaign.
 	 *
-	 * @param SS_HTTPRequest $request
+	 * @param HTTPRequest $request
 	 *
 	 * @return HTTPResponse
 	 */
@@ -382,7 +382,7 @@ 
 	/**
 	 * REST endpoint to delete a campaign.
 	 *
-	 * @param SS_HTTPRequest $request
+	 * @param HTTPRequest $request
 	 *
 	 * @return HTTPResponse
 	 */
@@ -409,7 +409,7 @@ 
 	/**
 	 * REST endpoint to publish a {@link ChangeSet} and all of its items.
 	 *
-	 * @param SS_HTTPRequest $request
+	 * @param HTTPRequest $request
 	 *
 	 * @return HTTPResponse
 	 */

control/Controller.php

Doc Comments +5 added lines, -5 removed lines

@@ -143,7 +143,7 @@ 
 	 * $this->pushCurrent() and end the method with $this->popCurrent(). Failure to do this will create
 	 * weird session errors.
 	 *
-	 * @param SS_HTTPRequest $request
+	 * @param HTTPRequest $request
 	 * @param DataModel $model
 	 *
 	 * @return HTTPResponse
@@ -281,7 +281,7 @@ 
 	/**
 	 * Sets the SS_HTTPResponse object that this controller is building up.
 	 *
-	 * @param SS_HTTPResponse $response
+	 * @param HTTPResponse $response
 	 *
 	 * @return $this
 	 */
@@ -322,7 +322,7 @@ 
 	 *
 	 * @param string $action
 	 *
-	 * @return HTMLText
+	 * @return \SilverStripe\Model\FieldType\DBField
 	 */
 	public function defaultAction($action) {
 		return $this->getViewer($action)->process($this);
@@ -458,7 +458,7 @@ 
 	 *
 	 * @param array $params
 	 *
-	 * @return string
+	 * @return \SilverStripe\Model\FieldType\DBField
 	 */
 	public function render($params = null) {
 		$template = $this->getViewer($this->getAction());
@@ -623,7 +623,7 @@ 
 	 * Tests whether a redirection has been requested. If redirect() has been called, it will return
 	 * the URL redirected to. Otherwise, it will return null.
 	 *
-	 * @return null|string
+	 * @return boolean
 	 */
 	public function redirectedTo() {
 		return $this->getResponse() && $this->getResponse()->getHeader('Location');

Unused Use Statements -2 removed lines

@@ -4,11 +4,9 @@
 
 use Deprecation;
 use SQLExpression;
-
 use InvalidArgumentException;
 use Config;
 use LogicException;
-
 use Injector;
 use SilverStripe\Model\Connect\Database;
 use SilverStripe\Control\Director;

control/Director.php

Doc Comments +5 added lines, -5 removed lines

@@ -278,7 +278,7 @@ 
 	 * @param array|Cookie_Backend $cookies to populate $_COOKIE.
 	 * @param HTTP_Request $request The {@see HTTP_Request} object generated as a part of this request.
 	 *
-	 * @return SilverStripe\Control\HTTPResponse
+	 * @return HTTPResponse
 	 *
 	 * @throws SilverStripe\Control\HTTPResponse_Exception
 	 */
@@ -414,7 +414,7 @@ 
 	/**
 	 * Handle an HTTP request, defined with a SS_HTTPRequest object.
 	 *
-	 * @param SS_HTTPRequest $request
+	 * @param HTTPRequest $request
 	 * @param Session $session
 	 * @param DataModel $model
 	 *
@@ -560,7 +560,7 @@ 
 	 * Returns the domain part of the URL 'http://www.mysite.com'. Returns FALSE is this environment
 	 * variable isn't set.
 	 *
-	 * @return bool|string
+	 * @return string|false
 	 */
 	public static function protocolAndHost() {
 		$alternate = Config::inst()->get('SilverStripe\Control\Director', 'alternate_base_url');
@@ -893,7 +893,7 @@ 
 	/**
 	 * Returns true if the given file exists. Filename should be relative to the site root.
 	 *
-	 * @param $file
+	 * @param string $file
 	 *
 	 * @return bool
 	 */
@@ -1111,7 +1111,7 @@ 
 	 * Can also be checked with {@link Director::isDev()}, {@link Director::isTest()}, and
 	 * {@link Director::isLive()}.
 	 *
-	 * @return bool|string
+	 * @return string|false
 	 */
 	public static function get_environment_type() {
 		if (Director::isLive()) {

control/HTTPRequest.php

Doc Comments +10 added lines, -10 removed lines

@@ -131,7 +131,7 @@ 
 	 *
 	 * @param string The new URL
 	 *
-	 * @return SS_HTTPRequest The updated request
+	 * @return HTTPRequest The updated request
 	 */
 	public function setUrl($url) {
 		$this->url = $url;
@@ -187,7 +187,7 @@ 
 
 	/**
 	 * @param string $body
-	 * @return SS_HTTPRequest $this
+	 * @return HTTPRequest $this
 	 */
 	public function setBody($body) {
 		$this->body = $body;
@@ -195,7 +195,7 @@ 
 	}
 
 	/**
-	 * @return null|string
+	 * @return string
 	 */
 	public function getBody() {
 		return $this->body;
@@ -244,7 +244,7 @@ 
 
 	/**
 	 * @param string $name
-	 * @return mixed
+	 * @return string
 	 */
 	public function requestVar($name) {
 		if(isset($this->postVars[$name])) return $this->postVars[$name];
@@ -297,7 +297,7 @@ 
 	 * Remove an existing HTTP header
 	 *
 	 * @param string $header
-	 * @return mixed
+	 * @return string
 	 */
 	public function getHeader($header) {
 		return (isset($this->headers[$header])) ? $this->headers[$header] : null;
@@ -308,7 +308,7 @@ 
 	 * e.g. "Content-Type".
 	 *
 	 * @param string $header
-	 * @return SS_HTTPRequest $this
+	 * @return HTTPRequest $this
 	 */
 	public function removeHeader($header) {
 		if(isset($this->headers[$header])) unset($this->headers[$header]);
@@ -394,9 +394,9 @@ 
 	 * it's only advisable to send small files through this method.
 	 *
 	 * @static
-	 * @param $fileData
+	 * @param string $fileData
 	 * @param $fileName
-	 * @param null $mimeType
+	 * @param string $mimeType
 	 * @return HTTPResponse
 	 */
 	public static function send_file($fileData, $fileName, $mimeType = null) {
@@ -571,7 +571,7 @@ 
 
 	/**
 	 * @param $params
-	 * @return SS_HTTPRequest $this
+	 * @return HTTPRequest $this
 	 */
 	public function setRouteParams($params) {
 		$this->routeParams = $params;
@@ -614,7 +614,7 @@ 
 	 * This is used by the request handler to prevent infinite parsing loops.
 	 *
 	 * @param $pattern
-	 * @return bool
+	 * @return boolean|null
 	 */
 	public function isEmptyPattern($pattern) {
 		if(preg_match('/^([A-Za-z]+) +(.*)$/', $pattern, $matches)) {

control/HTTPResponse.php

Doc Comments +9 added lines, -8 removed lines

@@ -120,7 +120,7 @@ 
 	 *  No newlines are allowed in the description.
 	 *  If omitted, will default to the standard HTTP description
 	 *  for the given $code value (see {@link $status_codes}).
-	 * @return SS_HTTPRequest $this
+	 * @return HTTPResponse $this
 	 */
 	public function setStatusCode($code, $description = null) {
 		if(isset(self::$status_codes[$code])) $this->statusCode = $code;
@@ -136,7 +136,7 @@ 
 	 * Caution: Will be overwritten by {@link setStatusCode()}.
 	 *
 	 * @param string $description
-	 * @return SS_HTTPRequest $this
+	 * @return HTTPResponse $this
 	 */
 	public function setStatusDescription($description) {
 		$this->statusDescription = $description;
@@ -168,7 +168,7 @@ 
 
 	/**
 	 * @param string $body
-	 * @return SS_HTTPRequest $this
+	 * @return HTTPResponse $this
 	 */
 	public function setBody($body) {
 		$this->body = $body ? (string) $body : $body; // Don't type-cast false-ish values, eg null is null not ''
@@ -176,7 +176,7 @@ 
 	}
 
 	/**
-	 * @return null|string
+	 * @return string
 	 */
 	public function getBody() {
 		return $this->body;
@@ -187,7 +187,7 @@ 
 	 *
 	 * @param string $header Example: "Content-Type"
 	 * @param string $value Example: "text/xml"
-	 * @return SS_HTTPRequest $this
+	 * @return HTTPResponse $this
 	 */
 	public function addHeader($header, $value) {
 		$this->headers[$header] = $value;
@@ -217,7 +217,7 @@ 
 	 * e.g. "Content-Type".
 	 *
 	 * @param string $header
-	 * @return SS_HTTPRequest $this
+	 * @return HTTPResponse $this
 	 */
 	public function removeHeader($header) {
 		if(isset($this->headers[$header])) unset($this->headers[$header]);
@@ -227,7 +227,7 @@ 
 	/**
 	 * @param string $dest
 	 * @param int $code
-	 * @return SS_HTTPRequest $this
+	 * @return HTTPResponse $this
 	 */
 	public function redirect($dest, $code=302) {
 		if(!in_array($code, self::$redirect_codes)) $code = 302;
@@ -327,6 +327,7 @@ 
 	 * @param string|SS_HTTPResponse body Either the plaintext content of the error message, or an SS_HTTPResponse
 	 *                                     object representing it.  In either case, the $statusCode and
 	 *                                     $statusDescription will be the HTTP status of the resulting response.
+	 * @param string $statusDescription
 	 * @see SS_HTTPResponse::__construct();
 	 */
 	public function __construct($body = null, $statusCode = null, $statusDescription = null) {
@@ -356,7 +357,7 @@ 
 	}
 
 	/**
-	 * @param SS_HTTPResponse $response
+	 * @param HTTPResponse $response
 	 */
 	public function setResponse(HTTPResponse $response) {
 		$this->response = $response;