sminnee / silverstripe-framework

src/Security/MemberAuthenticator/LoginHandler.php

Unused Use Statements -2 removed lines

@@ -3,12 +3,10 @@
 namespace SilverStripe\Security\MemberAuthenticator;
 
 use SilverStripe\Control\Controller;
-use SilverStripe\Control\Cookie;
 use SilverStripe\Control\HTTPResponse;
 use SilverStripe\Control\Session;
 use SilverStripe\Control\RequestHandler;
 use SilverStripe\ORM\ValidationResult;
-use SilverStripe\Security\RememberLoginHash;
 use SilverStripe\Security\Security;
 use SilverStripe\Security\Member;
 use SilverStripe\Core\Injector\Injector;

src/Security/Security.php

Doc Comments +3 added lines, -2 removed lines

@@ -601,7 +601,7 @@ 
      * Combine the given forms into a formset with a tabbed interface
      *
      * @param $forms
-     * @return string
+     * @return \SilverStripe\ORM\FieldType\DBHTMLText
      */
     protected function generateLoginFormSet($forms)
     {
@@ -1241,6 +1241,7 @@ 
 
     /**
      * For the database_is_ready call to return a certain value - used for testing
+     * @param boolean $isReady
      */
     public static function force_database_is_ready($isReady)
     {
@@ -1284,7 +1285,7 @@ 
     /**
      * Set to true to ignore access to disallowed actions, rather than returning permission failure
      * Note that this is just a flag that other code needs to check with Security::ignore_disallowed_actions()
-     * @param $flag True or false
+     * @param boolean $flag True or false
      */
     public static function set_ignore_disallowed_actions($flag)
     {

src/View/Parsers/Diff.php

Doc Comments +1 added lines, -1 removed lines

@@ -161,7 +161,7 @@
     }
 
     /**
-     * @param string|bool|array $content If passed as an array, values will be concatenated with a comma.
+     * @param string $content If passed as an array, values will be concatenated with a comma.
      * @return array
      */
     public static function getHTMLChunks($content)

tests/behat/src/CmsUiContext.php

Doc Comments +1 added lines

@@ -479,6 +479,7 @@
      *
      * @When /^(?:|I )fill in the "(?P<field>(?:[^"]|\\")*)" dropdown with "(?P<value>(?:[^"]|\\")*)"$/
      * @When /^(?:|I )fill in "(?P<value>(?:[^"]|\\")*)" for the "(?P<field>(?:[^"]|\\")*)" dropdown$/
+     * @param string $field
      */
     public function theIFillInTheDropdownWith($field, $value)
     {

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 use Behat\Mink\Session;
 use Behat\Behat\Context\Context;
 use SilverStripe\BehatExtension\Context\MainContextAwareTrait;
-use SilverStripe\BehatExtension\Context\RetryableContextTrait;
 use SilverStripe\BehatExtension\Utility\StepHelper;
 
 /**

tests/php/Forms/GridField/GridFieldAddNewButtonTest.php

Doc Comments +3 added lines

@@ -88,6 +88,9 @@
         $this->mockButtonFragments($list, null);
     }
 
+    /**
+     * @param \SilverStripe\ORM\DataObject $parent
+     */
     protected function mockButtonFragments(SS_List $list, $parent = null)
     {
         $form = Form::create(

tests/php/Forms/ValidatorTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -19,7 +19,7 @@
     /**
      * Common method for setting up form, since that will always be a dependency for the validator.
      *
-     * @param    array $fieldNames
+     * @param    string[] $fieldNames
      * @return    Form
      */
     protected function getForm(array $fieldNames = array())

tests/php/Logging/HTTPOutputHandlerTest.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace SilverStripe\Logging\Tests;
 
 use Monolog\Handler\HandlerInterface;
-use PhpParser\Node\Scalar\MagicConst\Dir;
 use SilverStripe\Control\Director;
 use SilverStripe\Core\Injector\Injector;
 use SilverStripe\Dev\SapphireTest;

tests/php/Security/InheritedPermissionsTest/TestPermissionNode.php

Doc Comments +3 added lines

@@ -42,6 +42,9 @@
         return Injector::inst()->get(PermissionChecker::class.'.testpermissions');
     }
 
+    /**
+     * @param DataObject $member
+     */
     public function canEdit($member = null)
     {
         if (!$member) {

tests/php/View/SSViewerTest.php

Doc Comments +13 added lines

@@ -159,6 +159,10 @@ 
         ]);
     }
 
+    /**
+     * @param \SilverStripe\ORM\FieldType\DBHTMLText $result
+     * @param string[] $expected
+     */
     private function assertExpectedStrings($result, $expected)
     {
         foreach ($expected as $expectedStr) {
@@ -1089,6 +1093,10 @@ 
         $this->assertEquals('A A1 A1 i A1 ii A2 A3', $rationalisedResult);
     }
 
+    /**
+     * @param string $a
+     * @param string $b
+     */
     public function assertEqualIgnoringWhitespace($a, $b, $message = '')
     {
         $this->assertEquals(preg_replace('/\s+/', '', $a), preg_replace('/\s+/', '', $b), $message);
@@ -1817,6 +1825,11 @@ 
             $this->_renderWithSourceFileComments('SSViewerTestComments/'.$template['name'], $template['expected']);
         }
     }
+
+    /**
+     * @param string $name
+     * @param string $expected
+     */
     private function _renderWithSourceFileComments($name, $expected)
     {
         $viewer = new SSViewer(array($name));