sminnee / silverstripe-framework

src/Control/HTTPResponse.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace SilverStripe\Control;
 
 use InvalidArgumentException;
-use Monolog\Formatter\FormatterInterface;
 use Monolog\Handler\HandlerInterface;
 use SilverStripe\Core\Convert;
 use SilverStripe\Core\Injector\Injectable;

src/Control/Session.php

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use SilverStripe\Core\Config\Config;
 use SilverStripe\Core\Injector\Injectable;
 use SilverStripe\Core\Injector\Injector;
-use SilverStripe\Dev\Deprecation;
 
 /**
  * Handles all manipulation of the session.

src/Core/Injector/Injector.php

Doc Comments +4 added lines, -3 removed lines

@@ -371,7 +371,7 @@ 
      *
      * @param string $property
      *                the name of the property
-     * @param object $object
+     * @param string $object
      *                the object to be set
      * @return $this
      */
@@ -466,7 +466,7 @@ 
      *              The name of the service to update the definition for
      * @param string $property
      *              The name of the property to update.
-     * @param mixed $value
+     * @param string $value
      *              The value to set
      * @param boolean $append
      *              Whether to append (the default) when the property is an array
@@ -788,7 +788,7 @@ 
     /**
      * @deprecated 4.0.0:5.0.0 Use Injector::has() instead
      * @param $name
-     * @return string
+     * @return boolean
      */
     public function hasService($name)
     {
@@ -993,6 +993,7 @@ 
      *
      * @param string $name
      * @param mixed $argument,... arguments to pass to the constructor
+     * @param string $argument
      * @return mixed A new instance of the specified object
      */
     public function create($name, $argument = null)

src/Forms/DatetimeField.php

Doc Comments +6 added lines, -3 removed lines

@@ -138,7 +138,7 @@ 
     }
 
     /**
-     * @param $bool
+     * @param boolean $bool
      * @return $this
      */
     public function setHTML5($bool)
@@ -151,7 +151,7 @@ 
      * Assign value posted from form submission, based on {@link $datetimeFormat}.
      * When $html5=true, this needs to be normalised ISO format (with "T" separator).
      *
-     * @param mixed $value
+     * @param string $value
      * @param mixed $data
      * @return $this
      */
@@ -317,7 +317,7 @@ 
      * When $html5=true, assign value from ISO 8601 normalised string (with a "T" separator).
      * Falls back to an ISO 8601 string (with a whitespace separator).
      *
-     * @param mixed $value
+     * @param string $value
      * @param mixed $data
      * @return $this
      */
@@ -492,6 +492,9 @@ 
         return $this;
     }
 
+    /**
+     * @param boolean $bool
+     */
     public function setReadonly($bool)
     {
         parent::setReadonly($bool);

src/Forms/FormField.php

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use SilverStripe\Control\RequestHandler;
 use SilverStripe\Core\ClassInfo;
 use SilverStripe\Core\Convert;
-use SilverStripe\Dev\Deprecation;
 use SilverStripe\ORM\DataObject;
 use SilverStripe\ORM\DataObjectInterface;
 use SilverStripe\ORM\FieldType\DBField;

src/ORM/DatabaseAdmin.php

Unused Use Statements -1 removed lines

@@ -8,7 +8,6 @@
 use SilverStripe\Core\Manifest\ClassLoader;
 use SilverStripe\Dev\SapphireTest;
 use SilverStripe\Dev\TestOnly;
-use SilverStripe\Dev\Deprecation;
 use SilverStripe\Versioned\Versioned;
 use SilverStripe\Security\Security;
 use SilverStripe\Security\Permission;

src/ORM/DataObject.php

Doc Comments +9 added lines, -8 removed lines

@@ -2165,7 +2165,7 @@ 
      * Called by {@link __get()} and any getFieldName() methods you might create.
      *
      * @param string $field The name of the field
-     * @return mixed The field value
+     * @return string|null The field value
      */
     public function getField($field)
     {
@@ -2447,6 +2447,7 @@ 
 
     /**
      * {@inheritdoc}
+     * @param string $field
      */
     public function castingHelper($field)
     {
@@ -2552,7 +2553,7 @@ 
      * </code>
      *
      * @param string $methodName Method on the same object, e.g. {@link canEdit()}
-     * @param Member|int $member
+     * @param Member|null $member
      * @param array $context Optional context
      * @return boolean|null
      */
@@ -2575,7 +2576,7 @@ 
 
     /**
      * @param Member $member
-     * @return boolean
+     * @return boolean|string
      */
     public function canView($member = null)
     {
@@ -2588,7 +2589,7 @@ 
 
     /**
      * @param Member $member
-     * @return boolean
+     * @return boolean|string
      */
     public function canEdit($member = null)
     {
@@ -2601,7 +2602,7 @@ 
 
     /**
      * @param Member $member
-     * @return boolean
+     * @return boolean|string
      */
     public function canDelete($member = null)
     {
@@ -2616,7 +2617,7 @@ 
      * @param Member $member
      * @param array $context Additional context-specific data which might
      * affect whether (or where) this object could be created.
-     * @return boolean
+     * @return boolean|string
      */
     public function canCreate($member = null, $context = array())
     {
@@ -2731,7 +2732,7 @@ 
      * Traverses to a field referenced by relationships between data objects, returning the value
      * The path to the related field is specified with dot separated syntax (eg: Parent.Child.Child.FieldName)
      *
-     * @param $fieldName string
+     * @param string $fieldName string
      * @return string | null - will return null on a missing value
      */
     public function relField($fieldName)
@@ -2809,7 +2810,7 @@ 
      * @param string $callerClass The class of objects to be returned
      * @param string|array $filter A filter to be inserted into the WHERE clause.
      * Supports parameterised queries. See SQLSelect::addWhere() for syntax examples.
-     * @param string|array $sort A sort expression to be inserted into the ORDER
+     * @param string $sort A sort expression to be inserted into the ORDER
      * BY clause.  If omitted, self::$default_sort will be used.
      * @param string $join Deprecated 3.0 Join clause. Use leftJoin($table, $joinClause) instead.
      * @param string|array $limit A limit expression to be inserted into the LIMIT clause.

src/Security/CMSSecurity.php

Doc Comments +6 added lines

@@ -49,6 +49,9 @@ 
         return parent::login($request, Authenticator::CMS_LOGIN);
     }
 
+    /**
+     * @param string $action
+     */
     public function Link($action = null)
     {
         /** @skipUpgrade */
@@ -79,6 +82,9 @@ 
         return null;
     }
 
+    /**
+     * @param string $title
+     */
     public function getResponseController($title)
     {
         // Use $this to prevent use of Page to render underlying templates

src/Security/InheritedPermissions.php

Doc Comments +1 added lines, -1 removed lines

@@ -111,7 +111,7 @@
     /**
      * Global permissions required to edit
      *
-     * @param array $permissions
+     * @param string[] $permissions
      * @return $this
      */
     public function setGlobalEditPermissions($permissions)