TestPermissionNode::canDelete() - Code Metrics - Inspection of "I have no idea where to look for these errors. And..." - sminnee/silverstripe-framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — authenticator-refactor ( 16f104...61b037 )

by Simon

created 2017-05-20 08:29 UTC

TestPermissionNode::canDelete() A

↳ Parent: TestPermissionNode

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	4

Duplication

Lines	7
Ratio	100 %

Importance

Changes

Metric	Value
cc	2
eloc	4
nc	2
nop	1
dl	7
loc	7
rs	9.4285
c	0
b	0
f	0

<?php

namespace SilverStripe\Security\Test\InheritedPermissionsTest;

use SilverStripe\Core\Injector\Injector;
use SilverStripe\Dev\TestOnly;
use SilverStripe\ORM\DataObject;
use SilverStripe\Security\InheritedPermissions;
use SilverStripe\Security\InheritedPermissionsExtension;
use SilverStripe\Security\Member;
use SilverStripe\Security\PermissionChecker;
use SilverStripe\Versioned\Versioned;

/**
 * @method TestPermissionNode Parent()
 * @mixin Versioned
 * @mixin InheritedPermissionsExtension
 */
class TestPermissionNode extends DataObject implements TestOnly
{
    private static $db = [

        "Title" => "Varchar(255)",
    ];

    private static $has_one = [

        "Parent" => self::class,
    ];

    private static $table_name = 'InheritedPermissionsTest_TestPermissionNode';


    private static $extensions = [

        Versioned::class,
        InheritedPermissionsExtension::class,
    ];

    /**
     * @return InheritedPermissions
     */
    public static function getInheritedPermissions()
    {
        /** @var InheritedPermissions $permissions */
        return Injector::inst()->get(PermissionChecker::class.'.testpermissions');
    }

    public function canEdit($member = null)

    {
        if (!$member) {
            $member = Member::currentUser();

        }
        return static::getInheritedPermissions()->canEdit($this->ID, $member);
    }

    public function canView($member = null)

    {
        if (!$member) {
            $member = Member::currentUser();

        }
        return static::getInheritedPermissions()->canView($this->ID, $member);
    }

    public function canDelete($member = null)

    {
        if (!$member) {
            $member = Member::currentUser();

        }
        return static::getInheritedPermissions()->canDelete($this->ID, $member);
    }
}


1		<?php
2
3		namespace SilverStripe\Security\Test\InheritedPermissionsTest;
4
5		use SilverStripe\Core\Injector\Injector;
6		use SilverStripe\Dev\TestOnly;
7		use SilverStripe\ORM\DataObject;
8		use SilverStripe\Security\InheritedPermissions;
9		use SilverStripe\Security\InheritedPermissionsExtension;
10		use SilverStripe\Security\Member;
11		use SilverStripe\Security\PermissionChecker;
12		use SilverStripe\Versioned\Versioned;
13
14		/**
15		* @method TestPermissionNode Parent()
16		* @mixin Versioned
17		* @mixin InheritedPermissionsExtension
18		*/
19		class TestPermissionNode extends DataObject implements TestOnly
20		{
21		private static $db = [
		0 ignored issues – show Comprehensibility introduced 2017-05-20 08:33 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history...
22		"Title" => "Varchar(255)",
23		];
24
25		private static $has_one = [
		0 ignored issues – show Comprehensibility introduced 2016-12-18 23:35 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history...
26		"Parent" => self::class,
27		];
28
29		private static $table_name = 'InheritedPermissionsTest_TestPermissionNode';
		0 ignored issues – show Comprehensibility introduced 2017-05-20 08:33 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history...
30
31		private static $extensions = [
		0 ignored issues – show Comprehensibility introduced 2017-05-20 08:33 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history...
32		Versioned::class,
33		InheritedPermissionsExtension::class,
34		];
35
36		/**
37		* @return InheritedPermissions
38		*/
39		public static function getInheritedPermissions()
40		{
41		/** @var InheritedPermissions $permissions */
42		return Injector::inst()->get(PermissionChecker::class.'.testpermissions');
43		}
44
45	View Code Duplication	public function canEdit($member = null)
		0 ignored issues – show Duplication introduced 2016-03-17 21:16 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
46		{
47		if (!$member) {
48		$member = Member::currentUser();
		0 ignored issues – show Deprecated Code introduced 2017-05-20 08:33 UTC by Report Bug Copy Issue Report The method `SilverStripe\Security\Member::currentUser()` has been deprecated with message: use Security::getCurrentUser() This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
49		}
50		return static::getInheritedPermissions()->canEdit($this->ID, $member);
51		}
52
53	View Code Duplication	public function canView($member = null)
		0 ignored issues – show Duplication introduced 2015-12-18 04:35 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
54		{
55		if (!$member) {
56		$member = Member::currentUser();
		0 ignored issues – show Deprecated Code introduced 2017-05-20 08:33 UTC by Report Bug Copy Issue Report The method `SilverStripe\Security\Member::currentUser()` has been deprecated with message: use Security::getCurrentUser() This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
57		}
58		return static::getInheritedPermissions()->canView($this->ID, $member);
59		}
60
61	View Code Duplication	public function canDelete($member = null)
		0 ignored issues – show Duplication introduced 2016-07-11 00:17 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
62		{
63		if (!$member) {
64		$member = Member::currentUser();
		0 ignored issues – show Deprecated Code introduced 2017-05-20 08:33 UTC by Report Bug Copy Issue Report The method `SilverStripe\Security\Member::currentUser()` has been deprecated with message: use Security::getCurrentUser() This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
65		}
66		return static::getInheritedPermissions()->canDelete($this->ID, $member);
67		}
68		}
69

sminnee / silverstripe-framework

Push — authenticator-refactor ( 16f104...61b037 )

TestPermissionNode::canDelete() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like