sminnee / silverstripe-framework

Completed

Push — authenticator-refactor ( e3c944...b14200 )

by Sam

created 2017-04-23 09:24 UTC

Changes

	5 issues (3 major, 2 minor) were introduced. 9 issues were fixed.
	1 new patch (Doc Comments) is available.
	3 added classes/operations
		B	Security::delegateToFormSet() added
		A	Security::delegateToHandler() added
		B	Security::renderWrappedController() added
B	↗	A	Authenticator::supportedServices() improved
B	↗	A	Security::getAuthenticators() improved
B	↗	A	Security::getAuthenticator() improved
A	↘	B	Security::login() got worse

6.76

▶ ± 0

Head	Sam Minnee 2017-04-23 21:24 GMT+1200 FIX: Refactor delegateToHandler / delegateToHandlers to have less duplicated code.
⋮	2 more commits
Base	Simon Erkelens 2017-04-22 08:14 UTC Initial (clunky) implementation of multiple authenticators. I don't want to loose it so I push. Most important change is the delegation to the handler now checking if it isn't a POST method, as a login _always_ requires a post. Further down the line, I'm only returning the `Member` on the doLogin, so it's possible for the Handler or Extending Handler to move to a second step. Also cleaned up some minor typos I ran in to. Nothing major.