sminnee / silverstripe-framework

tests/php/Forms/FormSchemaTest.php

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use SilverStripe\Forms\NumericField;
 use SilverStripe\Forms\Schema\FormSchema;
 use SilverStripe\Dev\SapphireTest;
-use SilverStripe\Control\Controller;
 use SilverStripe\Forms\FieldList;
 use SilverStripe\Forms\Form;
 use SilverStripe\Forms\TextField;

tests/php/ORM/DBDatetimeTest.php

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use SilverStripe\i18n\i18n;
 use SilverStripe\ORM\FieldType\DBDatetime;
 use SilverStripe\Dev\SapphireTest;
-use SilverStripe\Security\Member;
 
 /**
  * Tests for {@link Datetime} class.

src/Dev/SapphireTest.php

Unused Use Statements -3 removed lines

@@ -14,8 +14,6 @@ 
 use SilverStripe\Core\ClassInfo;
 use SilverStripe\Core\Config\ConfigLoader;
 use SilverStripe\Core\Config\CoreConfigFactory;
-use SilverStripe\Core\Config\DefaultConfig;
-use SilverStripe\Core\Config\Middleware\ExtensionMiddleware;
 use SilverStripe\Core\Extension;
 use SilverStripe\Core\Flushable;
 use SilverStripe\Core\Injector\Injector;
@@ -39,7 +37,6 @@ 
 use SilverStripe\View\ThemeResourceLoader;
 use SilverStripe\View\ThemeManifest;
 use PHPUnit_Framework_TestCase;
-use Translatable;
 use LogicException;
 use Exception;
 

src/Forms/DateField.php

Doc Comments +2 added lines, -2 removed lines

@@ -312,7 +312,7 @@ 
     /**
      * Assign value posted from form submission
      *
-     * @param mixed $value
+     * @param string $value
      * @param mixed $data
      * @return $this
      */
@@ -337,7 +337,7 @@ 
      *
      * When $html5=true, assign value from ISO 8601 string.
      *
-     * @param mixed $value
+     * @param string $value
      * @param mixed $data
      * @return $this
      */

src/Forms/DatetimeField.php

Doc Comments +7 added lines, -4 removed lines

@@ -135,7 +135,7 @@ 
     }
 
     /**
-     * @param $bool
+     * @param boolean $bool
      * @return $this
      */
     public function setHTML5($bool)
@@ -148,7 +148,7 @@ 
      * Assign value posted from form submission, based on {@link $datetimeFormat}.
      * When $html5=true, this needs to be normalised ISO format (with "T" separator).
      *
-     * @param mixed $value
+     * @param string $value
      * @param mixed $data
      * @return $this
      */
@@ -314,7 +314,7 @@ 
      * When $html5=true, assign value from ISO 8601 normalised string (with a "T" separator).
      * Falls back to an ISO 8601 string (with a whitespace separator).
      *
-     * @param mixed $value
+     * @param string $value
      * @param mixed $data
      * @return $this
      */
@@ -394,7 +394,7 @@ 
      * Tidy up the internal date representation (ISO 8601),
      * and fall back to strtotime() if there's parsing errors.
      *
-     * @param string $date Date in ISO 8601 or approximate form
+     * @param string $datetime
      * @return string ISO 8601 date, or null if not valid
      */
     public function tidyInternal($datetime)
@@ -489,6 +489,9 @@ 
         return $this;
     }
 
+    /**
+     * @param boolean $bool
+     */
     public function setReadonly($bool)
     {
         parent::setReadonly($bool);

src/Forms/TimeField.php

Doc Comments +2 added lines, -2 removed lines

@@ -250,7 +250,7 @@ 
     /**
      * Assign value posted from form submission
      *
-     * @param mixed $value
+     * @param string $value
      * @param mixed $data
      * @return $this
      */
@@ -267,7 +267,7 @@ 
     /**
      * Set time assigned from database value
      *
-     * @param mixed $value
+     * @param string $value
      * @param mixed $data
      * @return $this
      */

tests/php/Forms/DatetimeFieldTest.php

Unused Use Statements -2 removed lines

@@ -6,9 +6,7 @@
 use SilverStripe\Control\Controller;
 use SilverStripe\Forms\DatetimeField;
 use SilverStripe\Forms\RequiredFields;
-use SilverStripe\Forms\DateField;
 use SilverStripe\Forms\Tests\DatetimeFieldTest\Model;
-use SilverStripe\Forms\TimeField;
 use SilverStripe\Forms\FieldList;
 use SilverStripe\Forms\FormAction;
 use SilverStripe\Forms\Form;