smartboxgroup / core-bundle

Command/Fixtures/GenerateFixtureCommand.php

Doc Comments +7 added lines, -1 removed lines

@@ -101,7 +101,7 @@ 
     }
 
     /**
-     * @param $class
+     * @param null|string $class
      *
      * @return EntityInterface
      */
@@ -192,6 +192,9 @@ 
         return $entity;
     }
 
+    /**
+     * @param string $default
+     */
     protected function ask($text, $default = null)
     {
         $helper = $this->getQuestionHelper();
@@ -202,6 +205,9 @@ 
         return $res;
     }
 
+    /**
+     * @param string $field
+     */
     protected function askForField($field, $tName)
     {
         $question = "$field ($tName): ";

Tests/Fixtures/Entity/TestComplexEntity.php

Doc Comments +4 added lines, -4 removed lines

@@ -192,7 +192,7 @@ 
     }
 
     /**
-     * @return \Smartbox\CoreBundle\Type\IntegerType[]
+     * @return integer[]
      */
     public function getArrayOfIntegers()
     {
@@ -208,7 +208,7 @@ 
     }
 
     /**
-     * @return \Smartbox\CoreBundle\Type\StringType[]
+     * @return string[]
      */
     public function getArrayOfStrings()
     {
@@ -224,7 +224,7 @@ 
     }
 
     /**
-     * @return \Smartbox\CoreBundle\Type\DoubleType[]
+     * @return double[]
      */
     public function getArrayOfDoubles()
     {
@@ -240,7 +240,7 @@ 
     }
 
     /**
-     * @return \Smartbox\CoreBundle\Type\Date[]
+     * @return \DateTime[]
      */
     public function getArrayOfDates()
     {

Tests/Fixtures/Entity/TestNestedEntity.php

Doc Comments +2 added lines, -2 removed lines

@@ -97,7 +97,7 @@ 
     }
 
     /**
-     * @return \Smartbox\CoreBundle\Tests\Fixtures\Entity\TestEntity[]
+     * @return TestEntity
      */
     public function getAssocItems()
     {
@@ -113,7 +113,7 @@ 
     }
 
     /**
-     * @return Entity[]
+     * @return Entity
      */
     public function getGenericItems()
     {

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Smartbox\CoreBundle\Tests\Fixtures\Entity;
 
 use JMS\Serializer\Annotation as JMS;
-use Symfony\Component\Validator\Constraints as Assert;
 use Smartbox\CoreBundle\Type\Entity;
 
 class TestNestedEntity extends Entity

Tests/Serializer/Handler/CachedObjectHandlerTest.php

Doc Comments +3 added lines

@@ -29,6 +29,9 @@
         return $kernel;
     }
 
+    /**
+     * @param string $title
+     */
     protected function createCacheableEntity($title)
     {
         $testEntity = new CacheableEntity();

Tests/Symfony/Validator/Abstract2Dot5ApiTest.php

Doc Comments +3 added lines

@@ -55,6 +55,9 @@
         $this->validator = $this->createValidator($this->metadataFactory);
     }
 
+    /**
+     * @param string $groups
+     */
     protected function validate($value, $constraints = null, $groups = null)
     {
         return $this->validator->validate($value, $constraints, $groups);

Spacing +23 added lines, -23 removed lines

@@ -87,15 +87,15 @@ 
     {
         $entity = new Entity();
 
-        $callback1 = function ($value, ExecutionContextInterface $context) {
+        $callback1 = function($value, ExecutionContextInterface $context) {
             $context->addViolation('Message 1');
         };
-        $callback2 = function ($value, ExecutionContextInterface $context) {
+        $callback2 = function($value, ExecutionContextInterface $context) {
             $context->addViolation('Message 2');
         };
 
         $this->metadata->addConstraint(new Callback([
-            'callback' => function () {},
+            'callback' => function() {},
             'groups' => 'Group 1',
         ]));
         $this->metadata->addConstraint(new Callback([
@@ -120,10 +120,10 @@ 
         $entity = new Entity();
         $entity->reference = new Reference();
 
-        $callback1 = function ($value, ExecutionContextInterface $context) {
+        $callback1 = function($value, ExecutionContextInterface $context) {
             $context->addViolation('Reference violation 1');
         };
-        $callback2 = function ($value, ExecutionContextInterface $context) {
+        $callback2 = function($value, ExecutionContextInterface $context) {
             $context->addViolation('Reference violation 2');
         };
 
@@ -151,7 +151,7 @@ 
         $entity = new Entity();
         $entity->reference = new Reference();
 
-        $callback1 = function ($value, ExecutionContextInterface $context) use ($test, $entity) {
+        $callback1 = function($value, ExecutionContextInterface $context) use ($test, $entity) {
             $violations = $context
                 ->getValidator()
                 // Since the validator is not context aware, the group must
@@ -175,7 +175,7 @@ 
             $context->addViolation('Separate violation');
         };
 
-        $callback2 = function ($value, ExecutionContextInterface $context) use ($test, $entity) {
+        $callback2 = function($value, ExecutionContextInterface $context) use ($test, $entity) {
             $test->assertSame($test::REFERENCE_CLASS, $context->getClassName());
             $test->assertNull($context->getPropertyName());
             $test->assertSame('', $context->getPropertyPath());
@@ -210,7 +210,7 @@ 
         $entity = new Entity();
         $entity->reference = new Reference();
 
-        $callback1 = function ($value, ExecutionContextInterface $context) use ($test) {
+        $callback1 = function($value, ExecutionContextInterface $context) use ($test) {
             $previousValue = $context->getValue();
             $previousObject = $context->getObject();
             $previousMetadata = $context->getMetadata();
@@ -232,7 +232,7 @@ 
             $test->assertSame($previousGroup, $context->getGroup());
         };
 
-        $callback2 = function ($value, ExecutionContextInterface $context) use ($test, $entity) {
+        $callback2 = function($value, ExecutionContextInterface $context) use ($test, $entity) {
             $test->assertSame($test::REFERENCE_CLASS, $context->getClassName());
             $test->assertNull($context->getPropertyName());
             $test->assertSame('subpath', $context->getPropertyPath());
@@ -274,7 +274,7 @@ 
         $entity = new Entity();
         $entity->reference = new Reference();
 
-        $callback1 = function ($value, ExecutionContextInterface $context) use ($test) {
+        $callback1 = function($value, ExecutionContextInterface $context) use ($test) {
             $previousValue = $context->getValue();
             $previousObject = $context->getObject();
             $previousMetadata = $context->getMetadata();
@@ -296,7 +296,7 @@ 
             $test->assertSame($previousGroup, $context->getGroup());
         };
 
-        $callback2 = function ($value, ExecutionContextInterface $context) use ($test, $entity) {
+        $callback2 = function($value, ExecutionContextInterface $context) use ($test, $entity) {
             $test->assertSame($test::REFERENCE_CLASS, $context->getClassName());
             $test->assertNull($context->getPropertyName());
             $test->assertSame('subpath[key]', $context->getPropertyPath());
@@ -338,7 +338,7 @@ 
         $entity = new Entity();
         $traversable = new \ArrayIterator(['key' => $entity]);
 
-        $callback = function ($value, ExecutionContextInterface $context) use ($test, $entity, $traversable) {
+        $callback = function($value, ExecutionContextInterface $context) use ($test, $entity, $traversable) {
             $test->assertSame($test::ENTITY_CLASS, $context->getClassName());
             $test->assertNull($context->getPropertyName());
             $test->assertSame('[key]', $context->getPropertyPath());
@@ -376,7 +376,7 @@ 
         $entity = new Entity();
         $traversable = new \ArrayIterator(['key' => $entity]);
 
-        $callback = function ($value, ExecutionContextInterface $context) {
+        $callback = function($value, ExecutionContextInterface $context) {
             $context->addViolation('Message');
         };
 
@@ -401,7 +401,7 @@ 
         $entity = new Entity();
         $traversable = new \ArrayIterator(['key' => $entity]);
 
-        $callback = function ($value, ExecutionContextInterface $context) use ($test) {
+        $callback = function($value, ExecutionContextInterface $context) use ($test) {
             $test->fail('Should not be called');
         };
 
@@ -438,7 +438,7 @@ 
         $entity = new Entity();
         $entity->reference = new \ArrayIterator(['key' => new Reference()]);
 
-        $callback = function ($value, ExecutionContextInterface $context) use ($test) {
+        $callback = function($value, ExecutionContextInterface $context) use ($test) {
             $test->fail('Should not be called');
         };
 
@@ -464,7 +464,7 @@ 
         $entity = new Entity();
         $entity->reference = new \ArrayIterator(['key' => new Reference()]);
 
-        $callback = function ($value, ExecutionContextInterface $context) use ($test) {
+        $callback = function($value, ExecutionContextInterface $context) use ($test) {
             $test->fail('Should not be called');
         };
 
@@ -492,7 +492,7 @@ 
         $entity = new Entity();
         $entity->reference = new \ArrayIterator(['key' => new Reference()]);
 
-        $callback = function ($value, ExecutionContextInterface $context) use ($test) {
+        $callback = function($value, ExecutionContextInterface $context) use ($test) {
             $test->fail('Should not be called');
         };
 
@@ -518,7 +518,7 @@ 
     {
         $entity = new Entity();
 
-        $callback = function ($value, ExecutionContextInterface $context) {
+        $callback = function($value, ExecutionContextInterface $context) {
             $context->buildViolation('Message %param%')
                 ->setParameter('%param%', 'value')
                 ->setInvalidValue('Invalid value')
@@ -604,7 +604,7 @@ 
     {
         $entity = new Entity();
 
-        $callback = function ($value, ExecutionContextInterface $context) {
+        $callback = function($value, ExecutionContextInterface $context) {
             $context->addViolation('Message');
         };
 
@@ -623,7 +623,7 @@ 
     {
         $entity = new Entity();
 
-        $callback = function ($value, ExecutionContextInterface $context) {
+        $callback = function($value, ExecutionContextInterface $context) {
             $context->addViolation('Message');
         };
 
@@ -653,7 +653,7 @@ 
         $entity = new Entity();
         $entity->firstName = 'Bernhard';
 
-        $callback = function ($value, ExecutionContextInterface $context) use ($test, $entity, &$called) {
+        $callback = function($value, ExecutionContextInterface $context) use ($test, $entity, &$called) {
             $called = true;
             $test->assertSame($entity, $context->getObject());
         };
@@ -679,7 +679,7 @@ 
         $initializer1->expects($this->once())
             ->method('initialize')
             ->with($entity)
-            ->will($this->returnCallback(function ($object) {
+            ->will($this->returnCallback(function($object) {
                 $object->initialized = true;
             }));
 
@@ -695,7 +695,7 @@ 
         // prepare constraint which
         // * checks that "initialized" is set to true
         // * validates the object again
-        $callback = function ($object, ExecutionContextInterface $context) use ($test) {
+        $callback = function($object, ExecutionContextInterface $context) use ($test) {
             $test->assertTrue($object->initialized);
 
             // validate again in same group

Tests/Utils/Cache/FakeCacheService.php

Doc Comments +1 added lines, -1 removed lines

@@ -20,7 +20,7 @@
     }
 
     /**
-     * @param $method
+     * @param string $method
      * @param array $arguments
      * @param null  $result
      */

Tests/Serializer/ArraySerializationVisitorFunctionalTest.php

Spacing +2 added lines, -2 removed lines

@@ -45,7 +45,7 @@ 
         $arrayData = $this->serializer->serialize($data, 'array');
         $this->assertEquals(
             [
-                'internalType' => TestEntity::class,            // We are using the IdenticalPropertyNamingStrategy
+                'internalType' => TestEntity::class, // We are using the IdenticalPropertyNamingStrategy
                 'title' => 'some title',
                 'description' => 'some description',
                 'note' => 'some note',
@@ -70,7 +70,7 @@ 
         $arrayData = $this->serializer->serialize($data, 'array', $context);
         $this->assertEquals(
             [
-                'internalType' => TestEntity::class,        // We are using the IdenticalPropertyNamingStrategy
+                'internalType' => TestEntity::class, // We are using the IdenticalPropertyNamingStrategy
                 'title' => 'some title',
                 'note' => 'some note',
             ],

Utils/Generator/RandomFixtureGenerator.php

Doc Comments +2 added lines, -2 removed lines

@@ -95,8 +95,8 @@
     /**
      * @param $typeName
      * @param array|null $typeParams
-     * @param null       $group
-     * @param null       $version
+     * @param string       $group
+     * @param string       $version
      *
      * @return float|int|string|array|\DateTime|EntityInterface
      *

Command/SmokeTestRunCommand.php

Spacing +2 added lines, -2 removed lines

@@ -118,7 +118,7 @@ 
             $testNames = $this->getTestNames();
             $smokeTests = \array_filter(
                 $smokeTests,
-                function ($key) use ($test) {
+                function($key) use ($test) {
                     return $key === $test;
                 },
                 ARRAY_FILTER_USE_KEY
@@ -151,7 +151,7 @@ 
             if (!empty($skipTests)) {
                 $smokeTests = \array_filter(
                     $smokeTests,
-                    function ($smokeTestInfo) use ($skipTests, &$skipped) {
+                    function($smokeTestInfo) use ($skipTests, &$skipped) {
                         $key = $smokeTestInfo['id'];
                         $skipping = \in_array($key, $skipTests);
                         if ($skipping) {