IDCard::isShortLength() - Code Metrics - slince/China - Measure and Improve Code Quality continuously with Scrutinizer

IDCard::isShortLength() A
last analyzed 2017-11-09 11:17 UTC

↳ Parent: IDCard

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0

<?php
/*
 * This file is part of the Slince/China package.
 *
 * (c) Slince <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace China\IDCard;

class IDCard implements IDCardInterface
{
    /**
     * 身份证数字.
     *
     * @var number
     */
    protected $id;

    public function __construct($id)
    {
        static::assertValidIDCard($id);
        $this->id = $id;
    }

    /**
     * {@inheritdoc}
     */
    public function __toString()
    {
        return $this->id;
    }

    /**
     * {@inheritdoc}
     */
    public function isShortLength()
    {
        return strlen($this->id) === 15;
    }

    /**
     * {@inheritdoc}
     */
    public function getLongNumber()
    {
        $id = $this->id;
        if ($this->isShortLength()) {
            $id = IDCardUtils::convertIDCard15to18($this->id);

        }

        return $id;
    }

    /**
     * 身份证是否合法.
     *
     * @param string $id
     */
    public static function assertValidIDCard($id)
    {
        if (!is_numeric($id)) {
            throw new \InvalidArgumentException(sprintf('The id "%s" card contains the non-numeric characters', $id));
        }
        $length = strlen($id);
        if ($length !== 15 && $length !== 18) {
            throw new \InvalidArgumentException(sprintf('The id "%s" card length should be 15 numbers or 18 numbers, given %d', $id, $length));
        }
        $convertedId = $id;
        if ($length === 15) {
            $convertedId = IDCardUtils::convertIDCard15to18($id);
        }
        if (!IDCardUtils::check18IDCard($convertedId)) {
            throw new \InvalidArgumentException(sprintf('The Id card "%s" is invalid',  $id));
        }
    }
}

1			<?php
2			/*
3			* This file is part of the Slince/China package.
4			*
5			* (c) Slince <[email protected]>
6			*
7			* For the full copyright and license information, please view the LICENSE
8			* file that was distributed with this source code.
9			*/
10
11			namespace China\IDCard;
12
13			class IDCard implements IDCardInterface
14			{
15			/**
16			* 身份证数字.
17			*
18			* @var number
19			*/
20			protected $id;
21
22			public function __construct($id)
23			{
24			static::assertValidIDCard($id);
25			$this->id = $id;
26			}
27
28			/**
29			* {@inheritdoc}
30			*/
31			public function __toString()
32			{
33			return $this->id;
34			}
35
36			/**
37			* {@inheritdoc}
38			*/
39			public function isShortLength()
40			{
41			return strlen($this->id) === 15;
42			}
43
44			/**
45			* {@inheritdoc}
46			*/
47			public function getLongNumber()
48			{
49			$id = $this->id;
50			if ($this->isShortLength()) {
51			$id = IDCardUtils::convertIDCard15to18($this->id);
			0 ignored issues – show Comprehensibility Best Practice introduced 2017-11-09 08:08 UTC by Report Bug Copy Issue Report The expression `\China\IDCard\IDCardUtil...DCard15to18($this->id);` of type `false\|string` adds `false` to the return on line 54 which is incompatible with the return type declared by the interface `China\IDCard\IDCardInterface::getLongNumber` of type `integer\|double`. It seems like you forgot to handle an error condition. Loading history...
52			}
53
54			return $id;
55			}
56
57			/**
58			* 身份证是否合法.
59			*
60			* @param string $id
61			*/
62			public static function assertValidIDCard($id)
63			{
64			if (!is_numeric($id)) {
65			throw new \InvalidArgumentException(sprintf('The id "%s" card contains the non-numeric characters', $id));
66			}
67			$length = strlen($id);
68			if ($length !== 15 && $length !== 18) {
69			throw new \InvalidArgumentException(sprintf('The id "%s" card length should be 15 numbers or 18 numbers, given %d', $id, $length));
70			}
71			$convertedId = $id;
72			if ($length === 15) {
73			$convertedId = IDCardUtils::convertIDCard15to18($id);
74			}
75			if (!IDCardUtils::check18IDCard($convertedId)) {
76			throw new \InvalidArgumentException(sprintf('The Id card "%s" is invalid', $id));
77			}
78			}
79			}

slince / China

IDCard::isShortLength() A last analyzed 2017-11-09 11:17 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

IDCard::isShortLength() A
last analyzed 2017-11-09 11:17 UTC