China\IDCard\IDCard

Complexity

Total Complexity

11

Size/Duplication

Total Lines	67
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	__toString()	0	4	1
A	isShortLength()	0	4	1
A	getLongNumber()	0	9	2
B	assertValidIDCard()	0	17	6

<?php
/*
 * This file is part of the Slince/China package.
 *
 * (c) Slince <taosikai@yeah.net>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace China\IDCard;

class IDCard implements IDCardInterface
{
    /**
     * 身份证数字.
     *
     * @var number
     */
    protected $id;

    public function __construct($id)
    {
        static::assertValidIDCard($id);
        $this->id = $id;
    }

    /**
     * {@inheritdoc}
     */
    public function __toString()
    {
        return $this->id;
    }

    /**
     * {@inheritdoc}
     */
    public function isShortLength()
    {
        return strlen($this->id) === 15;
    }

    /**
     * {@inheritdoc}
     */
    public function getLongNumber()
    {
        $id = $this->id;
        if ($this->isShortLength()) {
            $id = IDCardUtils::convertIDCard15to18($this->id);

The expression \China\IDCard\IDCardUtils::convertIDCard15to18($this->id); of type false|string adds false to the return on line 54 which is incompatible with the return type declared by the interface China\IDCard\IDCardInterface::getLongNumber of type integer|double. It seems like you forgot to handle an error condition.

        }

        return $id;
    }

    /**
     * 身份证是否合法.
     *
     * @param string $id
     */
    public static function assertValidIDCard($id)
    {
        if (!is_numeric($id)) {
            throw new \InvalidArgumentException(sprintf('The id "%s" card contains the non-numeric characters', $id));
        }
        $length = strlen($id);
        if ($length !== 15 && $length !== 18) {
            throw new \InvalidArgumentException(sprintf('The id "%s" card length should be 15 numbers or 18 numbers, given %d', $id, $length));
        }
        $convertedId = $id;
        if ($length === 15) {
            $convertedId = IDCardUtils::convertIDCard15to18($id);
        }
        if (!IDCardUtils::check18IDCard($convertedId)) {
            throw new \InvalidArgumentException(sprintf('The Id card "%s" is invalid',  $id));
        }
    }
}