Slick\Telemetry\TelemetryClient\RequestFactoryTrait::endRequest()

Complexity

Conditions	2
Paths	2

Size

Total Lines	20
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

<?php
    public function endRequest(Request $request, int $statusCode = 200, iterable $context = []): TelemetryClient
    {
        $start = $request->context()['start'] ?? (float)($request->startTime() * 1000);

        $duration = ((float) microtime(true) - $start) * 1000;
        $context = array_merge((array) $request->context(), $context);

It seems like $context can also be of type iterable; however, parameter $arrays of array_merge() does only seem to accept array, maybe add an additional type check?

        if (array_key_exists('start', $context)) {
            unset($context['start']);
        }

        $this->trackRequest(

It seems like trackRequest() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $request->message(),
            $request->path(),
            $request->startTime(),
            $statusCode,
            $duration,
            $context
        );
        return $this;
    }