Slick\Telemetry\TelemetryClient\RequestFactoryTrait

Complexity

Total Complexity

3

Size/Duplication

Total Lines	36
Duplicated Lines	0 %

Importance

Changes	3
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	endRequest()	0	20	2
A	beginRequest()	0	4	1

<?php

/**
 * This file is part of Telemetry
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Slick\Telemetry\TelemetryClient;

use Slick\Telemetry\Model\Request;
use Slick\Telemetry\TelemetryClient;
use Slick\Telemetry\Trackable;

/**
 * RequestFactoryTrait trait
 *
 * @package Slick\Telemetry\TelemetryClient
 */
trait RequestFactoryTrait
{
    abstract public function track(Trackable $trackableData): TelemetryClient;

    /**
     * @inheritDoc
     */
    public function beginRequest(string $message, string $path, iterable $context = []): Request
    {
        $context = array_merge($context, ['start' => microtime(true)]);

It seems like $context can also be of type iterable; however, parameter $arrays of array_merge() does only seem to accept array, maybe add an additional type check?

        return new Request($message, $path, time(), 200, 0, $context);
    }

    /**
     * @inheritDoc
     */
    public function endRequest(Request $request, int $statusCode = 200, iterable $context = []): TelemetryClient
    {
        $start = $request->context()['start'] ?? (float)($request->startTime() * 1000);

        $duration = ((float) microtime(true) - $start) * 1000;
        $context = array_merge((array) $request->context(), $context);

It seems like $context can also be of type iterable; however, parameter $arrays of array_merge() does only seem to accept array, maybe add an additional type check?

        if (array_key_exists('start', $context)) {
            unset($context['start']);
        }

        $this->trackRequest(

It seems like trackRequest() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $request->message(),
            $request->path(),
            $request->startTime(),
            $statusCode,
            $duration,
            $context
        );
        return $this;
    }
}