Sirius\Orm\Relation\HasAggregates::compileAggregates()

Complexity

Conditions	5
Paths	4

Size

Total Lines	19
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

<?php
    protected function compileAggregates()
    {
        if (is_array($this->aggregates)) {
            return;
        }

        $aggregates = [];
        $aggregatesList = $this->getOption(RelationConfig::AGGREGATES);

It seems like getOption() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if (!is_array($aggregatesList) || empty($aggregatesList)) {
            $this->aggregates = $aggregates;
            return;
        }

        foreach ($aggregatesList as $name => $options) {
            $agg = new Aggregate($name, $this, $options);

$this of type Sirius\Orm\Relation\HasAggregates is incompatible with the type Sirius\Orm\Relation\Relation expected by parameter $relation of Sirius\Orm\Relation\Aggregate::__construct().

            $aggregates[$name] = $agg;
        }

        $this->aggregates = $aggregates;
    }