Sirius\Orm\Relation\HasAggregates

Complexity

Total Complexity

6

Size/Duplication

Total Lines	30
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	compileAggregates()	0	19	5
A	getAggregates()	0	5	1

<?php
declare(strict_types=1);

namespace Sirius\Orm\Relation;

use Sirius\Orm\Collection\Collection;
use Sirius\Orm\Entity\EntityInterface;
use Sirius\Orm\Entity\StateEnum;
use Sirius\Orm\Entity\Tracker;
use Sirius\Orm\Query;

trait HasAggregates
{
    protected $aggregates;

    protected function compileAggregates()
    {
        if (is_array($this->aggregates)) {
            return;
        }

        $aggregates = [];
        $aggregatesList = $this->getOption(RelationConfig::AGGREGATES);

It seems like getOption() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if (!is_array($aggregatesList) || empty($aggregatesList)) {
            $this->aggregates = $aggregates;
            return;
        }

        foreach ($aggregatesList as $name => $options) {
            $agg = new Aggregate($name, $this, $options);

$this of type Sirius\Orm\Relation\HasAggregates is incompatible with the type Sirius\Orm\Relation\Relation expected by parameter $relation of Sirius\Orm\Relation\Aggregate::__construct().

            $aggregates[$name] = $agg;
        }

        $this->aggregates = $aggregates;
    }

    public function getAggregates()
    {
        $this->compileAggregates();

        return $this->aggregates;
    }
}