siriusphp / input

src/DataContainer.php

Doc Comments +7 added lines

@@ -4,6 +4,10 @@ 
 class DataContainer extends \ArrayObject
 {
 
+    /**
+     * @param string $nameOrArray
+     * @param string $value
+     */
     function set($nameOrArray, $value = null)
     {
         if (is_array($nameOrArray)) {
@@ -23,6 +27,9 @@ 
         }
     }
 
+    /**
+     * @param string $name
+     */
     function get($name)
     {
         return isset($this[$name])

Spacing +1 added lines, -1 removed lines

@@ -13,7 +13,7 @@
 
             return;
         }
-        if ( ! is_string($nameOrArray)) {
+        if (!is_string($nameOrArray)) {
             throw new \InvalidArgumentException('Only strings or arrays are accepted as first argument of the set() method of the DataContainer class');
         }
         if ($value !== null) {

src/Element/Factory.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 
 use Sirius\Input\Element\Input;
 use Sirius\Input\Element;
-use Sirius\Input\Specs;
 
 class Factory
 {

Spacing +4 added lines, -4 removed lines

@@ -30,13 +30,13 @@ 
 
             return $this;
         }
-        if ( ! is_string($classOrClosure)) {
+        if (!is_string($classOrClosure)) {
             throw new \RuntimeException('Input type must be a class or a closure');
         }
-        if ( ! class_exists($classOrClosure)) {
+        if (!class_exists($classOrClosure)) {
             throw new \RuntimeException(sprintf('Class %s does not exist', $classOrClosure));
         }
-        if ( ! is_subclass_of($classOrClosure, '\Sirius\Input\Element')) {
+        if (!is_subclass_of($classOrClosure, '\Sirius\Input\Element')) {
             throw new \RuntimeException(
                 sprintf('Class %s must extend the \Sirius\Input\Element class', $classOrClosure)
             );
@@ -70,7 +70,7 @@ 
             $element = new $class($name, $options);
         }
 
-        if ( ! $element instanceof Element) {
+        if (!$element instanceof Element) {
             throw new \RuntimeException('Cannot create a valid element based on the data provided');
         }
 

src/Element/Input/MultiSelect.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 namespace Sirius\Input\Element\Input;
 
 use Sirius\Input\Specs;
-use Sirius\Filtration\Filter\Callback;
 
 class MultiSelect extends Select
 {

Spacing +2 added lines, -2 removed lines

@@ -27,10 +27,10 @@
      */
     function filterValue($value, $valueIdentifier = null)
     {
-        if ( ! $value) {
+        if (!$value) {
             return null;
         }
-        if ( ! is_array($value)) {
+        if (!is_array($value)) {
             $value = (array) $value;
         }
         $allowedValues = array_keys($this->getOptions());

src/InputFilter.php

Doc Comments +3 added lines, -3 removed lines

@@ -98,7 +98,7 @@ 
      * Initialize the form
      * This is the place to put your definition (properties, elements)
      *
-     * @return \Sirius\Input\Form
+     * @return InputFilter
      */
     function init()
     {
@@ -146,7 +146,7 @@ 
      * @param bool $force force the execution of the preparation code even if already prepared
      *
      * @throws \LogicException
-     * @return \Sirius\Input\Form
+     * @return InputFilter
      */
     function prepare($force = false)
     {
@@ -260,7 +260,7 @@ 
      *      $form->setUploadHandler('resume', $resumeHandler);
      *      $form->setUploadHandler('pictures[*]', $pictureHandler);
      *
-     * @param $selector
+     * @param string $selector
      * @param UploadHandler $handler
      *
      * @return $this

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 
 use Sirius\Filtration\Filtrator;
 use Sirius\Filtration\FiltratorInterface;
-use Sirius\Input\Element\AbstractElement;
 use Sirius\Input\Element\Factory as ElementFactory;
 use Sirius\Input\Traits\HasChildrenTrait;
 use Sirius\Input\Traits\HasAttributesTrait;

Spacing +11 added lines, -11 removed lines

@@ -77,17 +77,17 @@ 
         ValidatorInterface $validator = null,
         FiltratorInterface $filtrator = null
     ) {
-        if ( ! $elementFactory) {
+        if (!$elementFactory) {
             $elementFactory = new ElementFactory();
         }
         $this->elementFactory = $elementFactory;
 
-        if ( ! $validator) {
+        if (!$validator) {
             $validator = new Validator();
         }
         $this->validator = $validator;
 
-        if ( ! $filtrator) {
+        if (!$filtrator) {
             $filtrator = new Filtrator();
         }
         $this->filtrator = $filtrator;
@@ -150,11 +150,11 @@ 
      */
     function prepare($force = false)
     {
-        if ($this->isPrepared && ! $force) {
+        if ($this->isPrepared && !$force) {
             return $this;
         }
         $this->init();
-        if ( ! $this->isInitialized()) {
+        if (!$this->isInitialized()) {
             throw new \LogicException('Input was not properly initialized');
         }
 
@@ -198,12 +198,12 @@ 
     protected function prepareFiltration()
     {
         $filters = $this->getFilters();
-        if ( ! is_array($filters) || empty($filters)) {
+        if (!is_array($filters) || empty($filters)) {
             return;
         }
         $filtrator = $this->getFiltrator();
         foreach ($filters as $filter) {
-            $params = is_array($filter) ? $filter : array( $filter );
+            $params = is_array($filter) ? $filter : array($filter);
             if (isset($params[0])) {
                 $filtrator->add(Filtrator::SELECTOR_ROOT, $params[0], @$params[1], @$params[2], @$params[3]);
             }
@@ -248,7 +248,7 @@ 
      */
     function getUploadHandlers()
     {
-        if ( ! $this->uploadHandlers) {
+        if (!$this->uploadHandlers) {
             $this->uploadHandlers = new UploadHandlerAggregate;
         }
 
@@ -283,7 +283,7 @@ 
     function populate($values = array())
     {
         $this->prepare();
-        if ( ! $this->isPrepared()) {
+        if (!$this->isPrepared()) {
             throw new \LogicException('Input was not prepared and cannot receive data');
         }
 
@@ -332,7 +332,7 @@ 
      */
     function isValid($skipDataProcessing = false)
     {
-        if ( ! $skipDataProcessing) {
+        if (!$skipDataProcessing) {
             $this->values = $this->getFiltrator()->filter($this->rawValues);
         }
 
@@ -340,7 +340,7 @@ 
         $validator = $this->getValidator();
         $validator->validate($this->values);
 
-        if ( ! $skipDataProcessing) {
+        if (!$skipDataProcessing) {
             $this->processUploads();
         }
 

src/Traits/HasAttributesTrait.php

Doc Comments +2 added lines, -2 removed lines

@@ -31,7 +31,7 @@ 
      *
      * @param array $attrs
      *
-     * @return mixed
+     * @return HasAttributesTrait
      */
     function setAttributes($attrs)
     {
@@ -59,7 +59,7 @@ 
      * Set/Unset a label attribute
      *
      * @param string $attr
-     * @param mixed|null $value
+     * @param string $value
      *
      * @return self
      */

Spacing +1 added lines, -1 removed lines

@@ -9,7 +9,7 @@
 
     protected function ensureAttributes()
     {
-        if ( ! isset($this[Specs::ATTRIBUTES])) {
+        if (!isset($this[Specs::ATTRIBUTES])) {
             $this[Specs::ATTRIBUTES] = new AttributesContainer();
         }
     }

src/Traits/HasChildrenTrait.php

Doc Comments +1 added lines, -1 removed lines

@@ -130,7 +130,7 @@
      * @param \ArrayObject $childA
      * @param \ArrayObject $childB
      *
-     * @return number
+     * @return integer
      */
     protected function childComparator($childA, $childB)
     {

Spacing +7 added lines, -7 removed lines

@@ -61,8 +61,8 @@ 
             throw new \RuntimeException(sprintf('Variable $nameorElement must be a string or an instance of the Element class'));
         }
         // add the index for sorting
-        if ( ! isset($element['__index'])) {
-            $element['__index'] = ($this->elementsIndex --);
+        if (!isset($element['__index'])) {
+            $element['__index'] = ($this->elementsIndex--);
         }
         $this->elements[$name] = $element;
 
@@ -135,20 +135,20 @@ 
     protected function childComparator($childA, $childB)
     {
         if ($childA->getPosition() < $childB->getPosition()) {
-            return - 1;
+            return -1;
         }
         if ($childA->getPosition() > $childB->getPosition()) {
             return 1;
         }
         if ($childA->get('__index') > $childB->get('__index')) {
-            return - 1;
+            return -1;
         }
         if ($childA->get('__index') < $childB->get('__index')) {
             return 1;
         }
 
         // if the priority is the same, childB is first
-        return - 1;
+        return -1;
     }
 
     /**
@@ -159,7 +159,7 @@ 
     function getElements()
     {
         // first sort the children so they are retrieved by priority
-        uasort($this->elements, array( $this, 'childComparator' ));
+        uasort($this->elements, array($this, 'childComparator'));
 
         return $this->elements;
     }
@@ -172,7 +172,7 @@ 
     {
         foreach ($this->elements as $element) {
             $group = $element->getGroup();
-            if ($group && ! isset($this->elements[$group])) {
+            if ($group && !isset($this->elements[$group])) {
                 $element->setGroup(null);
             }
         }

src/Traits/HasHintTrait.php

Doc Comments +1 added lines, -1 removed lines

@@ -55,7 +55,7 @@
      *
      * @param array $attrs
      *
-     * @return mixed
+     * @return HasHintTrait
      */
     function setHintAttributes($attrs)
     {

Spacing +1 added lines, -1 removed lines

@@ -9,7 +9,7 @@
 
     protected function ensureHintAttributes()
     {
-        if ( ! isset($this[Specs::HINT_ATTRIBUTES])) {
+        if (!isset($this[Specs::HINT_ATTRIBUTES])) {
             $this[Specs::HINT_ATTRIBUTES] = new AttributesContainer();
         }
     }

src/Traits/HasLabelTrait.php

Doc Comments +1 added lines, -1 removed lines

@@ -55,7 +55,7 @@
      *
      * @param array $attrs
      *
-     * @return mixed
+     * @return HasLabelTrait
      */
     function setLabelAttributes($attrs)
     {

Spacing +1 added lines, -1 removed lines

@@ -9,7 +9,7 @@
 
     protected function ensureLabelAttributes()
     {
-        if ( ! isset($this[Specs::LABEL_ATTRIBUTES])) {
+        if (!isset($this[Specs::LABEL_ATTRIBUTES])) {
             $this[Specs::LABEL_ATTRIBUTES] = new AttributesContainer();
         }
     }

src/AttributesContainer.php

Spacing +1 added lines, -1 removed lines

@@ -19,7 +19,7 @@
 
     function removeClass($className)
     {
-        if ( ! $this->hasClass($className)) {
+        if (!$this->hasClass($className)) {
             return;
         }
         $classes = preg_replace('/\b' . $className . '\b/i', '', $this->get('class'));