SimpleSAML\Test\XML\ArrayizableElementTestTrait::testArrayization()

Complexity

Conditions	3
Paths	3

Size

Total Lines	23
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function testArrayization(): void
    {
        /** @psalm-var class-string|null */
        $testedClass = $this->testedClass;

The assignment to $testedClass is dead and can be removed.

        /** @psalm-var array|null */
        $arrayRepresentation = $this->arrayRepresentation;

The assignment to $arrayRepresentation is dead and can be removed.

        if (!class_exists($this->testedClass)) {
            $this->markTestSkipped(

It seems like markTestSkipped() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                'Unable to run ' . self::class . '::testArrayization(). Please set ' . self::class
                . ':$element to a class-string representing the XML-class being tested',
            );
        } elseif ($this->arrayRepresentation === null) {
            $this->markTestSkipped(
                'Unable to run ' . self::class . '::testArrayization(). Please set ' . self::class
                . ':$arrayRepresentation to an array representing the XML-class being tested',
            );
        } else {
            $this->assertEquals(

It seems like assertEquals() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                $this->arrayRepresentation,
                $this->testedClass::fromArray($this->arrayRepresentation)->toArray(),
            );