SimpleSAML\Test\XML\ArrayizableElementTestTrait

Complexity

Total Complexity

3

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	testArrayization()	0	23	3

<?php

declare(strict_types=1);

namespace SimpleSAML\Test\XML;

use DOMDocument;

use function class_exists;

/**
 * Test for arrayizable XML classes to perform default serialization tests.
 *
 * @package simplesamlphp\xml-common
 */
trait ArrayizableElementTestTrait
{
    /** @var class-string */

The doc comment class-string at position 0 could not be parsed: Unknown type name 'class-string' at position 0 in class-string.

    protected string $testedClass;

    /** @var array */
    protected array $arrayRepresentation;


    /**
     * Test arrayization / de-arrayization
     */
    public function testArrayization(): void
    {
        /** @psalm-var class-string|null */
        $testedClass = $this->testedClass;

The assignment to $testedClass is dead and can be removed.

        /** @psalm-var array|null */
        $arrayRepresentation = $this->arrayRepresentation;

The assignment to $arrayRepresentation is dead and can be removed.

        if (!class_exists($this->testedClass)) {
            $this->markTestSkipped(

It seems like markTestSkipped() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                'Unable to run ' . self::class . '::testArrayization(). Please set ' . self::class
                . ':$element to a class-string representing the XML-class being tested',
            );
        } elseif ($this->arrayRepresentation === null) {
            $this->markTestSkipped(
                'Unable to run ' . self::class . '::testArrayization(). Please set ' . self::class
                . ':$arrayRepresentation to an array representing the XML-class being tested',
            );
        } else {
            $this->assertEquals(

It seems like assertEquals() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                $this->arrayRepresentation,
                $this->testedClass::fromArray($this->arrayRepresentation)->toArray(),
            );
        }
    }
}