Passed
Pull Request — master (#65)
by
unknown
02:30
created
src/WebAuthn/WebAuthnAbstractEvent.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -182,7 +182,7 @@
 block discarded – undo
182 182
         return $this->credential;
183 183
     }
184 184
 
185
-   /**
185
+    /**
186 186
      * @return int
187 187
      */
188 188
     public function getAlgo(): int
Please login to merge, or discard this patch.
src/Controller/RegProcess.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -196,7 +196,7 @@
 block discarded – undo
196 196
         $id = $this->authState::saveState($state, 'webauthn:request');
197 197
         if ($debugEnabled === true) {
198 198
             $response = new RunnableResponse(
199
-                function (WebAuthnRegistrationEvent $regObject, string $id) {
199
+                function(WebAuthnRegistrationEvent $regObject, string $id) {
200 200
                     echo $regObject->getDebugBuffer();
201 201
                     echo $regObject->getValidateBuffer();
202 202
                     echo "<form id='regform' method='POST' action='" .
Please login to merge, or discard this patch.
src/Controller/WebAuthn.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -109,7 +109,7 @@
 block discarded – undo
109 109
             }
110 110
             return self::STATE_AUTH_ALLOWMGMT;
111 111
         } else { // in inflow, allow to check the management box; otherwise,
112
-                 // only auth
112
+                    // only auth
113 113
             $moduleConfig = Configuration::getOptionalConfig('module_webauthn.php')->toArray();
114 114
             return $moduleConfig['registration']['use_inflow_registration'] ? self::STATE_AUTH_ALLOWMGMT : self::STATE_AUTH_NOMGMT;
115 115
         }
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -215,7 +215,7 @@
 block discarded – undo
215 215
         $frontendData = [];
216 216
         $frontendData['challengeEncoded'] = $challengeEncoded;
217 217
         $frontendData['state'] = [];
218
-        foreach (['FIDO2Scope','FIDO2Username','FIDO2Displayname','requestTokenModel'] as $stateItem) {
218
+        foreach (['FIDO2Scope', 'FIDO2Username', 'FIDO2Displayname', 'requestTokenModel'] as $stateItem) {
219 219
             $frontendData['state'][$stateItem] = $state[$stateItem];
220 220
         }
221 221
 
Please login to merge, or discard this patch.
src/Controller/PushbackUserPass.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -131,7 +131,7 @@
 block discarded – undo
131 131
         // this is the confirmed username, we store it just like the Passwordless
132 132
         // one would have been
133 133
         
134
-        $state['Attributes'][$state['FIDO2AttributeStoringUsername']] = [ $request->request->get("username") ];
134
+        $state['Attributes'][$state['FIDO2AttributeStoringUsername']] = [$request->request->get("username")];
135 135
 
136 136
         // we deliberately do not store any additional attributes - these have
137 137
         // to be retrieved from the same authproc that would retrieve them
Please login to merge, or discard this patch.
src/Controller/Supercharged.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -215,7 +215,7 @@
 block discarded – undo
215 215
         $frontendData = [];
216 216
         $frontendData['challengeEncoded'] = $challengeEncoded;
217 217
         $frontendData['state'] = [];
218
-        foreach (['FIDO2Scope','FIDO2Username','FIDO2Displayname','requestTokenModel'] as $stateItem) {
218
+        foreach (['FIDO2Scope', 'FIDO2Username', 'FIDO2Displayname', 'requestTokenModel'] as $stateItem) {
219 219
             $frontendData['state'][$stateItem] = $state[$stateItem];
220 220
         }
221 221
 
Please login to merge, or discard this patch.
src/Controller/AuthProcess.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
169 169
             base64_decode($request->request->get('client_data_raw')),
170 170
             $oneToken[0],
171 171
             $oneToken[1],
172
-            (int)$oneToken[4], // algo
172
+            (int) $oneToken[4], // algo
173 173
             base64_decode($request->request->get('signature')),
174 174
             $debugEnabled
175 175
         );
@@ -227,7 +227,7 @@  discard block
 block discarded – undo
227 227
 
228 228
         if ($debugEnabled) {
229 229
             $response = new RunnableResponse(
230
-                function (WebAuthnAuthenticationEvent $authObject, array $state) {
230
+                function(WebAuthnAuthenticationEvent $authObject, array $state) {
231 231
                     echo $authObject->getDebugBuffer();
232 232
                     echo $authObject->getValidateBuffer();
233 233
                     echo "Debug mode, not continuing to " . ($state['FIDO2WantsRegister'] ? "credential registration page." : "destination.");
@@ -251,7 +251,7 @@  discard block
 block discarded – undo
251 251
              * In passwordless, we're on our own. The one thing we know is the
252 252
              * username.
253 253
              */
254
-            $state['Attributes'][$state['FIDO2AttributeStoringUsername']] = [ $state['FIDO2Username'] ];
254
+            $state['Attributes'][$state['FIDO2AttributeStoringUsername']] = [$state['FIDO2Username']];
255 255
             // in case this authentication happened in the Supercharged context
256 256
             // it may be that there is an authprocfilter for WebAuthN, too.
257 257
 
@@ -269,7 +269,7 @@  discard block
 block discarded – undo
269 269
             }
270 270
             // set an internal "authenticated passwordless" hint somewhere else
271 271
             // in $state, which the authproc can react upon
272
-            $state['Attributes']['internal:FIDO2PasswordlessAuthentication'] = [ $state['FIDO2Username'] ];
272
+            $state['Attributes']['internal:FIDO2PasswordlessAuthentication'] = [$state['FIDO2Username']];
273 273
 
274 274
             $this->authState::saveState($state, 'webauthn:request');
275 275
 
Please login to merge, or discard this patch.
src/WebAuthn/WebAuthnRegistrationEvent.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -496,7 +496,7 @@  discard block
 block discarded – undo
496 496
     }
497 497
 
498 498
     // Keymaster 3 - KeyMint ???
499
-    private const ORIGINS_3 = [ // https://source.android.com/docs/security/features/keystore/tags#origin
499
+    private const ORIGINS_3 = [// https://source.android.com/docs/security/features/keystore/tags#origin
500 500
         0 => "GENERATED",
501 501
         1 => "DERIVED",
502 502
         2 => "IMPORTED",
@@ -711,7 +711,7 @@  discard block
 block discarded – undo
711 711
          * STEP 13 of the validation procedure in § 7.1 of the spec: is the algorithm the expected one?
712 712
          */
713 713
         if (in_array($arrayPK['3'], self::PK_ALGORITHM)) { // we requested -7 or -257, so want to see it here
714
-            $this->algo = (int)$arrayPK['3'];
714
+            $this->algo = (int) $arrayPK['3'];
715 715
             $this->pass("Public Key Algorithm is expected (" . implode(' or ', WebAuthnRegistrationEvent::PK_ALGORITHM) . ").");
716 716
         } else {
717 717
             $this->fail("Public Key Algorithm mismatch!");
Please login to merge, or discard this patch.