Passed
Branch master (17012e)
by Tim
02:49
created
lib/Auth/Source/SQL.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -68,14 +68,14 @@  discard block
 block discarded – undo
68 68
         // Make sure that all required parameters are present.
69 69
         foreach (['dsn', 'username', 'password', 'query'] as $param) {
70 70
             if (!array_key_exists($param, $config)) {
71
-                throw new Exception('Missing required attribute \'' . $param .
72
-                    '\' for authentication source ' . $this->authId);
71
+                throw new Exception('Missing required attribute \''.$param.
72
+                    '\' for authentication source '.$this->authId);
73 73
             }
74 74
 
75 75
             if (!is_string($config[$param])) {
76
-                throw new Exception('Expected parameter \'' . $param .
77
-                    '\' for authentication source ' . $this->authId .
78
-                    ' to be a string. Instead it was: ' .
76
+                throw new Exception('Expected parameter \''.$param.
77
+                    '\' for authentication source '.$this->authId.
78
+                    ' to be a string. Instead it was: '.
79 79
                     var_export($config[$param], true));
80 80
             }
81 81
         }
@@ -101,10 +101,10 @@  discard block
 block discarded – undo
101 101
             $db = new PDO($this->dsn, $this->username, $this->password, $this->options);
102 102
         } catch (PDOException $e) {
103 103
             // Obfuscate the password if it's part of the dsn
104
-            $obfuscated_dsn =  preg_replace('/(user|password)=(.*?([;]|$))/', '${1}=***', $this->dsn);
104
+            $obfuscated_dsn = preg_replace('/(user|password)=(.*?([;]|$))/', '${1}=***', $this->dsn);
105 105
 
106
-            throw new \Exception('sqlauth:' . $this->authId . ': - Failed to connect to \'' .
107
-                $obfuscated_dsn . '\': ' . $e->getMessage());
106
+            throw new \Exception('sqlauth:'.$this->authId.': - Failed to connect to \''.
107
+                $obfuscated_dsn.'\': '.$e->getMessage());
108 108
         }
109 109
 
110 110
         $db->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);
@@ -148,30 +148,30 @@  discard block
 block discarded – undo
148 148
         try {
149 149
             $sth = $db->prepare($this->query);
150 150
         } catch (PDOException $e) {
151
-            throw new Exception('sqlauth:' . $this->authId .
152
-                ': - Failed to prepare query: ' . $e->getMessage());
151
+            throw new Exception('sqlauth:'.$this->authId.
152
+                ': - Failed to prepare query: '.$e->getMessage());
153 153
         }
154 154
 
155 155
         try {
156 156
             $sth->execute(['username' => $username, 'password' => $password]);
157 157
         } catch (PDOException $e) {
158
-            throw new Exception('sqlauth:' . $this->authId .
159
-                ': - Failed to execute query: ' . $e->getMessage());
158
+            throw new Exception('sqlauth:'.$this->authId.
159
+                ': - Failed to execute query: '.$e->getMessage());
160 160
         }
161 161
 
162 162
         try {
163 163
             $data = $sth->fetchAll(PDO::FETCH_ASSOC);
164 164
         } catch (PDOException $e) {
165
-            throw new Exception('sqlauth:' . $this->authId .
166
-                ': - Failed to fetch result set: ' . $e->getMessage());
165
+            throw new Exception('sqlauth:'.$this->authId.
166
+                ': - Failed to fetch result set: '.$e->getMessage());
167 167
         }
168 168
 
169
-        Logger::info('sqlauth:' . $this->authId . ': Got ' . count($data) .
169
+        Logger::info('sqlauth:'.$this->authId.': Got '.count($data).
170 170
             ' rows from database');
171 171
 
172 172
         if (count($data) === 0) {
173 173
             // No rows returned - invalid username/password
174
-            Logger::error('sqlauth:' . $this->authId .
174
+            Logger::error('sqlauth:'.$this->authId.
175 175
                 ': No rows in result set. Probably wrong username/password.');
176 176
             throw new Error\Error('WRONGUSERPASS');
177 177
         }
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
             }
203 203
         }
204 204
 
205
-        Logger::info('sqlauth:' . $this->authId . ': Attributes: ' . implode(',', array_keys($attributes)));
205
+        Logger::info('sqlauth:'.$this->authId.': Attributes: '.implode(',', array_keys($attributes)));
206 206
 
207 207
         return $attributes;
208 208
     }
Please login to merge, or discard this patch.