Passed
Push — master ( 4ec4dd...bebb12 )
by Tim
02:51
created
lib/MetaLoader.php 1 patch
Spacing   +39 added lines, -39 removed lines patch added patch discarded remove patch
@@ -106,13 +106,13 @@  discard block
 block discarded – undo
106 106
             try {
107 107
                 list($data, $responseHeaders) = \SimpleSAML\Utils\HTTP::fetch($source['src'], $context, true);
108 108
             } catch (\Exception $e) {
109
-                Logger::warning('metarefresh: ' . $e->getMessage());
109
+                Logger::warning('metarefresh: '.$e->getMessage());
110 110
             }
111 111
 
112 112
             // We have response headers, so the request succeeded
113 113
             if (!isset($responseHeaders)) {
114 114
                 // No response headers, this means the request failed in some way, so re-use old data
115
-                Logger::debug('No response from ' . $source['src'] . ' - attempting to re-use cached metadata');
115
+                Logger::debug('No response from '.$source['src'].' - attempting to re-use cached metadata');
116 116
                 $this->addCachedMetadata($source);
117 117
                 return;
118 118
             } elseif (preg_match('@^HTTP/1\.[01]\s304\s@', $responseHeaders[0])) {
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
                 return;
123 123
             } elseif (!preg_match('@^HTTP/1\.[01]\s200\s@', $responseHeaders[0])) {
124 124
                 // Other error
125
-                Logger::debug('Error from ' . $source['src'] . ' - attempting to re-use cached metadata');
125
+                Logger::debug('Error from '.$source['src'].' - attempting to re-use cached metadata');
126 126
                 $this->addCachedMetadata($source);
127 127
                 return;
128 128
             }
@@ -141,8 +141,8 @@  discard block
 block discarded – undo
141 141
         try {
142 142
             $entities = $this->loadXML($data, $source);
143 143
         } catch (\Exception $e) {
144
-            Logger::debug('XML parser error when parsing ' . $source['src'] . ' - attempting to re-use cached metadata');
145
-            Logger::debug('XML parser returned: ' . $e->getMessage());
144
+            Logger::debug('XML parser error when parsing '.$source['src'].' - attempting to re-use cached metadata');
145
+            Logger::debug('XML parser returned: '.$e->getMessage());
146 146
             $this->addCachedMetadata($source);
147 147
             return;
148 148
         }
@@ -150,14 +150,14 @@  discard block
 block discarded – undo
150 150
         foreach ($entities as $entity) {
151 151
             if (isset($source['blacklist'])) {
152 152
                 if (!empty($source['blacklist']) && in_array($entity->getEntityId(), $source['blacklist'], true)) {
153
-                    Logger::info('Skipping "' . $entity->getEntityId().'" - blacklisted.' . "\n");
153
+                    Logger::info('Skipping "'.$entity->getEntityId().'" - blacklisted.'."\n");
154 154
                     continue;
155 155
                 }
156 156
             }
157 157
 
158 158
             if (isset($source['whitelist'])) {
159 159
                 if (!empty($source['whitelist']) && !in_array($entity->getEntityId(), $source['whitelist'], true)) {
160
-                    Logger::info('Skipping "' . $entity->getEntityId() . '" - not in the whitelist.' . "\n");
160
+                    Logger::info('Skipping "'.$entity->getEntityId().'" - not in the whitelist.'."\n");
161 161
                     continue;
162 162
                 }
163 163
             }
@@ -165,7 +165,7 @@  discard block
 block discarded – undo
165 165
             if (array_key_exists('certificates', $source) && ($source['certificates'] !== null)) {
166 166
                 if (!$entity->validateSignature($source['certificates'])) {
167 167
                     Logger::info(
168
-                        'Skipping "' . $entity->getEntityId() . '" - could not verify signature using certificate.' . "\n"
168
+                        'Skipping "'.$entity->getEntityId().'" - could not verify signature using certificate.'."\n"
169 169
                     );
170 170
                     continue;
171 171
                 }
@@ -218,11 +218,11 @@  discard block
 block discarded – undo
218 218
                 $sourceState = $this->state[$source['src']];
219 219
 
220 220
                 if (isset($sourceState['last-modified'])) {
221
-                    $rawheader .= 'If-Modified-Since: ' . $sourceState['last-modified'] . "\r\n";
221
+                    $rawheader .= 'If-Modified-Since: '.$sourceState['last-modified']."\r\n";
222 222
                 }
223 223
 
224 224
                 if (isset($sourceState['etag'])) {
225
-                    $rawheader .= 'If-None-Match: ' . $sourceState['etag'] . "\r\n";
225
+                    $rawheader .= 'If-None-Match: '.$sourceState['etag']."\r\n";
226 226
                 }
227 227
             }
228 228
         }
@@ -294,10 +294,10 @@  discard block
 block discarded – undo
294 294
         try {
295 295
             $doc = \SAML2\DOMDocumentFactory::fromString($data);
296 296
         } catch (\Exception $e) {
297
-            throw new \Exception('Failed to read XML from ' . $source['src']);
297
+            throw new \Exception('Failed to read XML from '.$source['src']);
298 298
         }
299 299
         if ($doc->documentElement === null) {
300
-            throw new \Exception('Opened file is not an XML document: ' . $source['src']);
300
+            throw new \Exception('Opened file is not an XML document: '.$source['src']);
301 301
         }
302 302
         return \SimpleSAML\Metadata\SAMLParser::parseDescriptorsElement($doc->documentElement);
303 303
     }
@@ -314,9 +314,9 @@  discard block
 block discarded – undo
314 314
             Logger::debug('Writing: '.$this->stateFile);
315 315
             \SimpleSAML\Utils\System::writeFile(
316 316
                 $this->stateFile,
317
-                "<?php\n/* This file was generated by the metarefresh module at " . $this->getTime() . ".\n" .
318
-                " Do not update it manually as it will get overwritten. */\n" .
319
-                '$state = ' . var_export($this->state, true) . ";\n?>\n",
317
+                "<?php\n/* This file was generated by the metarefresh module at ".$this->getTime().".\n".
318
+                " Do not update it manually as it will get overwritten. */\n".
319
+                '$state = '.var_export($this->state, true).";\n?>\n",
320 320
                 0644
321 321
             );
322 322
         }
@@ -331,19 +331,19 @@  discard block
 block discarded – undo
331 331
     public function dumpMetadataStdOut(): void
332 332
     {
333 333
         foreach ($this->metadata as $category => $elements) {
334
-            echo '/* The following data should be added to metadata/' . $category . '.php. */' . "\n";
334
+            echo '/* The following data should be added to metadata/'.$category.'.php. */'."\n";
335 335
 
336 336
             foreach ($elements as $m) {
337 337
                 $filename = $m['filename'];
338 338
                 $entityID = $m['metadata']['entityid'];
339 339
 
340 340
                 echo "\n";
341
-                echo '/* The following metadata was generated from '.$filename.' on ' . $this->getTime() . '. */' . "\n";
342
-                echo '$metadata[\'' . addslashes($entityID) . '\'] = ' . var_export($m['metadata'], true) . ';' . "\n";
341
+                echo '/* The following metadata was generated from '.$filename.' on '.$this->getTime().'. */'."\n";
342
+                echo '$metadata[\''.addslashes($entityID).'\'] = '.var_export($m['metadata'], true).';'."\n";
343 343
             }
344 344
 
345 345
             echo "\n";
346
-            echo '/* End of data which should be added to metadata/' . $category . '.php. */' . "\n";
346
+            echo '/* End of data which should be added to metadata/'.$category.'.php. */'."\n";
347 347
             echo "\n";
348 348
         }
349 349
     }
@@ -424,7 +424,7 @@  discard block
 block discarded – undo
424 424
 
425 425
         $arpxml = $arp->getXML();
426 426
 
427
-        Logger::info('Writing ARP file: ' . $arpfile . "\n");
427
+        Logger::info('Writing ARP file: '.$arpfile."\n");
428 428
         file_put_contents($arpfile, $arpxml);
429 429
     }
430 430
 
@@ -442,37 +442,37 @@  discard block
 block discarded – undo
442 442
         }
443 443
 
444 444
         if (!file_exists($outputDir)) {
445
-            Logger::info('Creating directory: ' . $outputDir . "\n");
445
+            Logger::info('Creating directory: '.$outputDir."\n");
446 446
             $res = @mkdir($outputDir, 0777, true);
447 447
             if ($res === false) {
448
-                throw new \Exception('Error creating directory: ' . $outputDir);
448
+                throw new \Exception('Error creating directory: '.$outputDir);
449 449
             }
450 450
         }
451 451
 
452 452
         foreach ($this->types as $type) {
453
-            $filename = $outputDir . '/' . $type . '.php';
453
+            $filename = $outputDir.'/'.$type.'.php';
454 454
 
455 455
             if (array_key_exists($type, $this->metadata)) {
456 456
                 $elements = $this->metadata[$type];
457
-                Logger::debug('Writing: ' . $filename);
457
+                Logger::debug('Writing: '.$filename);
458 458
 
459
-                $content  = '<?php' . "\n" . '/* This file was generated by the metarefresh module at ';
460
-                $content .= $this->getTime() . "\nDo not update it manually as it will get overwritten\n" . '*/' . "\n";
459
+                $content  = '<?php'."\n".'/* This file was generated by the metarefresh module at ';
460
+                $content .= $this->getTime()."\nDo not update it manually as it will get overwritten\n".'*/'."\n";
461 461
 
462 462
                 foreach ($elements as $m) {
463 463
                     $entityID = $m['metadata']['entityid'];
464
-                    $content .= "\n" . '$metadata[\'';
465
-                    $content .= addslashes($entityID) . '\'] = ' . var_export($m['metadata'], true) . ';' . "\n";
464
+                    $content .= "\n".'$metadata[\'';
465
+                    $content .= addslashes($entityID).'\'] = '.var_export($m['metadata'], true).';'."\n";
466 466
                 }
467 467
 
468
-                $content .= "\n" . '?>';
468
+                $content .= "\n".'?>';
469 469
 
470 470
                 \SimpleSAML\Utils\System::writeFile($filename, $content, 0644);
471 471
             } elseif (is_file($filename)) {
472 472
                 if (unlink($filename)) {
473
-                    Logger::debug('Deleting stale metadata file: ' . $filename);
473
+                    Logger::debug('Deleting stale metadata file: '.$filename);
474 474
                 } else {
475
-                    Logger::warning('Could not delete stale metadata file: ' . $filename);
475
+                    Logger::warning('Could not delete stale metadata file: '.$filename);
476 476
                 }
477 477
             }
478 478
         }
@@ -495,8 +495,8 @@  discard block
 block discarded – undo
495 495
                 $entityId = $m['metadata']['entityid'];
496 496
 
497 497
                 Logger::debug(
498
-                    'metarefresh: Add metadata entry ' .
499
-                    var_export($entityId, true) . ' in set ' . var_export($set, true) . '.'
498
+                    'metarefresh: Add metadata entry '.
499
+                    var_export($entityId, true).' in set '.var_export($set, true).'.'
500 500
                 );
501 501
                 $metaHandler->saveMetadata($entityId, $set, $m['metadata']);
502 502
             }
@@ -508,19 +508,19 @@  discard block
 block discarded – undo
508 508
             foreach ($metaHandler->getMetadataSet($set) as $entityId => $metadata) {
509 509
                 if (!array_key_exists('expire', $metadata)) {
510 510
                     Logger::warning(
511
-                        'metarefresh: Metadata entry without expire timestamp: ' . var_export($entityId, true) .
512
-                        ' in set ' . var_export($set, true) . '.'
511
+                        'metarefresh: Metadata entry without expire timestamp: '.var_export($entityId, true).
512
+                        ' in set '.var_export($set, true).'.'
513 513
                     );
514 514
                     continue;
515 515
                 }
516 516
                 if ($metadata['expire'] > $ct) {
517 517
                     continue;
518 518
                 }
519
-                Logger::debug('metarefresh: ' . $entityId . ' expired ' . date('l jS \of F Y h:i:s A', $metadata['expire']));
519
+                Logger::debug('metarefresh: '.$entityId.' expired '.date('l jS \of F Y h:i:s A', $metadata['expire']));
520 520
                 Logger::debug(
521
-                    'metarefresh: Delete expired metadata entry ' .
522
-                    var_export($entityId, true) . ' in set ' . var_export($set, true) .
523
-                    '. (' . ($ct - $metadata['expire']) . ' sec)'
521
+                    'metarefresh: Delete expired metadata entry '.
522
+                    var_export($entityId, true).' in set '.var_export($set, true).
523
+                    '. ('.($ct - $metadata['expire']).' sec)'
524 524
                 );
525 525
                 $metaHandler->deleteMetadata($entityId, $set);
526 526
             }
Please login to merge, or discard this patch.