Passed
Push — master ( 046c45...04fc1c )
by Tim
02:47
created
lib/AdfsController.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
                 ];
112 112
             }
113 113
 
114
-            $adfs_service_location = Module::getModuleURL('adfs') . '/idp/prp.php';
114
+            $adfs_service_location = Module::getModuleURL('adfs').'/idp/prp.php';
115 115
             $metaArray = [
116 116
                 'metadata-set'        => 'adfs-idp-remote',
117 117
                 'entityid'            => $idpentityid,
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
173 173
                 $metaArray['RegistrationInfo'] = $idpmeta->getArray('RegistrationInfo');
174 174
             }
175 175
 
176
-            $metaflat = '$metadata[' . var_export($idpentityid, true) . '] = ' . var_export($metaArray, true) . ';';
176
+            $metaflat = '$metadata['.var_export($idpentityid, true).'] = '.var_export($metaArray, true).';';
177 177
 
178 178
             $metaBuilder = new Metadata\SAMLBuilder($idpentityid);
179 179
             $metaBuilder->addSecurityTokenServiceType($metaArray);
@@ -203,12 +203,12 @@  discard block
 block discarded – undo
203 203
                 $certdata = [];
204 204
                 foreach (array_keys($availableCerts) as $availableCert) {
205 205
                     $certdata[$availableCert]['name'] = $availableCert;
206
-                    $certdata[$availableCert]['url'] = Module::getModuleURL('saml/idp/certs.php') .
207
-                        '/' . $availableCert;
206
+                    $certdata[$availableCert]['url'] = Module::getModuleURL('saml/idp/certs.php').
207
+                        '/'.$availableCert;
208 208
 
209 209
                     $certdata[$availableCert]['comment'] = '';
210 210
                     if ($availableCerts[$availableCert]['certFingerprint'][0] === 'afe71c28ef740bc87425be13a2263d37971da1f9') {
211
-                        $certdata[$availableCert]['comment'] = 'This is the default certificate.' .
211
+                        $certdata[$availableCert]['comment'] = 'This is the default certificate.'.
212 212
                             ' Generate a new certificate if this is a production system.';
213 213
                     }
214 214
                 }
@@ -250,20 +250,20 @@  discard block
 block discarded – undo
250 250
         Logger::info('ADFS - IdP.prp: Accessing ADFS IdP endpoint prp');
251 251
 
252 252
         $idpEntityId = $this->metadata->getMetaDataCurrentEntityID('adfs-idp-hosted');
253
-        $idp = IdP::getById('adfs:' . $idpEntityId);
253
+        $idp = IdP::getById('adfs:'.$idpEntityId);
254 254
 
255 255
         if (isset($_GET['wa'])) {
256 256
             if ($_GET['wa'] === 'wsignout1.0') {
257 257
                 return new StreamedResponse(
258 258
                     /** @return void */
259
-                    function () use ($idp) {
259
+                    function() use ($idp) {
260 260
                         ADFS::receiveLogoutMessage($idp);
261 261
                     }
262 262
                 );
263 263
             } elseif ($_GET['wa'] === 'wsignin1.0') {
264 264
                 return new StreamedResponse(
265 265
                     /** @return void */
266
-                    function () use ($idp) {
266
+                    function() use ($idp) {
267 267
                         ADFS::receiveAuthnRequest($idp);
268 268
                     }
269 269
                 );
@@ -277,7 +277,7 @@  discard block
 block discarded – undo
277 277
 
278 278
             return new StreamedResponse(
279 279
                 /** @return void */
280
-                function () use ($idp, $assocId, $relayState, $logoutError) {
280
+                function() use ($idp, $assocId, $relayState, $logoutError) {
281 281
                     $idp->handleLogoutResponse($assocId, $relayState, $logoutError);
282 282
                 }
283 283
             );
Please login to merge, or discard this patch.
lib/IdP/ADFS.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
             $metadata = MetaDataStorageHandler::getMetadataHandler();
33 33
             $spMetadata = $metadata->getMetaDataConfig($issuer, 'adfs-sp-remote');
34 34
 
35
-            Logger::info('ADFS - IdP.prp: Incoming Authentication request: ' . $issuer . ' id ' . $requestid);
35
+            Logger::info('ADFS - IdP.prp: Incoming Authentication request: '.$issuer.' id '.$requestid);
36 36
         } catch (\Exception $exception) {
37 37
             throw new Error\Error('PROCESSAUTHNREQUEST', $exception);
38 38
         }
@@ -347,7 +347,7 @@  discard block
 block discarded – undo
347 347
         $spEntityId = $spMetadata['entityid'];
348 348
         $spMetadata = Configuration::loadFromArray(
349 349
             $spMetadata,
350
-            '$metadata[' . var_export($spEntityId, true) . ']'
350
+            '$metadata['.var_export($spEntityId, true).']'
351 351
         );
352 352
 
353 353
         $attributes = $state['Attributes'];
@@ -367,7 +367,7 @@  discard block
 block discarded – undo
367 367
         $idpEntityId = $idpMetadata->getString('entityid');
368 368
 
369 369
         $idp->addAssociation([
370
-            'id' => 'adfs:' . $spEntityId,
370
+            'id' => 'adfs:'.$spEntityId,
371 371
             'Handler' => ADFS::class,
372 372
             'adfs:entityID' => $spEntityId,
373 373
         ]);
@@ -390,7 +390,7 @@  discard block
 block discarded – undo
390 390
         $wresult = ADFS::signResponse($response, $privateKeyFile, $certificateFile, $algo, $passphrase);
391 391
 
392 392
         $wctx = $state['adfs:wctx'];
393
-        $wreply = $state['adfs:wreply'] ? : $spMetadata->getValue('prp');
393
+        $wreply = $state['adfs:wreply'] ?: $spMetadata->getValue('prp');
394 394
         ADFS::postResponse($wreply, $wresult, $wctx);
395 395
     }
396 396
 
@@ -448,8 +448,8 @@  discard block
 block discarded – undo
448 448
         $metadata = MetaDataStorageHandler::getMetadataHandler();
449 449
         $spMetadata = $metadata->getMetaDataConfig($association['adfs:entityID'], 'adfs-sp-remote');
450 450
         $returnTo = Module::getModuleURL(
451
-            'adfs/idp/prp.php?assocId=' . urlencode($association["id"]) . '&relayState=' . urlencode($relayState)
451
+            'adfs/idp/prp.php?assocId='.urlencode($association["id"]).'&relayState='.urlencode($relayState)
452 452
         );
453
-        return $spMetadata->getValue('prp') . '?wa=wsignoutcleanup1.0&wreply=' . urlencode($returnTo);
453
+        return $spMetadata->getValue('prp').'?wa=wsignoutcleanup1.0&wreply='.urlencode($returnTo);
454 454
     }
455 455
 }
Please login to merge, or discard this patch.