Passed
Push — master ( 1b1a3a...b67f9d )
by Tim
02:17
created
lib/IdP/ADFS.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
         $metadata = MetaDataStorageHandler::getMetadataHandler();
36 36
         $spMetadata = $metadata->getMetaDataConfig($issuer, 'adfs-sp-remote');
37 37
 
38
-        Logger::info('ADFS - IdP.prp: Incoming Authentication request: ' . $issuer . ' id ' . $requestid);
38
+        Logger::info('ADFS - IdP.prp: Incoming Authentication request: '.$issuer.' id '.$requestid);
39 39
 
40 40
         $state = [
41 41
             'Responder' => [ADFS::class, 'sendResponse'],
@@ -354,7 +354,7 @@  discard block
 block discarded – undo
354 354
         $spEntityId = $spMetadata['entityid'];
355 355
         $spMetadata = Configuration::loadFromArray(
356 356
             $spMetadata,
357
-            '$metadata[' . var_export($spEntityId, true) . ']'
357
+            '$metadata['.var_export($spEntityId, true).']'
358 358
         );
359 359
 
360 360
         $attributes = $state['Attributes'];
@@ -375,7 +375,7 @@  discard block
 block discarded – undo
375 375
         $idpEntityId = $idpMetadata->getString('entityid');
376 376
 
377 377
         $idp->addAssociation([
378
-            'id' => 'adfs:' . $spEntityId,
378
+            'id' => 'adfs:'.$spEntityId,
379 379
             'Handler' => ADFS::class,
380 380
             'adfs:entityID' => $spEntityId,
381 381
         ]);
@@ -399,7 +399,7 @@  discard block
 block discarded – undo
399 399
         $wresult = ADFS::signResponse($response, $privateKeyFile, $certificateFile, $algo, $passphrase);
400 400
 
401 401
         $wctx = $state['adfs:wctx'];
402
-        $wreply = $state['adfs:wreply'] ? : $spMetadata->getValue('prp');
402
+        $wreply = $state['adfs:wreply'] ?: $spMetadata->getValue('prp');
403 403
         ADFS::postResponse($wreply, $wresult, $wctx);
404 404
     }
405 405
 
@@ -457,8 +457,8 @@  discard block
 block discarded – undo
457 457
         $metadata = MetaDataStorageHandler::getMetadataHandler();
458 458
         $spMetadata = $metadata->getMetaDataConfig($association['adfs:entityID'], 'adfs-sp-remote');
459 459
         $returnTo = Module::getModuleURL(
460
-            'adfs/idp/prp.php?assocId=' . urlencode($association["id"]) . '&relayState=' . urlencode($relayState)
460
+            'adfs/idp/prp.php?assocId='.urlencode($association["id"]).'&relayState='.urlencode($relayState)
461 461
         );
462
-        return $spMetadata->getValue('prp') . '?wa=wsignoutcleanup1.0&wreply=' . urlencode($returnTo);
462
+        return $spMetadata->getValue('prp').'?wa=wsignoutcleanup1.0&wreply='.urlencode($returnTo);
463 463
     }
464 464
 }
Please login to merge, or discard this patch.
lib/Controller/Adfs.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
117 117
                 ];
118 118
             }
119 119
 
120
-            $adfs_service_location = Module::getModuleURL('adfs') . '/idp/prp.php';
120
+            $adfs_service_location = Module::getModuleURL('adfs').'/idp/prp.php';
121 121
             $metaArray = [
122 122
                 'metadata-set'        => 'adfs-idp-remote',
123 123
                 'entityid'            => $idpentityid,
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
                 $metaArray['RegistrationInfo'] = $idpmeta->getArray('RegistrationInfo');
180 180
             }
181 181
 
182
-            $metaflat = '$metadata[' . var_export($idpentityid, true) . '] = ' . var_export($metaArray, true) . ';';
182
+            $metaflat = '$metadata['.var_export($idpentityid, true).'] = '.var_export($metaArray, true).';';
183 183
 
184 184
             $metaBuilder = new Metadata\SAMLBuilder($idpentityid);
185 185
             $metaBuilder->addSecurityTokenServiceType($metaArray);
@@ -209,8 +209,8 @@  discard block
 block discarded – undo
209 209
                 $certdata = [];
210 210
                 foreach (array_keys($availableCerts) as $availableCert) {
211 211
                     $certdata[$availableCert]['name'] = $availableCert;
212
-                    $certdata[$availableCert]['url'] = Module::getModuleURL('saml/idp/certs.php') .
213
-                        '/' . $availableCert;
212
+                    $certdata[$availableCert]['url'] = Module::getModuleURL('saml/idp/certs.php').
213
+                        '/'.$availableCert;
214 214
 
215 215
                     $certdata[$availableCert]['comment'] = '';
216 216
                 }
@@ -252,13 +252,13 @@  discard block
 block discarded – undo
252 252
         Logger::info('ADFS - IdP.prp: Accessing ADFS IdP endpoint prp');
253 253
 
254 254
         $idpEntityId = $this->metadata->getMetaDataCurrentEntityID('adfs-idp-hosted');
255
-        $idp = IdP::getById('adfs:' . $idpEntityId);
255
+        $idp = IdP::getById('adfs:'.$idpEntityId);
256 256
 
257 257
         if ($request->query->has('wa')) {
258 258
             $wa = $request->get('wa');
259 259
             if ($wa === 'wsignout1.0') {
260 260
                 return new StreamedResponse(
261
-                    function () use ($idp) {
261
+                    function() use ($idp) {
262 262
                         ADFS_IDP::receiveLogoutMessage($idp);
263 263
                     }
264 264
                 );
@@ -273,7 +273,7 @@  discard block
 block discarded – undo
273 273
             $logoutError = null; // null on success, or an instance of a \SimpleSAML\Error\Exception on failure.
274 274
 
275 275
             return new StreamedResponse(
276
-                function () use ($idp, /** @scrutinizer ignore-type */ $assocId, $relayState, $logoutError) {
276
+                function() use ($idp, /** @scrutinizer ignore-type */ $assocId, $relayState, $logoutError) {
277 277
                     $idp->handleLogoutResponse($assocId, $relayState, $logoutError);
278 278
                 }
279 279
             );
Please login to merge, or discard this patch.