Completed
Pull Request — master (#60)
by Daan van
18:54 queued 55s
created
src/SAML2/Assertion.php 2 patches
Doc Comments   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -695,7 +695,7 @@  discard block
 block discarded – undo
695 695
     /**
696 696
      * Check whether the NameId is encrypted.
697 697
      *
698
-     * @return true if the NameId is encrypted, false if not.
698
+     * @return boolean if the NameId is encrypted, false if not.
699 699
      */
700 700
     public function isNameIdEncrypted()
701 701
     {
@@ -820,7 +820,7 @@  discard block
 block discarded – undo
820 820
      * This function returns null if there are no restrictions on how early the
821 821
      * assertion can be used.
822 822
      *
823
-     * @return int|null The earliest timestamp this assertion is valid.
823
+     * @return integer The earliest timestamp this assertion is valid.
824 824
      */
825 825
     public function getNotBefore()
826 826
     {
@@ -847,7 +847,7 @@  discard block
 block discarded – undo
847 847
      * This function returns null if there are no restrictions on how
848 848
      * late the assertion can be used.
849 849
      *
850
-     * @return int|null The latest timestamp this assertion is valid.
850
+     * @return integer The latest timestamp this assertion is valid.
851 851
      */
852 852
     public function getNotOnOrAfter()
853 853
     {
@@ -905,7 +905,7 @@  discard block
 block discarded – undo
905 905
     /**
906 906
      * Retrieve the AuthnInstant of the assertion.
907 907
      *
908
-     * @return int|null The timestamp the user was authenticated, or NULL if the user isn't authenticated.
908
+     * @return integer The timestamp the user was authenticated, or NULL if the user isn't authenticated.
909 909
      */
910 910
     public function getAuthnInstant()
911 911
     {
@@ -1067,7 +1067,7 @@  discard block
 block discarded – undo
1067 1067
      * See:
1068 1068
      * @url http://docs.oasis-open.org/security/saml/v2.0/saml-authn-context-2.0-os.pdf
1069 1069
      *
1070
-     * @return \SAML2\XML\Chunk|null
1070
+     * @return Chunk
1071 1071
      */
1072 1072
     public function getAuthnContextDecl()
1073 1073
     {
@@ -1097,7 +1097,7 @@  discard block
 block discarded – undo
1097 1097
      *
1098 1098
      * The URI reference MAY directly resolve into an XML document containing the referenced declaration.
1099 1099
      *
1100
-     * @return string
1100
+     * @return Chunk
1101 1101
      */
1102 1102
     public function getAuthnContextDeclRef()
1103 1103
     {
Please login to merge, or discard this patch.
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -246,7 +246,7 @@  discard block
 block discarded – undo
246 246
 
247 247
         if ($xml->getAttribute('Version') !== '2.0') {
248 248
             /* Currently a very strict check. */
249
-            throw new \Exception('Unsupported version: ' . $xml->getAttribute('Version'));
249
+            throw new \Exception('Unsupported version: '.$xml->getAttribute('Version'));
250 250
         }
251 251
 
252 252
         $this->issueInstant = Utils::xsDateTimeToTimestamp($xml->getAttribute('IssueInstant'));
@@ -346,7 +346,7 @@  discard block
 block discarded – undo
346 346
                 continue;
347 347
             }
348 348
             if ($node->namespaceURI !== Constants::NS_SAML) {
349
-                throw new \Exception('Unknown namespace of condition: ' . var_export($node->namespaceURI, true));
349
+                throw new \Exception('Unknown namespace of condition: '.var_export($node->namespaceURI, true));
350 350
             }
351 351
             switch ($node->localName) {
352 352
                 case 'AudienceRestriction':
@@ -369,7 +369,7 @@  discard block
 block discarded – undo
369 369
                     /* Currently ignored. */
370 370
                     break;
371 371
                 default:
372
-                    throw new \Exception('Unknown condition: ' . var_export($node->localName, true));
372
+                    throw new \Exception('Unknown condition: '.var_export($node->localName, true));
373 373
             }
374 374
         }
375 375
     }
@@ -530,7 +530,7 @@  discard block
 block discarded – undo
530 530
 
531 531
             $type = $value->getAttribute('xsi:type');
532 532
             if ($type === 'xs:integer') {
533
-                $this->attributes[$attributeName][] = (int)$value->textContent;
533
+                $this->attributes[$attributeName][] = (int) $value->textContent;
534 534
             } else {
535 535
                 $this->attributes[$attributeName][] = trim($value->textContent);
536 536
             }
@@ -1287,7 +1287,7 @@  discard block
 block discarded – undo
1287 1287
             $document = $parentElement->ownerDocument;
1288 1288
         }
1289 1289
 
1290
-        $root = $document->createElementNS(Constants::NS_SAML, 'saml:' . 'Assertion');
1290
+        $root = $document->createElementNS(Constants::NS_SAML, 'saml:'.'Assertion');
1291 1291
         $parentElement->appendChild($root);
1292 1292
 
1293 1293
         /* Ugly hack to add another namespace declaration to the root element. */
@@ -1339,7 +1339,7 @@  discard block
 block discarded – undo
1339 1339
         if ($this->encryptedNameId === null) {
1340 1340
             Utils::addNameId($subject, $this->nameId);
1341 1341
         } else {
1342
-            $eid = $subject->ownerDocument->createElementNS(Constants::NS_SAML, 'saml:' . 'EncryptedID');
1342
+            $eid = $subject->ownerDocument->createElementNS(Constants::NS_SAML, 'saml:'.'EncryptedID');
1343 1343
             $subject->appendChild($eid);
1344 1344
             $eid->appendChild($subject->ownerDocument->importNode($this->encryptedNameId, true));
1345 1345
         }
Please login to merge, or discard this patch.