Completed
Pull Request — master (#60)
by Daan van
18:54 queued 55s
created
src/SAML2/Certificate/KeyLoader.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -76,7 +76,7 @@
 block discarded – undo
76 76
      * are not configured to be used with the usage given
77 77
      *
78 78
      * @param array $configuredKeys
79
-     * @param       $usage
79
+     * @param       null|string $usage
80 80
      */
81 81
     public function loadKeys(array $configuredKeys, $usage)
82 82
     {
Please login to merge, or discard this patch.
src/SAML2/Utils.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -248,7 +248,7 @@
 block discarded – undo
248 248
      *
249 249
      * @param  DOMElement $node          The element we should fetch the attribute from.
250 250
      * @param  string     $attributeName The name of the attribute.
251
-     * @param  mixed      $default       The value that should be returned if the attribute doesn't exist.
251
+     * @param  false|null      $default       The value that should be returned if the attribute doesn't exist.
252 252
      * @return bool|mixed The value of the attribute, or $default if the attribute doesn't exist.
253 253
      * @throws Exception
254 254
      */
Please login to merge, or discard this patch.
src/SAML2/AuthnRequest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -569,7 +569,7 @@
 block discarded – undo
569 569
      * The returned NameId is in the format used by \SAML2\Utils::addNameId().
570 570
      *
571 571
      * @see \SAML2\Utils::addNameId()
572
-     * @return array|null The name identifier of the assertion.
572
+     * @return string The name identifier of the assertion.
573 573
      * @throws \Exception
574 574
      */
575 575
     public function getNameId()
Please login to merge, or discard this patch.
src/SAML2/LogoutRequest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -107,7 +107,7 @@
 block discarded – undo
107 107
     /**
108 108
      * Check whether the NameId is encrypted.
109 109
      *
110
-     * @return true if the NameId is encrypted, false if not.
110
+     * @return boolean if the NameId is encrypted, false if not.
111 111
      */
112 112
     public function isNameIdEncrypted()
113 113
     {
Please login to merge, or discard this patch.
src/SAML2/Response.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@
 block discarded – undo
45 45
     /**
46 46
      * Retrieve the assertions in this response.
47 47
      *
48
-     * @return \SAML2\Assertion[]|\SAML2\EncryptedAssertion[]
48
+     * @return Utilities\ArrayCollection
49 49
      */
50 50
     public function getAssertions()
51 51
     {
Please login to merge, or discard this patch.
src/SAML2/Response/Processor.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
      * @param \SAML2\Configuration\Destination      $currentDestination
65 65
      * @param \SAML2\Response                       $response
66 66
      *
67
-     * @return \SAML2\Assertion[] Collection (\SAML2\Utilities\ArrayCollection) of \SAML2\Assertion objects
67
+     * @return \SAML2\Utilities\ArrayCollection Collection (\SAML2\Utilities\ArrayCollection) of \SAML2\Assertion objects
68 68
      */
69 69
     public function process(
70 70
         ServiceProvider $serviceProviderConfiguration,
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
     /**
135 135
      * @param \SAML2\Response $response
136 136
      *
137
-     * @return \SAML2\Assertion[]
137
+     * @return \SAML2\Utilities\ArrayCollection
138 138
      */
139 139
     private function processAssertions(Response $response)
140 140
     {
Please login to merge, or discard this patch.
src/SAML2/SOAPClient.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -212,6 +212,10 @@
 block discarded – undo
212 212
      * @param $soapmessage Soap response needs to be type DOMDocument
213 213
      * @return $soapfaultstring string|null
214 214
      */
215
+
216
+    /**
217
+     * @param \DOMDocument $soapMessage
218
+     */
215 219
     private function getSOAPFault($soapMessage)
216 220
     {
217 221
         $soapFault = Utils::xpQuery($soapMessage->firstChild, '/soap-env:Envelope/soap-env:Body/soap-env:Fault');
Please login to merge, or discard this patch.
src/SAML2/Assertion.php 1 patch
Doc Comments   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -695,7 +695,7 @@  discard block
 block discarded – undo
695 695
     /**
696 696
      * Check whether the NameId is encrypted.
697 697
      *
698
-     * @return true if the NameId is encrypted, false if not.
698
+     * @return boolean if the NameId is encrypted, false if not.
699 699
      */
700 700
     public function isNameIdEncrypted()
701 701
     {
@@ -820,7 +820,7 @@  discard block
 block discarded – undo
820 820
      * This function returns null if there are no restrictions on how early the
821 821
      * assertion can be used.
822 822
      *
823
-     * @return int|null The earliest timestamp this assertion is valid.
823
+     * @return integer The earliest timestamp this assertion is valid.
824 824
      */
825 825
     public function getNotBefore()
826 826
     {
@@ -847,7 +847,7 @@  discard block
 block discarded – undo
847 847
      * This function returns null if there are no restrictions on how
848 848
      * late the assertion can be used.
849 849
      *
850
-     * @return int|null The latest timestamp this assertion is valid.
850
+     * @return integer The latest timestamp this assertion is valid.
851 851
      */
852 852
     public function getNotOnOrAfter()
853 853
     {
@@ -905,7 +905,7 @@  discard block
 block discarded – undo
905 905
     /**
906 906
      * Retrieve the AuthnInstant of the assertion.
907 907
      *
908
-     * @return int|null The timestamp the user was authenticated, or NULL if the user isn't authenticated.
908
+     * @return integer The timestamp the user was authenticated, or NULL if the user isn't authenticated.
909 909
      */
910 910
     public function getAuthnInstant()
911 911
     {
@@ -1067,7 +1067,7 @@  discard block
 block discarded – undo
1067 1067
      * See:
1068 1068
      * @url http://docs.oasis-open.org/security/saml/v2.0/saml-authn-context-2.0-os.pdf
1069 1069
      *
1070
-     * @return \SAML2\XML\Chunk|null
1070
+     * @return Chunk
1071 1071
      */
1072 1072
     public function getAuthnContextDecl()
1073 1073
     {
@@ -1097,7 +1097,7 @@  discard block
 block discarded – undo
1097 1097
      *
1098 1098
      * The URI reference MAY directly resolve into an XML document containing the referenced declaration.
1099 1099
      *
1100
-     * @return string
1100
+     * @return Chunk
1101 1101
      */
1102 1102
     public function getAuthnContextDeclRef()
1103 1103
     {
Please login to merge, or discard this patch.