SimpleSAML\SAML2\XML\md\AbstractSignedMdElement::toXML()

Complexity

Conditions	4
Paths	3

Size

Total Lines	19
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function toXML(DOMElement $parent = null): DOMElement
    {
        if ($this->isSigned() === true && $this->signer === null) {
            $e = $this->instantiateParentElement($parent);

            // We already have a signed document and no signer was set to re-sign it
            $node = $e->ownerDocument->importNode($this->xml, true);

The method importNode() does not exist on null.

            return $e->appendChild($node);

The expression return $e->appendChild($node) returns the type DOMNode which includes types incompatible with the type-hinted return DOMElement.

        }

        $e = $this->toUnsignedXML($parent);

The method toUnsignedXML() does not exist on SimpleSAML\SAML2\XML\md\AbstractSignedMdElement. Since it exists in all sub-types, consider adding an abstract or default implementation to SimpleSAML\SAML2\XML\md\AbstractSignedMdElement.

        if ($this->signer !== null) {
            $signedXML = $this->doSign($e);
            $signedXML->insertBefore($this->signature->toXML($signedXML), $signedXML->firstChild);
            return $signedXML;
        }

        return $e;
    }