SimpleSAML\SAML2\XML\md\AbstractSignedMdElement

Complexity

Total Complexity

5

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	toXML()	0	19	4
A	getBlacklistedAlgorithms()	0	4	1

<?php

declare(strict_types=1);

namespace SimpleSAML\SAML2\XML\md;

use DOMElement;
use SimpleSAML\XMLSecurity\XML\SignableElementTrait;
use SimpleSAML\XMLSecurity\XML\SignableElementInterface;
use SimpleSAML\XMLSecurity\XML\SignedElementTrait;
use SimpleSAML\XMLSecurity\XML\SignedElementInterface;

/**
 * Abstract class that represents a signed metadata element.
 *
 * @package simplesamlphp/saml2
 */
abstract class AbstractSignedMdElement extends AbstractMdElement implements SignableElementInterface, SignedElementInterface
{
    use SignableElementTrait;

The trait SimpleSAML\XMLSecurity\XML\SignableElementTrait requires some properties which are not provided by SimpleSAML\SAML2\XML\md\AbstractSignedMdElement: $ownerDocument, $documentElement

    use SignedElementTrait;

The trait SimpleSAML\XMLSecurity\XML\SignedElementTrait requires some properties which are not provided by SimpleSAML\SAML2\XML\md\AbstractSignedMdElement: $ownerDocument, $documentElement

    /**
     * @return array|null
     */
    public function getBlacklistedAlgorithms(): ?array
    {
        $container = ContainerSingleton::getInstance();

The type SimpleSAML\SAML2\XML\md\ContainerSingleton was not found. Maybe you did not declare it correctly or list all dependencies?

        return $container->getBlacklistedEncryptionAlgorithms();
    }


    /**
     * @param \DOMElement|null $parent The EntityDescriptor we should append this SPSSODescriptor to.
     * @return \DOMElement
     * @throws \Exception
     */
    public function toXML(DOMElement $parent = null): DOMElement
    {
        if ($this->isSigned() === true && $this->signer === null) {
            $e = $this->instantiateParentElement($parent);

            // We already have a signed document and no signer was set to re-sign it
            $node = $e->ownerDocument->importNode($this->xml, true);

The method importNode() does not exist on null.

            return $e->appendChild($node);

The expression return $e->appendChild($node) returns the type DOMNode which includes types incompatible with the type-hinted return DOMElement.

        }

        $e = $this->toUnsignedXML($parent);

The method toUnsignedXML() does not exist on SimpleSAML\SAML2\XML\md\AbstractSignedMdElement. Since it exists in all sub-types, consider adding an abstract or default implementation to SimpleSAML\SAML2\XML\md\AbstractSignedMdElement.

        if ($this->signer !== null) {
            $signedXML = $this->doSign($e);
            $signedXML->insertBefore($this->signature->toXML($signedXML), $signedXML->firstChild);
            return $signedXML;
        }

        return $e;
    }
}